)]}'
{"manifests/db.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"978c90ce910a40f1f1d92e1129d2c5a3f711e9a9","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  include designate::params"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  validate_legacy(String, \u0027validate_re\u0027, $database_connection,"},{"line_number":58,"context_line":"    [\u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  case $database_connection {"},{"line_number":61,"context_line":"    /^mysql(\\+pymysql)?:\\/\\//: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5e23af3d_4d98de10","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":43},"updated":"2021-03-11 10:42:14.000000000","message":"Can we make this consistent with the implementation in puppet-oslo ?\n\n https://github.com/openstack/puppet-oslo/blob/master/manifests/db.pp#L159","commit_id":"a7b09f6f7f0434ecac91295f15dd970bd999681f"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"9ae3c5d07135e05cc008991216d1f633525f7fd3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  include designate::params"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  validate_legacy(String, \u0027validate_re\u0027, $database_connection,"},{"line_number":58,"context_line":"    [\u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  case $database_connection {"},{"line_number":61,"context_line":"    /^mysql(\\+pymysql)?:\\/\\//: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"81681923_e035e185","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":43},"in_reply_to":"5e23af3d_4d98de10","updated":"2021-03-11 13:13:14.000000000","message":"Certainly, thanks a ton for the pointer. I already noticed that with Victora the whole db configuration and validation has moved to Oslo which makes applying this change to anything after Ussuri unnecessary.\n\nI took the liberty, since we are aligning things, to include the whole regex including MongoDB.","commit_id":"a7b09f6f7f0434ecac91295f15dd970bd999681f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"978c90ce910a40f1f1d92e1129d2c5a3f711e9a9","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        $backend_package \u003d false"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    /^(sqlite|postgresql):\\/\\//: {"},{"line_number":71,"context_line":"      $backend_package \u003d false"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"577dae99_214e4ac0","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":24},"updated":"2021-03-11 10:42:14.000000000","message":"ditto\n\nhttps://github.com/openstack/puppet-oslo/blob/master/manifests/db.pp#L172-L175","commit_id":"a7b09f6f7f0434ecac91295f15dd970bd999681f"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"9ae3c5d07135e05cc008991216d1f633525f7fd3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        $backend_package \u003d false"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    /^(sqlite|postgresql):\\/\\//: {"},{"line_number":71,"context_line":"      $backend_package \u003d false"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"cad80a1a_259f0a2d","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":24},"in_reply_to":"577dae99_214e4ac0","updated":"2021-03-11 13:13:14.000000000","message":"Done","commit_id":"a7b09f6f7f0434ecac91295f15dd970bd999681f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7808c9533508cbf850a3960ab439410b9e056196","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  include designate::params"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  validate_legacy(String, \u0027validate_re\u0027, $database_connection,"},{"line_number":58,"context_line":"    [\u0027^(sqlite|mysql(\\+pymysql)?|postgresql(\\+psycopg2)?|mongodb):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027])"},{"line_number":59,"context_line":"  case $database_connection {"},{"line_number":60,"context_line":"    /^mysql(\\+pymysql)?:\\/\\//: {"},{"line_number":61,"context_line":"      require \u0027::mysql::bindings\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"10f8c5bd_a162a07a","line":58,"range":{"start_line":58,"start_character":46,"end_line":58,"end_character":54},"updated":"2021-03-12 15:05:47.000000000","message":"My previous comment was not clear enough but I intended to add only this part.\nI agree with Tobias that MongoDB is never used by designate, and  I think adding support for mongodb is overkilling.\nLet\u0027s remove mongodb part.","commit_id":"2e3567a5c5f6545f9bc86441e1c2cbc4d70f9fe8"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"ba21896e3f34b60089e2c2f2f6a48442b5fc83c8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  include designate::params"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  validate_legacy(String, \u0027validate_re\u0027, $database_connection,"},{"line_number":58,"context_line":"    [\u0027^(sqlite|mysql(\\+pymysql)?|postgresql(\\+psycopg2)?|mongodb):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027])"},{"line_number":59,"context_line":"  case $database_connection {"},{"line_number":60,"context_line":"    /^mysql(\\+pymysql)?:\\/\\//: {"},{"line_number":61,"context_line":"      require \u0027::mysql::bindings\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f6af1f99_ba146555","line":58,"range":{"start_line":58,"start_character":46,"end_line":58,"end_character":54},"in_reply_to":"10f8c5bd_a162a07a","updated":"2021-03-12 16:17:56.000000000","message":"Done","commit_id":"2e3567a5c5f6545f9bc86441e1c2cbc4d70f9fe8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7808c9533508cbf850a3960ab439410b9e056196","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        $backend_package \u003d false"},{"line_number":67,"context_line":"      }"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"    /^(sqlite|postgresql(\\+psycopg2)?|mongodb):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?/: {"},{"line_number":70,"context_line":"      $backend_package \u003d false"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b3758cb0_6262d992","line":69,"range":{"start_line":69,"start_character":5,"end_line":69,"end_character":71},"updated":"2021-03-12 15:05:47.000000000","message":"Let\u0027s add the following \"independent\" block above instead of updating this line.\nThis makes the implementation more consistent with oslo::db\n\n```\n        /^postgresql(\\+psycopg2)?:\\/\\//: {\n          $backend_package \u003d false\n        }\n```\nNOTE: We shouldn\u0027t add \"require \u0027postgresql::lib::python\u0027\" which is implemented in oslo::db.\nThis requires adding puppet-postgresql to dependencies, but we should avoid adding a new dependency for stable branches","commit_id":"2e3567a5c5f6545f9bc86441e1c2cbc4d70f9fe8"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"ba21896e3f34b60089e2c2f2f6a48442b5fc83c8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        $backend_package \u003d false"},{"line_number":67,"context_line":"      }"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"    /^(sqlite|postgresql(\\+psycopg2)?|mongodb):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?/: {"},{"line_number":70,"context_line":"      $backend_package \u003d false"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"13ed89d9_2e0e8d12","line":69,"range":{"start_line":69,"start_character":5,"end_line":69,"end_character":71},"in_reply_to":"b3758cb0_6262d992","updated":"2021-03-12 16:17:56.000000000","message":"Done","commit_id":"2e3567a5c5f6545f9bc86441e1c2cbc4d70f9fe8"}]}