)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"acd236af7871565241a6c74511ade97f4fd28154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bf32acfd_eca2ad9b","updated":"2021-11-02 13:52:24.000000000","message":"This is currently being tested by https://review.opendev.org/c/openstack/puppet-openstack-integration/+/816309","commit_id":"0582931e0f8f240e42a9ad63703161fbedd1b3b1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"54b3b04824c977143fddb9f1ea87af26e79974c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2da97914_0c7481f5","updated":"2021-11-02 17:13:02.000000000","message":"LOL! Thanks 10^6 Takashi! ","commit_id":"1288b062e8f0ac88eea9eb6e83ba6cffd119c982"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59cbeb308733b3310e82dc75976fde54d2823c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c05be97b_dd86516a","updated":"2021-11-03 09:50:29.000000000","message":"recheck","commit_id":"1288b062e8f0ac88eea9eb6e83ba6cffd119c982"}],"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7754ce20b8a80f54861bcd89adb44379062df4d1","unresolved":true,"context_lines":[{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $service_name \u003d\u003d $::octavia::params::api_service_name {"},{"line_number":155,"context_line":"      designate::generic_service { \u0027api\u0027:"},{"line_number":156,"context_line":"        enabled        \u003d\u003e $enabled,"},{"line_number":157,"context_line":"        manage_service \u003d\u003e $manage_service,"},{"line_number":158,"context_line":"        package_ensure \u003d\u003e $package_ensure,"},{"line_number":159,"context_line":"        package_name   \u003d\u003e $api_package_name,"},{"line_number":160,"context_line":"        service_name   \u003d\u003e $service_name,"},{"line_number":161,"context_line":"      }"},{"line_number":162,"context_line":"  }"},{"line_number":163,"context_line":"  elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":164,"context_line":"    include ::apache::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"98cd1508_3f468564","line":161,"range":{"start_line":155,"start_character":6,"end_line":161,"end_character":7},"updated":"2021-11-02 05:16:44.000000000","message":"We need to use this partially to install packages. Please find the similar implementation we have in puppet-placement.\n\nhttps://github.com/openstack/puppet-placement/blob/master/manifests/api.pp#L54-L83","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8d55587dd3332021f64fd72d1a76cc5b25073c4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $service_name \u003d\u003d $::octavia::params::api_service_name {"},{"line_number":155,"context_line":"      designate::generic_service { \u0027api\u0027:"},{"line_number":156,"context_line":"        enabled        \u003d\u003e $enabled,"},{"line_number":157,"context_line":"        manage_service \u003d\u003e $manage_service,"},{"line_number":158,"context_line":"        package_ensure \u003d\u003e $package_ensure,"},{"line_number":159,"context_line":"        package_name   \u003d\u003e $api_package_name,"},{"line_number":160,"context_line":"        service_name   \u003d\u003e $service_name,"},{"line_number":161,"context_line":"      }"},{"line_number":162,"context_line":"  }"},{"line_number":163,"context_line":"  elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":164,"context_line":"    include ::apache::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5268488d_dc54bda0","line":161,"range":{"start_line":155,"start_character":6,"end_line":161,"end_character":7},"in_reply_to":"98cd1508_3f468564","updated":"2021-11-02 09:11:04.000000000","message":"Done","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7754ce20b8a80f54861bcd89adb44379062df4d1","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    include ::apache::params"},{"line_number":165,"context_line":"    service { \u0027designate-api\u0027:"},{"line_number":166,"context_line":"      ensure \u003d\u003e \u0027stopped\u0027,"},{"line_number":167,"context_line":"      name   \u003d\u003e $::octavia::params::api_service_name,"},{"line_number":168,"context_line":"      enable \u003d\u003e false,"},{"line_number":169,"context_line":"      tag    \u003d\u003e [\u0027designate-service\u0027, \u0027designate-db-sync-service\u0027],"},{"line_number":170,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"70ca55df_845ca26f","line":167,"range":{"start_line":167,"start_character":19,"end_line":167,"end_character":26},"updated":"2021-11-02 05:16:44.000000000","message":"should be designate.","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8d55587dd3332021f64fd72d1a76cc5b25073c4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    include ::apache::params"},{"line_number":165,"context_line":"    service { \u0027designate-api\u0027:"},{"line_number":166,"context_line":"      ensure \u003d\u003e \u0027stopped\u0027,"},{"line_number":167,"context_line":"      name   \u003d\u003e $::octavia::params::api_service_name,"},{"line_number":168,"context_line":"      enable \u003d\u003e false,"},{"line_number":169,"context_line":"      tag    \u003d\u003e [\u0027designate-service\u0027, \u0027designate-db-sync-service\u0027],"},{"line_number":170,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"92c55793_8e277466","line":167,"range":{"start_line":167,"start_character":19,"end_line":167,"end_character":26},"in_reply_to":"70ca55df_845ca26f","updated":"2021-11-02 09:11:04.000000000","message":"Done","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ec540826b22e90f45047329b44261c915473f25d","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      $producer_package_name        \u003d \u0027openstack-designate-producer\u0027"},{"line_number":32,"context_line":"      $worker_package_name          \u003d \u0027openstack-designate-worker\u0027"},{"line_number":33,"context_line":"      $designate_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/designate\u0027"},{"line_number":34,"context_line":"      $designate_wsgi_script_source \u003d \u0027/usr/bin/designate-wsgi\u0027"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"    \u0027Debian\u0027: {"},{"line_number":37,"context_line":"      # package name"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"4f11a2a0_64105929","line":34,"range":{"start_line":34,"start_character":39,"end_line":34,"end_character":62},"updated":"2021-11-02 13:31:36.000000000","message":"this should be /usr/bin/designate-api-wsgi","commit_id":"845e032f7f7d9fd822ef5397acfb5ac2ab9738b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"acd236af7871565241a6c74511ade97f4fd28154","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      $producer_package_name        \u003d \u0027openstack-designate-producer\u0027"},{"line_number":32,"context_line":"      $worker_package_name          \u003d \u0027openstack-designate-worker\u0027"},{"line_number":33,"context_line":"      $designate_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/designate\u0027"},{"line_number":34,"context_line":"      $designate_wsgi_script_source \u003d \u0027/usr/bin/designate-wsgi\u0027"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"    \u0027Debian\u0027: {"},{"line_number":37,"context_line":"      # package name"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"0cd0da65_e453efd4","line":34,"range":{"start_line":34,"start_character":39,"end_line":34,"end_character":62},"in_reply_to":"4f11a2a0_64105929","updated":"2021-11-02 13:52:24.000000000","message":"Done","commit_id":"845e032f7f7d9fd822ef5397acfb5ac2ab9738b5"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b5d3d68bd30b17ab7ffb0d7e6adc5e1a28ed4a5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d Class: designate::wsgi::apache"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Install Octavia API under apache with mod_wsgi."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"eff08534_cb9fe521","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":17},"updated":"2021-11-02 05:21:34.000000000","message":"should be Designate.","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8d55587dd3332021f64fd72d1a76cc5b25073c4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d Class: designate::wsgi::apache"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Install Octavia API under apache with mod_wsgi."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fc0df616_e710b7ce","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":17},"in_reply_to":"eff08534_cb9fe521","updated":"2021-11-02 09:11:04.000000000","message":"Done","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b5d3d68bd30b17ab7ffb0d7e6adc5e1a28ed4a5","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*port*]"},{"line_number":27,"context_line":"#   (Optional) The port."},{"line_number":28,"context_line":"#   Defaults to 9876"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*bind_host*]"},{"line_number":31,"context_line":"#   (Optional) The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6ecf9e31_68c4afc3","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":20},"updated":"2021-11-02 05:21:34.000000000","message":"should be 9001","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8d55587dd3332021f64fd72d1a76cc5b25073c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*port*]"},{"line_number":27,"context_line":"#   (Optional) The port."},{"line_number":28,"context_line":"#   Defaults to 9876"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*bind_host*]"},{"line_number":31,"context_line":"#   (Optional) The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"613c5044_dfc43f72","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":20},"in_reply_to":"6ecf9e31_68c4afc3","updated":"2021-11-02 09:11:04.000000000","message":"Done","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b5d3d68bd30b17ab7ffb0d7e6adc5e1a28ed4a5","unresolved":true,"context_lines":[{"line_number":97,"context_line":"#"},{"line_number":98,"context_line":"class designate::wsgi::apache ("},{"line_number":99,"context_line":"  $servername                  \u003d $::fqdn,"},{"line_number":100,"context_line":"  $port                        \u003d 9876,"},{"line_number":101,"context_line":"  $bind_host                   \u003d undef,"},{"line_number":102,"context_line":"  $path                        \u003d \u0027/\u0027,"},{"line_number":103,"context_line":"  $ssl                         \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"38497a8f_39685a2e","line":100,"range":{"start_line":100,"start_character":33,"end_line":100,"end_character":37},"updated":"2021-11-02 05:21:34.000000000","message":"ditto","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8d55587dd3332021f64fd72d1a76cc5b25073c4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"#"},{"line_number":98,"context_line":"class designate::wsgi::apache ("},{"line_number":99,"context_line":"  $servername                  \u003d $::fqdn,"},{"line_number":100,"context_line":"  $port                        \u003d 9876,"},{"line_number":101,"context_line":"  $bind_host                   \u003d undef,"},{"line_number":102,"context_line":"  $path                        \u003d \u0027/\u0027,"},{"line_number":103,"context_line":"  $ssl                         \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c80cc387_5e336671","line":100,"range":{"start_line":100,"start_character":33,"end_line":100,"end_character":37},"in_reply_to":"38497a8f_39685a2e","updated":"2021-11-02 09:11:04.000000000","message":"Done","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"30c2e84ebe2aa00872bc799129d3e83b6e8e8a10","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  $port                        \u003d 9001,"},{"line_number":101,"context_line":"  $bind_host                   \u003d undef,"},{"line_number":102,"context_line":"  $path                        \u003d \u0027/\u0027,"},{"line_number":103,"context_line":"  $ssl                         \u003d false,"},{"line_number":104,"context_line":"  $workers                     \u003d $::os_workers,"},{"line_number":105,"context_line":"  $ssl_cert                    \u003d undef,"},{"line_number":106,"context_line":"  $ssl_key                     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"66d9bcd3_ebdb29c7","line":103,"range":{"start_line":103,"start_character":33,"end_line":103,"end_character":38},"updated":"2021-11-02 09:10:44.000000000","message":"It seems ssl defaults to true for most of services while the same defaults to false in some services like Octavia. We should fix this inconsistency. I think false would be the better default so I\u0027ll leave this as it is.","commit_id":"845e032f7f7d9fd822ef5397acfb5ac2ab9738b5"}],"spec/classes/designate_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7754ce20b8a80f54861bcd89adb44379062df4d1","unresolved":true,"context_lines":[{"line_number":139,"context_line":"       }"},{"line_number":140,"context_line":"       include ::apache"},{"line_number":141,"context_line":"       \""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    let :params do"},{"line_number":144,"context_line":"      {"},{"line_number":145,"context_line":"        :service_name \u003d\u003e \u0027httpd\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"461a9a48_8eaeed52","line":142,"updated":"2021-11-02 05:16:44.000000000","message":"missing \"end\"","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8d55587dd3332021f64fd72d1a76cc5b25073c4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"       }"},{"line_number":140,"context_line":"       include ::apache"},{"line_number":141,"context_line":"       \""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    let :params do"},{"line_number":144,"context_line":"      {"},{"line_number":145,"context_line":"        :service_name \u003d\u003e \u0027httpd\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"afcbb9e6_cc0aca79","line":142,"in_reply_to":"461a9a48_8eaeed52","updated":"2021-11-02 09:11:04.000000000","message":"Done","commit_id":"9dce4746716f5166806573fb1680aeb33a556738"}]}