)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2951d6a468453c720cf98028f05b537f6175e8ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f7e906e_73186c17","updated":"2022-07-04 14:21:45.000000000","message":"You also need to fix the test case in spec/classes/designate_producer_spec.pp because the coordination parameter is no longer set by default.","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"fe7920a56d5041b7ede4a352fd1c52dd97c1f8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"42e8ecb7_37d8eec9","in_reply_to":"9f7e906e_73186c17","updated":"2022-07-04 16:11:32.000000000","message":"Done","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"}],"manifests/producer.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2951d6a468453c720cf98028f05b537f6175e8ac","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  $workers        \u003d $::os_workers,"},{"line_number":45,"context_line":"  $threads        \u003d $::os_service_default,"},{"line_number":46,"context_line":"  $enabled_tasks  \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $backend_url    \u003d $::os_service_default"},{"line_number":48,"context_line":"  ) inherits designate {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4fee16d3_fa138190","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":41},"updated":"2022-07-04 14:21:45.000000000","message":"You should use undef instead otherwise pick in the coordination class can pick up this value. If a user is setting this parameter to any value (including $::os_service_default) then it is reasonable to ensure the parameter setting.","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"fe7920a56d5041b7ede4a352fd1c52dd97c1f8e6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $workers        \u003d $::os_workers,"},{"line_number":45,"context_line":"  $threads        \u003d $::os_service_default,"},{"line_number":46,"context_line":"  $enabled_tasks  \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $backend_url    \u003d $::os_service_default"},{"line_number":48,"context_line":"  ) inherits designate {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"af1f9dd4_5db0adaa","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":41},"in_reply_to":"4fee16d3_fa138190","updated":"2022-07-04 16:11:32.000000000","message":"Done","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"}],"releasenotes/notes/coordination-9043dd34f67ee3a1.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2951d6a468453c720cf98028f05b537f6175e8ac","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The ``designate::producer::backend_url`` parameter has been deprecated in"},{"line_number":9,"context_line":"    favor of the new ``designate::coordination`` class."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"30a9e293_1818fdaf","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":74},"updated":"2022-07-04 14:21:45.000000000","message":"This is not correct as you avoided deprecating the parameter. What we\u0027d like to document is\n\nUse the ``designate::coordination::backend_url`` parameter instead of the ``designate::producer::backend_url`` parameter in case the new dedicate class is used.","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"fe7920a56d5041b7ede4a352fd1c52dd97c1f8e6","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The ``designate::producer::backend_url`` parameter has been deprecated in"},{"line_number":9,"context_line":"    favor of the new ``designate::coordination`` class."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cf2358f1_24487f0c","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":74},"in_reply_to":"30a9e293_1818fdaf","updated":"2022-07-04 16:11:32.000000000","message":"Ah good point. I\u0027m not sure what the consequences are of modifying a release note in a backport is so I\u0027ve added a different release note.","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"392bb2d49620e6aa20de87aa2cc33e9a7e6e35ea","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The ``designate::producer::backend_url`` parameter has been deprecated in"},{"line_number":9,"context_line":"    favor of the new ``designate::coordination`` class."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"713c6418_85a04eae","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":74},"in_reply_to":"cf2358f1_24487f0c","updated":"2022-07-05 23:13:38.000000000","message":"Done","commit_id":"12e8d33462a5be58e3891fab78d8541f7c342485"}]}
