)]}'
{"Gemfile":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"42648f1cf56bea672271b12d8124e4b98491b45a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test do"},{"line_number":4,"context_line":"  gem \u0027puppetlabs_spec_helper\u0027,               :require \u003d\u003e \u0027false\u0027"},{"line_number":5,"context_line":"  gem \u0027rspec-puppet\u0027, \u0027~\u003e 2.2.0\u0027,             :require \u003d\u003e \u0027false\u0027"},{"line_number":6,"context_line":"  gem \u0027rspec-puppet-facts\u0027,                   :require \u003d\u003e \u0027false\u0027"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a122d0e_e4aaf118","line":3,"updated":"2016-04-15 18:06:48.000000000","message":"We\u0027ve got a new way of specifying these now, you should leverage the puppet-openstack_spec_helper for these dependencies.  It simplifies this and allows us to manage all of them in a single place. Example:  https://github.com/openstack/puppet-keystone/blob/master/Gemfile","commit_id":"925228ec9045e8eb9f4ccd7b06d440358c4925b5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8d8f2c281d1d050542aa673905dd1111067d063","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test do"},{"line_number":4,"context_line":"  gem \u0027puppetlabs_spec_helper\u0027,               :require \u003d\u003e \u0027false\u0027"},{"line_number":5,"context_line":"  gem \u0027rspec-puppet\u0027, \u0027~\u003e 2.2.0\u0027,             :require \u003d\u003e \u0027false\u0027"},{"line_number":6,"context_line":"  gem \u0027rspec-puppet-facts\u0027,                   :require \u003d\u003e \u0027false\u0027"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a122d0e_0231dda2","line":3,"in_reply_to":"1a122d0e_c71a576e","updated":"2016-04-15 18:45:17.000000000","message":"Denis i\u0027ll update with this \u003d)\nI think we can merge to unblock the work for puppet-ec2api and in the next commit we should look to have the Gemfile like the link Alex put here.","commit_id":"925228ec9045e8eb9f4ccd7b06d440358c4925b5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fab9643d160342c35068bbb6865a13d26f8b2166","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test do"},{"line_number":4,"context_line":"  gem \u0027puppetlabs_spec_helper\u0027,               :require \u003d\u003e \u0027false\u0027"},{"line_number":5,"context_line":"  gem \u0027rspec-puppet\u0027, \u0027~\u003e 2.2.0\u0027,             :require \u003d\u003e \u0027false\u0027"},{"line_number":6,"context_line":"  gem \u0027rspec-puppet-facts\u0027,                   :require \u003d\u003e \u0027false\u0027"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a122d0e_c71a576e","line":3,"in_reply_to":"1a122d0e_e4aaf118","updated":"2016-04-15 18:09:56.000000000","message":"i guess, then we need to update cookiecutter, may be we can proceed with current stuff?","commit_id":"925228ec9045e8eb9f4ccd7b06d440358c4925b5"}],"README.md":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Overview"},{"line_number":15,"context_line":"--------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The ec2api module is a part of [OpenStack](https://www.openstack.org), an effort by the OpenStack infrastructure team to provide continuous integration testing and code review for OpenStack and OpenStack community projects not part of the core software.  The module its self is used to flexibly configure and manage the FIXME service for OpenStack."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Module Description"},{"line_number":20,"context_line":"------------------"}],"source_content_type":"text/x-gfm","patch_set":3,"id":"5a18252c_cb249e61","line":17,"updated":"2016-04-14 12:42:53.000000000","message":"The module its self is used to flexibly configure and manage the FIXME service for OpenStack\n\ns/FIXME/ec2-api","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"**What the ec2api module affects**"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* [Ec2api](https://wiki.openstack.org/wiki/Ec2api), the FIXME service for OpenStack."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"### Installing ec2api"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":3,"id":"5a18252c_cbdbfe4d","line":29,"range":{"start_line":29,"start_character":52,"end_line":29,"end_character":55},"updated":"2016-04-14 12:42:53.000000000","message":"s/FIXME/ec2-api","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"}],"manifests/db/postgresql.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# \u003d\u003d Authors"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# \u003d\u003d Copyright"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class ec2api::db::postgresql("},{"line_number":36,"context_line":"  $password,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_4bc36e38","line":33,"updated":"2016-04-14 12:42:53.000000000","message":"do we need Dependencies, Examples and etc if they are empty?","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"}],"manifests/db/sync.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   to the ec2api-dbsync command."},{"line_number":9,"context_line":"#   Defaults to undef"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class ec2api::db::sync("},{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027ec2api-db-sync\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_4bf1ae94","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":22},"updated":"2016-04-14 12:42:53.000000000","message":"do we want to have \u0027user\u0027 parameter configurable?","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#   Defaults to the value of auth_name."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*public_url*]"},{"line_number":41,"context_line":"#   (optional) The endpoint\u0027s public url. (Defaults to \u0027http://127.0.0.1:FIXME\u0027)"},{"line_number":42,"context_line":"#   This url should *not* contain any trailing \u0027/\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*admin_url*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_cb0ade78","line":41,"range":{"start_line":41,"start_character":68,"end_line":41,"end_character":69},"updated":"2016-04-14 12:42:53.000000000","message":"I think we need to set correct port","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#   This url should *not* contain any trailing \u0027/\u0027."},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*admin_url*]"},{"line_number":45,"context_line":"#   (optional) The endpoint\u0027s admin url. (Defaults to \u0027http://127.0.0.1:FIXME\u0027)"},{"line_number":46,"context_line":"#   This url should *not* contain any trailing \u0027/\u0027."},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*internal_url*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_0b2976e6","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":53},"updated":"2016-04-14 12:42:53.000000000","message":"ditto","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   This url should *not* contain any trailing \u0027/\u0027."},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*internal_url*]"},{"line_number":49,"context_line":"#   (optional) The endpoint\u0027s internal url. (Defaults to \u0027http://127.0.0.1:FIXME\u0027)"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"class ec2api::keystone::auth ("},{"line_number":52,"context_line":"  $password,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_eb6cfa36","line":49,"range":{"start_line":49,"start_character":19,"end_line":49,"end_character":27},"updated":"2016-04-14 12:42:53.000000000","message":"ditto","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":62,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:FIXME\u0027,"},{"line_number":63,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:FIXME\u0027,"},{"line_number":64,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:FIXME\u0027,"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  $real_service_name    \u003d pick($service_name, $auth_name)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_0b57b658","line":64,"range":{"start_line":64,"start_character":24,"end_line":64,"end_character":25},"updated":"2016-04-14 12:42:53.000000000","message":"ditto","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"69b046aa44c45209c7ce20f1de0875f043110adf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  $real_service_name    \u003d pick($service_name, $auth_name)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if $configure_user_role {"},{"line_number":70,"context_line":"    Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e Service \u003c| name \u003d\u003d \u0027ec2api-server\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a122d0e_555eff45","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":24},"updated":"2016-04-15 13:51:38.000000000","message":"alignment","commit_id":"67b1a1dac1dc4bf0fd28169fbd85028dc13a4c6a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"69b046aa44c45209c7ce20f1de0875f043110adf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"},{"line_number":78,"context_line":"    service_name        \u003d\u003e $real_service_name,"},{"line_number":79,"context_line":"    service_type        \u003d\u003e $service_type,"},{"line_number":80,"context_line":"    service_description \u003d\u003e \u0027ec2api Service\u0027,"},{"line_number":81,"context_line":"    region              \u003d\u003e $region,"},{"line_number":82,"context_line":"    auth_name           \u003d\u003e $auth_name,"},{"line_number":83,"context_line":"    password            \u003d\u003e $password,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a122d0e_5589dfc9","line":80,"range":{"start_line":80,"start_character":27,"end_line":80,"end_character":43},"updated":"2016-04-15 13:51:38.000000000","message":"it\u0027s better to have parameter for this, like service_description.","commit_id":"67b1a1dac1dc4bf0fd28169fbd85028dc13a4c6a"}],"manifests/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"399ef5f21aeb99c663d565dac6d4e264a1e0e05b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    fatal_deprecations            \u003d\u003e $fatal_deprecations,"},{"line_number":136,"context_line":"    instance_format               \u003d\u003e $instance_format,"},{"line_number":137,"context_line":"    instance_uuid_format          \u003d\u003e $instance_uuid_format,"},{"line_number":138,"context_line":"    log_date_format               \u003d\u003e $log_date_format,"},{"line_number":139,"context_line":"  }"},{"line_number":140,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_19e1dd9a","line":138,"updated":"2016-04-14 10:10:01.000000000","message":"So, tests failed because of bug in cookiecutter template. We fixed it here: https://review.openstack.org/#/c/305314/\n\nSo you need just add one more parameter here:\n\nsyslog_log_facility \u003d\u003e $log_facility","commit_id":"30a7cf15e5181c74ce526c23a28d0b3b33f5a552"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"58a96b87b27d4fe85ae67081478a735df6b3f7bd","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    fatal_deprecations            \u003d\u003e $fatal_deprecations,"},{"line_number":136,"context_line":"    instance_format               \u003d\u003e $instance_format,"},{"line_number":137,"context_line":"    instance_uuid_format          \u003d\u003e $instance_uuid_format,"},{"line_number":138,"context_line":"    log_date_format               \u003d\u003e $log_date_format,"},{"line_number":139,"context_line":"  }"},{"line_number":140,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_7cd27f5d","line":138,"in_reply_to":"5a18252c_19e1dd9a","updated":"2016-04-14 10:13:36.000000000","message":"Done","commit_id":"30a7cf15e5181c74ce526c23a28d0b3b33f5a552"}],"manifests/params.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  case $::osfamily {"},{"line_number":6,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":7,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":8,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"    \u0027Debian\u0027: {"},{"line_number":11,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a18252c_8b33c613","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":27},"updated":"2016-04-14 12:42:53.000000000","message":"these package aren\u0027t needed because they are handled in puppet-oslo module. I think we need to fix this in cookiecutter.","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"}],"spec/classes/ec2api_keystone_auth_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"98c185109a3064c34a40e2ef115fa1c65a73b3df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      :ensure       \u003d\u003e \u0027present\u0027,"},{"line_number":36,"context_line":"      :public_url   \u003d\u003e \u0027http://127.0.0.1:FIXME\u0027,"},{"line_number":37,"context_line":"      :admin_url    \u003d\u003e \u0027http://127.0.0.1:FIXME\u0027,"},{"line_number":38,"context_line":"      :internal_url \u003d\u003e \u0027http://127.0.0.1:FIXME\u0027,"},{"line_number":39,"context_line":"    ) }"},{"line_number":40,"context_line":"  end"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a18252c_66894175","line":38,"range":{"start_line":38,"start_character":40,"end_line":38,"end_character":41},"updated":"2016-04-14 12:42:53.000000000","message":"FIXME and below","commit_id":"fb29bc54f764a1405b11ea417da4302d7d4a0077"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"69b046aa44c45209c7ce20f1de0875f043110adf","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    it { is_expected.to contain_keystone_user(\u0027ec2api\u0027) }"},{"line_number":78,"context_line":"    it { is_expected.to contain_keystone_user_role(\u0027ec2api@services\u0027) }"},{"line_number":79,"context_line":"    it { is_expected.to contain_keystone_service(\u0027ec2api_service\u0027) }"},{"line_number":80,"context_line":"    it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/ec2api_service::ec2\u0027) }"},{"line_number":81,"context_line":"  end"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a122d0e_b055e1c7","line":79,"range":{"start_line":79,"start_character":50,"end_line":79,"end_character":64},"updated":"2016-04-15 13:51:38.000000000","message":"ec2api::ec2api_service","commit_id":"67b1a1dac1dc4bf0fd28169fbd85028dc13a4c6a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"84ccba83f989b2f6313be1e5a8521f6a17564a43","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    it { is_expected.to contain_keystone_user(\u0027ec2api\u0027) }"},{"line_number":78,"context_line":"    it { is_expected.to contain_keystone_user_role(\u0027ec2api@services\u0027) }"},{"line_number":79,"context_line":"    it { is_expected.to contain_keystone_service(\u0027ec2api_service\u0027) }"},{"line_number":80,"context_line":"    it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/ec2api_service::ec2\u0027) }"},{"line_number":81,"context_line":"  end"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1a122d0e_f003d974","line":79,"range":{"start_line":79,"start_character":50,"end_line":79,"end_character":64},"in_reply_to":"1a122d0e_b055e1c7","updated":"2016-04-15 13:55:11.000000000","message":"ec2api_service::ec2\n\nthis one is correct","commit_id":"67b1a1dac1dc4bf0fd28169fbd85028dc13a4c6a"}]}