)]}'
{".rspec":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-f doc -c"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a122d0e_80bce906","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":2},"updated":"2016-04-29 18:13:06.000000000","message":"This file should be removed. I not sure, but I think puppet modules for openstack should not provide this file. Please ask EmilienM or Denis Egorenko.","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"3d19641540cf75d35f0386b5ffd1a046e4471618","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-f doc -c"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a122d0e_6051cd2f","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":2},"in_reply_to":"1a122d0e_80bce906","updated":"2016-04-29 18:26:32.000000000","message":"ok, i\u0027ll remove it","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"/COMMIT_MSG":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"0aa38826b565cfb746477b05038161b06915fab4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add manifests and class specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* remove fodora 22 because postgresql module the"},{"line_number":10,"context_line":"  openstack integration uses does not support it"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I76cc9386d368d1516e42d741314baeeae650fa80"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_fd9cd76b","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":15},"updated":"2016-04-26 08:14:20.000000000","message":"fedora","commit_id":"1eddefaac311ccde46e5f7e1e4b8f27cfc446f42"}],"lib/puppet/parser/functions/contain.rb":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Called within a class definition, establishes a containment"},{"line_number":2,"context_line":"# relationship with another class"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Puppet::Parser::Functions::newfunction("}],"source_content_type":"text/x-ruby","patch_set":11,"id":"1a122d0e_404db13c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2016-04-29 18:13:06.000000000","message":"I not sure if this file is needed. @denis?","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"3d19641540cf75d35f0386b5ffd1a046e4471618","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Called within a class definition, establishes a containment"},{"line_number":2,"context_line":"# relationship with another class"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Puppet::Parser::Functions::newfunction("}],"source_content_type":"text/x-ruby","patch_set":11,"id":"1a122d0e_205b5555","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"in_reply_to":"1a122d0e_404db13c","updated":"2016-04-29 18:26:32.000000000","message":"it\u0027s puppet-3.3 support kludge","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/api.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"0aa38826b565cfb746477b05038161b06915fab4","unresolved":false,"context_lines":[{"line_number":419,"context_line":"  validate_bool($api_service_manage)"},{"line_number":420,"context_line":"  validate_string($api_service_name)"},{"line_number":421,"context_line":"  validate_bool($api_service_enable)"},{"line_number":422,"context_line":"  "},{"line_number":423,"context_line":"  if $use_ssl {"},{"line_number":424,"context_line":"    if !$wsgi_ssl_cert_file {"},{"line_number":425,"context_line":"        fail(\"The wsgi_ssl_cert_file parameter is required when use_ssl is \\"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_3db76fd9","line":422,"updated":"2016-04-26 08:14:20.000000000","message":"please remove these spaces","commit_id":"1eddefaac311ccde46e5f7e1e4b8f27cfc446f42"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"cb18f16e8b93ea9ea85bef74ca8ac6dfb854b0d5","unresolved":false,"context_lines":[{"line_number":419,"context_line":"  validate_bool($api_service_manage)"},{"line_number":420,"context_line":"  validate_string($api_service_name)"},{"line_number":421,"context_line":"  validate_bool($api_service_enable)"},{"line_number":422,"context_line":"  "},{"line_number":423,"context_line":"  if $use_ssl {"},{"line_number":424,"context_line":"    if !$wsgi_ssl_cert_file {"},{"line_number":425,"context_line":"        fail(\"The wsgi_ssl_cert_file parameter is required when use_ssl is \\"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_296a8781","line":422,"in_reply_to":"1a122d0e_3db76fd9","updated":"2016-04-26 15:49:11.000000000","message":"Done","commit_id":"1eddefaac311ccde46e5f7e1e4b8f27cfc446f42"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  $token_cache_time                   \u003d $ec2api::params::token_cache_time,"},{"line_number":405,"context_line":"  $revocation_cache_time              \u003d $ec2api::params::revocation_cache_time,"},{"line_number":406,"context_line":"  $memcache_security_strategy         \u003d $ec2api::params::memcache_security_strategy,"},{"line_number":407,"context_line":"  $memcache_secret_key                \u003d $ec2api::params::memcache_secret_key,"},{"line_number":408,"context_line":"  $include_service_catalog            \u003d $ec2api::params::include_service_catalog,"},{"line_number":409,"context_line":"  $enforce_token_bind                 \u003d $ec2api::params::enforce_token_bind,"},{"line_number":410,"context_line":"  $check_revocations_for_cached       \u003d $ec2api::params::check_revocations_for_cached,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_9c5f7b40","line":407,"updated":"2016-04-27 15:44:05.000000000","message":"just use defaults here in class, not from params","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  $token_cache_time                   \u003d $ec2api::params::token_cache_time,"},{"line_number":405,"context_line":"  $revocation_cache_time              \u003d $ec2api::params::revocation_cache_time,"},{"line_number":406,"context_line":"  $memcache_security_strategy         \u003d $ec2api::params::memcache_security_strategy,"},{"line_number":407,"context_line":"  $memcache_secret_key                \u003d $ec2api::params::memcache_secret_key,"},{"line_number":408,"context_line":"  $include_service_catalog            \u003d $ec2api::params::include_service_catalog,"},{"line_number":409,"context_line":"  $enforce_token_bind                 \u003d $ec2api::params::enforce_token_bind,"},{"line_number":410,"context_line":"  $check_revocations_for_cached       \u003d $ec2api::params::check_revocations_for_cached,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_86aeea7e","line":407,"in_reply_to":"1a122d0e_9c5f7b40","updated":"2016-04-28 15:59:04.000000000","message":"I\u0027m using any hardcoded default values ONLY in the params class, so this goes to the params too, even if it looks stupid","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b10e29b88688730723b1a3b29267398bf51087a6","unresolved":false,"context_lines":[{"line_number":432,"context_line":"  }"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"  ec2api_config {"},{"line_number":435,"context_line":"    \u0027DEFAULT/debug\u0027:                                   value \u003d\u003e $debug;"},{"line_number":436,"context_line":"    \u0027DEFAULT/verbose\u0027:                                 value \u003d\u003e $verbose;"},{"line_number":437,"context_line":"    \u0027DEFAULT/admin_user\u0027:                              value \u003d\u003e $admin_user;"},{"line_number":438,"context_line":"    \u0027DEFAULT/admin_password\u0027:                          value \u003d\u003e $admin_password;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_3ce907b8","line":435,"updated":"2016-04-27 15:31:33.000000000","message":"those debug options should go in init.pp","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":432,"context_line":"  }"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"  ec2api_config {"},{"line_number":435,"context_line":"    \u0027DEFAULT/debug\u0027:                                   value \u003d\u003e $debug;"},{"line_number":436,"context_line":"    \u0027DEFAULT/verbose\u0027:                                 value \u003d\u003e $verbose;"},{"line_number":437,"context_line":"    \u0027DEFAULT/admin_user\u0027:                              value \u003d\u003e $admin_user;"},{"line_number":438,"context_line":"    \u0027DEFAULT/admin_password\u0027:                          value \u003d\u003e $admin_password;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_e6bd1eb2","line":435,"in_reply_to":"1a122d0e_3ce907b8","updated":"2016-04-28 15:59:04.000000000","message":"yes, good idea, but it should go to the config.pp where all basic common values should be","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":320,"context_line":"#   Default: undef"},{"line_number":321,"context_line":"#"},{"line_number":322,"context_line":"class ec2api::api ("},{"line_number":323,"context_line":"  $admin_user                         \u003d $ec2api::params::admin_user,"},{"line_number":324,"context_line":"  $admin_password                     \u003d $ec2api::params::admin_password,"},{"line_number":325,"context_line":"  $admin_tenant_name                  \u003d $ec2api::params::admin_tenant_name,"},{"line_number":326,"context_line":"  $fatal_exception_format_errors      \u003d $ec2api::params::fatal_exception_format_errors,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_e00f9ddd","line":323,"range":{"start_line":323,"start_character":40,"end_line":323,"end_character":67},"updated":"2016-04-29 18:13:06.000000000","message":"I think we have to remove all $ec2api::params:* for set attributes. ie:\nReplace \n$admin_user \u003d $ec2api::params::admin_user\nby \n$admin_user \u003d \u0027admin\u0027\nor similar.\n\nSame thing for all class attributes.","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/config.pp":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   WARNING level). Defaults to false"},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"class ec2api::config ("},{"line_number":60,"context_line":"  $config_file_path     \u003d $::ec2api::params::config_file_path,"},{"line_number":61,"context_line":"  $paste_ini_file_path  \u003d $::ec2api::params::paste_ini_file_path,"},{"line_number":62,"context_line":"  $config_file_owner    \u003d $::ec2api::params::config_file_owner,"},{"line_number":63,"context_line":"  $config_file_group    \u003d $::ec2api::params::config_file_group,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_60fc2db5","line":60,"range":{"start_line":60,"start_character":26,"end_line":60,"end_character":61},"updated":"2016-04-29 18:13:06.000000000","message":"Same comment that I wrote in api.pp","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/db.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ec2api::db"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  Configure the ec2api database"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_bf4fc932","side":"PARENT","line":3,"updated":"2016-04-27 15:44:05.000000000","message":"why you removing this class?","commit_id":"a7185157223159a2275b854df61c101a45f85d9d"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ec2api::db"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  Configure the ec2api database"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_a6796631","side":"PARENT","line":3,"in_reply_to":"1a122d0e_bf4fc932","updated":"2016-04-28 15:59:04.000000000","message":"because i removed the old manifests folder without even looking inside","commit_id":"a7185157223159a2275b854df61c101a45f85d9d"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   (Optional) Defaults to $::os_service_default"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class ec2api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d $::ec2api::params::database_connection,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d $::ec2api::params::database_idle_timeout,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d $::ec2api::params::database_min_pool_size,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d $::ec2api::params::database_max_pool_size,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_00dbb94f","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":67},"updated":"2016-04-29 18:13:06.000000000","message":"Change this by something like:\nmysql://ec2:secrete@localhost:3306/ec2api\u0027","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class ec2api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d $::ec2api::params::database_connection,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d $::ec2api::params::database_idle_timeout,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d $::ec2api::params::database_min_pool_size,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d $::ec2api::params::database_max_pool_size,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d $::ec2api::params::database_max_retries,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_80efc9e7","line":38,"range":{"start_line":38,"start_character":29,"end_line":38,"end_character":69},"updated":"2016-04-29 18:13:06.000000000","message":"From $database_iddle_timeout to $database_max_overflow params, change the value to: $::os_service_default","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/db/mysql.pp":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# \u003d\u003d parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*password*]"},{"line_number":9,"context_line":"#   Password to connect to the database."},{"line_number":10,"context_line":"#   Defaults to \u0027CHANGEME\u0027."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*dbname*]"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_c0a261ad","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"updated":"2016-04-29 18:13:06.000000000","message":"This param is Mandatory, please, put it in the docstring","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*password*]"},{"line_number":9,"context_line":"#   Password to connect to the database."},{"line_number":10,"context_line":"#   Defaults to \u0027CHANGEME\u0027."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*dbname*]"},{"line_number":13,"context_line":"#   (Optional) Name of the database."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_40977147","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":12},"updated":"2016-04-29 18:13:06.000000000","message":"As mandatory param, there is not \"default\" value","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# \u003d\u003d Copyright"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class ec2api::db::mysql ("},{"line_number":47,"context_line":"  $password      \u003d $::ec2api::params::db_password,"},{"line_number":48,"context_line":"  $user          \u003d $::ec2api::params::db_user,"},{"line_number":49,"context_line":"  $dbname        \u003d $::ec2api::params::db_name,"},{"line_number":50,"context_line":"  $host          \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_0080d9f5","line":47,"range":{"start_line":47,"start_character":19,"end_line":47,"end_character":49},"updated":"2016-04-29 18:13:06.000000000","message":"Remove this value, there should not have default value:\n$password,","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class ec2api::db::mysql ("},{"line_number":47,"context_line":"  $password      \u003d $::ec2api::params::db_password,"},{"line_number":48,"context_line":"  $user          \u003d $::ec2api::params::db_user,"},{"line_number":49,"context_line":"  $dbname        \u003d $::ec2api::params::db_name,"},{"line_number":50,"context_line":"  $host          \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $charset       \u003d \u0027utf8\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_e082fdfd","line":48,"range":{"start_line":48,"start_character":19,"end_line":48,"end_character":45},"updated":"2016-04-29 18:13:06.000000000","message":"Change value by \"ec2\"","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class ec2api::db::mysql ("},{"line_number":47,"context_line":"  $password      \u003d $::ec2api::params::db_password,"},{"line_number":48,"context_line":"  $user          \u003d $::ec2api::params::db_user,"},{"line_number":49,"context_line":"  $dbname        \u003d $::ec2api::params::db_name,"},{"line_number":50,"context_line":"  $host          \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $charset       \u003d \u0027utf8\u0027,"},{"line_number":52,"context_line":"  $collate       \u003d \u0027utf8_general_ci\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_c090a145","line":49,"range":{"start_line":49,"start_character":19,"end_line":49,"end_character":45},"updated":"2016-04-29 18:13:06.000000000","message":"Change value by: ec2api","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/db/postgresql.pp":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# \u003d\u003d Copyright"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class ec2api::db::postgresql ("},{"line_number":37,"context_line":"  $password   \u003d $::ec2api::params::db_password,"},{"line_number":38,"context_line":"  $user       \u003d $::ec2api::params::db_user,"},{"line_number":39,"context_line":"  $dbname     \u003d $::ec2api::params::db_name,"},{"line_number":40,"context_line":"  $encoding   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_40a5b19f","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":46},"updated":"2016-04-29 18:13:06.000000000","message":"Same comments than mysql.pp","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    package_ensure   \u003d\u003e $package_ensure,"},{"line_number":159,"context_line":"    package_name     \u003d\u003e $package_name,"},{"line_number":160,"context_line":"    package_provider \u003d\u003e $package_provider"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  class { \u0027::ec2api::config\u0027 :"},{"line_number":164,"context_line":"    config_file_path    \u003d\u003e $config_file_path,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_3f70d9a3","line":161,"updated":"2016-04-27 15:44:05.000000000","message":"so, we are not using init.pp main class as orchestration layer, this class should only have common things like common config, common packages and etc.","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    package_ensure   \u003d\u003e $package_ensure,"},{"line_number":159,"context_line":"    package_name     \u003d\u003e $package_name,"},{"line_number":160,"context_line":"    package_provider \u003d\u003e $package_provider"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  class { \u0027::ec2api::config\u0027 :"},{"line_number":164,"context_line":"    config_file_path    \u003d\u003e $config_file_path,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_a6920655","line":161,"in_reply_to":"1a122d0e_3f70d9a3","updated":"2016-04-28 15:59:04.000000000","message":"no, we are using the init class as the orchestration layer","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"}],"manifests/install.pp":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"35b2775116ce88de32b07544483d35a30feb0753","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ec2api::install"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Installs the packages for the Nova ec2 api services"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_807509fb","line":1,"updated":"2016-04-29 18:13:06.000000000","message":"I think we don\u0027t need this install.pp file. Other puppet modules in OpenStack don\u0027t have it","commit_id":"4d011adeedb444ac4a4273210647c5da013c8879"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Type of service. Defaults to \u0027ec2api\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*public_protocol*]"},{"line_number":34,"context_line":"#   Protocol for public endpoint. Defaults to \u0027http\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*public_address*]"},{"line_number":37,"context_line":"#   Public address for endpoint. Defaults to \u0027127.0.0.1\u0027."},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*admin_protocol*]"},{"line_number":40,"context_line":"#   Protocol for admin endpoint. Defaults to \u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*admin_address*]"},{"line_number":43,"context_line":"#   Admin address for endpoint. Defaults to \u0027127.0.0.1\u0027."},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*internal_protocol*]"},{"line_number":46,"context_line":"#   Protocol for internal endpoint. Defaults to \u0027http\u0027."},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*internal_address*]"},{"line_number":49,"context_line":"#   Internal address for endpoint. Defaults to \u0027127.0.0.1\u0027."},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"# [*port*]"},{"line_number":52,"context_line":"#   Port for endpoint. Defaults to \u00278788\u0027."},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*public_port*]"},{"line_number":55,"context_line":"#   Port for public endpoint. Defaults to $port."},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*region*]"},{"line_number":58,"context_line":"#   Region for endpoint. Defaults to \u0027RegionOne\u0027."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_bfe1892c","line":55,"range":{"start_line":34,"start_character":0,"end_line":55,"end_character":48},"updated":"2016-04-27 15:44:05.000000000","message":"plese do not use outdated port,protocol host options, please use public|internal|admin_urls","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   Type of service. Defaults to \u0027ec2api\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*public_protocol*]"},{"line_number":34,"context_line":"#   Protocol for public endpoint. Defaults to \u0027http\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*public_address*]"},{"line_number":37,"context_line":"#   Public address for endpoint. Defaults to \u0027127.0.0.1\u0027."},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*admin_protocol*]"},{"line_number":40,"context_line":"#   Protocol for admin endpoint. Defaults to \u0027http\u0027."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*admin_address*]"},{"line_number":43,"context_line":"#   Admin address for endpoint. Defaults to \u0027127.0.0.1\u0027."},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*internal_protocol*]"},{"line_number":46,"context_line":"#   Protocol for internal endpoint. Defaults to \u0027http\u0027."},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*internal_address*]"},{"line_number":49,"context_line":"#   Internal address for endpoint. Defaults to \u0027127.0.0.1\u0027."},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"# [*port*]"},{"line_number":52,"context_line":"#   Port for endpoint. Defaults to \u00278788\u0027."},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*public_port*]"},{"line_number":55,"context_line":"#   Port for public endpoint. Defaults to $port."},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*region*]"},{"line_number":58,"context_line":"#   Region for endpoint. Defaults to \u0027RegionOne\u0027."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_c6faa274","line":55,"range":{"start_line":34,"start_character":0,"end_line":55,"end_character":48},"in_reply_to":"1a122d0e_bfe1892c","updated":"2016-04-28 15:59:04.000000000","message":"ok, i\u0027ll fix it","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"}],"manifests/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    ec2api_config {"},{"line_number":161,"context_line":"      \u0027DEFAULT/fatal_deprecations\u0027 : ensure \u003d\u003e \u0027absent\u0027;"},{"line_number":162,"context_line":"    }"},{"line_number":163,"context_line":"  }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"  if $instance_format {"},{"line_number":166,"context_line":"    ec2api_config {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_3fcc59ba","line":163,"updated":"2016-04-27 15:44:05.000000000","message":"here can be used puppet-oslo module for logging parameters","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    ec2api_config {"},{"line_number":161,"context_line":"      \u0027DEFAULT/fatal_deprecations\u0027 : ensure \u003d\u003e \u0027absent\u0027;"},{"line_number":162,"context_line":"    }"},{"line_number":163,"context_line":"  }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"  if $instance_format {"},{"line_number":166,"context_line":"    ec2api_config {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_06f13a95","line":163,"in_reply_to":"1a122d0e_3fcc59ba","updated":"2016-04-28 15:59:04.000000000","message":"ok","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"}],"manifests/params.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# should be considered to be constant"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"class ec2api::params {"},{"line_number":7,"context_line":"  # [package]"},{"line_number":8,"context_line":"  $package_ensure                      \u003d \u0027present\u0027"},{"line_number":9,"context_line":"  $package_manage                      \u003d true"},{"line_number":10,"context_line":"  $package_name                        \u003d \u0027openstack-ec2-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_5f3e758b","line":7,"updated":"2016-04-27 15:44:05.000000000","message":"let\u0027s do not keep defaults for classes here, let\u0027s keep it in place in each class.","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# should be considered to be constant"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"class ec2api::params {"},{"line_number":7,"context_line":"  # [package]"},{"line_number":8,"context_line":"  $package_ensure                      \u003d \u0027present\u0027"},{"line_number":9,"context_line":"  $package_manage                      \u003d true"},{"line_number":10,"context_line":"  $package_name                        \u003d \u0027openstack-ec2-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_8658aa8b","line":7,"in_reply_to":"1a122d0e_5f3e758b","updated":"2016-04-28 15:59:04.000000000","message":"Why? I prefer to have ALL defaults in a single place and classes are able to take their values from here by inheriting it.\n\nEvery class can be used separately from other classes and can override every default parameter.\n\nInit.pp class should have NO resources and should only declare some of other classes which should always be present\nand other classes can be declared separately.\n\nIt will also be friendly to the module level Hiera based defaults Puppet 4 will be using.\n\nOf course, there are a lot of other approaches with their own pluses and minuses to the Puppet module architecture, I\u0027ve tried many of them but found this architecture to be the most convenient and flexible. It\u0027s only downside is a lot of values and parameters assignment in the init and defaults, but I write them semi-automatically.","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"}],"manifests/policy.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configure the ec2api policies"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*policies*]"},{"line_number":8,"context_line":"#   (optional) Set of policies to configure for ec2api"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_3f5a99f2","side":"PARENT","line":5,"updated":"2016-04-27 15:44:05.000000000","message":"why you removing this class?","commit_id":"a7185157223159a2275b854df61c101a45f85d9d"}],"metadata.json":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"20ed10331bbef6655015e7bda39be3a9bcbe0b63","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  ],"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  \"requirements\": ["},{"line_number":39,"context_line":"    { \"name\": \"pe\", \"version_requirement\": \"\u003e\u003d 3.4.0\"  },"},{"line_number":40,"context_line":"    { \"name\": \"puppet\", \"version_requirement\": \"\u003e\u003d 3.4.0\" }"},{"line_number":41,"context_line":"  ]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"1a122d0e_9ffacdbb","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":59},"updated":"2016-04-27 15:44:05.000000000","message":"why we need this here?","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"18a151647aa4818cd6cb23d5061f8b570caa729e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  ],"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  \"requirements\": ["},{"line_number":39,"context_line":"    { \"name\": \"pe\", \"version_requirement\": \"\u003e\u003d 3.4.0\"  },"},{"line_number":40,"context_line":"    { \"name\": \"puppet\", \"version_requirement\": \"\u003e\u003d 3.4.0\" }"},{"line_number":41,"context_line":"  ]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"1a122d0e_51a64a0f","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":59},"in_reply_to":"1a122d0e_9ffacdbb","updated":"2016-04-28 15:59:04.000000000","message":"Every module should have inforamtion about which Puppet versions are supported.\nBut it doesn\u0027t work with OpenStack CI.\n\nIn this case Puppet 3.3 and lower is NOT supported.","commit_id":"153180c98f6b5d8df7ea8c9a3134c496ea090cf1"}]}