)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3f6fbacf47536f4222a1c74f9dff5e891eda1f96","unresolved":false,"context_lines":[{"line_number":408,"context_line":"  }"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"  ec2api_config {"},{"line_number":411,"context_line":"    \u0027DEFAULT/admin_user\u0027:                              value \u003d\u003e $admin_user;"},{"line_number":412,"context_line":"    \u0027DEFAULT/admin_password\u0027:                          value \u003d\u003e $admin_password;"},{"line_number":413,"context_line":"    \u0027DEFAULT/admin_tenant_name\u0027:                       value \u003d\u003e $admin_tenant_name;"},{"line_number":414,"context_line":"    \u0027DEFAULT/fatal_exception_format_errors\u0027:           value \u003d\u003e $fatal_exception_format_errors;"},{"line_number":415,"context_line":"    \u0027DEFAULT/ec2api_listen\u0027:                           value \u003d\u003e $ec2api_listen;"},{"line_number":416,"context_line":"    \u0027DEFAULT/ec2api_listen_port\u0027:                      value \u003d\u003e $ec2api_listen_port;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_36859059","line":413,"range":{"start_line":411,"start_character":0,"end_line":413,"end_character":83},"updated":"2016-05-11 13:04:22.000000000","message":"are these parameters deprecated for keystone_authtoken parameters or they have different logic?","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"660b9a9aef4a5e9c1f9eb9d41f2e70eb526893ff","unresolved":false,"context_lines":[{"line_number":408,"context_line":"  }"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"  ec2api_config {"},{"line_number":411,"context_line":"    \u0027DEFAULT/admin_user\u0027:                              value \u003d\u003e $admin_user;"},{"line_number":412,"context_line":"    \u0027DEFAULT/admin_password\u0027:                          value \u003d\u003e $admin_password;"},{"line_number":413,"context_line":"    \u0027DEFAULT/admin_tenant_name\u0027:                       value \u003d\u003e $admin_tenant_name;"},{"line_number":414,"context_line":"    \u0027DEFAULT/fatal_exception_format_errors\u0027:           value \u003d\u003e $fatal_exception_format_errors;"},{"line_number":415,"context_line":"    \u0027DEFAULT/ec2api_listen\u0027:                           value \u003d\u003e $ec2api_listen;"},{"line_number":416,"context_line":"    \u0027DEFAULT/ec2api_listen_port\u0027:                      value \u003d\u003e $ec2api_listen_port;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_ffa4744b","line":413,"range":{"start_line":411,"start_character":0,"end_line":413,"end_character":83},"in_reply_to":"dab17558_36859059","updated":"2016-05-11 14:48:58.000000000","message":"I have no idea tbh)","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3f6fbacf47536f4222a1c74f9dff5e891eda1f96","unresolved":false,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":"  # SSL options"},{"line_number":475,"context_line":"  if $use_ssl {"},{"line_number":476,"context_line":"    if $wsgi_ssl_ca_file {"},{"line_number":477,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_ca_file\u0027: value \u003d\u003e $wsgi_ssl_ca_file }"},{"line_number":478,"context_line":"    } else {"},{"line_number":479,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_ca_file\u0027: ensure \u003d\u003e \u0027absent\u0027 }"},{"line_number":480,"context_line":"    }"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    if $wsgi_ssl_cert_file {"},{"line_number":483,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_cert_file\u0027: value \u003d\u003e $wsgi_ssl_cert_file }"},{"line_number":484,"context_line":"    } else {"},{"line_number":485,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_cert_file\u0027: ensure \u003d\u003e \u0027absent\u0027 }"},{"line_number":486,"context_line":"    }"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    if $wsgi_ssl_key_file {"},{"line_number":489,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_key_file\u0027: value \u003d\u003e $wsgi_ssl_key_file }"},{"line_number":490,"context_line":"    } else {"},{"line_number":491,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_key_file\u0027: ensure \u003d\u003e \u0027absent\u0027 }"},{"line_number":492,"context_line":"    }"},{"line_number":493,"context_line":"  } else {"},{"line_number":494,"context_line":"    ec2api_config {"},{"line_number":495,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : ensure \u003d\u003e \u0027absent\u0027;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_16d96c57","line":492,"range":{"start_line":476,"start_character":4,"end_line":492,"end_character":5},"updated":"2016-05-11 13:04:22.000000000","message":"these parameters can be set $::os_service_default\n\nalso, all another parameters, which have default same to prject default can be set to $::os_service_default too.","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"660b9a9aef4a5e9c1f9eb9d41f2e70eb526893ff","unresolved":false,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":"  # SSL options"},{"line_number":475,"context_line":"  if $use_ssl {"},{"line_number":476,"context_line":"    if $wsgi_ssl_ca_file {"},{"line_number":477,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_ca_file\u0027: value \u003d\u003e $wsgi_ssl_ca_file }"},{"line_number":478,"context_line":"    } else {"},{"line_number":479,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_ca_file\u0027: ensure \u003d\u003e \u0027absent\u0027 }"},{"line_number":480,"context_line":"    }"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    if $wsgi_ssl_cert_file {"},{"line_number":483,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_cert_file\u0027: value \u003d\u003e $wsgi_ssl_cert_file }"},{"line_number":484,"context_line":"    } else {"},{"line_number":485,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_cert_file\u0027: ensure \u003d\u003e \u0027absent\u0027 }"},{"line_number":486,"context_line":"    }"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    if $wsgi_ssl_key_file {"},{"line_number":489,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_key_file\u0027: value \u003d\u003e $wsgi_ssl_key_file }"},{"line_number":490,"context_line":"    } else {"},{"line_number":491,"context_line":"      ec2api_config { \u0027DEFAULT/ssl_key_file\u0027: ensure \u003d\u003e \u0027absent\u0027 }"},{"line_number":492,"context_line":"    }"},{"line_number":493,"context_line":"  } else {"},{"line_number":494,"context_line":"    ec2api_config {"},{"line_number":495,"context_line":"      \u0027DEFAULT/ssl_cert_file\u0027 : ensure \u003d\u003e \u0027absent\u0027;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_bf75cccb","line":492,"range":{"start_line":476,"start_character":4,"end_line":492,"end_character":5},"in_reply_to":"dab17558_16d96c57","updated":"2016-05-11 14:48:58.000000000","message":"Ok, i\u0027ll do it","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3f6fbacf47536f4222a1c74f9dff5e891eda1f96","unresolved":false,"context_lines":[{"line_number":498,"context_line":"    }"},{"line_number":499,"context_line":"  }"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"  if $api_service_enable {"},{"line_number":502,"context_line":"    $api_service_ensure \u003d \u0027running\u0027"},{"line_number":503,"context_line":"  } else {"},{"line_number":504,"context_line":"    $api_service_ensure \u003d \u0027stopped\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_362e30fb","line":501,"updated":"2016-05-11 13:04:22.000000000","message":"https://github.com/openstack/puppet-neutron/blob/master/manifests/server.pp#L567\n\nwe are using just manage_service and service_ensure params for this.\n\nsame for other services","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"660b9a9aef4a5e9c1f9eb9d41f2e70eb526893ff","unresolved":false,"context_lines":[{"line_number":498,"context_line":"    }"},{"line_number":499,"context_line":"  }"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"  if $api_service_enable {"},{"line_number":502,"context_line":"    $api_service_ensure \u003d \u0027running\u0027"},{"line_number":503,"context_line":"  } else {"},{"line_number":504,"context_line":"    $api_service_ensure \u003d \u0027stopped\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_7a59b234","line":501,"in_reply_to":"dab17558_362e30fb","updated":"2016-05-11 14:48:58.000000000","message":"Ok, i\u0027ll change them","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b0d0e97bb230c8aa0a64c9f5b0195ce242929d78","unresolved":false,"context_lines":[{"line_number":371,"context_line":"  $http_request_max_retries           \u003d 3,"},{"line_number":372,"context_line":"  $admin_token                        \u003d $::os_service_default,"},{"line_number":373,"context_line":"  $keystone_admin_user                \u003d \u0027ec2api\u0027,"},{"line_number":374,"context_line":"  $keystone_admin_password            \u003d $::os_service_default,"},{"line_number":375,"context_line":"  $keystone_admin_tenant_name         \u003d \u0027services\u0027,"},{"line_number":376,"context_line":"  $keystone_certfile                  \u003d $::os_service_default,"},{"line_number":377,"context_line":"  $keystone_keyfile                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_58b99e14","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":62},"updated":"2016-05-16 11:38:55.000000000","message":"since we have only one auth strategy for now - keystone - i think this parameter should be required","commit_id":"d838fd36bbe1567fa4f5e70caa7a2190ce20ee12"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"# [*ec2_host*]"},{"line_number":101,"context_line":"#   The IP address of the EC2 API server"},{"line_number":102,"context_line":"#   Defaults $my_ip"},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"# [*ec2_port*]"},{"line_number":105,"context_line":"#   The port of the EC2 API server"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_783ed9b8","line":102,"updated":"2016-05-17 13:59:12.000000000","message":"it overlaps with the listen address defined before, no?","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#   Defaults $my_ip"},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"# [*ec2_port*]"},{"line_number":105,"context_line":"#   The port of the EC2 API server"},{"line_number":106,"context_line":"#   Defaults 8788"},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"# [*ec2_scheme*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_d849c561","line":105,"updated":"2016-05-17 13:59:12.000000000","message":"it overlaps with the listen port already define before, right?","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    }"},{"line_number":482,"context_line":"  }"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"  service { \u0027openstack-ec2api-api-service\u0027 :"},{"line_number":485,"context_line":"    ensure     \u003d\u003e $service_ensure,"},{"line_number":486,"context_line":"    name       \u003d\u003e $service_name,"},{"line_number":487,"context_line":"    enable     \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_b844c146","line":484,"updated":"2016-05-17 13:59:12.000000000","message":"the name is ugly, what can\u0027t it be openstack-ec2-api-service?","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"b5397ba6067d77229fe04e368bd8fd4eb2411b90","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    }"},{"line_number":482,"context_line":"  }"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"  service { \u0027openstack-ec2api-api-service\u0027 :"},{"line_number":485,"context_line":"    ensure     \u003d\u003e $service_ensure,"},{"line_number":486,"context_line":"    name       \u003d\u003e $service_name,"},{"line_number":487,"context_line":"    enable     \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_9b09dcdf","line":484,"in_reply_to":"dab17558_b844c146","updated":"2016-05-17 23:31:06.000000000","message":"Done","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":488,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":489,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":490,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":491,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":492,"context_line":"  }"},{"line_number":493,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_1876ada3","line":490,"updated":"2016-05-17 13:59:12.000000000","message":"we should not need it.","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"b5397ba6067d77229fe04e368bd8fd4eb2411b90","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":488,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":489,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":490,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":491,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":492,"context_line":"  }"},{"line_number":493,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_3bfb90c2","line":490,"in_reply_to":"dab17558_1876ada3","updated":"2016-05-17 23:31:06.000000000","message":"Puppet often select wrong providers, especially on Ubuntu, and on RH sometimes too. Mixing up sysv, upstart and systemd services can create a lot of FUN.","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":489,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":490,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":491,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":492,"context_line":"  }"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"  Ec2api_config \u003c||\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_f8780991","line":491,"updated":"2016-05-17 13:59:12.000000000","message":"some tags are missing please look other modules","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"b5397ba6067d77229fe04e368bd8fd4eb2411b90","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":489,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":490,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":491,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":492,"context_line":"  }"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"  Ec2api_config \u003c||\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_7b6a3882","line":491,"in_reply_to":"dab17558_f8780991","updated":"2016-05-17 23:31:06.000000000","message":"I see only one tag on services in other modules...","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cdf698f7befcc62b558d6ac671585ef93c0885e3","unresolved":false,"context_lines":[{"line_number":333,"context_line":"#"},{"line_number":334,"context_line":"class ec2api::api ("},{"line_number":335,"context_line":"  $keystone_admin_password,"},{"line_number":336,"context_line":"  $admin_user                         \u003d $::os_service_default,"},{"line_number":337,"context_line":"  $admin_password                     \u003d $::os_service_default,"},{"line_number":338,"context_line":"  $admin_tenant_name                  \u003d $::os_service_default,"},{"line_number":339,"context_line":"  $fatal_exception_format_errors      \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"bab6814e_2c746834","line":336,"range":{"start_line":336,"start_character":40,"end_line":336,"end_character":61},"updated":"2016-05-26 04:56:16.000000000","message":"Please updtade the doc in this file some parameters you declare $::os_service_default but you have put undef in the doc","commit_id":"ebe6d452b39a8c7c84e8840cebd54b88558cea19"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"780ccd93beed278ad9bf67bb66d94d6007782756","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*service_down_time*]"},{"line_number":58,"context_line":"#   Maximum time since last check-in for up service."},{"line_number":59,"context_line":"#   Defaul: 60"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*api_paste_config*]"},{"line_number":62,"context_line":"#   File name for the paste.deploy config for ec2api."}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9abb7d3a_4e68b487","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":10},"updated":"2016-05-31 15:59:32.000000000","message":"Default","commit_id":"8766a37aa342ef5bb3000d628d72753830ef0557"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"780ccd93beed278ad9bf67bb66d94d6007782756","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  $http_connect_timeout               \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $http_request_max_retries           \u003d 3,"},{"line_number":381,"context_line":"  $admin_token                        \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $keystone_admin_user                \u003d \u0027ec2api\u0027,"},{"line_number":383,"context_line":"  $keystone_admin_tenant_name         \u003d \u0027services\u0027,"},{"line_number":384,"context_line":"  $keystone_certfile                  \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $keystone_keyfile                   \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $keystone_cafile                    \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $insecure                           \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9abb7d3a_a94f9a69","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":61},"updated":"2016-05-31 15:59:32.000000000","message":"These auth options seem to be deprecated. Can you please check if its possible to switch to auth plugins and related params?","commit_id":"8766a37aa342ef5bb3000d628d72753830ef0557"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"b7e107021c7a2fcc87809520d647fd88997c86c7","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  $http_connect_timeout               \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $http_request_max_retries           \u003d 3,"},{"line_number":381,"context_line":"  $admin_token                        \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $keystone_admin_user                \u003d \u0027ec2api\u0027,"},{"line_number":383,"context_line":"  $keystone_admin_tenant_name         \u003d \u0027services\u0027,"},{"line_number":384,"context_line":"  $keystone_certfile                  \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $keystone_keyfile                   \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $keystone_cafile                    \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $insecure                           \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9abb7d3a_00786bc3","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":61},"in_reply_to":"9abb7d3a_60bfb760","updated":"2016-06-06 23:58:36.000000000","message":"It can be fixed in later patches anyway.","commit_id":"8766a37aa342ef5bb3000d628d72753830ef0557"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"a7a0a2929ee4bfebf114f39b5fea1e50a4b4bcac","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  $http_connect_timeout               \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $http_request_max_retries           \u003d 3,"},{"line_number":381,"context_line":"  $admin_token                        \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $keystone_admin_user                \u003d \u0027ec2api\u0027,"},{"line_number":383,"context_line":"  $keystone_admin_tenant_name         \u003d \u0027services\u0027,"},{"line_number":384,"context_line":"  $keystone_certfile                  \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $keystone_keyfile                   \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $keystone_cafile                    \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $insecure                           \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9abb7d3a_60bfb760","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":61},"in_reply_to":"9abb7d3a_a94f9a69","updated":"2016-06-03 18:03:15.000000000","message":"Nope, I have no idea what do these auth plugins mean.","commit_id":"8766a37aa342ef5bb3000d628d72753830ef0557"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#   Number of workers for metadata service."},{"line_number":54,"context_line":"#   The default will be the number of CPUs available."},{"line_number":55,"context_line":"#   Default: $::os_service_default"},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*service_down_time*]"},{"line_number":58,"context_line":"#   Maximum time since last check-in for up service."},{"line_number":59,"context_line":"#   Default: 60"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_7dcfe755","line":56,"updated":"2016-06-08 19:15:35.000000000","message":"why don\u0027t we have the metadata_* in metadata.pp?","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*log_dir*]"},{"line_number":66,"context_line":"#   Directory to save the logs."},{"line_number":67,"context_line":"#   Default: \u0027/var/log/ec2api\u0027"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*use_ssl*]"},{"line_number":70,"context_line":"#   Server will work under SSL."}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_ddda5b16","line":67,"updated":"2016-06-08 19:15:35.000000000","message":"why do we have this thing in api.pp? Why not only in logging or in init like we have for other modules?","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":190,"context_line":"#   This should specify the unversioned root endpoint."},{"line_number":191,"context_line":"#   Default: \u0027http://localhost:35357/\u0027"},{"line_number":192,"context_line":"#"},{"line_number":193,"context_line":"# [*auth_version*]"},{"line_number":194,"context_line":"#   API version of the admin Identity API endpoint"},{"line_number":195,"context_line":"#   Default: \u0027v2.0\u0027"},{"line_number":196,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_bdd5cfe5","line":193,"updated":"2016-06-08 19:15:35.000000000","message":"isn\u0027t it deprecated from OpenStack? is it actually useful?","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":208,"context_line":"#   Default: 3"},{"line_number":209,"context_line":"#"},{"line_number":210,"context_line":"# [*admin_token*]"},{"line_number":211,"context_line":"#   This option is deprecated and may be removed in a future release. Single"},{"line_number":212,"context_line":"#   shared secret with the Keystone configuration used for bootstrapping a"},{"line_number":213,"context_line":"#   Keystone installation, or otherwise bypassing the normal authentication"},{"line_number":214,"context_line":"#   process. This option should not be used, use `admin_user` and"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_1d07c382","line":211,"updated":"2016-06-08 19:15:35.000000000","message":"why do we deprecated that? it\u0027s a new module.","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"f29cb1da237a15fa42f220d566210d79cdcf06f6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"#   Default: 3"},{"line_number":209,"context_line":"#"},{"line_number":210,"context_line":"# [*admin_token*]"},{"line_number":211,"context_line":"#   This option is deprecated and may be removed in a future release. Single"},{"line_number":212,"context_line":"#   shared secret with the Keystone configuration used for bootstrapping a"},{"line_number":213,"context_line":"#   Keystone installation, or otherwise bypassing the normal authentication"},{"line_number":214,"context_line":"#   process. This option should not be used, use `admin_user` and"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_6d9ff850","line":211,"in_reply_to":"7aa08908_1d07c382","updated":"2016-06-09 17:51:52.000000000","message":"I don\u0027t know. I didn\u0027t make the list of these options, I\u0027ve just taken the existing one.","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":220,"context_line":"#   Default: \u0027ec2api\u0027"},{"line_number":221,"context_line":"#"},{"line_number":222,"context_line":"# [*keystone_admin_password*]"},{"line_number":223,"context_line":"#   (Mandatory) Keystone account password"},{"line_number":224,"context_line":"#"},{"line_number":225,"context_line":"# [*keystone_admin_tenant_name*]"},{"line_number":226,"context_line":"#   Keystone service account tenant name to validate user tokens"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_fd091796","line":223,"updated":"2016-06-08 19:15:35.000000000","message":"(Required)","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#   The real system name of the API service."},{"line_number":324,"context_line":"#   Default: openstack-ec2-api"},{"line_number":325,"context_line":"#"},{"line_number":326,"context_line":"# [*enabled*]"},{"line_number":327,"context_line":"#   Should the service be enabled and started (true) of disabled and stopped (false)."},{"line_number":328,"context_line":"#   Default: true"},{"line_number":329,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_5dfdcb6c","line":326,"updated":"2016-06-08 19:15:35.000000000","message":"For most of docstring, you missed the (optional) thing. Not a big deal, just FYI.","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":397,"context_line":"  $hash_algorithms                    \u003d \u0027md5\u0027,"},{"line_number":398,"context_line":"  $manage_service                     \u003d true,"},{"line_number":399,"context_line":"  $service_name                       \u003d $::ec2api::params::api_service_name,"},{"line_number":400,"context_line":"  $enabled                            \u003d true,"},{"line_number":401,"context_line":") inherits ::ec2api::params {"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"  validate_bool($manage_service)"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_3d00bf65","line":400,"updated":"2016-06-08 19:15:35.000000000","message":"this is really big... I think we have a design issue here. api.pp is really too big. Can\u0027t we split a little bit? See puppet-gnocchi for example or other modules, to see how we like splitting things.","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"d12f5e91a5c2adf7a15788aaa55070f39b948608","unresolved":false,"context_lines":[{"line_number":321,"context_line":"#   Default: true"},{"line_number":322,"context_line":"#"},{"line_number":323,"context_line":"class ec2api::api ("},{"line_number":324,"context_line":"  # API"},{"line_number":325,"context_line":"  $keystone_url                       \u003d $::os_service_default,"},{"line_number":326,"context_line":"  $keystone_ec2_tokens_url            \u003d $::os_service_default,"},{"line_number":327,"context_line":"  $ec2_timestamp_expiry               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7aa08908_3daa261a","line":324,"updated":"2016-06-10 07:02:51.000000000","message":"We need \"debug\" and \"verbose\" parameters","commit_id":"17efba66ab6e600155b0b68061c15c2caafcdb56"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"39531913a1488072d35624f84597700437ed2a3c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"#   Default: true"},{"line_number":322,"context_line":"#"},{"line_number":323,"context_line":"class ec2api::api ("},{"line_number":324,"context_line":"  # API"},{"line_number":325,"context_line":"  $keystone_url                       \u003d $::os_service_default,"},{"line_number":326,"context_line":"  $keystone_ec2_tokens_url            \u003d $::os_service_default,"},{"line_number":327,"context_line":"  $ec2_timestamp_expiry               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7aa08908_4c465b22","line":324,"in_reply_to":"7aa08908_3daa261a","updated":"2016-06-10 09:36:17.000000000","message":"Verbose was deprecated and has no effect since mitaka.","commit_id":"17efba66ab6e600155b0b68061c15c2caafcdb56"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"eef71cd0c9a5379a7ee32f58440118c445624442","unresolved":false,"context_lines":[{"line_number":324,"context_line":"#   Show debug messages"},{"line_number":325,"context_line":"#"},{"line_number":326,"context_line":"# [*verbose*]"},{"line_number":327,"context_line":"#   (Depricated) Increase verbosity"},{"line_number":328,"context_line":"#"},{"line_number":329,"context_line":"class ec2api::api ("},{"line_number":330,"context_line":"  # API"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"7aa08908_30cd1db8","line":327,"range":{"start_line":327,"start_character":5,"end_line":327,"end_character":15},"updated":"2016-06-10 12:13:20.000000000","message":"s/Depricated/Deprecated","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"eef71cd0c9a5379a7ee32f58440118c445624442","unresolved":false,"context_lines":[{"line_number":398,"context_line":"  # Exception"},{"line_number":399,"context_line":"  $fatal_exception_format_errors      \u003d $::os_service_default,"},{"line_number":400,"context_line":"  # Paths"},{"line_number":401,"context_line":"  $tempdir                            \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $pybasedir                          \u003d $::os_service_default,"},{"line_number":403,"context_line":"  $bindir                             \u003d $::os_service_default,"},{"line_number":404,"context_line":"  $state_path                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"7aa08908_d02019fa","line":401,"updated":"2016-06-10 12:13:20.000000000","message":"\"tempdir\" should be configurable too, right? You didn\u0027t add it to ec2api_conf dictionary yet.","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"4013bc99b064364cb171242418301e917036d722","unresolved":false,"context_lines":[{"line_number":398,"context_line":"  # Exception"},{"line_number":399,"context_line":"  $fatal_exception_format_errors      \u003d $::os_service_default,"},{"line_number":400,"context_line":"  # Paths"},{"line_number":401,"context_line":"  $tempdir                            \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $pybasedir                          \u003d $::os_service_default,"},{"line_number":403,"context_line":"  $bindir                             \u003d $::os_service_default,"},{"line_number":404,"context_line":"  $state_path                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"7aa08908_b703bc75","line":401,"in_reply_to":"7aa08908_d02019fa","updated":"2016-06-10 14:22:59.000000000","message":"No, it\u0027s there","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"eef71cd0c9a5379a7ee32f58440118c445624442","unresolved":false,"context_lines":[{"line_number":409,"context_line":"  # Debug"},{"line_number":410,"context_line":"  $debug                              \u003d $::os_service_default,"},{"line_number":411,"context_line":"  $verbose                            \u003d $::os_service_default,"},{"line_number":412,"context_line":") inherits ::ec2api::params {"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  validate_bool($manage_service)"},{"line_number":415,"context_line":"  validate_string($service_name)"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"7aa08908_50d1c9cc","line":412,"updated":"2016-06-10 12:13:20.000000000","message":"params missed:\n- log_file \n- log_dir\n- wsgi_log_format","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"2ee32e7ea9eefa7072e4ac98c0ae24471785e262","unresolved":false,"context_lines":[{"line_number":409,"context_line":"  # Debug"},{"line_number":410,"context_line":"  $debug                              \u003d $::os_service_default,"},{"line_number":411,"context_line":"  $verbose                            \u003d $::os_service_default,"},{"line_number":412,"context_line":") inherits ::ec2api::params {"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  validate_bool($manage_service)"},{"line_number":415,"context_line":"  validate_string($service_name)"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"7aa08908_ea787cc6","line":412,"in_reply_to":"7aa08908_173a9034","updated":"2016-06-13 08:50:41.000000000","message":"I learnt it because I installed the ec2api and checked the ec2api.conf file. AFAIK, the log file is managed by oslo, but in the ec2api.conf file you have to set the name and place for the log file","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"4013bc99b064364cb171242418301e917036d722","unresolved":false,"context_lines":[{"line_number":409,"context_line":"  # Debug"},{"line_number":410,"context_line":"  $debug                              \u003d $::os_service_default,"},{"line_number":411,"context_line":"  $verbose                            \u003d $::os_service_default,"},{"line_number":412,"context_line":") inherits ::ec2api::params {"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  validate_bool($manage_service)"},{"line_number":415,"context_line":"  validate_string($service_name)"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"7aa08908_173a9034","line":412,"in_reply_to":"7aa08908_50d1c9cc","updated":"2016-06-10 14:22:59.000000000","message":"How did you learn of there existance?\nI could not find any documentation aboub \"what you can write into the ec2api config\"\nAnd should they be managed bu the oslo::logging?","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"}],"manifests/metadata.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  service { \u0027openstack-ec2-api-metadata\u0027 :"},{"line_number":98,"context_line":"    ensure     \u003d\u003e $service_ensure,"},{"line_number":99,"context_line":"    name       \u003d\u003e $service_name,"},{"line_number":100,"context_line":"    enable     \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_5855d5f7","line":97,"updated":"2016-05-17 13:59:12.000000000","message":"why service name is not openstack-ec2api-api-metadata here? It\u0027s not consistent with api.pp","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":101,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":102,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":103,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":104,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_3858d130","line":103,"updated":"2016-05-17 13:59:12.000000000","message":"we don\u0027t need it","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":102,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":103,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":104,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  Ec2api_config \u003c||\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_9843bd41","line":104,"updated":"2016-05-17 13:59:12.000000000","message":"some tags are missing, please look other modules.","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cdf698f7befcc62b558d6ac671585ef93c0885e3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $nova_client_cert             \u003d undef,"},{"line_number":61,"context_line":"  $nova_client_priv_key         \u003d undef,"},{"line_number":62,"context_line":"  $metadata_proxy_shared_secret \u003d undef,"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  $manage_service               \u003d true,"},{"line_number":65,"context_line":"  $service_name                 \u003d $::ec2api::params::metadata_service_name,"},{"line_number":66,"context_line":"  $enabled                      \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"bab6814e_0cd6c4f0","line":63,"updated":"2016-05-26 04:56:16.000000000","message":"don\u0027t see why skip this line \u003d)","commit_id":"ebe6d452b39a8c7c84e8840cebd54b88558cea19"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cdf698f7befcc62b558d6ac671585ef93c0885e3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $service_name                 \u003d $::ec2api::params::metadata_service_name,"},{"line_number":66,"context_line":"  $enabled                      \u003d true,"},{"line_number":67,"context_line":"  $service_provider             \u003d undef,"},{"line_number":68,"context_line":") inherits ::ec2api::params {"},{"line_number":69,"context_line":"  validate_string($nova_metadata_ip)"},{"line_number":70,"context_line":"  validate_integer($nova_metadata_port)"},{"line_number":71,"context_line":"  validate_string($nova_metadata_protocol)"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"bab6814e_ccc83c58","line":68,"updated":"2016-05-26 04:56:16.000000000","message":"can you skip a line after the \"{\" it will make the file more readable.","commit_id":"ebe6d452b39a8c7c84e8840cebd54b88558cea19"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3eff7ed4269358d1d6f9d8b9031498d7dd2695ea","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  Ec2api_config \u003c||\u003e ~\u003e"},{"line_number":102,"context_line":"  Service[\u0027openstack-ec2-metadata-service\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7aa08908_9dd453ec","line":104,"updated":"2016-06-08 19:15:35.000000000","message":"this manifest is good! can we have something similar for api service? and move some bits in other classes?","commit_id":"10c28edb609863bee3a1fc8f6d1b46c9b9de62c8"}],"manifests/params.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3f6fbacf47536f4222a1c74f9dff5e891eda1f96","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $debug                 \u003d false"},{"line_number":28,"context_line":"  $verbose               \u003d false"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  $log_dir               \u003d \u0027/var/log/ec2api\u0027"},{"line_number":31,"context_line":"  $log_file              \u003d \u0027/var/log/ec2api/ec2api.log\u0027"},{"line_number":32,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_16a7acbd","line":31,"range":{"start_line":27,"start_character":0,"end_line":31,"end_character":55},"updated":"2016-05-11 13:04:22.000000000","message":"i guess it shouldnt be here","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  case $::osfamily {"},{"line_number":8,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":9,"context_line":"      $package_name \u003d \u0027openstack-ec2-api\u0027"},{"line_number":10,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":11,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_581e755f","line":10,"updated":"2016-05-17 13:59:12.000000000","message":"we don\u0027t need it","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":9,"context_line":"      $package_name \u003d \u0027openstack-ec2-api\u0027"},{"line_number":10,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":11,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    \u0027Debian\u0027: {"},{"line_number":14,"context_line":"      $package_name \u003d \u0027ec2api\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_3821f19e","line":11,"updated":"2016-05-17 13:59:12.000000000","message":"same","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    \u0027Debian\u0027: {"},{"line_number":14,"context_line":"      $package_name \u003d \u0027ec2api\u0027"},{"line_number":15,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"},{"line_number":16,"context_line":"      $pymysql_package_name \u003d \u0027python-pymysql\u0027"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_983c5dc9","line":15,"updated":"2016-05-17 13:59:12.000000000","message":"same","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u0027Debian\u0027: {"},{"line_number":14,"context_line":"      $package_name \u003d \u0027ec2api\u0027"},{"line_number":15,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"},{"line_number":16,"context_line":"      $pymysql_package_name \u003d \u0027python-pymysql\u0027"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"    default: {"},{"line_number":19,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_7837f9e2","line":16,"updated":"2016-05-17 13:59:12.000000000","message":"same","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_d83265f1","line":23,"updated":"2016-05-17 13:59:12.000000000","message":"ah you see? service name is clear now :-) Use this one please","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $log_dir               \u003d \u0027/var/log/ec2api\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_b82de190","line":24,"updated":"2016-05-17 13:59:12.000000000","message":"Same here","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $log_dir               \u003d \u0027/var/log/ec2api\u0027"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_184fcd6b","line":25,"updated":"2016-05-17 13:59:12.000000000","message":"Same here","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $log_dir               \u003d \u0027/var/log/ec2api\u0027"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_f851290f","line":27,"updated":"2016-05-17 13:59:12.000000000","message":"why do we need that?","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  case $::osfamily {"},{"line_number":8,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":9,"context_line":"      $package_name \u003d \u0027openstack-ec2-api\u0027"},{"line_number":10,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":11,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_64ba36c2","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":35},"updated":"2016-05-19 13:20:04.000000000","message":"we use puppet oslo to configure db related parameters and this package has been defined in oslo, so we don\u0027t need it.","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":9,"context_line":"      $package_name \u003d \u0027openstack-ec2-api\u0027"},{"line_number":10,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":11,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    \u0027Debian\u0027: {"},{"line_number":14,"context_line":"      $package_name \u003d \u0027ec2api\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_44fe1238","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":35},"updated":"2016-05-19 13:20:04.000000000","message":"same","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    \u0027Debian\u0027: {"},{"line_number":14,"context_line":"      $package_name \u003d \u0027ec2api\u0027"},{"line_number":15,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"},{"line_number":16,"context_line":"      $pymysql_package_name \u003d \u0027python-pymysql\u0027"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_a4a37e4e","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":48},"updated":"2016-05-19 13:20:04.000000000","message":"same","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u0027Debian\u0027: {"},{"line_number":14,"context_line":"      $package_name \u003d \u0027ec2api\u0027"},{"line_number":15,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"},{"line_number":16,"context_line":"      $pymysql_package_name \u003d \u0027python-pymysql\u0027"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"    default: {"},{"line_number":19,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_e48586ad","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":46},"updated":"2016-05-19 13:20:04.000000000","message":"same","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_672a3880","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":46},"updated":"2016-05-19 13:20:04.000000000","message":"service name is clear now.","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $log_dir               \u003d \u0027/var/log/ec2api\u0027"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_c72164a1","line":25,"range":{"start_line":24,"start_character":2,"end_line":25,"end_character":49},"updated":"2016-05-19 13:20:04.000000000","message":"same","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":25,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  $log_dir               \u003d \u0027/var/log/ec2api\u0027"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"bab6814e_844bda86","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":44},"updated":"2016-05-19 13:20:04.000000000","message":"why is this option here?","commit_id":"778003c90f7b150a04869e9d49df60f819182132"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8c2dccc758f885f113d4d1b30718601798e3b789","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":20,"context_line":"  $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":21,"context_line":"  $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9abb7d3a_6e92d8f7","line":21,"updated":"2016-05-31 15:57:15.000000000","message":"I think these service names are correct for rpms only, but we don\u0027t have deb packages yet","commit_id":"8766a37aa342ef5bb3000d628d72753830ef0557"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d5d4bf6a0332e66ebd0f7e1b80dac3cb3f34ec0e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      $package_name          \u003d \u0027ec2api\u0027"},{"line_number":16,"context_line":"      $api_service_name      \u003d \u0027openstack-ec2-api\u0027"},{"line_number":17,"context_line":"      $metadata_service_name \u003d \u0027openstack-ec2-api-metadata\u0027"},{"line_number":18,"context_line":"      $s3_service_name       \u003d \u0027openstack-ec2-api-s3\u0027"},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"    default: {"},{"line_number":21,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"7aa08908_04e1312a","line":18,"updated":"2016-06-14 14:45:24.000000000","message":"I am not sure that packages in debian will be named with openstack- prefix. Let\u0027s leave some comments that these parameters should be updated when UCA provides packages","commit_id":"c5e2e28c82b16f6e61f4e6e222482c6083bd4387"}],"manifests/s3.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $manage_service      \u003d true,"},{"line_number":41,"context_line":"  $service_name        \u003d $::ec2api::params::s3_service_name,"},{"line_number":42,"context_line":"  $enabled             \u003d true,"},{"line_number":43,"context_line":"  $service_provider    \u003d undef,"},{"line_number":44,"context_line":") inherits ::ec2api::params {"},{"line_number":45,"context_line":"  validate_string($s3_listen)"},{"line_number":46,"context_line":"  validate_integer($s3_listen_port)"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_586cb5cf","line":43,"updated":"2016-05-17 13:59:12.000000000","message":"not needed","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":73,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":74,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":75,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":76,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_386f31c5","line":75,"updated":"2016-05-17 13:59:12.000000000","message":"not needed","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1ee4494226dbed132d8de9375feedb61d61c576","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":74,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":75,"context_line":"    provider   \u003d\u003e $service_provider,"},{"line_number":76,"context_line":"    tag        \u003d\u003e \u0027ec2api\u0027,"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Ec2api_config \u003c||\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_986a9db1","line":76,"updated":"2016-05-17 13:59:12.000000000","message":"add tags","commit_id":"4407bc9e66f99c152d9ba718dc7778dfab8ff75f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cdf698f7befcc62b558d6ac671585ef93c0885e3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $manage_service      \u003d true,"},{"line_number":41,"context_line":"  $service_name        \u003d $::ec2api::params::s3_service_name,"},{"line_number":42,"context_line":"  $enabled             \u003d true,"},{"line_number":43,"context_line":"  $service_provider    \u003d undef,"},{"line_number":44,"context_line":") inherits ::ec2api::params {"},{"line_number":45,"context_line":"  validate_string($s3_listen)"},{"line_number":46,"context_line":"  validate_integer($s3_listen_port)"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"bab6814e_ace5f8a4","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":31},"updated":"2016-05-26 04:56:16.000000000","message":"In Patch #7 I think Emilien told this is not needed, any reason to keep?","commit_id":"ebe6d452b39a8c7c84e8840cebd54b88558cea19"}],"spec/classes/ec2api_api_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3f6fbacf47536f4222a1c74f9dff5e891eda1f96","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    context \"on #{os}\" do"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"      let(:facts) { facts }"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"      config_values \u003d {"},{"line_number":10,"context_line":"          \u0027DEFAULT/admin_user\u0027 \u003d\u003e {value: nil},"},{"line_number":11,"context_line":"          \u0027DEFAULT/admin_password\u0027 \u003d\u003e {value: nil},"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dab17558_61cc70bb","line":8,"updated":"2016-05-11 13:04:22.000000000","message":"you have different style for specs, its not critical, but take a look on another modules for example.","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"15fc1a4512fe6665b37589221c7081723cbf26a4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    context \"on #{os}\" do"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"      let(:facts) { facts }"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"      config_values \u003d {"},{"line_number":10,"context_line":"          \u0027DEFAULT/admin_user\u0027 \u003d\u003e {value: nil},"},{"line_number":11,"context_line":"          \u0027DEFAULT/admin_password\u0027 \u003d\u003e {value: nil},"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dab17558_b50a0d24","line":8,"in_reply_to":"dab17558_61cc70bb","updated":"2016-05-11 15:18:46.000000000","message":"Like this? https://github.com/openstack/puppet-neutron/blob/master/spec/classes/neutron_agents_metadata_spec.rb#L55\n\nI\u0027m doing the same thing but with a loop\n\nconfig_values.each do |title, parameters|\n  it { is_expected.to contain_ec2api_config(title).with(parameters) }\nend\n\nThere are just too many lines here","commit_id":"82f6966afd76caa2464f2d6ba263cfef59b6bb5b"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"eef71cd0c9a5379a7ee32f58440118c445624442","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            keystone_admin_password: \u0027my_password\u0027,"},{"line_number":12,"context_line":"        }"},{"line_number":13,"context_line":"      end"},{"line_number":14,"context_line":"      "},{"line_number":15,"context_line":"      config_items \u003d %w("},{"line_number":16,"context_line":"        DEFAULT/keystone_url"},{"line_number":17,"context_line":"        DEFAULT/keystone_ec2_tokens_url"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"7aa08908_c3b97130","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"updated":"2016-06-10 12:13:20.000000000","message":"Remove spaces","commit_id":"bdd8cc43ef2faefb745e0eb9a61038388672c429"}],"spec/classes/ec2api_init_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e7da09a92a930fa0b7c1f32df572cfb7a59c483f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027ec2api\u0027 do"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dab17558_5c46737b","side":"PARENT","line":1,"range":{"start_line":1,"start_character":20,"end_line":1,"end_character":21},"updated":"2016-05-11 13:25:22.000000000","message":"Can you provide the reason to remove this file?  Thanks","commit_id":"6ba14d194ade96e2fc5eb0a8f672cb11a5b02dd7"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"660b9a9aef4a5e9c1f9eb9d41f2e70eb526893ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027ec2api\u0027 do"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dab17558_dfded0db","side":"PARENT","line":1,"range":{"start_line":1,"start_character":20,"end_line":1,"end_character":21},"in_reply_to":"dab17558_5c46737b","updated":"2016-05-11 14:48:58.000000000","message":"I will be returned by the last of the 3 patches.\nIt doesn\u0027t allow them to be tested separately.","commit_id":"6ba14d194ade96e2fc5eb0a8f672cb11a5b02dd7"}],"spec/classes/ec2api_logging_spec.rb":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     :log_facility \u003d\u003e \u0027LOG_FOO\u0027,"},{"line_number":30,"context_line":"     :log_dir \u003d\u003e \u0027/var/log\u0027,"},{"line_number":31,"context_line":"     :log_file \u003d\u003e \u0027/var/log/ec2api.log\u0027,"},{"line_number":32,"context_line":"     :verbose \u003d\u003e true,"},{"line_number":33,"context_line":"     :debug \u003d\u003e true,"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"bab6814e_679fd8b4","side":"PARENT","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":22},"updated":"2016-05-19 13:20:04.000000000","message":"not need.","commit_id":"6ba14d194ade96e2fc5eb0a8f672cb11a5b02dd7"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/syslog_log_facility\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/log_dir\u0027).with(:value \u003d\u003e \u0027/var/log/ec2api\u0027)"},{"line_number":65,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/log_file\u0027).with(:value \u003d\u003e \u0027/var/log/ec2api/ec2api.log\u0027)"},{"line_number":66,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/verbose\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":67,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/debug\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":68,"context_line":"    end"},{"line_number":69,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"bab6814e_07b1ac47","side":"PARENT","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":97},"updated":"2016-05-19 13:20:04.000000000","message":"not need","commit_id":"6ba14d194ade96e2fc5eb0a8f672cb11a5b02dd7"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"521e6258fb40b8d42c10ee612a241f19ff6fca0b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/syslog_log_facility\u0027).with(:value \u003d\u003e \u0027LOG_FOO\u0027)"},{"line_number":76,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/log_dir\u0027).with(:value \u003d\u003e \u0027/var/log\u0027)"},{"line_number":77,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/log_file\u0027).with(:value \u003d\u003e \u0027/var/log/ec2api.log\u0027)"},{"line_number":78,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/verbose\u0027).with(:value \u003d\u003e \u0027true\u0027)"},{"line_number":79,"context_line":"      is_expected.to contain_ec2api_config(\u0027DEFAULT/debug\u0027).with(:value \u003d\u003e \u0027true\u0027)"},{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"bab6814e_6786b866","side":"PARENT","line":78,"range":{"start_line":78,"start_character":6,"end_line":78,"end_character":84},"updated":"2016-05-19 13:20:04.000000000","message":"not need.","commit_id":"6ba14d194ade96e2fc5eb0a8f672cb11a5b02dd7"}]}