)]}'
{"manifests/db.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $database_max_retries    \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $database_retry_interval \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $database_max_overflow   \u003d $::os_service_default,"},{"line_number":44,"context_line":") inherits ::ec2api::params {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  validate_re($database_connection, \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_615c707d","line":44,"updated":"2016-05-11 13:09:03.000000000","message":"why you need inherits here? for what?","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"}],"manifests/db/mysql.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*password*]"},{"line_number":9,"context_line":"#   Password to connect to the database."},{"line_number":10,"context_line":"#   Defaults to \u0027CHANGEME\u0027."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*dbname*]"},{"line_number":13,"context_line":"#   (Optional) Name of the database."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_219b8819","line":10,"updated":"2016-05-11 13:09:03.000000000","message":"that\u0027s not correct, it is required parameter","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class ec2api::db::mysql ("},{"line_number":47,"context_line":"  $password,"},{"line_number":48,"context_line":"  $user          \u003d \u0027ec2\u0027,"},{"line_number":49,"context_line":"  $dbname        \u003d \u0027ec2api\u0027,"},{"line_number":50,"context_line":"  $host          \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $charset       \u003d \u0027utf8\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_81b5147f","line":48,"updated":"2016-05-11 13:09:03.000000000","message":"why you changed it?","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  $charset       \u003d \u0027utf8\u0027,"},{"line_number":52,"context_line":"  $collate       \u003d \u0027utf8_general_ci\u0027,"},{"line_number":53,"context_line":"  $allowed_hosts \u003d undef"},{"line_number":54,"context_line":") inherits ::ec2api::params {"},{"line_number":55,"context_line":"  validate_string($password)"},{"line_number":56,"context_line":"  validate_string($dbname)"},{"line_number":57,"context_line":"  validate_string($user)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_c17a7cbc","line":54,"updated":"2016-05-11 13:09:03.000000000","message":"we don\u0027t use this class here","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"}],"manifests/db/postgresql.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*password*]"},{"line_number":9,"context_line":"#   Password to connect to the database."},{"line_number":10,"context_line":"#   Default: CHANGEME"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*dbname*]"},{"line_number":13,"context_line":"#   (Optional) Name of the database."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_01aac418","line":10,"updated":"2016-05-11 13:09:03.000000000","message":"same","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $dbname     \u003d \u0027ec2api\u0027,"},{"line_number":40,"context_line":"  $encoding   \u003d undef,"},{"line_number":41,"context_line":"  $privileges \u003d \u0027ALL\u0027,"},{"line_number":42,"context_line":") inherits ::ec2api::params {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  Class[\u0027ec2api::db::postgresql\u0027] -\u003e"},{"line_number":45,"context_line":"  Service\u003c| title \u003d\u003d \u0027ec2api\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_c161dc06","line":42,"updated":"2016-05-11 13:09:03.000000000","message":"same","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"32f8dfbb6f1290a024497cd4c8fd6301cc038c74","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (Optional) User to connect to the database."},{"line_number":17,"context_line":"#   Defaults to \u0027ec2api\u0027."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*encoding*]"},{"line_number":20,"context_line":"#    (Optional) The charset to use for the database."},{"line_number":21,"context_line":"#    Default to undef."},{"line_number":22,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_bff11998","line":19,"updated":"2016-05-12 11:41:53.000000000","message":"different alignment from 3 options above","commit_id":"8de31786cec9e49785a666ba2544500eb614b954"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"32f8dfbb6f1290a024497cd4c8fd6301cc038c74","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#    (Optional) The charset to use for the database."},{"line_number":21,"context_line":"#    Default to undef."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"#  [*privileges*]"},{"line_number":24,"context_line":"#    (Optional) Privileges given to the database user."},{"line_number":25,"context_line":"#    Default to \u0027ALL\u0027"},{"line_number":26,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_3f340949","line":23,"updated":"2016-05-12 11:41:53.000000000","message":"same","commit_id":"8de31786cec9e49785a666ba2544500eb614b954"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d58cea1ec6f095ad18792e3e2158a49744f827f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*password*]"},{"line_number":9,"context_line":"#   (Mandatory) Password to connect to the database."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*dbname*]"},{"line_number":12,"context_line":"#   (Optional) Name of the database."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"bab6814e_f2a19695","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":14},"updated":"2016-05-26 05:02:54.000000000","message":"do we really need to change?","commit_id":"3d108f04d52804b6c8a5f49c3ba64b0dec1f4d54"}],"manifests/db/sync.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e357ef971313a2e974a02d82206e791f6a2b417","unresolved":false,"context_lines":[{"line_number":15,"context_line":"class ec2api::db::sync ("},{"line_number":16,"context_line":"  $system_user  \u003d \u0027ec2api\u0027,"},{"line_number":17,"context_line":"  $system_group \u003d \u0027ec2api\u0027,"},{"line_number":18,"context_line":") inherits ::ec2api::params {"},{"line_number":19,"context_line":"  exec { \u0027ec2api_db_sync\u0027 :"},{"line_number":20,"context_line":"    command     \u003d\u003e \u0027ec2api-manage db_sync\u0027,"},{"line_number":21,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_411b2c81","line":18,"updated":"2016-05-11 13:09:03.000000000","message":"same","commit_id":"5b00ff3b6162557f336daace568e1d2b8a787829"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"32f8dfbb6f1290a024497cd4c8fd6301cc038c74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: ec2api::db::sync"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Class to execute \"ec2api-manage db_sync"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_df07bd7f","line":3,"updated":"2016-05-12 11:41:53.000000000","message":"\" not needed","commit_id":"8de31786cec9e49785a666ba2544500eb614b954"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"32f8dfbb6f1290a024497cd4c8fd6301cc038c74","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  User \u003c| title \u003d\u003d \u0027ec2api\u0027 |\u003e -\u003e"},{"line_number":34,"context_line":"  Exec[\u0027ec2api_db_sync\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  Exec[\u0027ec2api_db_sync\u0027] ~\u003e"},{"line_number":37,"context_line":"  Service\u003c| title \u003d\u003d \u0027openstack-ec2api-api-service\u0027 |\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  Exec[\u0027ec2api_db_sync\u0027] ~\u003e"},{"line_number":40,"context_line":"  Service\u003c| title \u003d\u003d \u0027openstack-ec2-api-metadata\u0027 |\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Exec[\u0027ec2api_db_sync\u0027] ~\u003e"},{"line_number":43,"context_line":"  Service\u003c| title \u003d\u003d \u0027openstack-ec2-api-s3\u0027 |\u003e"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_5ffe2d39","line":43,"range":{"start_line":36,"start_character":0,"end_line":43,"end_character":46},"updated":"2016-05-12 11:41:53.000000000","message":"it will be nice to add a common tag for those services, like \nhttps://github.com/openstack/puppet-neutron/blob/master/manifests/db/sync.pp#L19-L20","commit_id":"8de31786cec9e49785a666ba2544500eb614b954"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d58cea1ec6f095ad18792e3e2158a49744f827f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"class ec2api::db::sync ("},{"line_number":16,"context_line":"  $system_user  \u003d \u0027ec2api\u0027,"},{"line_number":17,"context_line":"  $system_group \u003d \u0027ec2api\u0027,"},{"line_number":18,"context_line":") inherits ::ec2api::params {"},{"line_number":19,"context_line":"  exec { \u0027ec2api_db_sync\u0027 :"},{"line_number":20,"context_line":"    command     \u003d\u003e \u0027ec2api-manage db_sync\u0027,"},{"line_number":21,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"bab6814e_92900a45","line":18,"updated":"2016-05-26 05:02:54.000000000","message":"pleasse skip a like here","commit_id":"3d108f04d52804b6c8a5f49c3ba64b0dec1f4d54"}],"spec/classes/ec2api_db_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d58cea1ec6f095ad18792e3e2158a49744f827f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        it { is_expected.to contain_class(\u0027ec2api::db\u0027) }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        parameters \u003d {"},{"line_number":45,"context_line":"            :connection \u003d\u003e \u0027sqlite:////path/to/my/db.sqlite\u0027,"},{"line_number":46,"context_line":"            :idle_timeout   \u003d\u003e \u00271\u0027,"},{"line_number":47,"context_line":"            :min_pool_size  \u003d\u003e \u00272\u0027,"},{"line_number":48,"context_line":"            :max_retries    \u003d\u003e \u00273\u0027,"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"bab6814e_d27f3215","line":45,"range":{"start_line":45,"start_character":24,"end_line":45,"end_character":26},"updated":"2016-05-26 05:02:54.000000000","message":"please indent","commit_id":"3d108f04d52804b6c8a5f49c3ba64b0dec1f4d54"}]}