)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"a3bc358c852f0bcd3fc17ecd67a560008c521295","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  include ::glance::params"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  Package\u003c| title \u003d\u003d $glance::params::registry_package_name |\u003e -\u003e Class[\u0027glance::db::sync\u0027]"},{"line_number":9,"context_line":"  Glance_registry_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":10,"context_line":"  Glance_api_config\u003c||\u003e ~\u003e Exec\u003c| title \u003d\u003d \u0027glance-manage db_sync\u0027 |\u003e"},{"line_number":11,"context_line":"  Glance_cache_config\u003c||\u003e ~\u003e Exec\u003c| title \u003d\u003d \u0027glance-manage db_sync\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_d060b8d1","line":8,"updated":"2015-07-14 19:57:01.000000000","message":"Package upgrades needs to notify the exec so that db migrations can be run on upgrade.  This is a change of semantics, however really all package upgrades should trigger a db sync, since any of them may inadvertently pull in the common package which is what actually contains the migrations.","commit_id":"cdb564cb2765c4379a0f6bd8bd66292bfcb5b1b2"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"c58bb66322edb11cd54b9bd0eb4f69574c6a6d1b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  Package\u003c| tag \u003d\u003d \u0027glance-package\u0027 |\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":9,"context_line":"  Exec[\u0027glance-manage db_sync\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027glance-service\u0027 |\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Glance_registry_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":12,"context_line":"  Glance_api_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":13,"context_line":"  Glance_cache_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1a4dcd0f_8f10a001","line":11,"updated":"2015-08-12 17:21:00.000000000","message":"Do we know with 100% certainty that only db/connection effects the migrations?  Personally I\u0027d rather be liberal about running db_sync, but I think more importantly we should be consistent across modules and it\u0027s not currently.  I tend to think these db::sync reviews should attempt to reproduce existing behavior aside from things that are obvious bugs.  If we\u0027re going to change the behavior for glance, we should change it for all the db::sync classes.","commit_id":"d77e774a4ac06082676320ae9283d0e8916bae47"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"90a16e3ed150d6683cb91ac86fab855ce30ccd39","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  Package\u003c| tag \u003d\u003d \u0027glance-package\u0027 |\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":9,"context_line":"  Exec[\u0027glance-manage db_sync\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027glance-service\u0027 |\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Glance_registry_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":12,"context_line":"  Glance_api_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":13,"context_line":"  Glance_cache_config\u003c||\u003e ~\u003e Exec[\u0027glance-manage db_sync\u0027]"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a50d1a3_1f70eadb","line":11,"updated":"2015-07-30 13:12:03.000000000","message":"Do we really need run db_sync every time when config was changed?","commit_id":"d77e774a4ac06082676320ae9283d0e8916bae47"}]}