)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cd74eccde19d89ede1c8eb6362cb670418d84efe","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":480,"context_line":"  }"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"  file { [\u0027/etc/glance/glance-api.conf\u0027,"},{"line_number":483,"context_line":"          \u0027/etc/glance/glance-api-paste.ini\u0027,"},{"line_number":484,"context_line":"          \u0027/etc/glance/glance-cache.conf\u0027]:"},{"line_number":485,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_caa27d4b","side":"PARENT","line":482,"updated":"2015-08-18 21:25:15.000000000","message":"so with the removal of these files, we\u0027re also losing the service notification for when content is changed. Is this something that is handled via the provider? Or would manual restarts of services need to be handled elsewhere because we are not longer tracking these files? I think it would be ok to drop the permissions stuff, but i\u0027m not sure about no longer tracking these file/service relationships.","commit_id":"4e8e53bff3818c7cfda3317426281d8f6c4ea295"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b271ff151d5e7501a2fb6bd0ce0d49f972d90ff4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  Class[\u0027glance::policy\u0027] ~\u003e Service[\u0027glance-api\u0027]"},{"line_number":263,"context_line":"  Service[\u0027glance-api\u0027]   ~\u003e Glance_image\u003c||\u003e"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  File {"},{"line_number":266,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":267,"context_line":"    notify  \u003d\u003e Service[\u0027glance-api\u0027],"},{"line_number":268,"context_line":"    require \u003d\u003e Class[\u0027glance\u0027]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba15a1d1_c9a073a8","line":265,"updated":"2015-09-21 15:34:34.000000000","message":"May be we should remove all File resources as well?","commit_id":"a1cab8b87a06c47775223a9a21238fd52fbc01c5"}],"manifests/init.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"ed674dd31223b6bdf4914086e2cdbad7e9338d29","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  include ::glance::params"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  file { \u0027/etc/glance/\u0027:"},{"line_number":19,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":20,"context_line":"    owner  \u003d\u003e \u0027glance\u0027,"},{"line_number":21,"context_line":"    group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a1a9d01_0a6e2795","side":"PARENT","line":18,"updated":"2015-09-28 11:22:35.000000000","message":"Should files resources be removed completely?","commit_id":"03e1e00cbd2f33f937a1a2919e3c444f67fa0731"}],"manifests/registry.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ce3fba3353b7edf6401446d603758c217d2c5acd","unresolved":false,"context_lines":[{"line_number":365,"context_line":"      user        \u003d\u003e \u0027glance\u0027,"},{"line_number":366,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":367,"context_line":"      logoutput   \u003d\u003e on_failure,"},{"line_number":368,"context_line":"      subscribe   \u003d\u003e [Package[$glance::params::registry_package_name], File[\u0027/etc/glance/glance-registry.conf\u0027]],"},{"line_number":369,"context_line":"    }"},{"line_number":370,"context_line":"  }"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_0179e081","side":"PARENT","line":368,"updated":"2015-08-12 09:58:22.000000000","message":"I think, the main goal of this subscribe is that every time when we change registry config we should take care about db_sync (in case changing database/connection parameter).","commit_id":"578252b06658f0b6936595ea4b6e4e5557166153"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8c0b6bde576747b50ace3cca6cc725be2e0e7d20","unresolved":false,"context_lines":[{"line_number":365,"context_line":"      user        \u003d\u003e \u0027glance\u0027,"},{"line_number":366,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":367,"context_line":"      logoutput   \u003d\u003e on_failure,"},{"line_number":368,"context_line":"      subscribe   \u003d\u003e [Package[$glance::params::registry_package_name], File[\u0027/etc/glance/glance-registry.conf\u0027]],"},{"line_number":369,"context_line":"    }"},{"line_number":370,"context_line":"  }"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_c86e1b96","side":"PARENT","line":368,"in_reply_to":"1a4dcd0f_0179e081","updated":"2015-08-18 13:54:44.000000000","message":"Maybe I\u0027m wrong, but I only run db_sync when I update a package, and never when I change configuration file. (except the first time).","commit_id":"578252b06658f0b6936595ea4b6e4e5557166153"}],"spec/classes/glance_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ba3331d0cd40d44c0a8223ed3dbfc029be9de32f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      let :params do param_set end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it { is_expected.to contain_file(\u0027/etc/glance/\u0027).with("},{"line_number":29,"context_line":"        \u0027ensure\u0027  \u003d\u003e \u0027directory\u0027,"},{"line_number":30,"context_line":"        \u0027owner\u0027   \u003d\u003e \u0027glance\u0027,"},{"line_number":31,"context_line":"        \u0027mode\u0027    \u003d\u003e \u00270770\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"da20952f_f535eaa7","side":"PARENT","line":28,"updated":"2015-09-09 21:09:51.000000000","message":"Should leave this in but remove the owner/mode since you\u0027re just touching that part.","commit_id":"f20357a7cf8b4adebdfed894205b6f0f99487784"},{"author":{"_account_id":10353,"name":"Drew Fisher","email":"drew.fisher@oracle.com","username":"drew-fisher"},"change_message_id":"0f174d31d98f9d2bbae8998123d3c4e651b9ed1d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      let :params do param_set end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it { is_expected.to contain_file(\u0027/etc/glance/\u0027).with("},{"line_number":29,"context_line":"        \u0027ensure\u0027  \u003d\u003e \u0027directory\u0027,"},{"line_number":30,"context_line":"        \u0027owner\u0027   \u003d\u003e \u0027glance\u0027,"},{"line_number":31,"context_line":"        \u0027mode\u0027    \u003d\u003e \u00270770\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"da20952f_f5d16a30","side":"PARENT","line":28,"in_reply_to":"da20952f_f535eaa7","updated":"2015-09-09 21:12:55.000000000","message":"I agree.  New patch coming ....","commit_id":"f20357a7cf8b4adebdfed894205b6f0f99487784"}]}