)]}'
{"manifests/backend/s3.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"57aa914de655b38b3938ac32dd3afd7ac201fd4c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# \u003d\u003d\u003d parameters:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#  [*access_key*]"},{"line_number":9,"context_line":"#    Required. The S3 query token access key."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#  [*secret_key*]"},{"line_number":12,"context_line":"#    Required. The S3 query token secret key."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_bc2194fe","line":9,"updated":"2015-09-22 10:58:58.000000000","message":"nit: use (), e.g. (required) (optional)","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"7581bb31e551eaffea1eac7bf8a911a0f588de05","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# \u003d\u003d\u003d parameters:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#  [*access_key*]"},{"line_number":9,"context_line":"#    Required. The S3 query token access key."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#  [*secret_key*]"},{"line_number":12,"context_line":"#    Required. The S3 query token secret key."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_502c7e98","line":9,"in_reply_to":"ba15a1d1_bc2194fe","updated":"2015-09-24 02:44:50.000000000","message":"Done","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"45ffdedab69ff3f20ff84095d2afc0e530a4e9b4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#  [*bucket_url_format*]"},{"line_number":21,"context_line":"#    Optional. The S3 calling format used to determine the bucket. Either"},{"line_number":22,"context_line":"#    subdomain or path can be used."},{"line_number":23,"context_line":"#    Default: \u0027subdomain\u0027"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"#  [*create_bucket_on_put*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_e86c149e","line":22,"updated":"2015-09-22 17:07:15.000000000","message":"Should put quotes around \u0027subdomain\u0027 and \u0027path\u0027 so people know that these are the values to be used.","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"7581bb31e551eaffea1eac7bf8a911a0f588de05","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#  [*bucket_url_format*]"},{"line_number":21,"context_line":"#    Optional. The S3 calling format used to determine the bucket. Either"},{"line_number":22,"context_line":"#    subdomain or path can be used."},{"line_number":23,"context_line":"#    Default: \u0027subdomain\u0027"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"#  [*create_bucket_on_put*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_90177644","line":22,"in_reply_to":"ba15a1d1_e86c149e","updated":"2015-09-24 02:44:50.000000000","message":"Done","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"45ffdedab69ff3f20ff84095d2afc0e530a4e9b4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fail(\u0027glance::backend::s3::large_object_chunk_size must be an integer \u003e\u003d 5\u0027)"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $bucket_url_format !\u003d \u0027subdomain\u0027 and $bucket_url_format !\u003d \u0027path\u0027 {"},{"line_number":72,"context_line":"    fail(\u0027glance::backend::s3::bucket_url_format must be either \"subdomain\" or \"path\"\u0027)"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_08686886","line":71,"updated":"2015-09-22 17:07:15.000000000","message":"Just a comment, this could be simplified by using\n\n  if !($bucker_url_format in [\u0027subdomain\u0027, \u0027path\u0027])","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"7581bb31e551eaffea1eac7bf8a911a0f588de05","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fail(\u0027glance::backend::s3::large_object_chunk_size must be an integer \u003e\u003d 5\u0027)"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $bucket_url_format !\u003d \u0027subdomain\u0027 and $bucket_url_format !\u003d \u0027path\u0027 {"},{"line_number":72,"context_line":"    fail(\u0027glance::backend::s3::bucket_url_format must be either \"subdomain\" or \"path\"\u0027)"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_701ae270","line":71,"in_reply_to":"ba15a1d1_08686886","updated":"2015-09-24 02:44:50.000000000","message":"Done","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"57aa914de655b38b3938ac32dd3afd7ac201fd4c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    \u0027glance_store/s3_store_create_bucket_on_put\u0027:    value \u003d\u003e $create_bucket_on_put;"},{"line_number":82,"context_line":"    \u0027glance_store/s3_store_large_object_size\u0027:       value \u003d\u003e $large_object_size;"},{"line_number":83,"context_line":"    \u0027glance_store/s3_store_large_object_chunk_size\u0027: value \u003d\u003e $large_object_chunk_size;"},{"line_number":84,"context_line":"    \u0027glance_store/s3_store_object_buffer_dir\u0027:       value \u003d\u003e $object_buffer_dir;"},{"line_number":85,"context_line":"    \u0027glance_store/s3_store_thread_pools\u0027:            value \u003d\u003e $thread_pools;"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_7ced3cb6","line":84,"updated":"2015-09-22 10:58:58.000000000","message":"should be set to absent if \u0027undef\u0027 or explicitly set some temp directory\n\nhttps://github.com/openstack/glance/blob/master/etc/glance-api.conf","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"7581bb31e551eaffea1eac7bf8a911a0f588de05","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    \u0027glance_store/s3_store_create_bucket_on_put\u0027:    value \u003d\u003e $create_bucket_on_put;"},{"line_number":82,"context_line":"    \u0027glance_store/s3_store_large_object_size\u0027:       value \u003d\u003e $large_object_size;"},{"line_number":83,"context_line":"    \u0027glance_store/s3_store_large_object_chunk_size\u0027: value \u003d\u003e $large_object_chunk_size;"},{"line_number":84,"context_line":"    \u0027glance_store/s3_store_object_buffer_dir\u0027:       value \u003d\u003e $object_buffer_dir;"},{"line_number":85,"context_line":"    \u0027glance_store/s3_store_thread_pools\u0027:            value \u003d\u003e $thread_pools;"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_304eaa6f","line":84,"in_reply_to":"ba15a1d1_7ced3cb6","updated":"2015-09-24 02:44:50.000000000","message":"Yup, that\u0027s fair.  Doing it the \"old\" way, as I\u0027m not sure if we can use the value \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027 thing in glance yet.","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"45ffdedab69ff3f20ff84095d2afc0e530a4e9b4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $default_store {"},{"line_number":89,"context_line":"    glance_api_config { \u0027glance_store/default_store\u0027:   value \u003d\u003e \u0027s3\u0027; }"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_a805bcc2","line":89,"updated":"2015-09-22 17:07:15.000000000","message":"Does this need an absent if default_store is set to false so that this can be changed?","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"7581bb31e551eaffea1eac7bf8a911a0f588de05","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  if $default_store {"},{"line_number":89,"context_line":"    glance_api_config { \u0027glance_store/default_store\u0027:   value \u003d\u003e \u0027s3\u0027; }"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_b014fa43","line":89,"in_reply_to":"ba15a1d1_a805bcc2","updated":"2015-09-24 02:44:50.000000000","message":"The intention is that whatever backend driver is set to default will set the value of glance_store/default_store.  So any drivers not being set as the default should do nothing with the value.\n\nI think a better approach in the long run is to move the setting of this to the api class, rather than it being in the backend store classes.  See https://bugs.launchpad.net/puppet-glance/+bug/1481460","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"}],"spec/classes/glance_backend_s3_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"75b83b64a7b00b0f9c857ad74b044abc92a419d7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"      is_expected.to raise_error(Puppet::Error, /glance::backend::s3::large_object_chunk_size must be an integer \u003e\u003d 5/)"},{"line_number":115,"context_line":"    end"},{"line_number":116,"context_line":"  end"},{"line_number":117,"context_line":"    "},{"line_number":118,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ba15a1d1_6eb8e975","line":117,"updated":"2015-09-23 11:48:45.000000000","message":"Agree with previous comments and please remove whitespaces","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"7581bb31e551eaffea1eac7bf8a911a0f588de05","unresolved":false,"context_lines":[{"line_number":114,"context_line":"      is_expected.to raise_error(Puppet::Error, /glance::backend::s3::large_object_chunk_size must be an integer \u003e\u003d 5/)"},{"line_number":115,"context_line":"    end"},{"line_number":116,"context_line":"  end"},{"line_number":117,"context_line":"    "},{"line_number":118,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ba15a1d1_905c561a","line":117,"in_reply_to":"ba15a1d1_6eb8e975","updated":"2015-09-24 02:44:50.000000000","message":"Done","commit_id":"695e41de9b66e49503be0fbb6705e9783dcf4a38"}]}