)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce1f6e93752ad62037902cca0b682f27c78daef3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"#   In order to prevent excessive effort spent validating tokens,"},{"line_number":89,"context_line":"#   the middleware caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":90,"context_line":"#   Set to -1 to disable caching completely."},{"line_number":91,"context_line":"#   Defaults to 300."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"# [*auth_uri*]"},{"line_number":94,"context_line":"#   (optional) Complete public Identity API endpoint."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_6fbb1ce6","line":91,"updated":"2015-10-20 19:16:52.000000000","message":"We should use $::os_service_default here as this is the service default","commit_id":"a4fa2b90bfdf6bc6aa55c5b39cb2aaa358d6956c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce1f6e93752ad62037902cca0b682f27c78daef3","unresolved":false,"context_lines":[{"line_number":178,"context_line":"#"},{"line_number":179,"context_line":"# [*delayed_delete*]"},{"line_number":180,"context_line":"#   (optional) Turn on/off delayed delete."},{"line_number":181,"context_line":"#   Defaults to false"},{"line_number":182,"context_line":"#"},{"line_number":183,"context_line":"# [*scrub_time*]"},{"line_number":184,"context_line":"#   (optional) The amount of time in seconds to delay before performing a delete."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_8fbeb8d2","line":181,"updated":"2015-10-20 19:16:52.000000000","message":"Should be $::os_service_default","commit_id":"a4fa2b90bfdf6bc6aa55c5b39cb2aaa358d6956c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce1f6e93752ad62037902cca0b682f27c78daef3","unresolved":false,"context_lines":[{"line_number":190,"context_line":"#"},{"line_number":191,"context_line":"# [*image_cache_stall_time*]"},{"line_number":192,"context_line":"#   (optional) The amount of time to let an image remain in the cache without being accessed."},{"line_number":193,"context_line":"#   Defaults to \u002786400\u0027"},{"line_number":194,"context_line":"#"},{"line_number":195,"context_line":"# [*image_cache_max_size*]"},{"line_number":196,"context_line":"#   (optional) The upper limit (the maximum size of accumulated cache in bytes) beyond which pruner,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_2fb524ed","line":193,"updated":"2015-10-20 19:16:52.000000000","message":"same","commit_id":"a4fa2b90bfdf6bc6aa55c5b39cb2aaa358d6956c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce1f6e93752ad62037902cca0b682f27c78daef3","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# [*image_cache_max_size*]"},{"line_number":196,"context_line":"#   (optional) The upper limit (the maximum size of accumulated cache in bytes) beyond which pruner,"},{"line_number":197,"context_line":"#   if running, starts cleaning the images cache."},{"line_number":198,"context_line":"#   Defaults to \u002710737418240\u0027."},{"line_number":199,"context_line":"#"},{"line_number":200,"context_line":"# [*os_region_name*]"},{"line_number":201,"context_line":"#   (optional) Sets the keystone region to use."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_4fb8a0e5","line":198,"updated":"2015-10-20 19:16:52.000000000","message":"Same","commit_id":"a4fa2b90bfdf6bc6aa55c5b39cb2aaa358d6956c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0bcb852b04e3275b50a0a699bb3ea9d7b631ef8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"  $scrub_time               \u003d $::os_service_default,"},{"line_number":239,"context_line":"  $delayed_delete           \u003d $::os_service_default,"},{"line_number":240,"context_line":"  $auth_type                \u003d \u0027keystone\u0027,"},{"line_number":241,"context_line":"  $auth_region              \u003d undef,"},{"line_number":242,"context_line":"  $auth_uri                 \u003d false,"},{"line_number":243,"context_line":"  $identity_uri             \u003d false,"},{"line_number":244,"context_line":"  $pipeline                 \u003d \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a26ad4f_73424e40","line":241,"updated":"2015-10-29 13:53:01.000000000","message":"Is there a reason this isn\u0027t $::os_service_default?","commit_id":"ea3df673b8b2db4b18c2320a093d1176f7d84b8f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0bcb852b04e3275b50a0a699bb3ea9d7b631ef8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"  $image_cache_stall_time   \u003d $::os_service_default,"},{"line_number":262,"context_line":"  $image_cache_dir          \u003d \u0027/var/lib/glance/image-cache\u0027,"},{"line_number":263,"context_line":"  $os_region_name           \u003d \u0027RegionOne\u0027,"},{"line_number":264,"context_line":"  $signing_dir              \u003d undef,"},{"line_number":265,"context_line":"  $token_cache_time         \u003d $::os_service_default,"},{"line_number":266,"context_line":"  $validate                 \u003d false,"},{"line_number":267,"context_line":"  $validation_options       \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a26ad4f_933daabd","line":264,"updated":"2015-10-29 13:53:01.000000000","message":"Same here","commit_id":"ea3df673b8b2db4b18c2320a093d1176f7d84b8f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1044dac62a0d8fdde1e9c513224eb7525644cf8a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*auth_region*]"},{"line_number":74,"context_line":"#   The region for the authentication service."},{"line_number":75,"context_line":"#   If \"use_user_token\" is not in effect and using keystone auth,"},{"line_number":76,"context_line":"#   then region name can be specified."},{"line_number":77,"context_line":"#   Defaults to undef."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_174dc5c3","line":74,"updated":"2015-11-06 13:36:46.000000000","message":"Please add (optional).\nHow we test if use_user_token  is not in effect and is using keystone auth?","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"353bafc9b48c1870c9e15de6743d5159542115e5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*auth_region*]"},{"line_number":74,"context_line":"#   The region for the authentication service."},{"line_number":75,"context_line":"#   If \"use_user_token\" is not in effect and using keystone auth,"},{"line_number":76,"context_line":"#   then region name can be specified."},{"line_number":77,"context_line":"#   Defaults to undef."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_c1be9364","line":74,"in_reply_to":"fa80f949_174dc5c3","updated":"2015-11-06 14:50:35.000000000","message":"yes you right, i think it is matter for another patch, i decided to postpone this parameter for now","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1044dac62a0d8fdde1e9c513224eb7525644cf8a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"#   Defaults to \u0027RegionOne\u0027."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*signing_dir*]"},{"line_number":195,"context_line":"#   Directory used to cache files related to PKI tokens."},{"line_number":196,"context_line":"#   Defaults to undef."},{"line_number":197,"context_line":"#"},{"line_number":198,"context_line":"# [*token_cache_time*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_979d350c","line":195,"updated":"2015-11-06 13:36:46.000000000","message":"please add optional.","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"353bafc9b48c1870c9e15de6743d5159542115e5","unresolved":false,"context_lines":[{"line_number":192,"context_line":"#   Defaults to \u0027RegionOne\u0027."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*signing_dir*]"},{"line_number":195,"context_line":"#   Directory used to cache files related to PKI tokens."},{"line_number":196,"context_line":"#   Defaults to undef."},{"line_number":197,"context_line":"#"},{"line_number":198,"context_line":"# [*token_cache_time*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_7edf4569","line":195,"in_reply_to":"fa80f949_979d350c","updated":"2015-11-06 14:50:35.000000000","message":"Done","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1044dac62a0d8fdde1e9c513224eb7525644cf8a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"#   Defaults to undef."},{"line_number":197,"context_line":"#"},{"line_number":198,"context_line":"# [*token_cache_time*]"},{"line_number":199,"context_line":"#   In order to prevent excessive effort spent validating tokens,"},{"line_number":200,"context_line":"#   the middleware caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":201,"context_line":"#   Set to -1 to disable caching completely."},{"line_number":202,"context_line":"#   Defaults to 300."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_b7a2b949","line":199,"updated":"2015-11-06 13:36:46.000000000","message":"please add optional.","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"353bafc9b48c1870c9e15de6743d5159542115e5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"#   Defaults to undef."},{"line_number":197,"context_line":"#"},{"line_number":198,"context_line":"# [*token_cache_time*]"},{"line_number":199,"context_line":"#   In order to prevent excessive effort spent validating tokens,"},{"line_number":200,"context_line":"#   the middleware caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":201,"context_line":"#   Set to -1 to disable caching completely."},{"line_number":202,"context_line":"#   Defaults to 300."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_3ee53d37","line":199,"in_reply_to":"fa80f949_b7a2b949","updated":"2015-11-06 14:50:35.000000000","message":"Done","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"04a6b213c11e1c635507e77ec5b4678e1123fc69","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    \u0027DEFAULT/scrub_time\u0027:             value \u003d\u003e $scrub_time;"},{"line_number":335,"context_line":"    \u0027DEFAULT/delayed_delete\u0027:         value \u003d\u003e $delayed_delete;"},{"line_number":336,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":337,"context_line":"    \u0027DEFAULT/auth_region\u0027:            value \u003d\u003e $auth_region;"},{"line_number":338,"context_line":"    \u0027glance_store/os_region_name\u0027:    value \u003d\u003e $os_region_name;"},{"line_number":339,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027: value \u003d\u003e $signing_dir;"},{"line_number":340,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7a740942_7ce6beb5","line":337,"updated":"2015-12-04 19:35:35.000000000","message":"I think it should no be in DEFAULT but in \u0027keystone_authtoken\u0027 section.","commit_id":"d60e07a14393b81dca261890019e757333157cdc"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"418492aafb393568cd1bd04bc9e24b84bbbd0d34","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    \u0027DEFAULT/scrub_time\u0027:             value \u003d\u003e $scrub_time;"},{"line_number":335,"context_line":"    \u0027DEFAULT/delayed_delete\u0027:         value \u003d\u003e $delayed_delete;"},{"line_number":336,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":337,"context_line":"    \u0027DEFAULT/auth_region\u0027:            value \u003d\u003e $auth_region;"},{"line_number":338,"context_line":"    \u0027glance_store/os_region_name\u0027:    value \u003d\u003e $os_region_name;"},{"line_number":339,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027: value \u003d\u003e $signing_dir;"},{"line_number":340,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7a740942_cc7d99b2","line":337,"in_reply_to":"7a740942_7ce6beb5","updated":"2015-12-07 08:05:57.000000000","message":"but in project docs it is in DEFAULT section - http://docs.openstack.org/liberty/config-reference/content/section_glance-api.conf.html and here https://github.com/openstack/glance/blob/87251828be0b22c899f207d14ee1c9f9203157c5/etc/glance-api.conf#L279-L282","commit_id":"d60e07a14393b81dca261890019e757333157cdc"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"dc33b9d422eae284032e200e7592fffad2f473f5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"#   Defaults to undef."},{"line_number":158,"context_line":"#"},{"line_number":159,"context_line":"# [*image_cache_max_size*]"},{"line_number":160,"context_line":"#   (optional) The upper limit (the maximum size of accumulated cache in bytes) beyond which pruner,"},{"line_number":161,"context_line":"#   if running, starts cleaning the images cache."},{"line_number":162,"context_line":"#   Defaults to $::os_service_default."},{"line_number":163,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7a740942_50f017fe","line":160,"updated":"2015-12-08 10:04:27.000000000","message":"Please remove blank line","commit_id":"650747c730043b7c92327794b2d53aa44eef7d75"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"388de9d2571c80a7b92d9c64e1adcbd981e5d2fb","unresolved":false,"context_lines":[{"line_number":157,"context_line":"#   Defaults to undef."},{"line_number":158,"context_line":"#"},{"line_number":159,"context_line":"# [*image_cache_max_size*]"},{"line_number":160,"context_line":"#   (optional) The upper limit (the maximum size of accumulated cache in bytes) beyond which pruner,"},{"line_number":161,"context_line":"#   if running, starts cleaning the images cache."},{"line_number":162,"context_line":"#   Defaults to $::os_service_default."},{"line_number":163,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7a740942_a2c8c6a9","line":160,"in_reply_to":"7a740942_50f017fe","updated":"2015-12-09 12:22:20.000000000","message":"its jenkins bug it seems, there is no empty line here","commit_id":"650747c730043b7c92327794b2d53aa44eef7d75"}],"manifests/api/logging.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"05d3c95a40d6abc88a0f9aa6fab5b255eadd84d9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    Defaults to \u0027false\u0027"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*use_syslog_rfc_format*]"},{"line_number":20,"context_line":"#    (Optional) (Optional) Enables or disables syslog rfc5424 format for logging."},{"line_number":21,"context_line":"#    If enabled, prefixes the MSG part of the syslog message with APP-NAME (RFC5424)."},{"line_number":22,"context_line":"#    The format without the APP-NAME is deprecated in Kilo, and will be removed in Mitaka,"},{"line_number":23,"context_line":"#    along with this option. This option is ignored if log_config_append is set."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_8e4c9a43","line":20,"updated":"2015-10-20 09:31:43.000000000","message":"Please remove \u0027(Optional)\u0027 duplication. And as I can see from description this option is deprecated.","commit_id":"c66b9737430bceac4aff42175feb2e8e27ce6cca"}],"manifests/notify/rabbitmq.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce1f6e93752ad62037902cca0b682f27c78daef3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#  [*kombu_reconnect_delay*]"},{"line_number":62,"context_line":"#    (optional) How long to wait before reconnecting in response to an AMQP"},{"line_number":63,"context_line":"#    consumer cancel notification."},{"line_number":64,"context_line":"#    Defaults to \u00271.0\u0027"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"#  [*rabbit_notification_exchange*]"},{"line_number":67,"context_line":"#    Defaults  to \u0027glance\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_aff294d0","line":64,"updated":"2015-10-20 19:16:52.000000000","message":"Should be $::os_service_default","commit_id":"a4fa2b90bfdf6bc6aa55c5b39cb2aaa358d6956c"}],"manifests/registry.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce1f6e93752ad62037902cca0b682f27c78daef3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#    In order to prevent excessive effort spent validating tokens,"},{"line_number":66,"context_line":"#    the middleware caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":67,"context_line":"#    Set to -1 to disable caching completely."},{"line_number":68,"context_line":"#    Defaults to 300."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"#  [*auth_admin_prefix*]"},{"line_number":71,"context_line":"#    (optional) DEPRECATED path part of the auth url."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_cfed90f0","line":68,"updated":"2015-10-20 19:16:52.000000000","message":"We should use $::os_service_default here as this is the service default","commit_id":"a4fa2b90bfdf6bc6aa55c5b39cb2aaa358d6956c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0bcb852b04e3275b50a0a699bb3ea9d7b631ef8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  $ca_file               \u003d false,"},{"line_number":172,"context_line":"  $sync_db               \u003d true,"},{"line_number":173,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":174,"context_line":"  $signing_dir           \u003d undef,"},{"line_number":175,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":176,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":177,"context_line":"  $auth_host             \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a26ad4f_f3741e9d","line":174,"updated":"2015-10-29 13:53:01.000000000","message":"Is there a reason this isn\u0027t $::os_service_default?","commit_id":"ea3df673b8b2db4b18c2320a093d1176f7d84b8f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1044dac62a0d8fdde1e9c513224eb7525644cf8a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"#   Defaults to true"},{"line_number":130,"context_line":"#"},{"line_number":131,"context_line":"# [*token_cache_time*]"},{"line_number":132,"context_line":"#   In order to prevent excessive effort spent validating tokens,"},{"line_number":133,"context_line":"#   the middleware caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":134,"context_line":"#   Set to -1 to disable caching completely."},{"line_number":135,"context_line":"#   Defaults to 300."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_fad7c848","line":132,"updated":"2015-11-06 13:36:46.000000000","message":"add optional","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"353bafc9b48c1870c9e15de6743d5159542115e5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"#   Defaults to true"},{"line_number":130,"context_line":"#"},{"line_number":131,"context_line":"# [*token_cache_time*]"},{"line_number":132,"context_line":"#   In order to prevent excessive effort spent validating tokens,"},{"line_number":133,"context_line":"#   the middleware caches previously-seen tokens for a configurable duration (in seconds)."},{"line_number":134,"context_line":"#   Set to -1 to disable caching completely."},{"line_number":135,"context_line":"#   Defaults to 300."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_bec7ed96","line":132,"in_reply_to":"fa80f949_fad7c848","updated":"2015-11-06 14:50:35.000000000","message":"Done","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1044dac62a0d8fdde1e9c513224eb7525644cf8a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"#   Defaults to 300."},{"line_number":136,"context_line":"#"},{"line_number":137,"context_line":"# [*signing_dir*]"},{"line_number":138,"context_line":"#   Directory used to cache files related to PKI tokens."},{"line_number":139,"context_line":"#   Defaults to undef."},{"line_number":140,"context_line":"#"},{"line_number":141,"context_line":"# [*os_region_name*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_9af1dc03","line":138,"updated":"2015-11-06 13:36:46.000000000","message":"add optional","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"353bafc9b48c1870c9e15de6743d5159542115e5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"#   Defaults to 300."},{"line_number":136,"context_line":"#"},{"line_number":137,"context_line":"# [*signing_dir*]"},{"line_number":138,"context_line":"#   Directory used to cache files related to PKI tokens."},{"line_number":139,"context_line":"#   Defaults to undef."},{"line_number":140,"context_line":"#"},{"line_number":141,"context_line":"# [*os_region_name*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa80f949_7ec6659b","line":138,"in_reply_to":"fa80f949_9af1dc03","updated":"2015-11-06 14:50:35.000000000","message":"Done","commit_id":"79cb2ee06c3d0066594e7dad5f8e1887d6b09c8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"acbffffbe84777e914b0f44b22fb8d0425936bd5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  $key_file              \u003d false,"},{"line_number":171,"context_line":"  $ca_file               \u003d false,"},{"line_number":172,"context_line":"  $sync_db               \u003d true,"},{"line_number":173,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":174,"context_line":"  $signing_dir           \u003d $::os_service_default,"},{"line_number":175,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":176,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a8ffd7b_6af752d3","line":173,"updated":"2015-12-03 13:05:32.000000000","message":"None by default. You should use service_default, or raise warning, that we use another default for puppet defaults.","commit_id":"f84dc617971a537b0cf446fe68d106f138629d7d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"5042e7fdf483e2471daa231808fbb7764d42bffe","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  $key_file              \u003d false,"},{"line_number":171,"context_line":"  $ca_file               \u003d false,"},{"line_number":172,"context_line":"  $sync_db               \u003d true,"},{"line_number":173,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":174,"context_line":"  $signing_dir           \u003d $::os_service_default,"},{"line_number":175,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":176,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a8ffd7b_ac047517","line":173,"in_reply_to":"9a8ffd7b_6af752d3","updated":"2015-12-03 14:04:16.000000000","message":"Yes, but in this case we have \u0027RegionOne\u0027 set because it is set in https://github.com/openstack/puppet-glance/blob/master/manifests/api.pp#L225 \n\nSo i don\u0027t want to have a situation when $os_region_name is different in api.pp and registry.pp.\n\nI suggest to make warning here for now, and then when glance will be switching to os_service_default we need to change both values\n\nwhat do you think?","commit_id":"f84dc617971a537b0cf446fe68d106f138629d7d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dc4ef77f8becace964ac517a1ba4f902da65f44d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  $key_file              \u003d false,"},{"line_number":171,"context_line":"  $ca_file               \u003d false,"},{"line_number":172,"context_line":"  $sync_db               \u003d true,"},{"line_number":173,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":174,"context_line":"  $signing_dir           \u003d $::os_service_default,"},{"line_number":175,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":176,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7a740942_bb651e46","line":173,"updated":"2015-12-04 14:10:40.000000000","message":"auth_region in API class is set to os_service_default. I guess, we need one scheme.","commit_id":"e2bde8691f1a3cc5bdcd0bd17f051f5b9229a28c"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"b914ff7dc8cea90c7d291dc81424e7e4dae3aaf6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  $key_file              \u003d false,"},{"line_number":171,"context_line":"  $ca_file               \u003d false,"},{"line_number":172,"context_line":"  $sync_db               \u003d true,"},{"line_number":173,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":174,"context_line":"  $signing_dir           \u003d $::os_service_default,"},{"line_number":175,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":176,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7a740942_d14ec9c0","line":173,"in_reply_to":"7a740942_bb651e46","updated":"2015-12-04 14:37:54.000000000","message":"Done","commit_id":"e2bde8691f1a3cc5bdcd0bd17f051f5b9229a28c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"dc33b9d422eae284032e200e7592fffad2f473f5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  $key_file                \u003d false,"},{"line_number":197,"context_line":"  $ca_file                 \u003d false,"},{"line_number":198,"context_line":"  $sync_db                 \u003d true,"},{"line_number":199,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":200,"context_line":"  $signing_dir           \u003d $::os_service_default,"},{"line_number":201,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":202,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7a740942_f05583c1","line":199,"updated":"2015-12-08 10:04:27.000000000","message":"Please align lines","commit_id":"650747c730043b7c92327794b2d53aa44eef7d75"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"388de9d2571c80a7b92d9c64e1adcbd981e5d2fb","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  $key_file                \u003d false,"},{"line_number":197,"context_line":"  $ca_file                 \u003d false,"},{"line_number":198,"context_line":"  $sync_db                 \u003d true,"},{"line_number":199,"context_line":"  $os_region_name        \u003d \u0027RegionOne\u0027,"},{"line_number":200,"context_line":"  $signing_dir           \u003d $::os_service_default,"},{"line_number":201,"context_line":"  $token_cache_time      \u003d $::os_service_default,"},{"line_number":202,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7a740942_22bdb602","line":199,"in_reply_to":"7a740942_f05583c1","updated":"2015-12-09 12:22:20.000000000","message":"Done","commit_id":"650747c730043b7c92327794b2d53aa44eef7d75"}],"manifests/registry/logging.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"05d3c95a40d6abc88a0f9aa6fab5b255eadd84d9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    Defaults to \u0027false\u0027"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*use_syslog_rfc_format*]"},{"line_number":20,"context_line":"#    (Optional) (Optional) Enables or disables syslog rfc5424 format for logging."},{"line_number":21,"context_line":"#    If enabled, prefixes the MSG part of the syslog message with APP-NAME (RFC5424)."},{"line_number":22,"context_line":"#    The format without the APP-NAME is deprecated in Kilo, and will be removed in Mitaka,"},{"line_number":23,"context_line":"#    along with this option. This option is ignored if log_config_append is set."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_ae915654","line":20,"updated":"2015-10-20 09:31:43.000000000","message":"the same here","commit_id":"c66b9737430bceac4aff42175feb2e8e27ce6cca"}],"spec/classes/glance_notify_rabbitmq_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"dc33b9d422eae284032e200e7592fffad2f473f5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/rabbit_notification_topic\u0027).with_value(\u0027notifications\u0027) }"},{"line_number":29,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/heartbeat_timeout_threshold\u0027).with_value(\u00270\u0027) }"},{"line_number":30,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/heartbeat_rate\u0027).with_value(\u00272\u0027) }"},{"line_number":31,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/kombu_reconnect_delay\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  describe \u0027when passing params and use ssl\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"7a740942_50da574d","line":31,"updated":"2015-12-08 10:04:27.000000000","message":"Please add some tests with overridden parameters (here and in other files)","commit_id":"650747c730043b7c92327794b2d53aa44eef7d75"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"388de9d2571c80a7b92d9c64e1adcbd981e5d2fb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/rabbit_notification_topic\u0027).with_value(\u0027notifications\u0027) }"},{"line_number":29,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/heartbeat_timeout_threshold\u0027).with_value(\u00270\u0027) }"},{"line_number":30,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/heartbeat_rate\u0027).with_value(\u00272\u0027) }"},{"line_number":31,"context_line":"    it { is_expected.to contain_glance_api_config(\u0027oslo_messaging_rabbit/kombu_reconnect_delay\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  describe \u0027when passing params and use ssl\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"7a740942_42ba420c","line":31,"in_reply_to":"7a740942_50da574d","updated":"2015-12-09 12:22:20.000000000","message":"Done","commit_id":"650747c730043b7c92327794b2d53aa44eef7d75"}]}