)]}'
{"manifests/notify/rabbitmq.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c38d23de4f0ad9f11acc01a546e4efdaa369e1a3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Heartbeating helps to ensure the TCP connection to RabbitMQ isn\u0027t silently"},{"line_number":28,"context_line":"#   closed, resulting in missed or lost messages from the queue."},{"line_number":29,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":30,"context_line":"#   Defaults to 0"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":33,"context_line":"#   (optional) How often during the rabbit_heartbeat_timeout_threshold period to"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_afae1483","line":30,"updated":"2015-10-20 19:19:55.000000000","message":"Should we use $::os_service_default for this one since this isn\u0027t defined and is marked as an experimental option in the docs that I found. I\u0027m not sure we should be providing a value here by default","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"e03b33f06fc38398e874ef146efed05719aabb28","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Heartbeating helps to ensure the TCP connection to RabbitMQ isn\u0027t silently"},{"line_number":28,"context_line":"#   closed, resulting in missed or lost messages from the queue."},{"line_number":29,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":30,"context_line":"#   Defaults to 0"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":33,"context_line":"#   (optional) How often during the rabbit_heartbeat_timeout_threshold period to"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa80f949_f720b64b","line":30,"in_reply_to":"1a26ad4f_565e2013","updated":"2015-11-03 23:35:46.000000000","message":"Yeah.  This will need to follow the old normal pattern of using if/else and absent.  Same as line 138.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9487547a76584b434a31e14c6002e2a9e84d89b4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Heartbeating helps to ensure the TCP connection to RabbitMQ isn\u0027t silently"},{"line_number":28,"context_line":"#   closed, resulting in missed or lost messages from the queue."},{"line_number":29,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":30,"context_line":"#   Defaults to 0"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":33,"context_line":"#   (optional) How often during the rabbit_heartbeat_timeout_threshold period to"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_565e2013","line":30,"in_reply_to":"1a26ad4f_c4b04746","updated":"2015-10-29 14:14:50.000000000","message":"Guys, we don\u0027t have such feature in Kilo.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"a429b3665744007948143e58561d204277d102a0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Heartbeating helps to ensure the TCP connection to RabbitMQ isn\u0027t silently"},{"line_number":28,"context_line":"#   closed, resulting in missed or lost messages from the queue."},{"line_number":29,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":30,"context_line":"#   Defaults to 0"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":33,"context_line":"#   (optional) How often during the rabbit_heartbeat_timeout_threshold period to"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_c4b04746","line":30,"in_reply_to":"1a26ad4f_d0f48288","updated":"2015-10-29 08:06:52.000000000","message":"n/m, I misread this.  I agree with making defaults here $::os_service_default","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"4960e928125dc7fc0ead18997ee38699159e9b81","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Heartbeating helps to ensure the TCP connection to RabbitMQ isn\u0027t silently"},{"line_number":28,"context_line":"#   closed, resulting in missed or lost messages from the queue."},{"line_number":29,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":30,"context_line":"#   Defaults to 0"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":33,"context_line":"#   (optional) How often during the rabbit_heartbeat_timeout_threshold period to"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_d0f48288","line":30,"in_reply_to":"3a29b11f_afae1483","updated":"2015-10-29 07:50:47.000000000","message":"The default value for kilo is 0, and when set to zero it disables this functionality.  So I think this addresses your concerns.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d1cb77037c9619c2ea618595b252031d811ee738","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   Heartbeating helps to ensure the TCP connection to RabbitMQ isn\u0027t silently"},{"line_number":28,"context_line":"#   closed, resulting in missed or lost messages from the queue."},{"line_number":29,"context_line":"#   (Requires kombu \u003e\u003d 3.0.7 and amqp \u003e\u003d 1.4.0)"},{"line_number":30,"context_line":"#   Defaults to 0"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":33,"context_line":"#   (optional) How often during the rabbit_heartbeat_timeout_threshold period to"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa80f949_6ea2444d","line":30,"in_reply_to":"fa80f949_f720b64b","updated":"2015-11-06 09:02:45.000000000","message":"We don\u0027t have in this patch any false/undef checks.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c38d23de4f0ad9f11acc01a546e4efdaa369e1a3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   check the heartbeat on RabbitMQ connection.  (i.e. rabbit_heartbeat_rate\u003d2"},{"line_number":35,"context_line":"#   when rabbit_heartbeat_timeout_threshold\u003d60, the heartbeat will be checked"},{"line_number":36,"context_line":"#   every 30 seconds."},{"line_number":37,"context_line":"#   Defaults to 2"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"#  [*rabbit_use_ssl*]"},{"line_number":40,"context_line":"#    (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_cfa9107d","line":37,"updated":"2015-10-20 19:19:55.000000000","message":"We should use $::os_service_default for this one","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"a429b3665744007948143e58561d204277d102a0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   check the heartbeat on RabbitMQ connection.  (i.e. rabbit_heartbeat_rate\u003d2"},{"line_number":35,"context_line":"#   when rabbit_heartbeat_timeout_threshold\u003d60, the heartbeat will be checked"},{"line_number":36,"context_line":"#   every 30 seconds."},{"line_number":37,"context_line":"#   Defaults to 2"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"#  [*rabbit_use_ssl*]"},{"line_number":40,"context_line":"#    (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_e4ab03d5","line":37,"in_reply_to":"1a26ad4f_302cd601","updated":"2015-10-29 08:06:52.000000000","message":"n/m, agree with Alex.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d1cb77037c9619c2ea618595b252031d811ee738","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   check the heartbeat on RabbitMQ connection.  (i.e. rabbit_heartbeat_rate\u003d2"},{"line_number":35,"context_line":"#   when rabbit_heartbeat_timeout_threshold\u003d60, the heartbeat will be checked"},{"line_number":36,"context_line":"#   every 30 seconds."},{"line_number":37,"context_line":"#   Defaults to 2"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"#  [*rabbit_use_ssl*]"},{"line_number":40,"context_line":"#    (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa80f949_6eeb2479","line":37,"in_reply_to":"1a26ad4f_e4ab03d5","updated":"2015-11-06 09:02:45.000000000","message":"Again, we don\u0027t have this for Kilo - should be just defaults from project.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"4960e928125dc7fc0ead18997ee38699159e9b81","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   check the heartbeat on RabbitMQ connection.  (i.e. rabbit_heartbeat_rate\u003d2"},{"line_number":35,"context_line":"#   when rabbit_heartbeat_timeout_threshold\u003d60, the heartbeat will be checked"},{"line_number":36,"context_line":"#   every 30 seconds."},{"line_number":37,"context_line":"#   Defaults to 2"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"#  [*rabbit_use_ssl*]"},{"line_number":40,"context_line":"#    (optional) Connect over SSL for RabbitMQ"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_302cd601","line":37,"in_reply_to":"3a29b11f_cfa9107d","updated":"2015-10-29 07:50:47.000000000","message":"Upstream kilo oslo-messaging default for this is 2.","commit_id":"ac0be6e51f34daa71fb0ea501b3099528b5cb89a"}]}
