)]}'
{"manifests/api/db.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"9e775a45ce4bedc604ed29e7bfb5db7c8ce0e6bc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  # NOTE(degorenko): In order to keep backward compatibility we rely on the pick function"},{"line_number":47,"context_line":"  # to use glance::api::\u003cmyparam\u003e if glance::api::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":48,"context_line":"  $database_connection_real     \u003d pick($::glance::api::database_connection, $database_connection)"},{"line_number":49,"context_line":"  $database_idle_timeout_real   \u003d pick($::glance::api::database_idle_timeout, $database_idle_timeout)"},{"line_number":50,"context_line":"  $database_min_pool_size_real  \u003d pick($::glance::api::database_min_pool_size, $database_min_pool_size)"},{"line_number":51,"context_line":"  $database_max_pool_size_real  \u003d pick($::glance::api::database_max_pool_size, $database_max_pool_size)"},{"line_number":52,"context_line":"  $database_max_retries_real    \u003d pick($::glance::api::database_max_retries, $database_max_retries)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_1d32b35f","line":49,"updated":"2015-10-21 15:00:52.000000000","message":"Most of those picks are unecessary as those value do not exist in glance::api. I think we should add those values in glance::api set to undef. Like https://github.com/openstack/puppet-heat/blob/master/manifests/init.pp#L279-L285","commit_id":"cc5a5e5f345f21d7bb9c37a25e895fd5034c913c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7d2db38c9d6ffd235edd03d6cf512c04300b7923","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  # NOTE(degorenko): In order to keep backward compatibility we rely on the pick function"},{"line_number":47,"context_line":"  # to use glance::api::\u003cmyparam\u003e if glance::api::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":48,"context_line":"  $database_connection_real     \u003d pick($::glance::api::database_connection, $database_connection)"},{"line_number":49,"context_line":"  $database_idle_timeout_real   \u003d pick($::glance::api::database_idle_timeout, $database_idle_timeout)"},{"line_number":50,"context_line":"  $database_min_pool_size_real  \u003d pick($::glance::api::database_min_pool_size, $database_min_pool_size)"},{"line_number":51,"context_line":"  $database_max_pool_size_real  \u003d pick($::glance::api::database_max_pool_size, $database_max_pool_size)"},{"line_number":52,"context_line":"  $database_max_retries_real    \u003d pick($::glance::api::database_max_retries, $database_max_retries)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_fd9e7bb7","line":49,"in_reply_to":"3a29b11f_1d32b35f","updated":"2015-10-23 14:34:29.000000000","message":"It is already done :)","commit_id":"cc5a5e5f345f21d7bb9c37a25e895fd5034c913c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e60bf8598216e8dff0de6931ac81f6ab61fb8da","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class glance::api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d \u0027sqlite:///var/lib/glance/glance.sqlite\u0027,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d 3600,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d 1,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d 10,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d 10,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_a0af682a","line":38,"updated":"2015-10-24 19:04:15.000000000","message":"Can we use $::os_service_default?","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"abd308d0e159f395fbe2b31e4cc7aa4958b119dd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class glance::api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d \u0027sqlite:///var/lib/glance/glance.sqlite\u0027,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d 3600,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d 1,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d 10,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d 10,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_1708a190","line":38,"in_reply_to":"3a29b11f_1b87ad13","updated":"2015-11-17 17:26:52.000000000","message":"I suggest we create a patch on top of this one fixing https://bugs.launchpad.net/puppet-tuskar/+bug/1515273\n\nWDYT?","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3cc898311507ff982bd41fcf70840a734d938c3e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class glance::api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d \u0027sqlite:///var/lib/glance/glance.sqlite\u0027,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d 3600,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d 1,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d 10,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d 10,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_1b87ad13","line":38,"in_reply_to":"3a29b11f_a0af682a","updated":"2015-10-24 21:32:10.000000000","message":"As i know, we start implementing this feature from cinder module. And for now, we don\u0027t use it for another. Will wait for more feedbacks.","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"47e372f70f68eef3d5351c34dc0b34feefef018c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class glance::api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d \u0027sqlite:///var/lib/glance/glance.sqlite\u0027,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d 3600,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d 1,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d 10,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d 10,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_d75d397a","line":38,"in_reply_to":"ba8a016a_1708a190","updated":"2015-11-17 17:28:22.000000000","message":"+1 to Emilien idea \u003d)","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c8fdd0505d8bde1d9c77457ff8a86c5964dfb35f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class glance::api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d \u0027sqlite:///var/lib/glance/glance.sqlite\u0027,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d 3600,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d 1,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d 10,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d 10,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_5a4ad0ad","line":38,"in_reply_to":"ba8a016a_1a6208ae","updated":"2015-11-17 17:42:34.000000000","message":"Sorry, my bad - os-service-default is not implemented yet for glance. I suggest to use https://review.openstack.org/237973 as dependency for this patch.","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"da7178bc67db2732c866fe4724173bc78c37fa6e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class glance::api::db ("},{"line_number":37,"context_line":"  $database_connection     \u003d \u0027sqlite:///var/lib/glance/glance.sqlite\u0027,"},{"line_number":38,"context_line":"  $database_idle_timeout   \u003d 3600,"},{"line_number":39,"context_line":"  $database_min_pool_size  \u003d 1,"},{"line_number":40,"context_line":"  $database_max_pool_size  \u003d 10,"},{"line_number":41,"context_line":"  $database_max_retries    \u003d 10,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_1a6208ae","line":38,"in_reply_to":"ba8a016a_d75d397a","updated":"2015-11-17 17:36:25.000000000","message":"I think i just will update this one :)","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"}],"manifests/params.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e60bf8598216e8dff0de6931ac81f6ab61fb8da","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      $registry_service_name \u003d \u0027glance-registry\u0027"},{"line_number":29,"context_line":"      $db_sync_command       \u003d \u0027glance-manage --config-file\u003d/etc/glance/glance-registry.conf db_sync\u0027"},{"line_number":30,"context_line":"      $pyceph_package_name   \u003d \u0027python-ceph\u0027"},{"line_number":31,"context_line":"      $sqlite_package_name   \u003d \u0027python-pysqlite2\u0027"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"    default: {"},{"line_number":34,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem: ${::operatingsystem}, module ${module_name} only support osfamily RedHat and Debian\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_80a6ec51","line":31,"updated":"2015-10-24 19:04:15.000000000","message":"this patch should be aligned with the https://review.openstack.org/#/c/238811/4/manifests/params.pp\nthey both seem are using different patterns for db class and params","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3cc898311507ff982bd41fcf70840a734d938c3e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      $registry_service_name \u003d \u0027glance-registry\u0027"},{"line_number":29,"context_line":"      $db_sync_command       \u003d \u0027glance-manage --config-file\u003d/etc/glance/glance-registry.conf db_sync\u0027"},{"line_number":30,"context_line":"      $pyceph_package_name   \u003d \u0027python-ceph\u0027"},{"line_number":31,"context_line":"      $sqlite_package_name   \u003d \u0027python-pysqlite2\u0027"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"    default: {"},{"line_number":34,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem: ${::operatingsystem}, module ${module_name} only support osfamily RedHat and Debian\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_5b9e8564","line":31,"in_reply_to":"3a29b11f_80a6ec51","updated":"2015-10-24 21:32:10.000000000","message":"Bogdan, take a look on my comment in patch above.","commit_id":"ba22ada67ebb31c3cae58725cbce65c050354fb6"}],"manifests/registry/db.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"9e775a45ce4bedc604ed29e7bfb5db7c8ce0e6bc","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # NOTE(degorenko): In order to keep backward compatibility we rely on the pick function"},{"line_number":47,"context_line":"  # to use glance::registry::\u003cmyparam\u003e if glance::registry::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":48,"context_line":"  $database_connection_real     \u003d pick($::glance::api::database_connection, $database_connection)"},{"line_number":49,"context_line":"  $database_idle_timeout_real   \u003d pick($::glance::api::database_idle_timeout, $database_idle_timeout)"},{"line_number":50,"context_line":"  $database_min_pool_size_real  \u003d pick($::glance::api::database_min_pool_size, $database_min_pool_size)"},{"line_number":51,"context_line":"  $database_max_pool_size_real  \u003d pick($::glance::api::database_max_pool_size, $database_max_pool_size)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_fd901745","line":48,"updated":"2015-10-21 15:00:52.000000000","message":"you mean glance::registry here I guess","commit_id":"cc5a5e5f345f21d7bb9c37a25e895fd5034c913c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7d2db38c9d6ffd235edd03d6cf512c04300b7923","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # NOTE(degorenko): In order to keep backward compatibility we rely on the pick function"},{"line_number":47,"context_line":"  # to use glance::registry::\u003cmyparam\u003e if glance::registry::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":48,"context_line":"  $database_connection_real     \u003d pick($::glance::api::database_connection, $database_connection)"},{"line_number":49,"context_line":"  $database_idle_timeout_real   \u003d pick($::glance::api::database_idle_timeout, $database_idle_timeout)"},{"line_number":50,"context_line":"  $database_min_pool_size_real  \u003d pick($::glance::api::database_min_pool_size, $database_min_pool_size)"},{"line_number":51,"context_line":"  $database_max_pool_size_real  \u003d pick($::glance::api::database_max_pool_size, $database_max_pool_size)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_7dab4bd7","line":48,"in_reply_to":"3a29b11f_fd901745","updated":"2015-10-23 14:34:29.000000000","message":"Done","commit_id":"cc5a5e5f345f21d7bb9c37a25e895fd5034c913c"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"9e775a45ce4bedc604ed29e7bfb5db7c8ce0e6bc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  # NOTE(degorenko): In order to keep backward compatibility we rely on the pick function"},{"line_number":47,"context_line":"  # to use glance::registry::\u003cmyparam\u003e if glance::registry::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":48,"context_line":"  $database_connection_real     \u003d pick($::glance::api::database_connection, $database_connection)"},{"line_number":49,"context_line":"  $database_idle_timeout_real   \u003d pick($::glance::api::database_idle_timeout, $database_idle_timeout)"},{"line_number":50,"context_line":"  $database_min_pool_size_real  \u003d pick($::glance::api::database_min_pool_size, $database_min_pool_size)"},{"line_number":51,"context_line":"  $database_max_pool_size_real  \u003d pick($::glance::api::database_max_pool_size, $database_max_pool_size)"},{"line_number":52,"context_line":"  $database_max_retries_real    \u003d pick($::glance::api::database_max_retries, $database_max_retries)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_5da82b77","line":49,"updated":"2015-10-21 15:00:52.000000000","message":"Most of those picks are unecessary as those value do not exist in glance::registry. I think we should add those values in glance::api set to undef. Like https://github.com/openstack/puppet-heat/blob/master/manifests/init.pp#L279-L285","commit_id":"cc5a5e5f345f21d7bb9c37a25e895fd5034c913c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7d2db38c9d6ffd235edd03d6cf512c04300b7923","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  # NOTE(degorenko): In order to keep backward compatibility we rely on the pick function"},{"line_number":47,"context_line":"  # to use glance::registry::\u003cmyparam\u003e if glance::registry::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":48,"context_line":"  $database_connection_real     \u003d pick($::glance::api::database_connection, $database_connection)"},{"line_number":49,"context_line":"  $database_idle_timeout_real   \u003d pick($::glance::api::database_idle_timeout, $database_idle_timeout)"},{"line_number":50,"context_line":"  $database_min_pool_size_real  \u003d pick($::glance::api::database_min_pool_size, $database_min_pool_size)"},{"line_number":51,"context_line":"  $database_max_pool_size_real  \u003d pick($::glance::api::database_max_pool_size, $database_max_pool_size)"},{"line_number":52,"context_line":"  $database_max_retries_real    \u003d pick($::glance::api::database_max_retries, $database_max_retries)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a29b11f_bda803dd","line":49,"in_reply_to":"3a29b11f_5da82b77","updated":"2015-10-23 14:34:29.000000000","message":"It is already done :)","commit_id":"cc5a5e5f345f21d7bb9c37a25e895fd5034c913c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a729023ae762968c3538a8299bd21850b27277bf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027(sqlite|mysql|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $database_connection_real {"},{"line_number":60,"context_line":"    case $database_connection_real {"},{"line_number":61,"context_line":"      /^mysql:\\/\\//: {"},{"line_number":62,"context_line":"        $backend_package \u003d false"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a8ffd7b_71c61418","line":59,"updated":"2015-12-01 00:49:12.000000000","message":"We really need this? \ndatabase_connection it\u0027s not undef\n\nTake a look: https://github.com/openstack/puppet-cinder/blob/master/manifests/db.pp","commit_id":"3f8df1ab491b925a7a1f3d268e5518cb486501c1"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4370cb26585a482f021bbbd1b989ce75bfa399d3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  validate_re($database_connection_real,"},{"line_number":57,"context_line":"    \u0027(sqlite|mysql|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $database_connection_real {"},{"line_number":60,"context_line":"    case $database_connection_real {"},{"line_number":61,"context_line":"      /^mysql:\\/\\//: {"},{"line_number":62,"context_line":"        $backend_package \u003d false"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a8ffd7b_e61c756c","line":59,"in_reply_to":"9a8ffd7b_71c61418","updated":"2015-12-01 10:37:19.000000000","message":"Done","commit_id":"3f8df1ab491b925a7a1f3d268e5518cb486501c1"}]}