)]}'
{"spec/classes/glance_api_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f26022d1811b65dabd9a843886522064bfeee463","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  describe \u0027on Debian platforms\u0027 do"},{"line_number":379,"context_line":"    let :facts do"},{"line_number":380,"context_line":"      { :osfamily \u003d\u003e \u0027Debian\u0027 }"},{"line_number":381,"context_line":"    end"},{"line_number":382,"context_line":"    let(:params) { default_params }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a29b11f_511b3aca","line":379,"updated":"2015-10-21 14:04:38.000000000","message":"I think you actually need to update these facts. Not sure why facts is defined above as they will be overridden here.","commit_id":"976e60e4e3fee49e3a1a94019dd39986ecd6e261"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f26022d1811b65dabd9a843886522064bfeee463","unresolved":false,"context_lines":[{"line_number":395,"context_line":"  end"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"  describe \u0027on RedHat platforms\u0027 do"},{"line_number":398,"context_line":"    let :facts do"},{"line_number":399,"context_line":"      { :osfamily \u003d\u003e \u0027RedHat\u0027 }"},{"line_number":400,"context_line":"    end"},{"line_number":401,"context_line":"    let(:params) { default_params }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a29b11f_b1808ec0","line":398,"updated":"2015-10-21 14:04:38.000000000","message":"these too","commit_id":"976e60e4e3fee49e3a1a94019dd39986ecd6e261"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f1a0560b061ad6cc98c9a524e086b0f35710a278","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027glance::api\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    @default_facts.merge!({"},{"line_number":7,"context_line":"     :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":8,"context_line":"     :processorcount \u003d\u003e \u00277\u0027,"},{"line_number":9,"context_line":"    })"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_a5436512","line":6,"updated":"2015-10-21 15:49:54.000000000","message":"I think you want .merge and not .merge! in all these spots.","commit_id":"d198d9dac522fa0d33bd552148def003548eb91d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4c7175c05f1c2efdc0bbf871b72f752730c7e7e5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027glance::api\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    @default_facts.merge!({"},{"line_number":7,"context_line":"     :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":8,"context_line":"     :processorcount \u003d\u003e \u00277\u0027,"},{"line_number":9,"context_line":"    })"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_439a896f","line":6,"in_reply_to":"3a29b11f_231bcd74","updated":"2015-10-21 16:23:37.000000000","message":"So .merge! will merge the parameter hash with the hash from @default_facts and update @default_facts.  Where .merge will merge the parameter hash in with default_facts and return a new object.  I might be wrong but I think the correct one to do here would be .merge(...).  Probably not a big deal but might lead to some weird results later.","commit_id":"d198d9dac522fa0d33bd552148def003548eb91d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"d509d75013e961ff7686cac8a183a97acfd99f20","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027glance::api\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    @default_facts.merge!({"},{"line_number":7,"context_line":"     :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":8,"context_line":"     :processorcount \u003d\u003e \u00277\u0027,"},{"line_number":9,"context_line":"    })"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_e0f052cb","line":6,"in_reply_to":"3a29b11f_439a896f","updated":"2015-10-22 07:21:30.000000000","message":"today i reread docs, yesterday i interpreted them incorrectly and now understand you are right, thank you for helping me to figure this out","commit_id":"d198d9dac522fa0d33bd552148def003548eb91d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"40f1eda7d9430c40c06606b8704348815c659419","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027glance::api\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    @default_facts.merge!({"},{"line_number":7,"context_line":"     :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":8,"context_line":"     :processorcount \u003d\u003e \u00277\u0027,"},{"line_number":9,"context_line":"    })"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_231bcd74","line":6,"in_reply_to":"3a29b11f_a5436512","updated":"2015-10-21 16:15:56.000000000","message":"strange because in cinder example - there is .merge! method used\n\nwhat is the significant difference?\n\nfrom what i see from ruby docs:\n\n .merge - merge default_facts hash with hash in (..) and Returns a new hash,\n\n .merge! - adds content of default_facts hash to in (...)\n\nhttp://ruby-doc.org/core-2.1.5/Hash.html\n\nso as for me both cases are ok for us, and i decided to use your cinder example","commit_id":"d198d9dac522fa0d33bd552148def003548eb91d"}],"spec/classes/glance_registry_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f26022d1811b65dabd9a843886522064bfeee463","unresolved":false,"context_lines":[{"line_number":272,"context_line":"  end"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"  describe \u0027on Debian platforms\u0027 do"},{"line_number":275,"context_line":"    let :facts do"},{"line_number":276,"context_line":"      { :osfamily \u003d\u003e \u0027Debian\u0027 }"},{"line_number":277,"context_line":"    end"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a29b11f_51725a12","line":275,"updated":"2015-10-21 14:04:38.000000000","message":"These facts too","commit_id":"976e60e4e3fee49e3a1a94019dd39986ecd6e261"}]}