)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d8dbb76ab6e11afe643f062cbc9fcf12f50da42d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service[\u0027glance-api\u0027]"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_d841c9aa","line":185,"updated":"2015-10-31 16:55:31.000000000","message":"I don\u0027t understand this patch.\n\nIt already works fine in our CI (that runs both ubuntu \u0026 centos).\n\nThe service name resource is glance-api for any distro:\nhttps://github.com/openstack/puppet-glance/blob/master/manifests/api.pp#L453","commit_id":"78702c807f0bbde07a3befdd092a1f060a517566"},{"author":{"_account_id":18622,"name":"Doug Knight","email":"doug.knight@karmix.org","username":"karmix"},"change_message_id":"e1475fa3e4d09d55b35e208fc13dafc2711b910e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service[\u0027glance-api\u0027]"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_24e3d7a5","line":185,"in_reply_to":"1a26ad4f_d841c9aa","updated":"2015-11-02 21:45:30.000000000","message":"That is not quite correct.  The service name is $::glance::params::api_service_name, which is \u0027openstack-glance-api\u0027 on Red Hat: https://github.com/openstack/puppet-glance/blob/master/manifests/api.pp#L455 \u0026 https://github.com/openstack/puppet-glance/blob/master/manifests/params.pp#L14 .  As Denis mentioned, this changes the dependency rules to match the service title, which is \u0027glance-api\u0027 on all distros, as you noted.","commit_id":"78702c807f0bbde07a3befdd092a1f060a517566"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d75d359c4f187414b088cc4d7abf0e7fe2577911","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service[\u0027glance-api\u0027]"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a26ad4f_654c8d9e","line":185,"in_reply_to":"1a26ad4f_d841c9aa","updated":"2015-11-01 15:19:28.000000000","message":"That\u0027s true. But now it relies on resource \u0027name\u0027 and this patch is going to change it on resource \u0027title\u0027 as i understand","commit_id":"78702c807f0bbde07a3befdd092a1f060a517566"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"890a93880bdfa2c91167457a502f7ae88d6f53ca","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service\u003c| title \u003d\u003d \u0027glance-api\u0027 |\u003e"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_2804767c","line":185,"updated":"2015-11-14 13:45:09.000000000","message":"I believe the intent is for this to be a soft dependency, so that it only applies if you\u0027re running keystone and glance on the same node.","commit_id":"2a12d86fa13ebc8e0d6e23598c51d79dadb5cd8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f7a71c3fc3e1044bd45004c57984d8142c9e0053","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service\u003c| title \u003d\u003d \u0027glance-api\u0027 |\u003e"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_4425dcbe","line":185,"updated":"2015-11-06 10:54:44.000000000","message":"btw, in this case you can just use Service[\u0027glance-api\u0027]","commit_id":"2a12d86fa13ebc8e0d6e23598c51d79dadb5cd8c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3a79ec1db4a4b71f50e92c213f43d1aa64dab6df","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service\u003c| title \u003d\u003d \u0027glance-api\u0027 |\u003e"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_5359e433","line":185,"in_reply_to":"ba8a016a_09dd1a42","updated":"2015-11-19 16:12:08.000000000","message":"Yeah, i forgot about it.","commit_id":"2a12d86fa13ebc8e0d6e23598c51d79dadb5cd8c"},{"author":{"_account_id":18622,"name":"Doug Knight","email":"doug.knight@karmix.org","username":"karmix"},"change_message_id":"0be5adfc0b5557dea9bc9e19fa0dc0fa210b596d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  $real_service_name \u003d pick($service_name, $auth_name)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  if $configure_endpoint {"},{"line_number":185,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"]  ~\u003e Service\u003c| title \u003d\u003d \u0027glance-api\u0027 |\u003e"},{"line_number":186,"context_line":"    Keystone_endpoint[\"${region}/${real_service_name}\"] -\u003e Glance_image\u003c||\u003e"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_09dd1a42","line":185,"in_reply_to":"da85f559_2804767c","updated":"2015-11-16 22:42:33.000000000","message":"Clayton is correct.","commit_id":"2a12d86fa13ebc8e0d6e23598c51d79dadb5cd8c"}],"spec/acceptance/basic_glance_spec.rb":[{"author":{"_account_id":18622,"name":"Doug Knight","email":"doug.knight@karmix.org","username":"karmix"},"change_message_id":"e1475fa3e4d09d55b35e208fc13dafc2711b910e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027glance class\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":6,"context_line":"    pp\u003d \u003c\u003c-EOS"},{"line_number":7,"context_line":"    Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    # Common resources"},{"line_number":10,"context_line":"    case $::osfamily {"},{"line_number":11,"context_line":"      \u0027Debian\u0027: {"},{"line_number":12,"context_line":"        include ::apt"},{"line_number":13,"context_line":"        class { \u0027::openstack_extras::repo::debian::ubuntu\u0027:"},{"line_number":14,"context_line":"          release         \u003d\u003e \u0027liberty\u0027,"},{"line_number":15,"context_line":"          repo            \u003d\u003e \u0027proposed\u0027,"},{"line_number":16,"context_line":"          package_require \u003d\u003e true,"},{"line_number":17,"context_line":"        }"},{"line_number":18,"context_line":"      }"},{"line_number":19,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":20,"context_line":"        class { \u0027::openstack_extras::repo::redhat::redhat\u0027:"},{"line_number":21,"context_line":"          manage_rdo \u003d\u003e false,"},{"line_number":22,"context_line":"          repo_hash \u003d\u003e {"},{"line_number":23,"context_line":"            \u0027openstack-common-testing\u0027 \u003d\u003e {"},{"line_number":24,"context_line":"              \u0027baseurl\u0027  \u003d\u003e \u0027http://cbs.centos.org/repos/cloud7-openstack-common-testing/x86_64/os/\u0027,"},{"line_number":25,"context_line":"              \u0027descr\u0027    \u003d\u003e \u0027openstack-common-testing\u0027,"},{"line_number":26,"context_line":"              \u0027gpgcheck\u0027 \u003d\u003e \u0027no\u0027,"},{"line_number":27,"context_line":"            },"},{"line_number":28,"context_line":"            \u0027openstack-liberty-testing\u0027 \u003d\u003e {"},{"line_number":29,"context_line":"              \u0027baseurl\u0027  \u003d\u003e \u0027http://cbs.centos.org/repos/cloud7-openstack-liberty-testing/x86_64/os/\u0027,"},{"line_number":30,"context_line":"              \u0027descr\u0027    \u003d\u003e \u0027openstack-liberty-testing\u0027,"},{"line_number":31,"context_line":"              \u0027gpgcheck\u0027 \u003d\u003e \u0027no\u0027,"},{"line_number":32,"context_line":"            },"},{"line_number":33,"context_line":"            \u0027openstack-liberty-trunk\u0027 \u003d\u003e {"},{"line_number":34,"context_line":"              \u0027baseurl\u0027  \u003d\u003e \u0027http://trunk.rdoproject.org/centos7-liberty/current-passed-ci/\u0027,"},{"line_number":35,"context_line":"              \u0027descr\u0027    \u003d\u003e \u0027openstack-liberty-trunk\u0027,"},{"line_number":36,"context_line":"              \u0027gpgcheck\u0027 \u003d\u003e \u0027no\u0027,"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"          },"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        package { \u0027openstack-selinux\u0027: ensure \u003d\u003e \u0027latest\u0027 }"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"      default: {"},{"line_number":43,"context_line":"        fail(\"Unsupported osfamily (${::osfamily})\")"},{"line_number":44,"context_line":"      }"},{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    class { \u0027::mysql::server\u0027: }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    # Keystone resources, needed by Glance to run"},{"line_number":50,"context_line":"    class { \u0027::keystone::db::mysql\u0027:"},{"line_number":51,"context_line":"      # https://bugs.launchpad.net/puppet-keystone/+bug/1446375"},{"line_number":52,"context_line":"      collate  \u003d\u003e \u0027utf8_general_ci\u0027,"},{"line_number":53,"context_line":"      password \u003d\u003e \u0027keystone\u0027,"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"    class { \u0027::keystone\u0027:"},{"line_number":56,"context_line":"      verbose             \u003d\u003e true,"},{"line_number":57,"context_line":"      debug               \u003d\u003e true,"},{"line_number":58,"context_line":"      database_connection \u003d\u003e \u0027mysql://keystone:keystone@127.0.0.1/keystone\u0027,"},{"line_number":59,"context_line":"      admin_token         \u003d\u003e \u0027admin_token\u0027,"},{"line_number":60,"context_line":"      enabled             \u003d\u003e true,"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"    class { \u0027::keystone::roles::admin\u0027:"},{"line_number":63,"context_line":"      email    \u003d\u003e \u0027test@example.tld\u0027,"},{"line_number":64,"context_line":"      password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":"    class { \u0027::keystone::endpoint\u0027:"},{"line_number":67,"context_line":"      public_url \u003d\u003e \"https://${::fqdn}:5000/\","},{"line_number":68,"context_line":"      admin_url  \u003d\u003e \"https://${::fqdn}:35357/\","},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # Glance resources"},{"line_number":72,"context_line":"    include ::glance"},{"line_number":73,"context_line":"    include ::glance::client"},{"line_number":74,"context_line":"    include ::glance::backend::file"},{"line_number":75,"context_line":"    class { \u0027::glance::db::mysql\u0027:"},{"line_number":76,"context_line":"      # https://bugs.launchpad.net/puppet-glance/+bug/1446375"},{"line_number":77,"context_line":"      collate  \u003d\u003e \u0027utf8_general_ci\u0027,"},{"line_number":78,"context_line":"      password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":"    class { \u0027::glance::keystone::auth\u0027:"},{"line_number":81,"context_line":"      password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":"    class { \u0027::glance::api\u0027:"},{"line_number":84,"context_line":"      database_connection \u003d\u003e \u0027mysql://glance:a_big_secret@127.0.0.1/glance?charset\u003dutf8\u0027,"},{"line_number":85,"context_line":"      verbose             \u003d\u003e false,"},{"line_number":86,"context_line":"      keystone_password   \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"    class { \u0027::glance::registry\u0027:"},{"line_number":89,"context_line":"      database_connection \u003d\u003e \u0027mysql://glance:a_big_secret@127.0.0.1/glance?charset\u003dutf8\u0027,"},{"line_number":90,"context_line":"      verbose             \u003d\u003e false,"},{"line_number":91,"context_line":"      keystone_password   \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    glance_image { \u0027test_image\u0027:"},{"line_number":95,"context_line":"      ensure           \u003d\u003e present,"},{"line_number":96,"context_line":"      container_format \u003d\u003e \u0027bare\u0027,"},{"line_number":97,"context_line":"      disk_format      \u003d\u003e \u0027qcow2\u0027,"},{"line_number":98,"context_line":"      is_public        \u003d\u003e \u0027yes\u0027,"},{"line_number":99,"context_line":"      source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-disk.img\u0027,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":"    EOS"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    it \u0027should configure the glance endpoint before the glance-api service uses it\u0027 do"},{"line_number":104,"context_line":"      pp2 \u003d pp + \"Service[\u0027glance-api\u0027] -\u003e Keystone_endpoint[\u0027RegionOne/glance\u0027]\""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_09585d89","line":101,"range":{"start_line":6,"start_character":2,"end_line":101,"end_character":7},"updated":"2015-11-02 21:45:30.000000000","message":"This is the same manifest as the previous test used, simply moved into context scope (which included indentation changes).  The four tests below this manifest are new.","commit_id":"78702c807f0bbde07a3befdd092a1f060a517566"}]}