)]}'
{"manifests/api.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"1779b04a83552ac7a2cd46756f0129bf6b9334ce","unresolved":false,"context_lines":[{"line_number":181,"context_line":"#   (optional) Expose image location to trusted clients."},{"line_number":182,"context_line":"#   Defaults to false."},{"line_number":183,"context_line":"#"},{"line_number":184,"context_line":"# [*show_multiple_locations*]"},{"line_number":185,"context_line":"#   (optional) Whether to include the backend image locations in image"},{"line_number":186,"context_line":"#    properties."},{"line_number":187,"context_line":"#   Defaults to false."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_0fb9fe2d","line":184,"range":{"start_line":184,"start_character":4,"end_line":184,"end_character":27},"updated":"2015-12-21 13:05:43.000000000","message":"Please add tests for new parameters","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"1f45eac4d1068a229f99b6ee40be3991628ecb2e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"#   (optional) Expose image location to trusted clients."},{"line_number":182,"context_line":"#   Defaults to false."},{"line_number":183,"context_line":"#"},{"line_number":184,"context_line":"# [*show_multiple_locations*]"},{"line_number":185,"context_line":"#   (optional) Whether to include the backend image locations in image"},{"line_number":186,"context_line":"#    properties."},{"line_number":187,"context_line":"#   Defaults to false."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_b5a1fb95","line":184,"range":{"start_line":184,"start_character":4,"end_line":184,"end_character":27},"in_reply_to":"3a7e1126_0fb9fe2d","updated":"2015-12-22 02:38:09.000000000","message":"Thanks for the guidance. Spec tests added and testing passed on my local machine. Will you review and see if tests are sufficient please?","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"f74c65432fc5aaefd559647d3dbd053fea50f999","unresolved":false,"context_lines":[{"line_number":280,"context_line":"  $use_stderr               \u003d undef,"},{"line_number":281,"context_line":"  $log_facility             \u003d undef,"},{"line_number":282,"context_line":"  $show_image_direct_url    \u003d false,"},{"line_number":283,"context_line":"  $location_strategy        \u003d \u0027location_order\u0027,"},{"line_number":284,"context_line":"  $show_multiple_locations  \u003d false,"},{"line_number":285,"context_line":"  $purge_config             \u003d false,"},{"line_number":286,"context_line":"  $cert_file                \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_68fa0a45","line":283,"updated":"2015-12-21 08:30:26.000000000","message":"when parameter has service default value or is undefined, it should be:\n$location_strategy \u003d $::os_service_default,\n\nfor example - https://github.com/openstack/puppet-heat/blob/master/manifests/init.pp#L268","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"1f45eac4d1068a229f99b6ee40be3991628ecb2e","unresolved":false,"context_lines":[{"line_number":280,"context_line":"  $use_stderr               \u003d undef,"},{"line_number":281,"context_line":"  $log_facility             \u003d undef,"},{"line_number":282,"context_line":"  $show_image_direct_url    \u003d false,"},{"line_number":283,"context_line":"  $location_strategy        \u003d \u0027location_order\u0027,"},{"line_number":284,"context_line":"  $show_multiple_locations  \u003d false,"},{"line_number":285,"context_line":"  $purge_config             \u003d false,"},{"line_number":286,"context_line":"  $cert_file                \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_7f8db4d1","line":283,"in_reply_to":"3a7e1126_68fa0a45","updated":"2015-12-22 02:38:09.000000000","message":"Done","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"f74c65432fc5aaefd559647d3dbd053fea50f999","unresolved":false,"context_lines":[{"line_number":281,"context_line":"  $log_facility             \u003d undef,"},{"line_number":282,"context_line":"  $show_image_direct_url    \u003d false,"},{"line_number":283,"context_line":"  $location_strategy        \u003d \u0027location_order\u0027,"},{"line_number":284,"context_line":"  $show_multiple_locations  \u003d false,"},{"line_number":285,"context_line":"  $purge_config             \u003d false,"},{"line_number":286,"context_line":"  $cert_file                \u003d false,"},{"line_number":287,"context_line":"  $key_file                 \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_e8b35a98","line":284,"updated":"2015-12-21 08:30:26.000000000","message":"the same here","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"1f45eac4d1068a229f99b6ee40be3991628ecb2e","unresolved":false,"context_lines":[{"line_number":281,"context_line":"  $log_facility             \u003d undef,"},{"line_number":282,"context_line":"  $show_image_direct_url    \u003d false,"},{"line_number":283,"context_line":"  $location_strategy        \u003d \u0027location_order\u0027,"},{"line_number":284,"context_line":"  $show_multiple_locations  \u003d false,"},{"line_number":285,"context_line":"  $purge_config             \u003d false,"},{"line_number":286,"context_line":"  $cert_file                \u003d false,"},{"line_number":287,"context_line":"  $key_file                 \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_55ac578b","line":284,"in_reply_to":"3a7e1126_e8b35a98","updated":"2015-12-22 02:38:09.000000000","message":"Done","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"f74c65432fc5aaefd559647d3dbd053fea50f999","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    \u0027DEFAULT/workers\u0027:                  value \u003d\u003e $workers;"},{"line_number":354,"context_line":"    \u0027DEFAULT/show_image_direct_url\u0027:    value \u003d\u003e $show_image_direct_url;"},{"line_number":355,"context_line":"    \u0027DEFAULT/location_strategy\u0027:        value \u003d\u003e $location_strategy;"},{"line_number":356,"context_line":"    \u0027DEFAULT/show_multiple_locations\u0027:  value \u003d\u003e $show_multiple_locations;"},{"line_number":357,"context_line":"    \u0027DEFAULT/scrub_time\u0027:               value \u003d\u003e $scrub_time;"},{"line_number":358,"context_line":"    \u0027DEFAULT/delayed_delete\u0027:           value \u003d\u003e $delayed_delete;"},{"line_number":359,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:          value \u003d\u003e $image_cache_dir;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_a8b23292","line":356,"updated":"2015-12-21 08:30:26.000000000","message":"wrong alignment, should be 1 space from \":\" symbol","commit_id":"68af9f2efabcf6e979d111a9caa81982ee0901d7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2b44524c818de6bcc15e955343b51ececf305498","unresolved":false,"context_lines":[{"line_number":184,"context_line":"# [*show_multiple_locations*]"},{"line_number":185,"context_line":"#   (optional) Whether to include the backend image locations in image"},{"line_number":186,"context_line":"#    properties."},{"line_number":187,"context_line":"#   Defaults to false."},{"line_number":188,"context_line":"#"},{"line_number":189,"context_line":"# [*location_strategy*]"},{"line_number":190,"context_line":"#   (optional) Strategy used to determine the image location order."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_f3f474f1","line":187,"updated":"2015-12-22 08:37:58.000000000","message":"this should be \"Defaults to $::os_service_default.\"","commit_id":"ef00f29b69ffad107bb24acab7d2dcfc1aac15ae"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2b44524c818de6bcc15e955343b51ececf305498","unresolved":false,"context_lines":[{"line_number":188,"context_line":"#"},{"line_number":189,"context_line":"# [*location_strategy*]"},{"line_number":190,"context_line":"#   (optional) Strategy used to determine the image location order."},{"line_number":191,"context_line":"#   Defaults to location_order."},{"line_number":192,"context_line":"#"},{"line_number":193,"context_line":"# [*purge_config*]"},{"line_number":194,"context_line":"#   (optional) Whether to set only the specified config options"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_73e16429","line":191,"updated":"2015-12-22 08:37:58.000000000","message":"the same here","commit_id":"ef00f29b69ffad107bb24acab7d2dcfc1aac15ae"}]}
