)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d595b3a79c1234f01f451f7e3d04badf8835519f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update documentation of known_stores"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"stores params has changed its passed value, see more info:"},{"line_number":10,"context_line":"  https://github.com/openstack/glance/blob/master/etc/glance-api.conf#L696"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I913be3415c02adbaa3b1aafe120366a097ede09d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_cec8aa57","line":10,"updated":"2016-01-25 19:45:33.000000000","message":"Maybe master was updated since this was posted - the line I see is\n\n # Deprecated group/name - [DEFAULT]/sql_max_overflow\n\nI don\u0027t see known_stores anywhere","commit_id":"7ebcd151301f3f0340a207160d3ed7980ab4f074"}],"manifests/api.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d595b3a79c1234f01f451f7e3d04badf8835519f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"# [*known_stores*]"},{"line_number":189,"context_line":"#   (optional) List of which store classes and store class locations are"},{"line_number":190,"context_line":"#    currently known to glance at startup."},{"line_number":191,"context_line":"#    Example: [\u0027file\u0027,\u0027http\u0027]"},{"line_number":192,"context_line":"#    Defaults to false."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*image_cache_dir*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a68dd71_6ef17e94","line":191,"updated":"2016-01-25 19:45:33.000000000","message":"Maybe we could add a check to help users use the correct format? I could see this causing problems if someone tries to use the old values.","commit_id":"7ebcd151301f3f0340a207160d3ed7980ab4f074"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0349bf7792941d3f5d61555c3ee93a0b0ef98d85","unresolved":false,"context_lines":[{"line_number":189,"context_line":"#   (optional) List of which store classes and store class locations are"},{"line_number":190,"context_line":"#    currently known to glance at startup."},{"line_number":191,"context_line":"#    Example: [\u0027file\u0027,\u0027http\u0027]"},{"line_number":192,"context_line":"#    Defaults to false."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*image_cache_dir*]"},{"line_number":195,"context_line":"#   (optional) Base directory that the Image Cache uses."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_392d3e95","line":192,"updated":"2016-02-01 05:21:39.000000000","message":"Defaults to $::os_service_default","commit_id":"1d54cb1b984c805e3f56b588b0150a6aa59cedfe"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"71f9e047ecf8d05301950706b522a05393339b10","unresolved":false,"context_lines":[{"line_number":189,"context_line":"#   (optional) List of which store classes and store class locations are"},{"line_number":190,"context_line":"#    currently known to glance at startup."},{"line_number":191,"context_line":"#    Example: [\u0027file\u0027,\u0027http\u0027]"},{"line_number":192,"context_line":"#    Defaults to false."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*image_cache_dir*]"},{"line_number":195,"context_line":"#   (optional) Base directory that the Image Cache uses."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_5471d10d","line":192,"updated":"2016-02-01 12:24:02.000000000","message":"Well, if you change it to os_service_default, you\u0027ll have default_store \u003d file by default, and it would unlikely be backward compatible for people running the default value.","commit_id":"1d54cb1b984c805e3f56b588b0150a6aa59cedfe"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4b970721c8a0698480140ebf2ff7d5451bc6ce41","unresolved":false,"context_lines":[{"line_number":189,"context_line":"#   (optional) List of which store classes and store class locations are"},{"line_number":190,"context_line":"#    currently known to glance at startup."},{"line_number":191,"context_line":"#    Example: [\u0027file\u0027,\u0027http\u0027]"},{"line_number":192,"context_line":"#    Defaults to false."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*image_cache_dir*]"},{"line_number":195,"context_line":"#   (optional) Base directory that the Image Cache uses."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_7322d9a4","line":192,"in_reply_to":"7a5de9d1_5471d10d","updated":"2016-02-01 15:25:19.000000000","message":"Well it sounds like the default parameter value should be false and not $::os_service_default which it was updated to on line 271. Sounds like we should set it to false like it says in here in the docs","commit_id":"1d54cb1b984c805e3f56b588b0150a6aa59cedfe"}]}