)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"55da03404f814f0f891d9cfb6b4d1397648eda8a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"#"},{"line_number":176,"context_line":"# [*cert_file*]"},{"line_number":177,"context_line":"#   (optinal) Certificate file to use when starting API server securely"},{"line_number":178,"context_line":"#   Defaults to false, not set"},{"line_number":179,"context_line":"#"},{"line_number":180,"context_line":"# [*key_file*]"},{"line_number":181,"context_line":"#   (optional) Private key file to use when starting API server securely"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_46779a02","side":"PARENT","line":178,"range":{"start_line":178,"start_character":27,"end_line":178,"end_character":30},"updated":"2016-01-12 09:27:23.000000000","message":"unrelated changes.","commit_id":"429c256ebc4ba916ae42dae6454e591503515614"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"55da03404f814f0f891d9cfb6b4d1397648eda8a","unresolved":false,"context_lines":[{"line_number":391,"context_line":"      \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":392,"context_line":"    }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    if $memcached_servers {"},{"line_number":395,"context_line":"      glance_api_config { \u0027keystone_authtoken/memcached_servers\u0027: value  \u003d\u003e join($memcached_servers, \u0027,\u0027) }"},{"line_number":396,"context_line":"    } else {"},{"line_number":397,"context_line":"      glance_api_config { \u0027keystone_authtoken/memcached_servers\u0027: ensure \u003d\u003e absent }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_a6d8d6f0","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":25},"updated":"2016-01-12 09:27:23.000000000","message":"you forgot to add this to parameter list","commit_id":"1cda1aa4b8d434f2bd6c46d3278b223029039996"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"c3eb70d747bc047c1f4c2ee73661708b32471568","unresolved":false,"context_lines":[{"line_number":391,"context_line":"      \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":392,"context_line":"    }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    if $memcached_servers {"},{"line_number":395,"context_line":"      glance_api_config { \u0027keystone_authtoken/memcached_servers\u0027: value  \u003d\u003e join($memcached_servers, \u0027,\u0027) }"},{"line_number":396,"context_line":"    } else {"},{"line_number":397,"context_line":"      glance_api_config { \u0027keystone_authtoken/memcached_servers\u0027: ensure \u003d\u003e absent }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_7a63411b","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":25},"in_reply_to":"da6ed579_a6d8d6f0","updated":"2016-01-12 14:26:34.000000000","message":"sorry for this low-level mistake.","commit_id":"1cda1aa4b8d434f2bd6c46d3278b223029039996"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1009a7f8015fa994f663df4eb3b3e8d885004b5f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  $auth_region              \u003d $::os_service_default,"},{"line_number":255,"context_line":"  $auth_uri                 \u003d \u0027http://127.0.0.1:5000/\u0027,"},{"line_number":256,"context_line":"  $identity_uri             \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":257,"context_line":"  $memcached_servers        \u003d false,"},{"line_number":258,"context_line":"  $pipeline                 \u003d \u0027keystone\u0027,"},{"line_number":259,"context_line":"  $keystone_tenant          \u003d \u0027services\u0027,"},{"line_number":260,"context_line":"  $keystone_user            \u003d \u0027glance\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_d5b51231","line":257,"updated":"2016-01-13 17:50:05.000000000","message":"To follow a similar pattern that we use in keystone, this should be $::os_service_default","commit_id":"1451f0c28a1b25815ed35a246c7bcf0e1adf13d4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1009a7f8015fa994f663df4eb3b3e8d885004b5f","unresolved":false,"context_lines":[{"line_number":398,"context_line":"      \u0027DEFAULT/admin_password\u0027   : value \u003d\u003e $keystone_password, secret \u003d\u003e true;"},{"line_number":399,"context_line":"    }"},{"line_number":400,"context_line":"    if $memcached_servers {"},{"line_number":401,"context_line":"      glance_api_config { \u0027keystone_authtoken/memcached_servers\u0027: value  \u003d\u003e join($memcached_servers, \u0027,\u0027) }"},{"line_number":402,"context_line":"    } else {"},{"line_number":403,"context_line":"      glance_api_config { \u0027keystone_authtoken/memcached_servers\u0027: ensure \u003d\u003e absent }"},{"line_number":404,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_5545a214","line":401,"updated":"2016-01-13 17:50:05.000000000","message":"If you use $::os_service_default, this entire block can be replaced with:\n\nglance_api_config { \n  \u0027keystone_authtoken/memcached_servers\u0027: value \u003d\u003e join(any2array($memcached_servers), \u0027,\u0027)) \n}\n\n\nsee https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L768","commit_id":"1451f0c28a1b25815ed35a246c7bcf0e1adf13d4"}],"manifests/registry.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"55da03404f814f0f891d9cfb6b4d1397648eda8a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"#     Defaults to \u0027keystone\u0027."},{"line_number":94,"context_line":"#"},{"line_number":95,"context_line":"#  [*use_syslog*]"},{"line_number":96,"context_line":"#    (optional) Use syslog for logging."},{"line_number":97,"context_line":"#    Defaults to undef."},{"line_number":98,"context_line":"#"},{"line_number":99,"context_line":"#  [*use_stderr*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_e6ec8e91","side":"PARENT","line":96,"range":{"start_line":96,"start_character":20,"end_line":96,"end_character":26},"updated":"2016-01-12 09:27:23.000000000","message":"unrelated change. Upload please separate patch for this.","commit_id":"429c256ebc4ba916ae42dae6454e591503515614"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1009a7f8015fa994f663df4eb3b3e8d885004b5f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  $sync_db                 \u003d true,"},{"line_number":188,"context_line":"  $os_region_name          \u003d $::os_service_default,"},{"line_number":189,"context_line":"  $signing_dir             \u003d $::os_service_default,"},{"line_number":190,"context_line":"  $memcached_servers       \u003d false,"},{"line_number":191,"context_line":"  $token_cache_time        \u003d $::os_service_default,"},{"line_number":192,"context_line":") inherits glance {"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_d55192d9","line":190,"updated":"2016-01-13 17:50:05.000000000","message":"this should be $::os_service_default","commit_id":"1451f0c28a1b25815ed35a246c7bcf0e1adf13d4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1009a7f8015fa994f663df4eb3b3e8d885004b5f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027:          value \u003d\u003e $auth_uri;"},{"line_number":248,"context_line":"      \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":249,"context_line":"    }"},{"line_number":250,"context_line":"    if $memcached_servers {"},{"line_number":251,"context_line":"      glance_registry_config { \u0027keystone_authtoken/memcached_servers\u0027: value  \u003d\u003e join($memcached_servers, \u0027,\u0027) }"},{"line_number":252,"context_line":"    } else {"},{"line_number":253,"context_line":"      glance_registry_config { \u0027keystone_authtoken/memcached_servers\u0027: ensure \u003d\u003e absent }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_9509dadf","line":250,"updated":"2016-01-13 17:50:05.000000000","message":"and then this would be the same as mentioned for the other file","commit_id":"1451f0c28a1b25815ed35a246c7bcf0e1adf13d4"}]}