)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"6fec2251e4bb38902111e7bbc9053fe35132be74","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch:"},{"line_number":10,"context_line":"    * Delete a option vmware_datacenter_path"},{"line_number":11,"context_line":"    * Delete a option vmware_datastore_name"},{"line_number":12,"context_line":"    This \"options\" has been deleted from [glance_store] section in"},{"line_number":13,"context_line":"    Liberty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I193fdff9a762d8c5968da10d0c4de48909a2093b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_6e599034","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":22},"updated":"2016-01-15 08:45:15.000000000","message":"Please ref other commits\u0027 msg about how to describe deprecated params.","commit_id":"ae8dfac83088f690f963d2aa96b951b50d3735ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1d29dfc00f57b69a13b78cec87f71d4814907abd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * Delete a option vmware_datacenter_path"},{"line_number":11,"context_line":"    * Delete a option vmware_datastore_name"},{"line_number":12,"context_line":"    This \"options\" has been deleted from [glance_store] section in"},{"line_number":13,"context_line":"    Liberty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I193fdff9a762d8c5968da10d0c4de48909a2093b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_186ad5ee","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":11},"updated":"2016-01-14 11:32:49.000000000","message":"It is very helpful, when you also attaching commit, where some thing were deleted.","commit_id":"ae8dfac83088f690f963d2aa96b951b50d3735ba"},{"author":{"_account_id":17293,"name":"luyuan","email":"imluyuan@gmail.com","username":"luyuan"},"change_message_id":"7f0452e8bb10be58f8c6e8eae172a4a8b41123dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * Delete a option vmware_datacenter_path"},{"line_number":11,"context_line":"    * Delete a option vmware_datastore_name"},{"line_number":12,"context_line":"    This \"options\" has been deleted from [glance_store] section in"},{"line_number":13,"context_line":"    Liberty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I193fdff9a762d8c5968da10d0c4de48909a2093b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_d2706c42","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":11},"in_reply_to":"da6ed579_186ad5ee","updated":"2016-01-15 05:55:55.000000000","message":"What\u0027s mean?I need delete a word of liberty?","commit_id":"ae8dfac83088f690f963d2aa96b951b50d3735ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d707e6e64bd7a169b662ca4c82acf4ccb2f34930","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * Delete a option vmware_datacenter_path"},{"line_number":11,"context_line":"    * Delete a option vmware_datastore_name"},{"line_number":12,"context_line":"    This \"options\" has been deleted from [glance_store] section in"},{"line_number":13,"context_line":"    Liberty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I193fdff9a762d8c5968da10d0c4de48909a2093b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_b1c28451","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":11},"in_reply_to":"da6ed579_d2706c42","updated":"2016-01-15 11:35:11.000000000","message":"That\u0027s meant, that you can add link to commit where it was done.","commit_id":"ae8dfac83088f690f963d2aa96b951b50d3735ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e6daabed36bd5b82cec4c4fca1387314fa671f72","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     luyuan \u003cluyuan@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-16 23:32:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removed deprecated options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to description in doc[1] in Glance it\u0027s recommeded to remove"},{"line_number":10,"context_line":"vmware_datastore and vmware_datacenter option from configuration files."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6ed579_663f15d7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-01-18 11:28:12.000000000","message":"I don\u0027t see any removing, only deprecating. You should update your commit message or update your change according to your commit message.","commit_id":"a3619ccc82985507dab6a08fade79a779eb88e62"}],"manifests/backend/vsphere.pp":[{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"6fec2251e4bb38902111e7bbc9053fe35132be74","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  $vcenter_host,"},{"line_number":62,"context_line":"  $vcenter_user,"},{"line_number":63,"context_line":"  $vcenter_password,"},{"line_number":64,"context_line":"  $vcenter_datacenter,"},{"line_number":65,"context_line":"  $vcenter_datastore,"},{"line_number":66,"context_line":"  $vcenter_image_dir,"},{"line_number":67,"context_line":"  $vcenter_api_insecure \u003d \u0027False\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_6edf503a","side":"PARENT","line":64,"range":{"start_line":64,"start_character":3,"end_line":64,"end_character":21},"updated":"2016-01-15 08:45:15.000000000","message":"dito","commit_id":"e58c73f9c6e3ec53961690df90f3d207d73c1e48"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"6fec2251e4bb38902111e7bbc9053fe35132be74","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $vcenter_user,"},{"line_number":63,"context_line":"  $vcenter_password,"},{"line_number":64,"context_line":"  $vcenter_datacenter,"},{"line_number":65,"context_line":"  $vcenter_datastore,"},{"line_number":66,"context_line":"  $vcenter_image_dir,"},{"line_number":67,"context_line":"  $vcenter_api_insecure \u003d \u0027False\u0027,"},{"line_number":68,"context_line":"  $vcenter_task_poll_interval \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_0e24945b","side":"PARENT","line":65,"range":{"start_line":65,"start_character":3,"end_line":65,"end_character":20},"updated":"2016-01-15 08:45:15.000000000","message":"You shoud also mark this param as deprecated, now it\u0027s still required.","commit_id":"e58c73f9c6e3ec53961690df90f3d207d73c1e48"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d707e6e64bd7a169b662ca4c82acf4ccb2f34930","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $vcenter_user,"},{"line_number":63,"context_line":"  $vcenter_password,"},{"line_number":64,"context_line":"  $vcenter_datacenter,"},{"line_number":65,"context_line":"  $vcenter_datastore,"},{"line_number":66,"context_line":"  $vcenter_image_dir,"},{"line_number":67,"context_line":"  $vcenter_api_insecure \u003d \u0027False\u0027,"},{"line_number":68,"context_line":"  $vcenter_task_poll_interval \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_31845409","side":"PARENT","line":65,"range":{"start_line":65,"start_character":3,"end_line":65,"end_character":20},"in_reply_to":"da6ed579_0e24945b","updated":"2016-01-15 11:35:11.000000000","message":"Exactly, and raise warning.","commit_id":"e58c73f9c6e3ec53961690df90f3d207d73c1e48"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"88f21b7263429a7a65fcf5afe6164026f020539f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $vcenter_task_poll_interval \u003d \u00275\u0027,"},{"line_number":71,"context_line":"  $vcenter_api_retry_count \u003d \u002710\u0027,"},{"line_number":72,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":73,"context_line":"  $vcenter_datacenter,"},{"line_number":74,"context_line":"  $vcenter_datastore,"},{"line_number":75,"context_line":") {"},{"line_number":76,"context_line":"  if $vcenter_datacenter {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a68dd71_b7b8462b","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":22},"updated":"2016-01-25 11:16:32.000000000","message":"deprecated parameters should be set to undef. Hence these parameters should be added in conf if they are not undef.\n\nFor vmware_datacenter_path can be used only \u0027ha-datacenter\u0027, so also additional check is needed.\n\nAlso as i see in docs, there is another new parameter, that should be used instead. Can you add it?\n\nhttps://github.com/openstack/glance/blob/ca5cdb59e136a54862f8132bc5b3f9867ae44390/etc/glance-api.conf#L805-L819\n\nAnd do not forget to update tests.","commit_id":"e0fed63a9d639cbe20dfd53ce99626b4ca516237"}]}