)]}'
{"lib/puppet/provider/glance_image/openstack.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"224644c00a049d354be7289e7e8a65631f989381","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  # openstackclient now uses image v2 API by default."},{"line_number":15,"context_line":"  # in the meantime it\u0027s implemented in openstackclient, hardcode version"},{"line_number":16,"context_line":"  # see https://bugs.launchpad.net/python-openstackclient/+bug/1405562"},{"line_number":17,"context_line":"  ENV[\u0027OS_IMAGE_API_VERSION\u0027] \u003d \u00271\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  def initialize(value\u003d{})"},{"line_number":20,"context_line":"    super(value)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba0121b8_6ca69811","side":"PARENT","line":17,"updated":"2016-03-29 22:20:32.000000000","message":"unfortunately it looks like v2 doesn\u0027t support remote locations so we\u0027ll need to either stick with v1 or provide an alternative mechanism for this","commit_id":"035d1e6c718d155b889fe3cc9ca976ac508a3f5c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2c26e024853e4f725858edd80b9f7a4ed263f174","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  def create"},{"line_number":24,"context_line":"    if @resource[:source]"},{"line_number":25,"context_line":"      # copy_from cannot handle file://"},{"line_number":26,"context_line":"      if @resource[:source] \u003d~ /^\\// # local file"},{"line_number":27,"context_line":"        location \u003d \"--file\u003d#{@resource[:source]}\""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba0121b8_a680b347","line":24,"updated":"2016-03-30 11:16:25.000000000","message":"resource and @resource are same","commit_id":"1a8eadd47ccc2582ae38a32e288f5132aeb19651"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b99badfb4c1e7367e69d14684826cdba6ab9378a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  def create"},{"line_number":24,"context_line":"    if @resource[:source]"},{"line_number":25,"context_line":"      # copy_from cannot handle file://"},{"line_number":26,"context_line":"      if @resource[:source] \u003d~ /^\\// # local file"},{"line_number":27,"context_line":"        location \u003d \"--file\u003d#{@resource[:source]}\""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_ef9a626d","line":24,"updated":"2016-03-30 17:10:02.000000000","message":"@resource \u003d\u003d resource","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"008202f31af08c8cfc5ca87b06e13119e4226cb1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  def create"},{"line_number":24,"context_line":"    if @resource[:source]"},{"line_number":25,"context_line":"      # copy_from cannot handle file://"},{"line_number":26,"context_line":"      if @resource[:source] \u003d~ /^\\// # local file"},{"line_number":27,"context_line":"        location \u003d \"--file\u003d#{@resource[:source]}\""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_98e5d139","line":24,"in_reply_to":"ba0121b8_ef9a626d","updated":"2016-03-31 08:21:50.000000000","message":"just to make it right (refer to instance var)","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b99badfb4c1e7367e69d14684826cdba6ab9378a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    list \u003d request(\u0027image\u0027, \u0027list\u0027)"},{"line_number":97,"context_line":"    list.collect do |image|"},{"line_number":98,"context_line":"      attrs \u003d request(\u0027image\u0027, \u0027show\u0027, image[:id])"},{"line_number":99,"context_line":"      properties \u003d Hash[attrs[:properties].scan(/(\\S+)\u003d\u0027([^\u0027]*)\u0027/)] rescue nil"},{"line_number":100,"context_line":"      new("},{"line_number":101,"context_line":"        :ensure           \u003d\u003e :present,"},{"line_number":102,"context_line":"        :name             \u003d\u003e attrs[:name],"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_8f3f6686","line":99,"updated":"2016-03-30 17:10:02.000000000","message":"may be we can have here something like it done for nova: \n\nhttps://github.com/openstack/puppet-nova/blob/master/lib/puppet/provider/nova.rb#L132-L140","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"008202f31af08c8cfc5ca87b06e13119e4226cb1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    list \u003d request(\u0027image\u0027, \u0027list\u0027)"},{"line_number":97,"context_line":"    list.collect do |image|"},{"line_number":98,"context_line":"      attrs \u003d request(\u0027image\u0027, \u0027show\u0027, image[:id])"},{"line_number":99,"context_line":"      properties \u003d Hash[attrs[:properties].scan(/(\\S+)\u003d\u0027([^\u0027]*)\u0027/)] rescue nil"},{"line_number":100,"context_line":"      new("},{"line_number":101,"context_line":"        :ensure           \u003d\u003e :present,"},{"line_number":102,"context_line":"        :name             \u003d\u003e attrs[:name],"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_98c2f132","line":99,"in_reply_to":"ba0121b8_8f3f6686","updated":"2016-03-31 08:21:50.000000000","message":"I thought about smth similar ...\nI (want to) believe  this mapping will catch all the inputs properly.","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"},{"author":{"_account_id":12559,"name":"Valyavskiy Viacheslav","email":"vvalyavskiy@mirantis.com","username":"vvalyavskiy"},"change_message_id":"b1f5e2130a5c0269ea9f52381a25fd8d4c51cd82","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    end"},{"line_number":38,"context_line":"    opts \u003d [@resource[:name]]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    opts \u003c\u003c (@resource[:is_public] \u003d\u003d :true ? \u0027--public\u0027 : \u0027--private\u0027)"},{"line_number":41,"context_line":"    opts \u003c\u003c \"--container-format\u003d#{@resource[:container_format]}\""},{"line_number":42,"context_line":"    opts \u003c\u003c \"--disk-format\u003d#{@resource[:disk_format]}\""},{"line_number":43,"context_line":"    opts \u003c\u003c \"--min-disk\u003d#{@resource[:min_disk]}\" if @resource[:min_disk]"},{"line_number":44,"context_line":"    opts \u003c\u003c \"--min-ram\u003d#{@resource[:min_ram]}\" if @resource[:min_ram]"},{"line_number":45,"context_line":"    opts \u003c\u003c props_to_s(@resource[:properties]) if @resource[:properties]"},{"line_number":46,"context_line":"    opts \u003c\u003c location"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property_hash \u003d self.class.request(\u0027image\u0027, \u0027create\u0027, opts)"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a061dce_0e839b57","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":72},"updated":"2016-04-05 10:55:27.000000000","message":"Could you please move this part into separate method as you are doing the same actions on lines 125-134","commit_id":"d0957fb622a0f5f4f6e038aa22d87ee61a2f1ad2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"02c9de0462f06cc950dd95b48a022dcebccad5a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    end"},{"line_number":38,"context_line":"    opts \u003d [@resource[:name]]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    opts \u003c\u003c (@resource[:is_public] \u003d\u003d :true ? \u0027--public\u0027 : \u0027--private\u0027)"},{"line_number":41,"context_line":"    opts \u003c\u003c \"--container-format\u003d#{@resource[:container_format]}\""},{"line_number":42,"context_line":"    opts \u003c\u003c \"--disk-format\u003d#{@resource[:disk_format]}\""},{"line_number":43,"context_line":"    opts \u003c\u003c \"--min-disk\u003d#{@resource[:min_disk]}\" if @resource[:min_disk]"},{"line_number":44,"context_line":"    opts \u003c\u003c \"--min-ram\u003d#{@resource[:min_ram]}\" if @resource[:min_ram]"},{"line_number":45,"context_line":"    opts \u003c\u003c props_to_s(@resource[:properties]) if @resource[:properties]"},{"line_number":46,"context_line":"    opts \u003c\u003c location"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property_hash \u003d self.class.request(\u0027image\u0027, \u0027create\u0027, opts)"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a061dce_39e187ff","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":72},"in_reply_to":"9a061dce_0e839b57","updated":"2016-04-05 11:09:01.000000000","message":"That\u0027s not correct: we are using two different hashes in both methods.","commit_id":"d0957fb622a0f5f4f6e038aa22d87ee61a2f1ad2"},{"author":{"_account_id":12559,"name":"Valyavskiy Viacheslav","email":"vvalyavskiy@mirantis.com","username":"vvalyavskiy"},"change_message_id":"7295addd169f1297593db1b17fbd9ae7b5e8237e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    end"},{"line_number":38,"context_line":"    opts \u003d [@resource[:name]]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    opts \u003c\u003c (@resource[:is_public] \u003d\u003d :true ? \u0027--public\u0027 : \u0027--private\u0027)"},{"line_number":41,"context_line":"    opts \u003c\u003c \"--container-format\u003d#{@resource[:container_format]}\""},{"line_number":42,"context_line":"    opts \u003c\u003c \"--disk-format\u003d#{@resource[:disk_format]}\""},{"line_number":43,"context_line":"    opts \u003c\u003c \"--min-disk\u003d#{@resource[:min_disk]}\" if @resource[:min_disk]"},{"line_number":44,"context_line":"    opts \u003c\u003c \"--min-ram\u003d#{@resource[:min_ram]}\" if @resource[:min_ram]"},{"line_number":45,"context_line":"    opts \u003c\u003c props_to_s(@resource[:properties]) if @resource[:properties]"},{"line_number":46,"context_line":"    opts \u003c\u003c location"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property_hash \u003d self.class.request(\u0027image\u0027, \u0027create\u0027, opts)"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a061dce_f9e0afce","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":72},"in_reply_to":"9a061dce_39e187ff","updated":"2016-04-05 11:13:06.000000000","message":"yes, we are, but we can pass these hashes to the function as argument and receives array as result. Ok, it doesn\u0027t matter, patche\u0027s merging is in progress)","commit_id":"d0957fb622a0f5f4f6e038aa22d87ee61a2f1ad2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7d663164f30f95f50366f95a63b3f5e431949bad","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    end"},{"line_number":38,"context_line":"    opts \u003d [@resource[:name]]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    opts \u003c\u003c (@resource[:is_public] \u003d\u003d :true ? \u0027--public\u0027 : \u0027--private\u0027)"},{"line_number":41,"context_line":"    opts \u003c\u003c \"--container-format\u003d#{@resource[:container_format]}\""},{"line_number":42,"context_line":"    opts \u003c\u003c \"--disk-format\u003d#{@resource[:disk_format]}\""},{"line_number":43,"context_line":"    opts \u003c\u003c \"--min-disk\u003d#{@resource[:min_disk]}\" if @resource[:min_disk]"},{"line_number":44,"context_line":"    opts \u003c\u003c \"--min-ram\u003d#{@resource[:min_ram]}\" if @resource[:min_ram]"},{"line_number":45,"context_line":"    opts \u003c\u003c props_to_s(@resource[:properties]) if @resource[:properties]"},{"line_number":46,"context_line":"    opts \u003c\u003c location"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property_hash \u003d self.class.request(\u0027image\u0027, \u0027create\u0027, opts)"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a061dce_3a5a0b51","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":72},"in_reply_to":"9a061dce_f9e0afce","updated":"2016-04-05 14:27:36.000000000","message":"we need to rewrite this anyway for v2 support, so we\u0027ll tackle that during the rewrite.","commit_id":"d0957fb622a0f5f4f6e038aa22d87ee61a2f1ad2"}],"lib/puppet/type/glance_image.rb":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"30335dd91d32274e180ee3cc94ccebb0a6304099","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    munge do |value|"},{"line_number":92,"context_line":"      return value if value.is_a? Hash"},{"line_number":93,"context_line":"      Hash[value.scan(/(\\S+)\\s*\u003d\\s*\u0027([^\u0027]*)\u0027/)]"},{"line_number":94,"context_line":"    end"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    validate do |value|"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba0121b8_66c05be1","line":93,"range":{"start_line":93,"start_character":6,"end_line":93,"end_character":47},"updated":"2016-03-30 11:22:40.000000000","message":"needs to be tested to catch all variants.","commit_id":"1a8eadd47ccc2582ae38a32e288f5132aeb19651"}],"spec/acceptance/basic_glance_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2c26e024853e4f725858edd80b9f7a4ed263f174","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        container_format \u003d\u003e \u0027bare\u0027,"},{"line_number":47,"context_line":"        disk_format      \u003d\u003e \u0027qcow2\u0027,"},{"line_number":48,"context_line":"        is_public        \u003d\u003e \u0027yes\u0027,"},{"line_number":49,"context_line":"        source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-disk.img\u0027,"},{"line_number":50,"context_line":"      }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      glance_image { \u0027test_property_image\u0027:"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba0121b8_c627a762","line":49,"updated":"2016-03-30 11:16:25.000000000","message":"just add some properties to existing image resource","commit_id":"1a8eadd47ccc2582ae38a32e288f5132aeb19651"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b99badfb4c1e7367e69d14684826cdba6ab9378a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        disk_format      \u003d\u003e \u0027qcow2\u0027,"},{"line_number":56,"context_line":"        is_public        \u003d\u003e \u0027yes\u0027,"},{"line_number":57,"context_line":"        source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-disk.img\u0027,"},{"line_number":58,"context_line":"        properties       \u003d\u003e { \u0027icanhaz\u0027 \u003d\u003e \u0027cheezburger\u0027 },"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_4f070eca","line":58,"updated":"2016-03-30 17:10:02.000000000","message":"we can use property for first image resource","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"559bba842ff51bdcd851cc157f061218428870f5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        disk_format      \u003d\u003e \u0027qcow2\u0027,"},{"line_number":56,"context_line":"        is_public        \u003d\u003e \u0027yes\u0027,"},{"line_number":57,"context_line":"        source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-disk.img\u0027,"},{"line_number":58,"context_line":"        properties       \u003d\u003e { \u0027icanhaz\u0027 \u003d\u003e \u0027cheezburger\u0027 },"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_cfd31e03","line":58,"in_reply_to":"ba0121b8_4f070eca","updated":"2016-03-30 17:13:17.000000000","message":"Yea we could, i just thought it might be good to have multiple configurations.  Should probably change this one to private as well and do additional properties checking.","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4dffc11bb2f4339d828b865b7898f96f42ff898e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        disk_format      \u003d\u003e \u0027qcow2\u0027,"},{"line_number":56,"context_line":"        is_public        \u003d\u003e \u0027yes\u0027,"},{"line_number":57,"context_line":"        source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-disk.img\u0027,"},{"line_number":58,"context_line":"        properties       \u003d\u003e { \u0027icanhaz\u0027 \u003d\u003e \u0027cheezburger\u0027 },"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a061dce_2b795afd","line":58,"in_reply_to":"ba0121b8_cfd31e03","updated":"2016-04-04 15:48:38.000000000","message":"Agree.","commit_id":"9fdf04577dafe34c9e32724791fd3da78d439ed2"}]}
