)]}'
{"manifests/notify/rabbitmq.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54b2d22e6f774cdaa1d2eea59676660aa7666f0c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  if !$rabbit_use_ssl or is_service_default(rabbit_use_ssl) {"},{"line_number":112,"context_line":"    if ($kombu_ssl_keyfile or $kombu_ssl_certfile or $kombu_ssl_ca_certs) {"},{"line_number":113,"context_line":"      notice(\u0027Configuration of certificates with $rabbit_use_ssl \u003d\u003d false is a useless config\u0027)"},{"line_number":114,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_b02c6a03","line":111,"range":{"start_line":111,"start_character":44,"end_line":111,"end_character":58},"updated":"2016-04-05 19:57:34.000000000","message":"\u0027$\u0027 is missed near rabbit_use_ssl","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"3516e50a58389953714fa1f43510c1b3aef20f63","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  if !$rabbit_use_ssl or is_service_default(rabbit_use_ssl) {"},{"line_number":112,"context_line":"    if ($kombu_ssl_keyfile or $kombu_ssl_certfile or $kombu_ssl_ca_certs) {"},{"line_number":113,"context_line":"      notice(\u0027Configuration of certificates with $rabbit_use_ssl \u003d\u003d false is a useless config\u0027)"},{"line_number":114,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_1b7f0416","line":111,"range":{"start_line":111,"start_character":44,"end_line":111,"end_character":58},"in_reply_to":"9a061dce_b02c6a03","updated":"2016-04-06 15:57:55.000000000","message":"Done","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54b2d22e6f774cdaa1d2eea59676660aa7666f0c","unresolved":false,"context_lines":[{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  if !$rabbit_use_ssl or is_service_default(rabbit_use_ssl) {"},{"line_number":112,"context_line":"    if ($kombu_ssl_keyfile or $kombu_ssl_certfile or $kombu_ssl_ca_certs) {"},{"line_number":113,"context_line":"      notice(\u0027Configuration of certificates with $rabbit_use_ssl \u003d\u003d false is a useless config\u0027)"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_f09a6262","line":112,"updated":"2016-04-05 19:57:34.000000000","message":"if these ssl params are service_default we will see this notice. I think we need to do \u0027!is_service_default\u0027 check for each of them.\n\nfrom my POV the notice is useless.","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ea3900531408df98141e9426347b35f8b4a6d4de","unresolved":false,"context_lines":[{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  if !$rabbit_use_ssl or is_service_default(rabbit_use_ssl) {"},{"line_number":112,"context_line":"    if ($kombu_ssl_keyfile or $kombu_ssl_certfile or $kombu_ssl_ca_certs) {"},{"line_number":113,"context_line":"      notice(\u0027Configuration of certificates with $rabbit_use_ssl \u003d\u003d false is a useless config\u0027)"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_42d41646","line":112,"in_reply_to":"9a061dce_f09a6262","updated":"2016-04-06 06:06:00.000000000","message":"+1 to uselessness of that notice, i just copied it, it was here before","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"3516e50a58389953714fa1f43510c1b3aef20f63","unresolved":false,"context_lines":[{"line_number":109,"context_line":") {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  if !$rabbit_use_ssl or is_service_default(rabbit_use_ssl) {"},{"line_number":112,"context_line":"    if ($kombu_ssl_keyfile or $kombu_ssl_certfile or $kombu_ssl_ca_certs) {"},{"line_number":113,"context_line":"      notice(\u0027Configuration of certificates with $rabbit_use_ssl \u003d\u003d false is a useless config\u0027)"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_5b75fc2f","line":112,"in_reply_to":"9a061dce_f09a6262","updated":"2016-04-06 15:57:55.000000000","message":"Done","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54b2d22e6f774cdaa1d2eea59676660aa7666f0c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_host\u0027:      value \u003d\u003e $rabbit_host;"},{"line_number":142,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_port\u0027:      value \u003d\u003e $rabbit_port;"},{"line_number":143,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_hosts\u0027:     ensure \u003d\u003e absent;"},{"line_number":144,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_3004da48","line":144,"updated":"2016-04-05 19:57:34.000000000","message":"please add \u0027;\u0027","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"3516e50a58389953714fa1f43510c1b3aef20f63","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_host\u0027:      value \u003d\u003e $rabbit_host;"},{"line_number":142,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_port\u0027:      value \u003d\u003e $rabbit_port;"},{"line_number":143,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_hosts\u0027:     ensure \u003d\u003e absent;"},{"line_number":144,"context_line":"      \u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027: value \u003d\u003e $rabbit_ha_queues"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a061dce_3b72c849","line":144,"in_reply_to":"9a061dce_3004da48","updated":"2016-04-06 15:57:55.000000000","message":"Done","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"}],"spec/classes/glance_registry_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54b2d22e6f774cdaa1d2eea59676660aa7666f0c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        it { is_expected.to contain_glance_registry_config(\u0027DEFAULT/key_file\u0027).with_value(\u0027/tmp/key_file\u0027) }"},{"line_number":203,"context_line":"      end"},{"line_number":204,"context_line":"    end"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"  end"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  shared_examples_for \u0027glance::registry Debian\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a061dce_105b9655","line":205,"updated":"2016-04-05 19:57:34.000000000","message":"useless","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"3516e50a58389953714fa1f43510c1b3aef20f63","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        it { is_expected.to contain_glance_registry_config(\u0027DEFAULT/key_file\u0027).with_value(\u0027/tmp/key_file\u0027) }"},{"line_number":203,"context_line":"      end"},{"line_number":204,"context_line":"    end"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"  end"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  shared_examples_for \u0027glance::registry Debian\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a061dce_5b485ccc","line":205,"in_reply_to":"9a061dce_105b9655","updated":"2016-04-06 15:57:55.000000000","message":"Done","commit_id":"8c2a96437d9365828a2400951ff953937c021f0b"}]}