)]}'
{"manifests/api.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"99b3843728e922c9a34c8dc911fa73596cec37e7","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $identity_uri              \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":294,"context_line":"  $memcached_servers         \u003d $::os_service_default,"},{"line_number":295,"context_line":"  $pipeline                  \u003d \u0027keystone\u0027,"},{"line_number":296,"context_line":"  $keystone_auth_type        \u003d \u0027password\u0027,"},{"line_number":297,"context_line":"  $keystone_tenant           \u003d \u0027services\u0027,"},{"line_number":298,"context_line":"  $keystone_user             \u003d \u0027glance\u0027,"},{"line_number":299,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_67e9d21a","line":296,"range":{"start_line":296,"start_character":32,"end_line":296,"end_character":40},"updated":"2016-05-06 15:36:33.000000000","message":"If this is the only available method than it doesn\u0027t make sense to make in configurable - you can just leave a parameter for backward compatibility","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":20517,"name":"Dmitry Burmistrov","email":"dmburmistrov@mirantis.com","username":"dmburmistrov"},"change_message_id":"f7eff813eca7a2a5c1250bddb0f86ccf04c6e4c9","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $identity_uri              \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":294,"context_line":"  $memcached_servers         \u003d $::os_service_default,"},{"line_number":295,"context_line":"  $pipeline                  \u003d \u0027keystone\u0027,"},{"line_number":296,"context_line":"  $keystone_auth_type        \u003d \u0027password\u0027,"},{"line_number":297,"context_line":"  $keystone_tenant           \u003d \u0027services\u0027,"},{"line_number":298,"context_line":"  $keystone_user             \u003d \u0027glance\u0027,"},{"line_number":299,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_96a06992","line":296,"range":{"start_line":296,"start_character":32,"end_line":296,"end_character":40},"in_reply_to":"dab17558_36e9bd1b","updated":"2016-05-06 16:19:16.000000000","message":"As I know keystone middleware have some \"magic\" heuristics to \"guess\" the plugin. If it fails it should pick \"token\" plugin (type), I guess. (https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L980)\n\nI\u0027ve never seen token auth_type being used in puppets, everyone use \"password-like plugins\" (I can be wrong).\n\nAs Sergey mentioned, I can implement \"password\" plugin support. And I\u0027d propose to use it as the default one.\n\nWhat do you think?","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ec266f04131783c72f5ee4f67e3980ed7cabe933","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $identity_uri              \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":294,"context_line":"  $memcached_servers         \u003d $::os_service_default,"},{"line_number":295,"context_line":"  $pipeline                  \u003d \u0027keystone\u0027,"},{"line_number":296,"context_line":"  $keystone_auth_type        \u003d \u0027password\u0027,"},{"line_number":297,"context_line":"  $keystone_tenant           \u003d \u0027services\u0027,"},{"line_number":298,"context_line":"  $keystone_user             \u003d \u0027glance\u0027,"},{"line_number":299,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_36e9bd1b","line":296,"range":{"start_line":296,"start_character":32,"end_line":296,"end_character":40},"in_reply_to":"dab17558_62eee08c","updated":"2016-05-06 16:11:43.000000000","message":"Should this be $::os_service_default by default? Or does this really need to be password","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"68068586a7cfc1514924879b356a77725d765cf4","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $identity_uri              \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":294,"context_line":"  $memcached_servers         \u003d $::os_service_default,"},{"line_number":295,"context_line":"  $pipeline                  \u003d \u0027keystone\u0027,"},{"line_number":296,"context_line":"  $keystone_auth_type        \u003d \u0027password\u0027,"},{"line_number":297,"context_line":"  $keystone_tenant           \u003d \u0027services\u0027,"},{"line_number":298,"context_line":"  $keystone_user             \u003d \u0027glance\u0027,"},{"line_number":299,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_62eee08c","line":296,"range":{"start_line":296,"start_character":32,"end_line":296,"end_character":40},"in_reply_to":"dab17558_67e9d21a","updated":"2016-05-06 16:06:06.000000000","message":"Got your idea, it\u0027s an auth plugin in fact","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"f8759c3ed8e19ab23300bd569aab151e1dd5e602","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $identity_uri              \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":294,"context_line":"  $memcached_servers         \u003d $::os_service_default,"},{"line_number":295,"context_line":"  $pipeline                  \u003d \u0027keystone\u0027,"},{"line_number":296,"context_line":"  $keystone_auth_type        \u003d \u0027password\u0027,"},{"line_number":297,"context_line":"  $keystone_tenant           \u003d \u0027services\u0027,"},{"line_number":298,"context_line":"  $keystone_user             \u003d \u0027glance\u0027,"},{"line_number":299,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_d655d11d","line":296,"range":{"start_line":296,"start_character":32,"end_line":296,"end_character":40},"in_reply_to":"dab17558_96a06992","updated":"2016-05-06 16:27:45.000000000","message":"Leaving $::os_service_default here will break authorization when only auth plugin-related options are set, so I think it\u0027a safer to keep password. I agree with this proposal, password-related opts are enough for most cases (v2/v3 password-based auth)","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"320bb09240ffbe98b6c8770b84e8157ca53b5fd9","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $identity_uri              \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":294,"context_line":"  $memcached_servers         \u003d $::os_service_default,"},{"line_number":295,"context_line":"  $pipeline                  \u003d \u0027keystone\u0027,"},{"line_number":296,"context_line":"  $keystone_auth_type        \u003d \u0027password\u0027,"},{"line_number":297,"context_line":"  $keystone_tenant           \u003d \u0027services\u0027,"},{"line_number":298,"context_line":"  $keystone_user             \u003d \u0027glance\u0027,"},{"line_number":299,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_e821d7b5","line":296,"range":{"start_line":296,"start_character":32,"end_line":296,"end_character":40},"in_reply_to":"dab17558_d655d11d","updated":"2016-05-09 14:19:29.000000000","message":"Ok","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"68068586a7cfc1514924879b356a77725d765cf4","unresolved":false,"context_lines":[{"line_number":469,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027:          value \u003d\u003e $auth_uri;"},{"line_number":470,"context_line":"      \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":471,"context_line":"      \u0027keystone_authtoken/memcached_servers\u0027: value \u003d\u003e join(any2array($memcached_servers), \u0027,\u0027);"},{"line_number":472,"context_line":"      \u0027keystone_authtoken/auth_type\u0027:         value \u003d\u003e $keystone_auth_type;"},{"line_number":473,"context_line":"      \u0027keystone_authtoken/auth_url\u0027:          value \u003d\u003e $identity_uri;"},{"line_number":474,"context_line":"      \u0027keystone_authtoken/username\u0027:          value \u003d\u003e $keystone_user;"},{"line_number":475,"context_line":"      \u0027keystone_authtoken/password\u0027:          value \u003d\u003e $keystone_password, secret \u003d\u003e true;"},{"line_number":476,"context_line":"      \u0027keystone_authtoken/project_name\u0027:      value \u003d\u003e $keystone_tenant;"},{"line_number":477,"context_line":"    }"},{"line_number":478,"context_line":"    glance_cache_config {"},{"line_number":479,"context_line":"      \u0027DEFAULT/auth_url\u0027         : value \u003d\u003e $auth_uri;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_2294d8e0","line":476,"range":{"start_line":472,"start_character":0,"end_line":476,"end_character":72},"updated":"2016-05-06 16:06:06.000000000","message":"I\u0027d prefer to fully implement plugin-based auth system instead of just passing values to actual parameters","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"50e3b55aba979b0c6d348b64658ff3cc3178d83e","unresolved":false,"context_lines":[{"line_number":469,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027:          value \u003d\u003e $auth_uri;"},{"line_number":470,"context_line":"      \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":471,"context_line":"      \u0027keystone_authtoken/memcached_servers\u0027: value \u003d\u003e join(any2array($memcached_servers), \u0027,\u0027);"},{"line_number":472,"context_line":"      \u0027keystone_authtoken/auth_type\u0027:         value \u003d\u003e $keystone_auth_type;"},{"line_number":473,"context_line":"      \u0027keystone_authtoken/auth_url\u0027:          value \u003d\u003e $identity_uri;"},{"line_number":474,"context_line":"      \u0027keystone_authtoken/username\u0027:          value \u003d\u003e $keystone_user;"},{"line_number":475,"context_line":"      \u0027keystone_authtoken/password\u0027:          value \u003d\u003e $keystone_password, secret \u003d\u003e true;"},{"line_number":476,"context_line":"      \u0027keystone_authtoken/project_name\u0027:      value \u003d\u003e $keystone_tenant;"},{"line_number":477,"context_line":"    }"},{"line_number":478,"context_line":"    glance_cache_config {"},{"line_number":479,"context_line":"      \u0027DEFAULT/auth_url\u0027         : value \u003d\u003e $auth_uri;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_89145ba0","line":476,"range":{"start_line":472,"start_character":0,"end_line":476,"end_character":72},"in_reply_to":"dab17558_2294d8e0","updated":"2016-05-10 11:49:24.000000000","message":"May be we can fill config like it done for neutron: https://github.com/openstack/puppet-neutron/blob/master/manifests/server.pp#L505-L565\n\nWhy we need to mix all parameters in one setup?","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"50e3b55aba979b0c6d348b64658ff3cc3178d83e","unresolved":false,"context_lines":[{"line_number":479,"context_line":"      \u0027DEFAULT/auth_url\u0027         : value \u003d\u003e $auth_uri;"},{"line_number":480,"context_line":"      \u0027DEFAULT/admin_tenant_name\u0027: value \u003d\u003e $keystone_tenant;"},{"line_number":481,"context_line":"      \u0027DEFAULT/admin_user\u0027       : value \u003d\u003e $keystone_user;"},{"line_number":482,"context_line":"      \u0027DEFAULT/admin_password\u0027   : value \u003d\u003e $keystone_password, secret \u003d\u003e true;"},{"line_number":483,"context_line":"    }"},{"line_number":484,"context_line":"  }"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_698017c1","line":482,"updated":"2016-05-10 11:49:24.000000000","message":"do we need same (new) settings for cache or glare?","commit_id":"cf9f7670be851d813e0b523fbabf6861d75823a6"}]}