)]}'
{"lib/puppet/type/glance_image.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d93abebc929bcb43be6fa28f3bcebdc61fcdc2a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_eb0ef88a","line":38,"updated":"2016-05-25 10:23:21.000000000","message":"this will not work, when this provider will be switched to v2 glance api.\n\nprobably you need also put here TODO, that this also should be reworked for v2.","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"3f27bdcffa10c043b2e3c4428e51bb736392de14","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_ede28900","line":38,"in_reply_to":"bab6814e_467739d4","updated":"2016-05-25 11:41:39.000000000","message":"No, in v2 \u0027id\u0027 is read-only property and it cannot be set by user. Proof: https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L340-L342","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8de3f00bbfe5d3be2444f31cd5ac217a2b9d7f63","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_cb0e8a31","line":38,"in_reply_to":"bab6814e_de3be9e9","updated":"2016-05-25 12:48:22.000000000","message":"Yeah, user can specify id, but only during image creation. Changing this is not allowed.","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f7b0b692a14337cbf6f4f5d6d176bbfd43965ab5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_467739d4","line":38,"in_reply_to":"bab6814e_eb0ef88a","updated":"2016-05-25 10:45:46.000000000","message":"I may be missing something but I\u0027m not sure why it should fail with api v2. \n\nGlance API v2 keeps the option to set the id when creating an image and openstackclient allows it so it should work fine. I\u0027ve tested it and seems to be working fine.","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"bdd861a06a52b74710be831fab35ecc2b33ca8c5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_9804d97e","line":38,"in_reply_to":"bab6814e_ede28900","updated":"2016-05-25 12:02:32.000000000","message":"According to APIv2 documentation, http://developer.openstack.org/api-ref-image-v2.html, in image creation operation, id is an optional parameter. If you omit this value, the API generates a UUID for the image.\n\n_readonly_properties is only used in update operations what means that can not be changed after creation. That\u0027s covered in puppet-glance (it raises an error alerting it can not be changed after creation).\n\nI\u0027ve tested and it works fine with APIv2.","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"e82e18b8d53749bf3f2bb8376510266519028ed2","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_fe906d50","line":38,"in_reply_to":"bab6814e_ede28900","updated":"2016-05-25 12:28:20.000000000","message":"_readonly_properties is only used in function validate_change(), https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L486-L490, which in turn is used only in function update() -\u003e https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L575\n\nSo I think Alfredo is right, the id can be set on creation but not modified after that.","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b3e5c5d4b9d327f88ee88faea69f070bc4eeec91","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newproperty(:id) do"},{"line_number":37,"context_line":"    desc \u0027The unique id of the image\u0027"},{"line_number":38,"context_line":"    newvalues(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/)"},{"line_number":39,"context_line":"  end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  newparam(:location) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_de3be9e9","line":38,"in_reply_to":"bab6814e_fe906d50","updated":"2016-05-25 12:36:47.000000000","message":"Hm, looks like you\u0027re right:\n\nroot@node-1:~# glance image-list\n+--------------------------------------+--------+\n| ID                                   | Name   |\n+--------------------------------------+--------+\n| 0483d51f-762d-4001-99d7-db34f3a92a32 | TestVM |\n+--------------------------------------+--------+\n\nroot@node-1:~# glance --os-image-api-version 2 image-create --name test --id 0483d51f-762d-4001-99d7-db34f3a92a45 --file /usr/share/cirros-testvm/cirros-x86_64-disk.img --disk-format qcow2 --container-format bare                     \n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | 23e30da39536e725984126ea4ea6f247     |\n| container_format | bare                                 |\n| created_at       | 2016-05-25T12:32:37Z                 |\n| disk_format      | qcow2                                |\n| id               | 0483d51f-762d-4001-99d7-db34f3a92a45 |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | test                                 |\n| owner            | 289a0122d27947fabeba70165604cc46     |\n| protected        | False                                |\n| size             | 22534144                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2016-05-25T12:32:39Z                 |\n| virtual_size     | None                                 |\n| visibility       | private                              |\n+------------------+--------------------------------------+\n\nroot@node-1:~# glance image-list\n+--------------------------------------+--------+\n| ID                                   | Name   |\n+--------------------------------------+--------+\n| 0483d51f-762d-4001-99d7-db34f3a92a45 | test   |\n| 0483d51f-762d-4001-99d7-db34f3a92a32 | TestVM |\n+--------------------------------------+--------+","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"}],"releasenotes/notes/glance-image-id-d1a32b5ec443611e.yaml":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d93abebc929bcb43be6fa28f3bcebdc61fcdc2a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the ability to create an image with a id"},{"line_number":4,"context_line":"    specified by the user. The provider now accepts"},{"line_number":5,"context_line":"    id parameter to create the image."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_2b4f60bf","line":4,"updated":"2016-05-25 10:23:21.000000000","message":"for Glance v1 API","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b3e5c5d4b9d327f88ee88faea69f070bc4eeec91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add the ability to create an image with a id"},{"line_number":4,"context_line":"    specified by the user. The provider now accepts"},{"line_number":5,"context_line":"    id parameter to create the image."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_b971dfaa","line":4,"in_reply_to":"bab6814e_2b4f60bf","updated":"2016-05-25 12:36:47.000000000","message":"current description is fine","commit_id":"3079b7caaebedbbe64e19c934bd54a9d29e6d0b8"}]}