)]}'
{"manifests/backend/vsphere.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0b957bbb911f0df5d6e8185a1f4cc4cc912d2508","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*vcenter_insecure*]"},{"line_number":25,"context_line":"#   (Boolean) If true, the ESX/vCenter server certificate is not verified."},{"line_number":26,"context_line":"#   If false, then the default CA truststore is used for verification."},{"line_number":27,"context_line":"#   This option is ignored if “vmware_ca_file” is set."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_a62ee53f","line":24,"updated":"2016-05-25 10:35:27.000000000","message":"it\u0027s not a correct deprecation. You should leave an ability to use old parameter and leave warning that it\u0027ll be removed in next release. And add a new parameter which should be used if old one is not set.","commit_id":"e483b9312c43277acedb13ff08e5d7aba85504a9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"290ab695cb5a700f64979af49e140416126ec9f7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*vcenter_insecure*]"},{"line_number":25,"context_line":"#   (Boolean) If true, the ESX/vCenter server certificate is not verified."},{"line_number":26,"context_line":"#   If false, then the default CA truststore is used for verification."},{"line_number":27,"context_line":"#   This option is ignored if “vmware_ca_file” is set."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_c6ede98f","line":24,"in_reply_to":"bab6814e_a62ee53f","updated":"2016-05-25 10:43:00.000000000","message":"+1","commit_id":"e483b9312c43277acedb13ff08e5d7aba85504a9"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"7abcbd07060b4416141720fd89bab7b97f4db024","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*vcenter_insecure*]"},{"line_number":25,"context_line":"#   (Boolean) If true, the ESX/vCenter server certificate is not verified."},{"line_number":26,"context_line":"#   If false, then the default CA truststore is used for verification."},{"line_number":27,"context_line":"#   This option is ignored if “vmware_ca_file” is set."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_0426cacd","line":24,"in_reply_to":"bab6814e_a62ee53f","updated":"2016-05-25 11:00:04.000000000","message":"Done","commit_id":"e483b9312c43277acedb13ff08e5d7aba85504a9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"290ab695cb5a700f64979af49e140416126ec9f7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \u0027glance_store/vmware_store_image_dir\u0027: value    \u003d\u003e $vcenter_image_dir;"},{"line_number":98,"context_line":"    \u0027glance_store/vmware_task_poll_interval\u0027: value \u003d\u003e $vcenter_task_poll_interval;"},{"line_number":99,"context_line":"    \u0027glance_store/vmware_api_retry_count\u0027: value    \u003d\u003e $vcenter_api_retry_count;"},{"line_number":100,"context_line":"    \u0027glance_store/vmware_datastores\u0027: value         \u003d\u003e \"$vcenter_datacenter:$vcenter_datastore\";"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  if $glare_enabled {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_06e7f1e4","line":100,"updated":"2016-05-25 10:43:00.000000000","message":"this param can be multi valued, may be we need also deprecate old parameters (name, path) and add new $vmware_datastores?","commit_id":"e483b9312c43277acedb13ff08e5d7aba85504a9"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"3dcc5294e0ff542298b7ea56555f4cfbe88663b4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \u0027glance_store/vmware_store_image_dir\u0027: value    \u003d\u003e $vcenter_image_dir;"},{"line_number":98,"context_line":"    \u0027glance_store/vmware_task_poll_interval\u0027: value \u003d\u003e $vcenter_task_poll_interval;"},{"line_number":99,"context_line":"    \u0027glance_store/vmware_api_retry_count\u0027: value    \u003d\u003e $vcenter_api_retry_count;"},{"line_number":100,"context_line":"    \u0027glance_store/vmware_datastores\u0027: value         \u003d\u003e \"$vcenter_datacenter:$vcenter_datastore\";"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  if $glare_enabled {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_f646ca4d","line":100,"in_reply_to":"bab6814e_06e7f1e4","updated":"2016-05-25 14:35:31.000000000","message":"Done","commit_id":"e483b9312c43277acedb13ff08e5d7aba85504a9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e9761c1b98617f73e0669303279031cb7a2b8d47","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*vcenter_api_insecure*]"},{"line_number":25,"context_line":"#   (BoolOpt) DEPRECATED. Allow to perform insecure SSL requests to ESX/VC. "},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*vcenter_insecure*]"},{"line_number":28,"context_line":"#   (Boolean) If true, the ESX/vCenter server certificate is not verified."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_562cf649","line":25,"updated":"2016-05-25 14:38:18.000000000","message":"usually we move deperacted parameter after regular params adding # DEPRECATED.\nSee https://github.com/openstack/puppet-cinder/blob/master/manifests/init.pp#L291-L296","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*vcenter_api_insecure*]"},{"line_number":25,"context_line":"#   (BoolOpt) DEPRECATED. Allow to perform insecure SSL requests to ESX/VC. "},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*vcenter_insecure*]"},{"line_number":28,"context_line":"#   (Boolean) If true, the ESX/vCenter server certificate is not verified."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_dc5e4744","line":25,"in_reply_to":"bab6814e_562cf649","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   (required) Password for authenticating with vCenter/ESXi server."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*vcenter_datacenter*]"},{"line_number":66,"context_line":"#   (StrOpt) DEPRECATED. Inventory path to a datacenter."},{"line_number":67,"context_line":"#   If the vmware_server_host specified is an ESX/ESXi,"},{"line_number":68,"context_line":"#   the vcenter_datacenter is optional. If specified,"},{"line_number":69,"context_line":"#   it should be \"ha-datacenter\". This option is deprecated"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_9683fecb","line":66,"range":{"start_line":66,"start_character":5,"end_line":66,"end_character":11},"updated":"2016-05-25 14:42:36.000000000","message":"just optional","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   (required) Password for authenticating with vCenter/ESXi server."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*vcenter_datacenter*]"},{"line_number":66,"context_line":"#   (StrOpt) DEPRECATED. Inventory path to a datacenter."},{"line_number":67,"context_line":"#   If the vmware_server_host specified is an ESX/ESXi,"},{"line_number":68,"context_line":"#   the vcenter_datacenter is optional. If specified,"},{"line_number":69,"context_line":"#   it should be \"ha-datacenter\". This option is deprecated"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_dc25a7c2","line":66,"range":{"start_line":66,"start_character":5,"end_line":66,"end_character":11},"in_reply_to":"bab6814e_9683fecb","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#   in favor of vcenter_datastores and will be removed."},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*vcenter_datastore*]"},{"line_number":73,"context_line":"#   (StrOpt) DEPRECATED. Datastore associated with the datacenter."},{"line_number":74,"context_line":"#   This option is deprecated in favor of vcenter_datastores"},{"line_number":75,"context_line":"#   and will be removed."},{"line_number":76,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_1678aef1","line":73,"range":{"start_line":73,"start_character":5,"end_line":73,"end_character":11},"updated":"2016-05-25 14:42:36.000000000","message":"same","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#   in favor of vcenter_datastores and will be removed."},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*vcenter_datastore*]"},{"line_number":73,"context_line":"#   (StrOpt) DEPRECATED. Datastore associated with the datacenter."},{"line_number":74,"context_line":"#   This option is deprecated in favor of vcenter_datastores"},{"line_number":75,"context_line":"#   and will be removed."},{"line_number":76,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_1c30cf00","line":73,"range":{"start_line":73,"start_character":5,"end_line":73,"end_character":11},"in_reply_to":"bab6814e_1678aef1","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $vcenter_host,"},{"line_number":101,"context_line":"  $vcenter_user,"},{"line_number":102,"context_line":"  $vcenter_password,"},{"line_number":103,"context_line":"  $vcenter_datacenter,"},{"line_number":104,"context_line":"  $vcenter_datastore,"},{"line_number":105,"context_line":"  $vcenter_image_dir,"},{"line_number":106,"context_line":"  $vcenter_ca_file            \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $vcenter_datastores         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_1621cefb","line":104,"range":{"start_line":103,"start_character":1,"end_line":104,"end_character":21},"updated":"2016-05-25 14:42:36.000000000","message":"should be undef now by default","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $vcenter_host,"},{"line_number":101,"context_line":"  $vcenter_user,"},{"line_number":102,"context_line":"  $vcenter_password,"},{"line_number":103,"context_line":"  $vcenter_datacenter,"},{"line_number":104,"context_line":"  $vcenter_datastore,"},{"line_number":105,"context_line":"  $vcenter_image_dir,"},{"line_number":106,"context_line":"  $vcenter_ca_file            \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $vcenter_datastores         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_5c189784","line":104,"range":{"start_line":103,"start_character":1,"end_line":104,"end_character":21},"in_reply_to":"bab6814e_1621cefb","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e9761c1b98617f73e0669303279031cb7a2b8d47","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  $vcenter_task_poll_interval \u003d $::os_service_default,"},{"line_number":111,"context_line":"  $vcenter_api_retry_count    \u003d $::os_service_default,"},{"line_number":112,"context_line":"  $multi_store                \u003d false,"},{"line_number":113,"context_line":"  $glare_enabled              \u003d false,"},{"line_number":114,"context_line":") {"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  if $vcenter_datacenter {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_362fb23f","line":113,"updated":"2016-05-25 14:38:18.000000000","message":"same here, please add # DEPRECATED section","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  $vcenter_task_poll_interval \u003d $::os_service_default,"},{"line_number":111,"context_line":"  $vcenter_api_retry_count    \u003d $::os_service_default,"},{"line_number":112,"context_line":"  $multi_store                \u003d false,"},{"line_number":113,"context_line":"  $glare_enabled              \u003d false,"},{"line_number":114,"context_line":") {"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  if $vcenter_datacenter {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_bf0ed52f","line":113,"in_reply_to":"bab6814e_362fb23f","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":127,"context_line":"    $vmware_datastores \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":128,"context_line":"  }"},{"line_number":129,"context_line":"  else {"},{"line_number":130,"context_line":"    $vmware_datastores \u003d $vcenter_datastores"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_56607635","line":127,"updated":"2016-05-25 14:42:36.000000000","message":"use suffix _real here","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":127,"context_line":"    $vmware_datastores \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":128,"context_line":"  }"},{"line_number":129,"context_line":"  else {"},{"line_number":130,"context_line":"    $vmware_datastores \u003d $vcenter_datastores"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_1f1e0163","line":127,"in_reply_to":"bab6814e_56607635","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    $vmware_datastores \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":128,"context_line":"  }"},{"line_number":129,"context_line":"  else {"},{"line_number":130,"context_line":"    $vmware_datastores \u003d $vcenter_datastores"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  glance_api_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_d6dbc6eb","line":130,"updated":"2016-05-25 14:42:36.000000000","message":"see above, we can\u0027t reassign vars in puppet","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    $vmware_datastores \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":128,"context_line":"  }"},{"line_number":129,"context_line":"  else {"},{"line_number":130,"context_line":"    $vmware_datastores \u003d $vcenter_datastores"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  glance_api_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_ff185d77","line":130,"in_reply_to":"bab6814e_d6dbc6eb","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    \u0027glance_store/vmware_store_image_dir\u0027: value    \u003d\u003e $vcenter_image_dir;"},{"line_number":140,"context_line":"    \u0027glance_store/vmware_task_poll_interval\u0027: value \u003d\u003e $vcenter_task_poll_interval;"},{"line_number":141,"context_line":"    \u0027glance_store/vmware_api_retry_count\u0027: value    \u003d\u003e $vcenter_api_retry_count;"},{"line_number":142,"context_line":"    \u0027glance_store/vmware_datastores\u0027: value         \u003d\u003e $vmware_datastores;"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if $glare_enabled {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_36f1726b","line":142,"updated":"2016-05-25 14:42:36.000000000","message":"will be $vmware_datastores_real","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    \u0027glance_store/vmware_store_image_dir\u0027: value    \u003d\u003e $vcenter_image_dir;"},{"line_number":140,"context_line":"    \u0027glance_store/vmware_task_poll_interval\u0027: value \u003d\u003e $vcenter_task_poll_interval;"},{"line_number":141,"context_line":"    \u0027glance_store/vmware_api_retry_count\u0027: value    \u003d\u003e $vcenter_api_retry_count;"},{"line_number":142,"context_line":"    \u0027glance_store/vmware_datastores\u0027: value         \u003d\u003e $vmware_datastores;"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if $glare_enabled {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_5f26c9ba","line":142,"in_reply_to":"bab6814e_36f1726b","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"30c6d805c1e8b27592b345c3df39e38207cb263d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      \u0027glance_store/vmware_store_image_dir\u0027: value    \u003d\u003e $vcenter_image_dir;"},{"line_number":153,"context_line":"      \u0027glance_store/vmware_task_poll_interval\u0027: value \u003d\u003e $vcenter_task_poll_interval;"},{"line_number":154,"context_line":"      \u0027glance_store/vmware_api_retry_count\u0027: value    \u003d\u003e $vcenter_api_retry_count;"},{"line_number":155,"context_line":"      \u0027glance_store/vmware_datastores\u0027: value         \u003d\u003e $vmware_datastores;"},{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"  }"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_96e81e7e","line":155,"updated":"2016-05-25 14:42:36.000000000","message":"see line 142","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"f31d03b69e1c13afb4f860060ad8f1466074660f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      \u0027glance_store/vmware_store_image_dir\u0027: value    \u003d\u003e $vcenter_image_dir;"},{"line_number":153,"context_line":"      \u0027glance_store/vmware_task_poll_interval\u0027: value \u003d\u003e $vcenter_task_poll_interval;"},{"line_number":154,"context_line":"      \u0027glance_store/vmware_api_retry_count\u0027: value    \u003d\u003e $vcenter_api_retry_count;"},{"line_number":155,"context_line":"      \u0027glance_store/vmware_datastores\u0027: value         \u003d\u003e $vmware_datastores;"},{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"  }"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_3f29458a","line":155,"in_reply_to":"bab6814e_96e81e7e","updated":"2016-05-25 15:09:26.000000000","message":"Done","commit_id":"1d82de9dc8f479f9e361705315c064414cfd12f4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"120ce859558fe42e6fa4df132afcaab4d74e793a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  if $vcenter_datastore {"},{"line_number":123,"context_line":"    notice(\u0027The vcenter_datastore parameter is deprecated, use parameter vcenter_datastores\u0027)"},{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":"  if $vcenter_api_insecure {"},{"line_number":126,"context_line":"    notice(\u0027The vcenter_api_insecure parameter is deprecated, use parameter vcenter_insecure\u0027)"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":130,"context_line":"    $vmware_datastores_real \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_8aa59105","line":127,"range":{"start_line":125,"start_character":0,"end_line":127,"end_character":3},"updated":"2016-05-25 15:27:53.000000000","message":"this parameter is also should be used with _real suffix and new parameter, like you done for datastores.","commit_id":"8a084d91b841e67d0ce8dbd86d05511112574860"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"460c370659d93a616b1b038d0aee1bc9eaeae89a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  if $vcenter_datastore {"},{"line_number":123,"context_line":"    notice(\u0027The vcenter_datastore parameter is deprecated, use parameter vcenter_datastores\u0027)"},{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":"  if $vcenter_api_insecure {"},{"line_number":126,"context_line":"    notice(\u0027The vcenter_api_insecure parameter is deprecated, use parameter vcenter_insecure\u0027)"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":130,"context_line":"    $vmware_datastores_real \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_c05e5544","line":127,"range":{"start_line":125,"start_character":0,"end_line":127,"end_character":3},"in_reply_to":"bab6814e_8aa59105","updated":"2016-05-25 16:47:39.000000000","message":"Done","commit_id":"8a084d91b841e67d0ce8dbd86d05511112574860"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"120ce859558fe42e6fa4df132afcaab4d74e793a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":130,"context_line":"    $vmware_datastores_real \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":"  else {"},{"line_number":133,"context_line":"    $vmware_datastores_real \u003d $vcenter_datastores"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_aa91759c","line":132,"updated":"2016-05-25 15:27:53.000000000","message":"please add here check, that if this parameter is undef - it should fail.\n\nBecause afaik user have to specify $vcenter_datastores or $vcenter_datacenter and $vcenter_datastore","commit_id":"8a084d91b841e67d0ce8dbd86d05511112574860"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"460c370659d93a616b1b038d0aee1bc9eaeae89a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":130,"context_line":"    $vmware_datastores_real \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":"  else {"},{"line_number":133,"context_line":"    $vmware_datastores_real \u003d $vcenter_datastores"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_a059915d","line":132,"in_reply_to":"bab6814e_aa91759c","updated":"2016-05-25 16:47:39.000000000","message":"Done","commit_id":"8a084d91b841e67d0ce8dbd86d05511112574860"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   (optional) If true, the ESX/vCenter server certificate is not verified."},{"line_number":26,"context_line":"#   If false, then the default CA truststore is used for verification."},{"line_number":27,"context_line":"#   This option is ignored if \"vcenter_ca_file\" is set."},{"line_number":28,"context_line":"#   Defaults to \u0027True\u0027"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*vcenter_ca_file*]"},{"line_number":31,"context_line":"#   (optional) The name of the CA bundle file which will be used in"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_528e97d0","line":28,"updated":"2016-05-26 10:08:20.000000000","message":"can we use $::os_service_default here?","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   (optional) If true, the ESX/vCenter server certificate is not verified."},{"line_number":26,"context_line":"#   If false, then the default CA truststore is used for verification."},{"line_number":27,"context_line":"#   This option is ignored if \"vcenter_ca_file\" is set."},{"line_number":28,"context_line":"#   Defaults to \u0027True\u0027"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*vcenter_ca_file*]"},{"line_number":31,"context_line":"#   (optional) The name of the CA bundle file which will be used in"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_1fb1b301","line":28,"in_reply_to":"bab6814e_528e97d0","updated":"2016-05-26 11:39:30.000000000","message":"No, it will deteriorate user experience in most cases.","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#   size is already known. If no weight is given, it is assumed to be"},{"line_number":48,"context_line":"#   zero and the directory will be considered for selection last."},{"line_number":49,"context_line":"#   If multiple datastores have the same weight, then the one with the most"},{"line_number":50,"context_line":"#   free space available is selected."},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*vcenter_host*]"},{"line_number":53,"context_line":"#   (required) vCenter/ESXi Server target system."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_52e05796","line":50,"updated":"2016-05-26 10:08:20.000000000","message":"Defaults to ...\n\ncan we use $::os_service_default here?","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#   size is already known. If no weight is given, it is assumed to be"},{"line_number":48,"context_line":"#   zero and the directory will be considered for selection last."},{"line_number":49,"context_line":"#   If multiple datastores have the same weight, then the one with the most"},{"line_number":50,"context_line":"#   free space available is selected."},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*vcenter_host*]"},{"line_number":53,"context_line":"#   (required) vCenter/ESXi Server target system."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_7f8a7f65","line":50,"in_reply_to":"bab6814e_52e05796","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*vcenter_api_insecure*]"},{"line_number":87,"context_line":"#   (optional) DEPRECATED. Allow to perform insecure SSL requests to ESX/VC."},{"line_number":88,"context_line":"#"},{"line_number":89,"context_line":"# [*vcenter_datacenter*]"},{"line_number":90,"context_line":"#   (optional) DEPRECATED. Inventory path to a datacenter."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_72fabb44","line":87,"updated":"2016-05-26 10:08:20.000000000","message":"Defaults to undef","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*vcenter_api_insecure*]"},{"line_number":87,"context_line":"#   (optional) DEPRECATED. Allow to perform insecure SSL requests to ESX/VC."},{"line_number":88,"context_line":"#"},{"line_number":89,"context_line":"# [*vcenter_datacenter*]"},{"line_number":90,"context_line":"#   (optional) DEPRECATED. Inventory path to a datacenter."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_682daea7","line":87,"in_reply_to":"bab6814e_72fabb44","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   If the vmware_server_host specified is an ESX/ESXi,"},{"line_number":92,"context_line":"#   the vcenter_datacenter is optional. If specified,"},{"line_number":93,"context_line":"#   it should be \"ha-datacenter\". This option is deprecated"},{"line_number":94,"context_line":"#   in favor of vcenter_datastores and will be removed."},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*vcenter_datastore*]"},{"line_number":97,"context_line":"#   (optional) DEPRECATED. Datastore associated with the datacenter."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_52f7b758","line":94,"updated":"2016-05-26 10:08:20.000000000","message":"Defaults to undef","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   If the vmware_server_host specified is an ESX/ESXi,"},{"line_number":92,"context_line":"#   the vcenter_datacenter is optional. If specified,"},{"line_number":93,"context_line":"#   it should be \"ha-datacenter\". This option is deprecated"},{"line_number":94,"context_line":"#   in favor of vcenter_datastores and will be removed."},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*vcenter_datastore*]"},{"line_number":97,"context_line":"#   (optional) DEPRECATED. Datastore associated with the datacenter."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_0824e2c2","line":94,"in_reply_to":"bab6814e_52f7b758","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# [*vcenter_datastore*]"},{"line_number":97,"context_line":"#   (optional) DEPRECATED. Datastore associated with the datacenter."},{"line_number":98,"context_line":"#   This option is deprecated in favor of vcenter_datastores"},{"line_number":99,"context_line":"#   and will be removed."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"class glance::backend::vsphere("},{"line_number":102,"context_line":"  $vcenter_host,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_d2a1e747","line":99,"updated":"2016-05-26 10:08:20.000000000","message":"Defaults to undef","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# [*vcenter_datastore*]"},{"line_number":97,"context_line":"#   (optional) DEPRECATED. Datastore associated with the datacenter."},{"line_number":98,"context_line":"#   This option is deprecated in favor of vcenter_datastores"},{"line_number":99,"context_line":"#   and will be removed."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"class glance::backend::vsphere("},{"line_number":102,"context_line":"  $vcenter_host,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_282726cb","line":99,"in_reply_to":"bab6814e_d2a1e747","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    notice(\u0027The vcenter_api_insecure parameter is deprecated, use parameter vcenter_insecure\u0027)"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  if $vcenter_api_insecure {"},{"line_number":130,"context_line":"    $vmware_insecure_real \u003d $vcenter_api_insecure"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_125d2f47","line":129,"updated":"2016-05-26 10:08:20.000000000","message":"you can move notice here. But I\u0027d prefer to use warnings","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    notice(\u0027The vcenter_api_insecure parameter is deprecated, use parameter vcenter_insecure\u0027)"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  if $vcenter_api_insecure {"},{"line_number":130,"context_line":"    $vmware_insecure_real \u003d $vcenter_api_insecure"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_df828b51","line":129,"in_reply_to":"bab6814e_125d2f47","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    $vmware_insecure_real \u003d $vcenter_insecure"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":137,"context_line":"    $vmware_datastores_real \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":"  elsif $vcenter_datastores !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_f2386bf0","line":136,"updated":"2016-05-26 10:08:20.000000000","message":"same here","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    $vmware_insecure_real \u003d $vcenter_insecure"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  if $vcenter_datacenter and $vcenter_datastore {"},{"line_number":137,"context_line":"    $vmware_datastores_real \u003d \"${vcenter_datacenter}:${vcenter_datastore}\""},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":"  elsif $vcenter_datastores !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bab6814e_1f79b382","line":136,"in_reply_to":"bab6814e_f2386bf0","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"}],"releasenotes/notes/deprecate_old_vsphere_backend_parameters-8d798bd64b750911.yaml":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"0a8ad0c7b34035f3f609bdf1e397491b6bf094bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - vmware_api_insecure deprecated - use vmware_insecure"},{"line_number":4,"context_line":"    vmware_datacenter_path and vmware_datastore_name"},{"line_number":5,"context_line":"    deprecated - use vmware_datastores"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_6d32e0f3","line":3,"updated":"2016-05-26 10:08:20.000000000","message":"- vmware_api_insecure is deprecated, use vmware_insecure\n- vmware_datacenter_path and vmware_datastore_name are    deprecated, use vmware_datastores","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"},{"author":{"_account_id":14946,"name":"Alexander Arzhanov","email":"aarzhanov@mirantis.com","username":"aarzhanov"},"change_message_id":"9e7d86fe1649f37e90371ef73c0a5be317348eea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - vmware_api_insecure deprecated - use vmware_insecure"},{"line_number":4,"context_line":"    vmware_datacenter_path and vmware_datastore_name"},{"line_number":5,"context_line":"    deprecated - use vmware_datastores"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_ff830f01","line":3,"in_reply_to":"bab6814e_6d32e0f3","updated":"2016-05-26 11:39:30.000000000","message":"Done","commit_id":"a276fc4f76d5c51b8dc6422c4ac38f0230d5be29"}]}