)]}'
{"manifests/client.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a8a243561cb38776683c89ccffc9ab3009e11aab","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  package { \u0027python-glanceclient\u0027:"},{"line_number":17,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":18,"context_line":"    name   \u003d\u003e $::glance::params::client_package_name,"},{"line_number":19,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027glance-support-package\u0027],"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_32235da9","line":19,"updated":"2016-06-10 13:33:15.000000000","message":"why glance-support-package name? do we use this pattern somewhere else?","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"25350014e9158b4fc2563b6ba5f93516dff0899d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  package { \u0027python-glanceclient\u0027:"},{"line_number":17,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":18,"context_line":"    name   \u003d\u003e $::glance::params::client_package_name,"},{"line_number":19,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027glance-support-package\u0027],"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_3bd8527f","line":19,"in_reply_to":"7aa08908_32235da9","updated":"2016-06-10 16:11:46.000000000","message":"Well, we have same tag for nova, but for keystone, heat and trove - nothing :) I think we need some common pattern here.","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"86a97a75a523ae35014284b66bec8f706d7db2d1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  package { \u0027python-glanceclient\u0027:"},{"line_number":17,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":18,"context_line":"    name   \u003d\u003e $::glance::params::client_package_name,"},{"line_number":19,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027glance-support-package\u0027],"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_7bedbab6","line":19,"in_reply_to":"7aa08908_3bd8527f","updated":"2016-06-10 16:15:19.000000000","message":"When I did the heat work, I didn\u0027t really see a need for it, but I\u0027d be fine with this concept going into heat also.  I suspect the client is the only thing where it would make sense.  However, for things like neutron, nova and glance, they have external deps where this concept is nearly required (like libvirt)","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"}],"manifests/deps.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a8a243561cb38776683c89ccffc9ab3009e11aab","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  # glance-package should be whether or not glance services would need to be"},{"line_number":51,"context_line":"  # restarted if the package state was changed."},{"line_number":52,"context_line":"  Anchor[\u0027glance::install::begin\u0027]"},{"line_number":53,"context_line":"  -\u003e Package\u003c| tag \u003d\u003d \u0027glance-support-package\u0027|\u003e"},{"line_number":54,"context_line":"  -\u003e Anchor[\u0027glance::install::end\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  Anchor[\u0027glance::service::end\u0027] -\u003e Glance_image\u003c||\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_5220a99b","line":53,"updated":"2016-06-10 13:33:15.000000000","message":"why not just glance-package ?","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"}],"manifests/registry.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"25350014e9158b4fc2563b6ba5f93516dff0899d","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":277,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":278,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":279,"context_line":"    require    \u003d\u003e Class[\u0027glance\u0027],"},{"line_number":280,"context_line":"    tag        \u003d\u003e \u0027glance-service\u0027,"},{"line_number":281,"context_line":"  }"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_db04aec7","line":279,"updated":"2016-06-10 16:11:46.000000000","message":"i guess we can use here Anchor[\u0027install::end\u0027]\n\nmain class contains only main package and client.","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"c8c914e0753e7edcac5c12069f7f7760c73ffa69","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":277,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":278,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":279,"context_line":"    require    \u003d\u003e Class[\u0027glance\u0027],"},{"line_number":280,"context_line":"    tag        \u003d\u003e \u0027glance-service\u0027,"},{"line_number":281,"context_line":"  }"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_d4928956","line":279,"in_reply_to":"7aa08908_9b4986d3","updated":"2016-06-17 13:19:32.000000000","message":"Done","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"86a97a75a523ae35014284b66bec8f706d7db2d1","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    enable     \u003d\u003e $enabled,"},{"line_number":277,"context_line":"    hasstatus  \u003d\u003e true,"},{"line_number":278,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":279,"context_line":"    require    \u003d\u003e Class[\u0027glance\u0027],"},{"line_number":280,"context_line":"    tag        \u003d\u003e \u0027glance-service\u0027,"},{"line_number":281,"context_line":"  }"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_9b4986d3","line":279,"in_reply_to":"7aa08908_db04aec7","updated":"2016-06-10 16:15:19.000000000","message":"We can remove it entirely.  This is already collected in deps.pp.  Good catch.","commit_id":"5c4581beb8af1f770c281ce3a4bfc2c22755ab99"}]}