)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1218e44ff696ca052a0d0b309f536df622a4eedf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     François Charlier \u003cfrancois.charlier@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-19 10:53:51 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add options for taskflow_executor \u0026 conversion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ice376ca219ee36ddc97a8317fac20bf8f157b7db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8ec9b2_72026eb5","line":7,"updated":"2016-09-19 09:58:38.000000000","message":"please add a bit more details","commit_id":"081c66c7b3f5a0e67fd532c62b3988ef73e589f2"}],"manifests/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a0be45f8dc0d54931879cc54966e794c57496a7d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"#"},{"line_number":193,"context_line":"# [*task_time_to_live*]"},{"line_number":194,"context_line":"#   (optional) Time in hours for which a task lives after."},{"line_number":195,"context_line":"#   Defaults to 48"},{"line_number":196,"context_line":"#"},{"line_number":197,"context_line":"# [*task_executor*]"},{"line_number":198,"context_line":"#   (optional) Task executor to be used t orun task scripts."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_7d951e85","line":195,"updated":"2016-09-16 15:08:34.000000000","message":"Please do not set values, and use $::os_service_default","commit_id":"1dfc20e60fbd02cf76c43f0aba2a0496edc1f411"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d8f4b2da2fe71deb3b701e89347b48c4e3a2590b","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \u0027taskflow_executor/engine_mode\u0027: value \u003d\u003e $taskflow_engine_mode;"},{"line_number":469,"context_line":"    \u0027taskflow_executor/max_workers\u0027: value \u003d\u003e $taskflow_max_workers;"},{"line_number":470,"context_line":"  }"},{"line_number":471,"context_line":"  if $conversion_format {"},{"line_number":472,"context_line":"    glance_api_config {"},{"line_number":473,"context_line":"      \u0027taskflow_executor/conversion_format\u0027: value \u003d\u003e $conversion_format,"},{"line_number":474,"context_line":"    }"},{"line_number":475,"context_line":"  }"},{"line_number":476,"context_line":"  else"},{"line_number":477,"context_line":"  {"},{"line_number":478,"context_line":"    glance_api_config {"},{"line_number":479,"context_line":"      \u0027taskflow_executor/conversion_format\u0027: ensure \u003d\u003e absent,"},{"line_number":480,"context_line":"    }"},{"line_number":481,"context_line":"  }"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"  # stores config"},{"line_number":484,"context_line":"  if $stores and $known_stores {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a8ec9b2_360f3389","line":481,"range":{"start_line":471,"start_character":0,"end_line":481,"end_character":3},"updated":"2016-09-16 16:07:06.000000000","message":"fyi using $::os_service_default does this for you already.","commit_id":"b8a02eceafc78ebb1db47b77468430d1bdd36e27"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6124d6fc8968d87ed7bd3f8057dde05670453f9a","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \u0027taskflow_executor/engine_mode\u0027: value \u003d\u003e $taskflow_engine_mode;"},{"line_number":469,"context_line":"    \u0027taskflow_executor/max_workers\u0027: value \u003d\u003e $taskflow_max_workers;"},{"line_number":470,"context_line":"  }"},{"line_number":471,"context_line":"  if $conversion_format {"},{"line_number":472,"context_line":"    glance_api_config {"},{"line_number":473,"context_line":"      \u0027taskflow_executor/conversion_format\u0027: value \u003d\u003e $conversion_format,"},{"line_number":474,"context_line":"    }"},{"line_number":475,"context_line":"  }"},{"line_number":476,"context_line":"  else"},{"line_number":477,"context_line":"  {"},{"line_number":478,"context_line":"    glance_api_config {"},{"line_number":479,"context_line":"      \u0027taskflow_executor/conversion_format\u0027: ensure \u003d\u003e absent,"},{"line_number":480,"context_line":"    }"},{"line_number":481,"context_line":"  }"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"  # stores config"},{"line_number":484,"context_line":"  if $stores and $known_stores {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a8ec9b2_ec2c1a9b","line":481,"range":{"start_line":471,"start_character":0,"end_line":481,"end_character":3},"in_reply_to":"7a8ec9b2_11e6c1af","updated":"2016-09-16 16:27:50.000000000","message":"Yea, so $os_service_default is really a puppet convention where it\u0027ll fall back to whatever the \u0027default\u0027 value is in the code because we remove the configuration item from the config files. It\u0027s not smart enough to actually know what the default value really is, we\u0027re just removing it from the configuration file.","commit_id":"b8a02eceafc78ebb1db47b77468430d1bdd36e27"},{"author":{"_account_id":1918,"name":"François Charlier","email":"francois.charlier@redhat.com","username":"francois-charlier"},"change_message_id":"0e9ffe6c1cbf3c717750f135cfb3e05caa984154","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \u0027taskflow_executor/engine_mode\u0027: value \u003d\u003e $taskflow_engine_mode;"},{"line_number":469,"context_line":"    \u0027taskflow_executor/max_workers\u0027: value \u003d\u003e $taskflow_max_workers;"},{"line_number":470,"context_line":"  }"},{"line_number":471,"context_line":"  if $conversion_format {"},{"line_number":472,"context_line":"    glance_api_config {"},{"line_number":473,"context_line":"      \u0027taskflow_executor/conversion_format\u0027: value \u003d\u003e $conversion_format,"},{"line_number":474,"context_line":"    }"},{"line_number":475,"context_line":"  }"},{"line_number":476,"context_line":"  else"},{"line_number":477,"context_line":"  {"},{"line_number":478,"context_line":"    glance_api_config {"},{"line_number":479,"context_line":"      \u0027taskflow_executor/conversion_format\u0027: ensure \u003d\u003e absent,"},{"line_number":480,"context_line":"    }"},{"line_number":481,"context_line":"  }"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"  # stores config"},{"line_number":484,"context_line":"  if $stores and $known_stores {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a8ec9b2_11e6c1af","line":481,"range":{"start_line":471,"start_character":0,"end_line":481,"end_character":3},"in_reply_to":"7a8ec9b2_360f3389","updated":"2016-09-16 16:24:55.000000000","message":"Didn\u0027t know it. But in that case the default value is \u0027false\u0027 as there\u0027s no default value for this parameter in glance.\n\nShould I still use $::os_service_default in that case ?","commit_id":"b8a02eceafc78ebb1db47b77468430d1bdd36e27"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1218e44ff696ca052a0d0b309f536df622a4eedf","unresolved":false,"context_lines":[{"line_number":201,"context_line":"# [*task_work_dir*]"},{"line_number":202,"context_line":"#   (optional) Absolute path to the work directory to use for asynchronous"},{"line_number":203,"context_line":"#   task operations."},{"line_number":204,"context_line":"#   Defaults to \u0027/tmp\u0027"},{"line_number":205,"context_line":"#"},{"line_number":206,"context_line":"# [*taskflow_engine_mode*]"},{"line_number":207,"context_line":"#   (optional) Set the taskflow engine mode."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_32754663","line":204,"updated":"2016-09-19 09:58:38.000000000","message":"defaults to $::os_service_default","commit_id":"081c66c7b3f5a0e67fd532c62b3988ef73e589f2"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1218e44ff696ca052a0d0b309f536df622a4eedf","unresolved":false,"context_lines":[{"line_number":216,"context_line":"# [*conversion_format*]"},{"line_number":217,"context_line":"#   (optional) Allow automatic image conversion."},{"line_number":218,"context_line":"#   Allowed values: \u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027, false."},{"line_number":219,"context_line":"#   Defaults to $::os_service_default (disabled)"},{"line_number":220,"context_line":"#"},{"line_number":221,"context_line":"# [*os_region_name*]"},{"line_number":222,"context_line":"#   (optional) Sets the keystone region to use."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_125a0af2","line":219,"updated":"2016-09-19 09:58:38.000000000","message":"defaults to false","commit_id":"081c66c7b3f5a0e67fd532c62b3988ef73e589f2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b89fc0f276ab56f6c3978959b49a3fff324c0a56","unresolved":false,"context_lines":[{"line_number":216,"context_line":"# [*conversion_format*]"},{"line_number":217,"context_line":"#   (optional) Allow automatic image conversion."},{"line_number":218,"context_line":"#   Allowed values: \u0027qcow2\u0027, \u0027raw\u0027, \u0027vmdk\u0027, false."},{"line_number":219,"context_line":"#   Defaults to $::os_service_default (disabled)"},{"line_number":220,"context_line":"#"},{"line_number":221,"context_line":"# [*os_region_name*]"},{"line_number":222,"context_line":"#   (optional) Sets the keystone region to use."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_8d435bae","line":219,"in_reply_to":"7a8ec9b2_125a0af2","updated":"2016-09-19 10:14:45.000000000","message":"So, i guess it also can be $::os_service_default","commit_id":"081c66c7b3f5a0e67fd532c62b3988ef73e589f2"}]}