)]}'
{"manifests/api.pp":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"96d5c129a18c303916297eccef6744d7dc182637","unresolved":false,"context_lines":[{"line_number":229,"context_line":"#"},{"line_number":230,"context_line":"# [*sync_db*]"},{"line_number":231,"context_line":"#   (Optional) Run db sync on the node."},{"line_number":232,"context_line":"#   Defaults to true"},{"line_number":233,"context_line":"#"},{"line_number":234,"context_line":"# [*validate*]"},{"line_number":235,"context_line":"#   (optional) Whether to validate the service is working after any service refreshes"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f6a8fd7_773a1099","line":232,"range":{"start_line":232,"start_character":16,"end_line":232,"end_character":20},"updated":"2018-04-26 10:13:37.000000000","message":"Seems it default to false.","commit_id":"6645bcbe75bf82cf6bd49f455261b339efdfbec4"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"96d5c129a18c303916297eccef6744d7dc182637","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  $conversion_format                    \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $os_region_name                       \u003d \u0027RegionOne\u0027,"},{"line_number":381,"context_line":"  $enable_proxy_headers_parsing         \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $sync_db                              \u003d false,"},{"line_number":383,"context_line":"  $validate                             \u003d false,"},{"line_number":384,"context_line":"  $validation_options                   \u003d {},"},{"line_number":385,"context_line":"  $limit_param_default                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f6a8fd7_3744981b","line":382,"range":{"start_line":382,"start_character":3,"end_line":382,"end_character":10},"updated":"2018-04-26 10:13:37.000000000","message":"It\u0027s not used, or am i missing something. ?","commit_id":"6645bcbe75bf82cf6bd49f455261b339efdfbec4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a74cd05a6de32c0fbf74afc5e70f7e7cfb38e94b","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  $conversion_format                    \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $os_region_name                       \u003d \u0027RegionOne\u0027,"},{"line_number":381,"context_line":"  $enable_proxy_headers_parsing         \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $sync_db                              \u003d false,"},{"line_number":383,"context_line":"  $validate                             \u003d false,"},{"line_number":384,"context_line":"  $validation_options                   \u003d {},"},{"line_number":385,"context_line":"  $limit_param_default                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f6a8fd7_9861ff14","line":382,"range":{"start_line":382,"start_character":3,"end_line":382,"end_character":10},"in_reply_to":"9f6a8fd7_3744981b","updated":"2018-04-27 06:24:18.000000000","message":"Actually \u0027sync_db\u0027 has been moved here from registry.pp during this change https://review.openstack.org/#/c/408161/\n\nBut as per Alex comment on it\u0027s backport https://review.openstack.org/#/c/515308/ I have skipped switching the db sync behavior here \u0026 just added the parameter separately.\n\nPlease let me know if we can fix this with some better way.. :)","commit_id":"6645bcbe75bf82cf6bd49f455261b339efdfbec4"}]}