)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0d2c6ce62c24f8a32cca77be9fca6d887064d2e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pranali Deore \u003cpdeore@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-13 09:05:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to configure filesystem metadata related parametrs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding below new options to support netapp glance configuration"},{"line_number":10,"context_line":"- \"filesystem_store_metadata_file\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_50c78d47","line":7,"updated":"2018-07-13 15:03:17.000000000","message":"typo: \"parameters\"","commit_id":"13c23fd6fe796acfa6846a02e0bfce0e7b726e60"}],"manifests/api.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0d2c6ce62c24f8a32cca77be9fca6d887064d2e9","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    \u0027DEFAULT/limit_param_default\u0027:                 value \u003d\u003e $limit_param_default;"},{"line_number":426,"context_line":"    \u0027DEFAULT/api_limit_max\u0027:                       value \u003d\u003e $api_limit_max;"},{"line_number":427,"context_line":"    \u0027glance_store/os_region_name\u0027:                 value \u003d\u003e $os_region_name;"},{"line_number":428,"context_line":"    \u0027glance_store/filesystem_store_metadata_file\u0027: value \u003d\u003e $filesystem_store_metadata_file;"},{"line_number":429,"context_line":"    \u0027glance_store/filesystem_store_file_perm\u0027:     value \u003d\u003e $filesystem_store_file_perm;"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_708ba921","line":428,"updated":"2018-07-13 15:03:17.000000000","message":"Let\u0027s move these down to around L484 so that it\u0027s grouped near the place where the rest of the glance store settings are configured. It would look like this:\n\n  glance_api_config {\n    \u0027glance_store/os_region_name\u0027:                 value \u003d\u003e $os_region_name;\n    \u0027glance_store/filesystem_store_metadata_file\u0027: value \u003d\u003e $filesystem_store_metadata_file;\n  }\n\nThis also has a positive side effect of not having to change the whitespace you had to add in L410..L426.","commit_id":"13c23fd6fe796acfa6846a02e0bfce0e7b726e60"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"628d12227dc0353beb0d0d8e65afedb09729d33b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    \u0027DEFAULT/enable_v2_api\u0027:           value \u003d\u003e $enable_v2_api;"},{"line_number":425,"context_line":"    \u0027DEFAULT/limit_param_default\u0027:     value \u003d\u003e $limit_param_default;"},{"line_number":426,"context_line":"    \u0027DEFAULT/api_limit_max\u0027:           value \u003d\u003e $api_limit_max;"},{"line_number":427,"context_line":"    \u0027glance_store/os_region_name\u0027:     value \u003d\u003e $os_region_name;"},{"line_number":428,"context_line":"  }"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  # task/taskflow_executor config."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_6a6c7f9c","line":427,"updated":"2018-10-16 08:17:02.000000000","message":"Would have been ideal to add the new configs here (glance_store configs are together).","commit_id":"749a07541bf45b94ec0f1be52331980f45f1c207"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0b2ce1d7ec0e778245f872032e016f094fe97c3e","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    \u0027DEFAULT/enable_v2_api\u0027:           value \u003d\u003e $enable_v2_api;"},{"line_number":425,"context_line":"    \u0027DEFAULT/limit_param_default\u0027:     value \u003d\u003e $limit_param_default;"},{"line_number":426,"context_line":"    \u0027DEFAULT/api_limit_max\u0027:           value \u003d\u003e $api_limit_max;"},{"line_number":427,"context_line":"    \u0027glance_store/os_region_name\u0027:     value \u003d\u003e $os_region_name;"},{"line_number":428,"context_line":"  }"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  # task/taskflow_executor config."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_ed6bc650","line":427,"in_reply_to":"3f79a3b5_6a6c7f9c","updated":"2018-10-16 11:27:48.000000000","message":"Yeah, I had done it in previous patch but had to add extra white spaces in L410..L426. So, to avoid that I moved it below as per Alan\u0027s suggestion :)\n\nhttps://review.openstack.org/#/c/582444/2..3/manifests/api.pp","commit_id":"749a07541bf45b94ec0f1be52331980f45f1c207"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a2c00363950b30da1ca1d911ec2ddd31bbdb2a76","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    \u0027DEFAULT/enable_v2_api\u0027:           value \u003d\u003e $enable_v2_api;"},{"line_number":425,"context_line":"    \u0027DEFAULT/limit_param_default\u0027:     value \u003d\u003e $limit_param_default;"},{"line_number":426,"context_line":"    \u0027DEFAULT/api_limit_max\u0027:           value \u003d\u003e $api_limit_max;"},{"line_number":427,"context_line":"    \u0027glance_store/os_region_name\u0027:     value \u003d\u003e $os_region_name;"},{"line_number":428,"context_line":"  }"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"  # task/taskflow_executor config."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_b0e9a119","line":427,"in_reply_to":"3f79a3b5_ed6bc650","updated":"2018-10-16 12:11:19.000000000","message":"Thanks.","commit_id":"749a07541bf45b94ec0f1be52331980f45f1c207"}],"releasenotes/notes/add_metadata_file_related_parameters-dd365b3cfaed47a1.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0d2c6ce62c24f8a32cca77be9fca6d887064d2e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new parameter \u0027filesystem_store_metadata_file\u0027,"},{"line_number":4,"context_line":"    While enabling glance netapp nfs, this parameters needs to be set with"},{"line_number":5,"context_line":"    file path which must contain a valid JSON object with the keys \u0027id\u0027 and"},{"line_number":6,"context_line":"    \u0027mountpoint\u0027."},{"line_number":7,"context_line":"  - Add new parameter \u0027filesystem_store_file_perm\u0027,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_b097013a","line":4,"updated":"2018-07-13 15:03:17.000000000","message":"I would avoid mentioning netapp, and keep it simple by just stating the feature adds the ability to configure these two parameters.","commit_id":"13c23fd6fe796acfa6846a02e0bfce0e7b726e60"}]}