)]}'
{"manifests/api.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"98753a31cf098c1ff0a0e9f169a6930c53b690c7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":365,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"},{"line_number":366,"context_line":"  $image_import_plugins                 \u003d $::os_service_default,"},{"line_number":367,"context_line":"  $image_output_format                  \u003d $::os_service_default,"},{"line_number":368,"context_line":"  $enabled_import_methods               \u003d $::os_service_default,"},{"line_number":369,"context_line":"  $node_staging_uri                     \u003d $::os_service_default,"},{"line_number":370,"context_line":"  $image_member_quota                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_978daddb","line":367,"updated":"2018-12-07 17:30:19.000000000","message":"I\u0027m not a glance expert, but wonder if image_output_format is too generic. Would \"image_conversion_output_format\" or \"image_import_output_format\" be more descriptive and accurate?","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"860276508d0b75bc17277699ac660bc86af0e9fe","unresolved":false,"context_lines":[{"line_number":364,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":365,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"},{"line_number":366,"context_line":"  $image_import_plugins                 \u003d $::os_service_default,"},{"line_number":367,"context_line":"  $image_output_format                  \u003d $::os_service_default,"},{"line_number":368,"context_line":"  $enabled_import_methods               \u003d $::os_service_default,"},{"line_number":369,"context_line":"  $node_staging_uri                     \u003d $::os_service_default,"},{"line_number":370,"context_line":"  $image_member_quota                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_ed2afb2b","line":367,"in_reply_to":"3f79a3b5_978daddb","updated":"2018-12-10 08:16:18.000000000","message":"Agreed. :)","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"98753a31cf098c1ff0a0e9f169a6930c53b690c7","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    \u0027glance_store/os_region_name\u0027:    value \u003d\u003e $os_region_name;"},{"line_number":505,"context_line":"  }"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"  if $image_import_plugins!\u003d $::os_service_default {"},{"line_number":508,"context_line":"     $image_import_plugins_real \u003d sprintf(\u0027[%s]\u0027, join(any2array($image_import_plugins), \u0027,\u0027))"},{"line_number":509,"context_line":"  } else {"},{"line_number":510,"context_line":"    $image_import_plugins_real \u003d $image_import_plugins"},{"line_number":511,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_b760e90d","line":508,"range":{"start_line":507,"start_character":0,"end_line":508,"end_character":94},"updated":"2018-12-07 17:30:19.000000000","message":"Watch your whitespace.\n- space missing before \"!\u003d\" on L507\n- L508 looks to be indented too far (compare w/ L510)","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"860276508d0b75bc17277699ac660bc86af0e9fe","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    \u0027glance_store/os_region_name\u0027:    value \u003d\u003e $os_region_name;"},{"line_number":505,"context_line":"  }"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"  if $image_import_plugins!\u003d $::os_service_default {"},{"line_number":508,"context_line":"     $image_import_plugins_real \u003d sprintf(\u0027[%s]\u0027, join(any2array($image_import_plugins), \u0027,\u0027))"},{"line_number":509,"context_line":"  } else {"},{"line_number":510,"context_line":"    $image_import_plugins_real \u003d $image_import_plugins"},{"line_number":511,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_4d1bef1b","line":508,"range":{"start_line":507,"start_character":0,"end_line":508,"end_character":94},"in_reply_to":"3f79a3b5_b760e90d","updated":"2018-12-10 08:16:18.000000000","message":"Done","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"}],"releasenotes/notes/enable_image_conversion_parameters-d47ac86850ad9a90.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"98753a31cf098c1ff0a0e9f169a6930c53b690c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new parameter \u0027image_import_plugins\u0027, to enable for"},{"line_number":5,"context_line":"    task processing."},{"line_number":6,"context_line":"    Add parameter \u0027output_format\u0027, to provide desired output"},{"line_number":7,"context_line":"    format for image conversion plugin."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_da102c50","line":5,"range":{"start_line":4,"start_character":1,"end_line":5,"end_character":20},"updated":"2018-12-07 17:30:19.000000000","message":"The phrase \"to enable for task processing\" doesn\u0027t mean much to me. Maybe this? \"... to enable plugins used by the image import process.\"","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"860276508d0b75bc17277699ac660bc86af0e9fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new parameter \u0027image_import_plugins\u0027, to enable for"},{"line_number":5,"context_line":"    task processing."},{"line_number":6,"context_line":"    Add parameter \u0027output_format\u0027, to provide desired output"},{"line_number":7,"context_line":"    format for image conversion plugin."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_8dd26731","line":5,"range":{"start_line":4,"start_character":1,"end_line":5,"end_character":20},"in_reply_to":"3f79a3b5_da102c50","updated":"2018-12-10 08:16:18.000000000","message":"Done","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"}],"spec/classes/glance_api_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"98753a31cf098c1ff0a0e9f169a6930c53b690c7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027delayed_delete\u0027,"},{"line_number":140,"context_line":"            \u0027scrub_time\u0027,"},{"line_number":141,"context_line":"            \u0027image_cache_dir\u0027,"},{"line_number":142,"context_line":"            \u0027image_output_format\u0027,"},{"line_number":143,"context_line":"            \u0027node_staging_uri\u0027,"},{"line_number":144,"context_line":"            \u0027image_member_quota\u0027,"},{"line_number":145,"context_line":"            \u0027enable_v1_api\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_1a6224db","line":142,"updated":"2018-12-07 17:30:19.000000000","message":"I think this is wrong, because this array are the list of options that are supposed to appear in glance-api.conf, but I believe the image_output_format should appear only in glance-image-import.conf.","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"860276508d0b75bc17277699ac660bc86af0e9fe","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027delayed_delete\u0027,"},{"line_number":140,"context_line":"            \u0027scrub_time\u0027,"},{"line_number":141,"context_line":"            \u0027image_cache_dir\u0027,"},{"line_number":142,"context_line":"            \u0027image_output_format\u0027,"},{"line_number":143,"context_line":"            \u0027node_staging_uri\u0027,"},{"line_number":144,"context_line":"            \u0027image_member_quota\u0027,"},{"line_number":145,"context_line":"            \u0027enable_v1_api\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_0de65715","line":142,"in_reply_to":"3f79a3b5_1a6224db","updated":"2018-12-10 08:16:18.000000000","message":"Done","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"98753a31cf098c1ff0a0e9f169a6930c53b690c7","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          # Verify brackets \"[]\" are added to satisfy the ListOpt syntax."},{"line_number":162,"context_line":"          is_expected.to contain_glance_image_import_config(\"image_import_opts/image_import_plugins\").with_value("},{"line_number":163,"context_line":"                           \"[%s]\" % param_hash[:image_import_plugins])"},{"line_number":164,"context_line":"        end"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        it \u0027is_expected.to lay down default cache config\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_ba81b04e","line":164,"updated":"2018-12-07 17:30:19.000000000","message":"Here is where I think you need to check whether the image_output_format appears in glance-image-import.conf.","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"860276508d0b75bc17277699ac660bc86af0e9fe","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          # Verify brackets \"[]\" are added to satisfy the ListOpt syntax."},{"line_number":162,"context_line":"          is_expected.to contain_glance_image_import_config(\"image_import_opts/image_import_plugins\").with_value("},{"line_number":163,"context_line":"                           \"[%s]\" % param_hash[:image_import_plugins])"},{"line_number":164,"context_line":"        end"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        it \u0027is_expected.to lay down default cache config\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_edb8bbe7","line":164,"in_reply_to":"3f79a3b5_ba81b04e","updated":"2018-12-10 08:16:18.000000000","message":"Done","commit_id":"b78e2950ee20b31202c7e6222de197e1fdd524ad"}]}