)]}'
{"manifests/api.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9ff6fb07acee5522e1a2b227f2e0f292375e4b8f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#  (optional) Desired output format for image conversion plugin."},{"line_number":123,"context_line":"#   Defaults to $::os_service_default."},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":"# [*inject_metadata_properties*]"},{"line_number":127,"context_line":"# (optional) Dictionary contains metadata properties to be injected in image."},{"line_number":128,"context_line":"#    Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f769fc5_0f5caf7c","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":1},"updated":"2018-12-30 00:59:42.000000000","message":"remove this line","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"fb0e914f40ebb97687747855fe12f440c53fc4dc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#  (optional) Desired output format for image conversion plugin."},{"line_number":123,"context_line":"#   Defaults to $::os_service_default."},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":"# [*inject_metadata_properties*]"},{"line_number":127,"context_line":"# (optional) Dictionary contains metadata properties to be injected in image."},{"line_number":128,"context_line":"#    Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfd5e7cf_767d2a1b","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":1},"in_reply_to":"1f769fc5_0f5caf7c","updated":"2019-01-08 07:16:53.000000000","message":"Done","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6ab1fc87f7a0dc0bba07bdb6cb54c5692e78810d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":"# [*inject_metadata_properties*]"},{"line_number":127,"context_line":"# (optional) Dictionary contains metadata properties to be injected in image."},{"line_number":128,"context_line":"#    Defaults to $::os_service_default."},{"line_number":129,"context_line":"#"},{"line_number":130,"context_line":"# [*ignore_user_roles*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ffd0ebdf_463de4b9","line":127,"updated":"2019-01-03 19:28:32.000000000","message":"nit: The alignment of all these \"Parameters\" comments is not 100% consistent, but the lines you\u0027re adding should at least be consistent with their neighbors. Note the column number where you start \"(optional)\" and \"Defaults to\" (see also L131)","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"fb0e914f40ebb97687747855fe12f440c53fc4dc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#"},{"line_number":126,"context_line":"# [*inject_metadata_properties*]"},{"line_number":127,"context_line":"# (optional) Dictionary contains metadata properties to be injected in image."},{"line_number":128,"context_line":"#    Defaults to $::os_service_default."},{"line_number":129,"context_line":"#"},{"line_number":130,"context_line":"# [*ignore_user_roles*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfd5e7cf_967a0e22","line":127,"in_reply_to":"ffd0ebdf_463de4b9","updated":"2019-01-08 07:16:53.000000000","message":"Done","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6ab1fc87f7a0dc0bba07bdb6cb54c5692e78810d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"#"},{"line_number":130,"context_line":"# [*ignore_user_roles*]"},{"line_number":131,"context_line":"# (optional) List containing user roles."},{"line_number":132,"context_line":"#  For example: [admin,member]"},{"line_number":133,"context_line":"#"},{"line_number":134,"context_line":"# [*use_syslog*]"},{"line_number":135,"context_line":"#   (optional) Use syslog for logging."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ffd0ebdf_66a4a809","line":132,"updated":"2019-01-03 19:28:32.000000000","message":"This could be merged with L131.\n\nAlso, \"Defaults to\" is missing.","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"fb0e914f40ebb97687747855fe12f440c53fc4dc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"#"},{"line_number":130,"context_line":"# [*ignore_user_roles*]"},{"line_number":131,"context_line":"# (optional) List containing user roles."},{"line_number":132,"context_line":"#  For example: [admin,member]"},{"line_number":133,"context_line":"#"},{"line_number":134,"context_line":"# [*use_syslog*]"},{"line_number":135,"context_line":"#   (optional) Use syslog for logging."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfd5e7cf_3677a23d","line":132,"in_reply_to":"ffd0ebdf_66a4a809","updated":"2019-01-08 07:16:53.000000000","message":"Done","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9ff6fb07acee5522e1a2b227f2e0f292375e4b8f","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":374,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"},{"line_number":375,"context_line":"  $image_import_plugins                 \u003d $::os_service_default,"},{"line_number":376,"context_line":"  $inject_metadata_properties           \u003d $::os_service_default,"},{"line_number":377,"context_line":"  $ignore_user_roles                    \u003d $::os_service_default,"},{"line_number":378,"context_line":"  $image_conversion_output_format       \u003d $::os_service_default,"},{"line_number":379,"context_line":"  $enabled_import_methods               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f769fc5_6f67634f","line":376,"range":{"start_line":376,"start_character":34,"end_line":376,"end_character":40},"updated":"2018-12-30 00:59:42.000000000","message":"spacing is off on all params for this class, somebody probably forgot to fix that","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6ab1fc87f7a0dc0bba07bdb6cb54c5692e78810d","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":374,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"},{"line_number":375,"context_line":"  $image_import_plugins                 \u003d $::os_service_default,"},{"line_number":376,"context_line":"  $inject_metadata_properties           \u003d $::os_service_default,"},{"line_number":377,"context_line":"  $ignore_user_roles                    \u003d $::os_service_default,"},{"line_number":378,"context_line":"  $image_conversion_output_format       \u003d $::os_service_default,"},{"line_number":379,"context_line":"  $enabled_import_methods               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ffd0ebdf_86f74cf6","line":376,"range":{"start_line":376,"start_character":34,"end_line":376,"end_character":40},"in_reply_to":"1f769fc5_6f67634f","updated":"2019-01-03 19:28:32.000000000","message":"Would you prefer the spacing here (and at L538..541) be fixed in this patch? Just trying to provide clear guidance for Pranali.","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"fb0e914f40ebb97687747855fe12f440c53fc4dc","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":374,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"},{"line_number":375,"context_line":"  $image_import_plugins                 \u003d $::os_service_default,"},{"line_number":376,"context_line":"  $inject_metadata_properties           \u003d $::os_service_default,"},{"line_number":377,"context_line":"  $ignore_user_roles                    \u003d $::os_service_default,"},{"line_number":378,"context_line":"  $image_conversion_output_format       \u003d $::os_service_default,"},{"line_number":379,"context_line":"  $enabled_import_methods               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfd5e7cf_b698726a","line":376,"range":{"start_line":376,"start_character":34,"end_line":376,"end_character":40},"in_reply_to":"ffd0ebdf_86f74cf6","updated":"2019-01-08 07:16:53.000000000","message":"IMO, we should fix this spacing in separate patch since there are lot of places where it is required.","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9ff6fb07acee5522e1a2b227f2e0f292375e4b8f","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    \u0027image_import_opts/image_import_plugins\u0027:           value \u003d\u003e $image_import_plugins_real;"},{"line_number":539,"context_line":"    \u0027image_conversion/output_format\u0027:                   value \u003d\u003e $image_conversion_output_format;"},{"line_number":540,"context_line":"    \u0027inject_metadata_properties/inject\u0027:                value \u003d\u003e $inject_metadata_properties_real;"},{"line_number":541,"context_line":"    \u0027inject_metadata_properties/ignore_user_roles\u0027:     value \u003d\u003e $ignore_user_roles_real;"},{"line_number":542,"context_line":"  }"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f769fc5_4f62a740","line":541,"range":{"start_line":541,"start_character":52,"end_line":541,"end_character":56},"updated":"2018-12-30 00:59:42.000000000","message":"spacing is off on all these lines","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"fb0e914f40ebb97687747855fe12f440c53fc4dc","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    \u0027image_import_opts/image_import_plugins\u0027:           value \u003d\u003e $image_import_plugins_real;"},{"line_number":539,"context_line":"    \u0027image_conversion/output_format\u0027:                   value \u003d\u003e $image_conversion_output_format;"},{"line_number":540,"context_line":"    \u0027inject_metadata_properties/inject\u0027:                value \u003d\u003e $inject_metadata_properties_real;"},{"line_number":541,"context_line":"    \u0027inject_metadata_properties/ignore_user_roles\u0027:     value \u003d\u003e $ignore_user_roles_real;"},{"line_number":542,"context_line":"  }"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfd5e7cf_d69df659","line":541,"range":{"start_line":541,"start_character":52,"end_line":541,"end_character":56},"in_reply_to":"1f769fc5_4f62a740","updated":"2019-01-08 07:16:53.000000000","message":"Done","commit_id":"663ee27f8e67b64bf37c8a99aac60e106908c6aa"}]}