)]}'
{"id":"openstack%2Fpuppet-glance~695754","triplet_id":"openstack%2Fpuppet-glance~stable%2Ftrain~I4f3ec9ee7c4147a4e62de961a9532bdc45526f6b","project":"openstack/puppet-glance","branch":"stable/train","topic":"bug/1846808","hashtags":[],"change_id":"I4f3ec9ee7c4147a4e62de961a9532bdc45526f6b","subject":"Update the method of configuring glance backends","status":"MERGED","created":"2019-11-22 19:19:59.000000000","updated":"2019-11-26 22:44:44.000000000","submitted":"2019-11-26 22:43:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"695754-1574808222693-ded4c5e8","meta_rev_id":"3bce95fa6888bf4e8af61f509579b0f39e9c4cb6","_number":695754,"virtual_id_number":695754,"owner":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-11-22 21:27:29.000000000","_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"date":"2019-11-26 01:00:03.000000000","_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-26 22:43:42.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-11-26 13:55:40.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":2,"date":"2019-11-26 20:58:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":1,"date":"2019-11-26 20:58:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-22 21:27:29.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-11-26 13:55:40.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-11-26 20:58:53.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-11-26 22:43:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"17f7415b56b2dd40c2cb059231c1eae9547526a5","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-11-22 19:19:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f918c5214c0cce5caf3b978219792bbe7264ee2a","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-11-22 19:20:26.000000000","message":"Patch Set 1:\n\nReason for proposing this for stable/train:\n\nAs mentioned in the commit message, glance deprecated its \u0027stores\u0027 and\n\u0027default_store\u0027 parameters a while ago, and is scheduled to remove them\nentirely in ussuri (see [1], [2]). The deprecated options are replaced by \nthe \u0027enabled_backends\u0027 and \u0027default_backend\u0027 options introduced in rocky.\n\nAdding this patch to stable/train will allow the community a chance to\nmigrate away from using the deprecated parameters during the train cycle.\nThis will help avoid breakage when upgrading to ussuri, when the deprecated\noptions will have been removed.\n\n[1] https://opendev.org/openstack/glance_store/src/branch/stable/train/glance_store/backend.py#L44\n[2] https://opendev.org/openstack/glance_store/src/branch/stable/train/glance_store/backend.py#L80","accounts_in_message":[],"_revision_number":1},{"id":"20677cad0921fe7aab86b581acc43db70f4dfd1f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-22 21:06:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1dcaeb4009124ed29bad1289aa33b619 : SUCCESS in 3m 55s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bd3993782913401ea79ae07e51505c6d : SUCCESS in 4m 17s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/afcebb0519274db5b223eb778c9eb0f8 : SUCCESS in 19m 44s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/316e73fe8e954f66a72be46f2a796e23 : SUCCESS in 1h 01m 48s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/dd1ebb573a074834abb4578f77e4d72f : SUCCESS in 1h 04m 08s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/334a3e4a31734774a06761f47fbc8c94 : SUCCESS in 1h 06m 29s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/e040370ce46c41d0acd5a321b3fb222d : SUCCESS in 45m 29s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/6fc89a55a0bb4f67b33461657c1caf40 : SUCCESS in 47m 31s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2499294acc004fb19324c6f4fcd62f17 : SUCCESS in 47m 04s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/91eff69538ef4579a6c148ffe7b551dc : SUCCESS in 42m 41s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/a9bfc30ced1f443bb2bd05ca0d0fb6ee : SUCCESS in 33m 25s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/fb638fcb0d90408cb9846f7b8213a94e : SUCCESS in 17m 08s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ae2dc3c5db3343eeb66556ec8c6d0f62 : FAILURE in 7m 32s (non-voting)\n- tripleo-puppet-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/5cbe37b2893d4b64aeeff59c7c841930 : SUCCESS in 1h 43m 50s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f1229e726bc9448f92d4a7b2d069667c : SUCCESS in 2m 44s\n- puppet-glance-tripleo-standalone https://zuul.opendev.org/t/openstack/build/bad2132ad7664e538da4be6d805efb55 : FAILURE in 1h 03m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"40270e05a78698efec9af0818c0ef766a1753195","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-11-22 21:27:29.000000000","message":"Patch Set 1:\n\nWhat is the behavior if this were to be applied directly on a existing deployment? Will it cause service restart, config changes etc?","accounts_in_message":[],"_revision_number":1},{"id":"bfb0681a560fbda23acc22a593ec28a67fcec720","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-11-25 14:08:49.000000000","message":"Patch Set 1:\n\nMy original goal for this patch was it would behave that way (no config changes when invoked with same inputs), and the patch makes no changes to the spec/glance_backend_*_spec.rb tests (except s3, which should be OK as that backend no longer exists in glance).\n\nThat said, I will test some real deployments and report back with the results.","accounts_in_message":[],"_revision_number":1},{"id":"aa4cf1005c9018b1dd2b51860950bde47311b8ea","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-11-26 00:56:43.000000000","message":"Patch Set 1:\n\nI did several tests today using TripleO Standalone deployments [1] with stable/train. The general test sequence was this:\n\n1. Deploy a specific backend (e.g. \u0027swift\u0027)\n2. Note the time when the glance-api container started running, and save a copy of its /etc/glance/*.conf files.\n3. Update the puppet-glance module to include this patch\n4. Redeploy with no configuration changes\n5. Verify the following\n   - The new deprecation warnings were logged\n   - The glance-api container did not restart\n   - The /etc/glance/*.conf files were identical to the copies saved in 2.\n\nI repeated this process for the swift, file, cinder and rbd backends, and the results were good. \n\n[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/standalone.html","accounts_in_message":[],"_revision_number":1},{"id":"4cbddcd248b84d511e1e4c0123df443156771238","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-11-26 01:00:03.000000000","message":"Patch Set 1:\n\n\u003e 4. Redeploy with no configuration changes\n \nWhat I meant is I updated the deployment from step 1, but with puppet-glance patched.","accounts_in_message":[],"_revision_number":1},{"id":"445d9630bef70ec99f6d9223b0e98e7ab3cc882c","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-11-26 13:55:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5ff3cdb9c98f143e8fb652a023367a48fcfc8de3","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-11-26 20:58:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1938d862ff22bfbde40612ea85d36fdf587db4e8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 20:59:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e4595c51facaeed57617fd06fbdad7bdeffa7b59","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 22:43:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"5283fa988e078fa01d9125368a8fa970a690755f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 22:43:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/884f1ccb856345debaf14a4fe3e65f3f : SUCCESS in 4m 26s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e5a1d915244d4266b5778989c1a4d46b : SUCCESS in 3m 39s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f10ba9f1a39948cdb2b2fc75ce1b106f : SUCCESS in 4m 12s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/88f21b5a88214ca9ac38c9057e73d070 : SUCCESS in 20m 10s\n- puppet-openstack-unit-6.4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2a625c15f4b94f87ada0d0c3422f2ee7 : SUCCESS in 13m 35s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/56c7e978b0e5440fbad2efcf7c0ea8e9 : SUCCESS in 52m 12s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/a3770a2b0ca94e48878c865c60de8211 : SUCCESS in 1h 00m 48s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/aa3f5f3721c14aaf9d60f7cb9c7bf445 : SUCCESS in 1h 18m 45s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/11e09ffaf72e4e7c821e5b119aef6926 : SUCCESS in 49m 08s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/e53338d499a04ed09d0d986e4d421835 : SUCCESS in 19m 32s\n- tripleo-puppet-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/8af8b0e2b48744f3a333a421de0d27b9 : SUCCESS in 1h 39m 15s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cfaff2578f5047c5927a44e3f01484fc : SUCCESS in 3m 25s\n- puppet-glance-tripleo-standalone https://zuul.opendev.org/t/openstack/build/f6d3f84cabe4461f8650170f4c6f6ecb : SUCCESS in 1h 35m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5cd3808bda54068dceccafec0a88857deef521d3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 22:44:44.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/684b83dd46374858b738761abf48f330 : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"69c10c44441028574827e77379bd2d36f3dd5dd5","revisions":{"69c10c44441028574827e77379bd2d36f3dd5dd5":{"kind":"REWORK","_number":1,"created":"2019-11-22 19:19:59.000000000","uploader":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"ref":"refs/changes/54/695754/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-glance","ref":"refs/changes/54/695754/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-glance refs/changes/54/695754/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-glance refs/changes/54/695754/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-glance refs/changes/54/695754/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-glance refs/changes/54/695754/1"}}},"commit":{"parents":[{"commit":"9439d5662282099a859bacfcd16e42f99e0add2f","subject":"Switch to Train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-glance/commit/9439d5662282099a859bacfcd16e42f99e0add2f"}]}],"author":{"name":"Alan Bishop","email":"abishop@redhat.com","date":"2019-10-11 12:58:47.000000000","tz":-420},"committer":{"name":"Alan Bishop","email":"abishop@redhat.com","date":"2019-11-22 18:42:06.000000000","tz":-480},"subject":"Update the method of configuring glance backends","message":"Update the method of configuring glance backends\n\nThis patch updates the method of configuring glance backends to use the\nmodern syntax associated with glance\u0027s Multi Store feature. Glance\u0027s\nglance_store/stores and glance_store/default_store parameters were\ndeprecated in Rocky, and are scheduled for removal in Ussuri.\n\nBackends are now specified using new glance::api::enabled_backends and\nglance::api::default_backend parameters. A series of\nglance::backend::multistore::* defined resources support configuring\nmultiple instances of each backend.\n\nThe legacy glance::api::stores and glance::api::default_store parameters,\nas well as the glance::backend::* class resources, are deprecated, but\ncontinue to function for backward compatibility.\n\nThe glance::backend::s3 class is completely deprecated. Glance removed\nsupport for the s3 backend in Newton.\n\nCloses-Bug: #1846808\nChange-Id: I4f3ec9ee7c4147a4e62de961a9532bdc45526f6b\n(cherry picked from commit fd02761c6e634100ce4583c88a092f2958742ae7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-glance/commit/69c10c44441028574827e77379bd2d36f3dd5dd5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-glance/commit/69c10c44441028574827e77379bd2d36f3dd5dd5"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}