)]}'
{"manifests/api.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1b1509ed8f27aa4ae7b56fa6dbb878e10d7896f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#   (optional) The amount of time to let an image remain in the cache without being accessed."},{"line_number":85,"context_line":"#   Defaults to $::os_service_default."},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"# [*cache_prefetcher_interval*]"},{"line_number":88,"context_line":"#   (optional) The interval in seconds to run periodic job \u0027cache_images\u0027"},{"line_number":89,"context_line":"#   Defaults to $::os_service_default."},{"line_number":90,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_52acdf9d","line":87,"updated":"2020-05-21 17:47:57.000000000","message":"The order of the parameter descriptions should match the parameter order starting on L324. I think the descriptions are quite a bit out of order, but lets add new ones where they _should_ appear. In this instance, it would be just prior to the image_cache_max_size (see L354,355)","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"af1fdbd35f0509baed68a26bcbea0d937d0db9b5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#   (optional) The amount of time to let an image remain in the cache without being accessed."},{"line_number":85,"context_line":"#   Defaults to $::os_service_default."},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"# [*cache_prefetcher_interval*]"},{"line_number":88,"context_line":"#   (optional) The interval in seconds to run periodic job \u0027cache_images\u0027"},{"line_number":89,"context_line":"#   Defaults to $::os_service_default."},{"line_number":90,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_498d4d29","line":87,"in_reply_to":"ff570b3c_52acdf9d","updated":"2020-05-22 05:52:38.000000000","message":"Done","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1b1509ed8f27aa4ae7b56fa6dbb878e10d7896f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"  $database_max_retries                 \u003d undef,"},{"line_number":352,"context_line":"  $database_retry_interval              \u003d undef,"},{"line_number":353,"context_line":"  $database_max_overflow                \u003d undef,"},{"line_number":354,"context_line":"  $cache_prefetcher_interval            \u003d $::os_service_default,"},{"line_number":355,"context_line":"  $image_cache_max_size                 \u003d $::os_service_default,"},{"line_number":356,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":357,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_1267074f","line":354,"updated":"2020-05-21 17:47:57.000000000","message":"I\u0027d prefer the parameter start with \"image_\" so that it\u0027s consistent with others, like the ones on L355..358.","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2b82c2233a42760de96b969447357bb034763991","unresolved":false,"context_lines":[{"line_number":351,"context_line":"  $database_max_retries                 \u003d undef,"},{"line_number":352,"context_line":"  $database_retry_interval              \u003d undef,"},{"line_number":353,"context_line":"  $database_max_overflow                \u003d undef,"},{"line_number":354,"context_line":"  $cache_prefetcher_interval            \u003d $::os_service_default,"},{"line_number":355,"context_line":"  $image_cache_max_size                 \u003d $::os_service_default,"},{"line_number":356,"context_line":"  $image_cache_stall_time               \u003d $::os_service_default,"},{"line_number":357,"context_line":"  $image_cache_dir                      \u003d \u0027/var/lib/glance/image-cache\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_32f20b71","line":354,"in_reply_to":"ff570b3c_1267074f","updated":"2020-05-21 17:50:25.000000000","message":"I changed my mind, so you can ignore this comment. It seems that\u0027s the name chosen by the glance team, and so it makes more sense for the puppet parameter to match glance\u0027s name.","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdb71b86255ed56d1df87c1b00bd5f1866ac9684","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"  # basic service config"},{"line_number":426,"context_line":"  glance_api_config {"},{"line_number":427,"context_line":"    \u0027DEFAULT/bind_host\u0027:                  value \u003d\u003e $bind_host;"},{"line_number":428,"context_line":"    \u0027DEFAULT/bind_port\u0027:                  value \u003d\u003e $bind_port;"},{"line_number":429,"context_line":"    \u0027DEFAULT/backlog\u0027:                    value \u003d\u003e $backlog;"},{"line_number":430,"context_line":"    \u0027DEFAULT/workers\u0027:                    value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_0b907b94","line":427,"range":{"start_line":427,"start_character":41,"end_line":427,"end_character":42},"updated":"2020-05-21 12:43:16.000000000","message":"We can remove 1 space.","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdb71b86255ed56d1df87c1b00bd5f1866ac9684","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":553,"context_line":"  }"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  glance_cache_config {"},{"line_number":556,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":557,"context_line":"    \u0027DEFAULT/image_cache_stall_time\u0027: value \u003d\u003e $image_cache_stall_time;"},{"line_number":558,"context_line":"    \u0027DEFAULT/image_cache_max_size\u0027:   value \u003d\u003e $image_cache_max_size;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_eb1427eb","line":555,"range":{"start_line":555,"start_character":2,"end_line":555,"end_character":21},"updated":"2020-05-21 12:43:16.000000000","message":"Don\u0027t we need to set these parameters in glance-api.conf if caching is managed by glance-api ?","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7e186f3f893a37f711dce3b9054c2d1a6bf2e95c","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":553,"context_line":"  }"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  glance_cache_config {"},{"line_number":556,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":557,"context_line":"    \u0027DEFAULT/image_cache_stall_time\u0027: value \u003d\u003e $image_cache_stall_time;"},{"line_number":558,"context_line":"    \u0027DEFAULT/image_cache_max_size\u0027:   value \u003d\u003e $image_cache_max_size;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_c3e003fe","line":555,"range":{"start_line":555,"start_character":2,"end_line":555,"end_character":21},"in_reply_to":"ff570b3c_a9c6a948","updated":"2020-05-24 01:20:37.000000000","message":"I\u0027m afraid it depends on their setup whether the glance-cache.conf is loaded by glance-api, and in most of distros/deployments it is never loaded.\n\nFor example in tripleo deployment glance-cache.conf is not added in the command for glance-api, which means that glance-cache.conf is NEVER loaded by glance-api.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/glance/glance-api-container-puppet.yaml#L548\n\nI\u0027ve not yet checked all distros, but I believe it is not common to add glance-cache.conf into glance-api command line, so we should configure this option to glance_api_config, too, to make sure the parameters are actually loaded by glance-api.","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ba6828c7e1bdc05936843f0f53e0a7d6b22e7b43","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":553,"context_line":"  }"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  glance_cache_config {"},{"line_number":556,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":557,"context_line":"    \u0027DEFAULT/image_cache_stall_time\u0027: value \u003d\u003e $image_cache_stall_time;"},{"line_number":558,"context_line":"    \u0027DEFAULT/image_cache_max_size\u0027:   value \u003d\u003e $image_cache_max_size;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_e9eb81d9","line":555,"range":{"start_line":555,"start_character":2,"end_line":555,"end_character":21},"in_reply_to":"ff570b3c_d26f4f25","updated":"2020-05-22 05:35:49.000000000","message":"Alan you are right, most of the time operator configures all parameters related to cache in glance-api.conf file. The actual reason for separating these config options to different files is to avoid the large contents in sample config file.\n\nBut as glance-cache now will be part of glance-api we will propose to deprecate/remove this glance-cache.conf file.","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"af1fdbd35f0509baed68a26bcbea0d937d0db9b5","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":553,"context_line":"  }"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  glance_cache_config {"},{"line_number":556,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":557,"context_line":"    \u0027DEFAULT/image_cache_stall_time\u0027: value \u003d\u003e $image_cache_stall_time;"},{"line_number":558,"context_line":"    \u0027DEFAULT/image_cache_max_size\u0027:   value \u003d\u003e $image_cache_max_size;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_a9c6a948","line":555,"range":{"start_line":555,"start_character":2,"end_line":555,"end_character":21},"in_reply_to":"ff570b3c_d26f4f25","updated":"2020-05-22 05:52:38.000000000","message":"In the glance cache doc[1], it\u0027s also mentioned that, Admin/Operator can configure this interval in glance-api.conf file or glance-cache.conf file using cache_prefetcher_interval configuration option.\n\n[1]: https://docs.openstack.org/glance/latest/admin/cache.html#prefetching-images-into-the-image-cache","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1b1509ed8f27aa4ae7b56fa6dbb878e10d7896f","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":553,"context_line":"  }"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  glance_cache_config {"},{"line_number":556,"context_line":"    \u0027DEFAULT/image_cache_dir\u0027:        value \u003d\u003e $image_cache_dir;"},{"line_number":557,"context_line":"    \u0027DEFAULT/image_cache_stall_time\u0027: value \u003d\u003e $image_cache_stall_time;"},{"line_number":558,"context_line":"    \u0027DEFAULT/image_cache_max_size\u0027:   value \u003d\u003e $image_cache_max_size;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_d26f4f25","line":555,"range":{"start_line":555,"start_character":2,"end_line":555,"end_character":21},"in_reply_to":"ff570b3c_eb1427eb","updated":"2020-05-21 17:47:57.000000000","message":"Yes, this should be investigated. I once asked the glance team about the role of these various config files, but got a somewhat confusing answer. The sense I got is the glance-cache-config.yaml file may not even be used (but I could be totally wrong).","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"}],"spec/classes/glance_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdb71b86255ed56d1df87c1b00bd5f1866ac9684","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      :image_member_quota       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":34,"context_line":"      :image_cache_stall_time   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":35,"context_line":"      :image_cache_max_size     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":36,"context_line":"      :cache_prefetcher_interval \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":37,"context_line":"      :pipeline                 \u003d\u003e \u0027keystone\u0027,"},{"line_number":38,"context_line":"      :task_time_to_live        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":39,"context_line":"      :task_executor            \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_abd98f83","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":35},"updated":"2020-05-21 12:43:16.000000000","message":"Can you please align \u003d\u003e ?","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdb71b86255ed56d1df87c1b00bd5f1866ac9684","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :image_member_quota       \u003d\u003e \u0027128\u0027,"},{"line_number":79,"context_line":"        :image_cache_stall_time   \u003d\u003e \u002710\u0027,"},{"line_number":80,"context_line":"        :image_cache_max_size     \u003d\u003e \u002710737418240\u0027,"},{"line_number":81,"context_line":"\t:cache_prefetcher_interval \u003d\u003e \u0027300\u0027,"},{"line_number":82,"context_line":"        :pipeline                 \u003d\u003e \u0027keystone2\u0027,"},{"line_number":83,"context_line":"        :sync_db                  \u003d\u003e false,"},{"line_number":84,"context_line":"        :limit_param_default      \u003d\u003e \u002710\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_ab3d0fbc","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"updated":"2020-05-21 12:43:16.000000000","message":"Use space instead of tab.\nAlso, Can you please align \u003d\u003e , here, too?","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"af1fdbd35f0509baed68a26bcbea0d937d0db9b5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :image_member_quota       \u003d\u003e \u0027128\u0027,"},{"line_number":79,"context_line":"        :image_cache_stall_time   \u003d\u003e \u002710\u0027,"},{"line_number":80,"context_line":"        :image_cache_max_size     \u003d\u003e \u002710737418240\u0027,"},{"line_number":81,"context_line":"\t:cache_prefetcher_interval \u003d\u003e \u0027300\u0027,"},{"line_number":82,"context_line":"        :pipeline                 \u003d\u003e \u0027keystone2\u0027,"},{"line_number":83,"context_line":"        :sync_db                  \u003d\u003e false,"},{"line_number":84,"context_line":"        :limit_param_default      \u003d\u003e \u002710\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_69877111","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"in_reply_to":"ff570b3c_ab3d0fbc","updated":"2020-05-22 05:52:38.000000000","message":"Done","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdb71b86255ed56d1df87c1b00bd5f1866ac9684","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            \u0027image_cache_dir\u0027,"},{"line_number":134,"context_line":"            \u0027image_cache_stall_time\u0027,"},{"line_number":135,"context_line":"            \u0027image_cache_max_size\u0027,"},{"line_number":136,"context_line":"\t    \u0027cache_prefetcher_interval\u0027,"},{"line_number":137,"context_line":"            \u0027node_staging_uri\u0027,"},{"line_number":138,"context_line":"            \u0027image_member_quota\u0027,"},{"line_number":139,"context_line":"            \u0027enable_v1_api\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_4b78b38e","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":5},"updated":"2020-05-21 12:43:16.000000000","message":"ditto. Use space.","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"af1fdbd35f0509baed68a26bcbea0d937d0db9b5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            \u0027image_cache_dir\u0027,"},{"line_number":134,"context_line":"            \u0027image_cache_stall_time\u0027,"},{"line_number":135,"context_line":"            \u0027image_cache_max_size\u0027,"},{"line_number":136,"context_line":"\t    \u0027cache_prefetcher_interval\u0027,"},{"line_number":137,"context_line":"            \u0027node_staging_uri\u0027,"},{"line_number":138,"context_line":"            \u0027image_member_quota\u0027,"},{"line_number":139,"context_line":"            \u0027enable_v1_api\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_c97b1d27","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":5},"in_reply_to":"ff570b3c_4b78b38e","updated":"2020-05-22 05:52:38.000000000","message":"Done","commit_id":"2036708a30128569c721e5d9468feac62a2f1cf9"}]}