)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c448bfceea6b4603cb91a068d6577bfc1c6f0cb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cinder volume type for multiple cinder stores"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During initialization of service, all volume types configured"},{"line_number":10,"context_line":"in the cinder store(s) will be checked if they exist in deployment"},{"line_number":11,"context_line":"or not, the store with the wrong type will be disabled. if cinder"},{"line_number":12,"context_line":"store is configured using traditional/old way (i.e. using \u0027stores\u0027"},{"line_number":13,"context_line":"config option) then this validation will not be performed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Adding missing \u0027cinder_volume_type\u0027 parameter."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0d6992c4_4a31846e","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":58},"updated":"2020-12-15 12:52:40.000000000","message":"IIUC glance validates the volume type if it is explicitly defined in conf and it doesn\u0027t run validation if the cinder_volume_type parameter is not set, right ?\n\nThe current description sounds like we need this parameter to avoid validation error in multistore setup, which seems to be not very correct.","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"034d9250a9d0505c610dfc3771d00d6ee744d4be","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cinder volume type for multiple cinder stores"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During initialization of service, all volume types configured"},{"line_number":10,"context_line":"in the cinder store(s) will be checked if they exist in deployment"},{"line_number":11,"context_line":"or not, the store with the wrong type will be disabled. if cinder"},{"line_number":12,"context_line":"store is configured using traditional/old way (i.e. using \u0027stores\u0027"},{"line_number":13,"context_line":"config option) then this validation will not be performed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Adding missing \u0027cinder_volume_type\u0027 parameter."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6c0a7a26_bf8db199","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":58},"in_reply_to":"0d6992c4_4a31846e","updated":"2020-12-15 21:51:33.000000000","message":"And I\u0027m still not sure I see the value in describing glance\u0027s own behavior (the part about disabling stores if the volume type doesn\u0027t exist) in this patch. This patch is just responsible for configuring the value, and not what glance does with it.","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e9106da137611de114b9cc44fd3cc64b3f0338b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cinder volume type for multiple cinder stores"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During initialization of service, all volume types configured"},{"line_number":10,"context_line":"in the cinder store(s) will be checked if they exist in deployment"},{"line_number":11,"context_line":"or not, the store with the wrong type will be disabled. if cinder"},{"line_number":12,"context_line":"store is configured using traditional/old way (i.e. using \u0027stores\u0027"},{"line_number":13,"context_line":"config option) then this validation will not be performed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Adding missing \u0027cinder_volume_type\u0027 parameter."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"052eead3_0a3428ae","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":58},"in_reply_to":"6c0a7a26_bf8db199","updated":"2020-12-17 10:26:30.000000000","message":"Ack","commit_id":"272bc857547a901228a378a5861cd009493c836c"}],"manifests/backend/cinder.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bf5fe08ad9014221f07ca8ffc24549845e7f4d38","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    cinder_store_project_name   \u003d\u003e $cinder_store_project_name,"},{"line_number":110,"context_line":"    cinder_store_user_name      \u003d\u003e $cinder_store_user_name,"},{"line_number":111,"context_line":"    cinder_store_password       \u003d\u003e $cinder_store_password,"},{"line_number":112,"context_line":"    cinder_volume_type          \u003d\u003e $cinder_volume_type,"},{"line_number":113,"context_line":"    cinder_os_region_name       \u003d\u003e $cinder_os_region_name_real,"},{"line_number":114,"context_line":"    store_description           \u003d\u003e undef,"},{"line_number":115,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e93f6d7b_6ea82d53","line":112,"updated":"2020-12-10 19:50:19.000000000","message":"You should exclude the change from this file because it\u0027s deprecated (see L97). It doesn\u0027t make sense to enhance something that\u0027s deprecated.","commit_id":"96508a3ddb65ba4c0e139db25bed0daf2099c26d"}],"manifests/backend/multistore/cinder.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bf5fe08ad9014221f07ca8ffc24549845e7f4d38","unresolved":true,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#  (Optional) Volume types configured in the cinder store(s) which will be checked"},{"line_number":66,"context_line":"#  if they exist in deployment or not, the store with the wrong type will be"},{"line_number":67,"context_line":"#  disabled."},{"line_number":68,"context_line":"#   Defaults to $::os_service_default."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*cinder_os_region_name*]"},{"line_number":71,"context_line":"#   (optional) Sets the keystone region to use."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0cfdb04d_a734249d","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":0},"updated":"2020-12-10 19:50:19.000000000","message":"This statement may be true (especially the part about the store being disabled), but it describes glance\u0027s internal behavior. I believe this puppet comment should focus on just the fact that it tells glance which volume type it should use for this particular cinder store.","commit_id":"96508a3ddb65ba4c0e139db25bed0daf2099c26d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b35439aa009f9dfae0146301277d4b35e3385c48","unresolved":true,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#  (Optional) Volume types configured in the cinder store(s) which will be checked"},{"line_number":66,"context_line":"#  if they exist in deployment or not, the store with the wrong type will be"},{"line_number":67,"context_line":"#  disabled."},{"line_number":68,"context_line":"#   Defaults to $::os_service_default."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"# [*cinder_os_region_name*]"},{"line_number":71,"context_line":"#   (optional) Sets the keystone region to use."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ae9330ff_e1f08a53","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":0},"in_reply_to":"0cfdb04d_a734249d","updated":"2020-12-14 01:02:14.000000000","message":"+1\n\nThis also helps us keep consistency with Glance itself.","commit_id":"96508a3ddb65ba4c0e139db25bed0daf2099c26d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b35439aa009f9dfae0146301277d4b35e3385c48","unresolved":true,"context_lines":[{"line_number":136,"context_line":"    \"${name}/cinder_enforce_multipath\":    value \u003d\u003e $cinder_enforce_multipath;"},{"line_number":137,"context_line":"    \"${name}/cinder_use_multipath\":        value \u003d\u003e $cinder_use_multipath;"},{"line_number":138,"context_line":"    \"${name}/cinder_store_password\":       value \u003d\u003e $cinder_store_password;"},{"line_number":139,"context_line":"    \"${name}/cinder_volume_type\":          value \u003d\u003e $cinder_volume_type;"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  create_resources(\u0027glance_api_config\u0027, {})"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4362ab33_59baf3df","line":139,"range":{"start_line":139,"start_character":4,"end_line":139,"end_character":72},"updated":"2020-12-14 01:02:14.000000000","message":"Can we put this to the consistent position ? ( I mean before cinder_os_region_name )","commit_id":"96508a3ddb65ba4c0e139db25bed0daf2099c26d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c448bfceea6b4603cb91a068d6577bfc1c6f0cb","unresolved":true,"context_lines":[{"line_number":61,"context_line":"#   (optional) A valid password for the user specified by `cinder_store_user_name\u0027"},{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#   (Optional) The apropriate volume type as per backend name to configure multiple"},{"line_number":66,"context_line":"#   cinder stores. Example: \u0027glance-cinder1\u0027"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"d2268089_83d09df0","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":24},"updated":"2020-12-15 12:52:40.000000000","message":"Can we put this parameter AFTER cinder_os_region_name so that it doesn\u0027t interrupt parameters about keystone credentials ?\n# Sorry I should have pointed this in my previous comment...","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e9106da137611de114b9cc44fd3cc64b3f0338b2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#   (optional) A valid password for the user specified by `cinder_store_user_name\u0027"},{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#   (Optional) The apropriate volume type as per backend name to configure multiple"},{"line_number":66,"context_line":"#   cinder stores. Example: \u0027glance-cinder1\u0027"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3eddec7b_479cd675","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":24},"in_reply_to":"d2268089_83d09df0","updated":"2020-12-17 10:26:30.000000000","message":"Ack","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c448bfceea6b4603cb91a068d6577bfc1c6f0cb","unresolved":true,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#   (Optional) The apropriate volume type as per backend name to configure multiple"},{"line_number":66,"context_line":"#   cinder stores. Example: \u0027glance-cinder1\u0027"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*cinder_os_region_name*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"eb31b59a_81e48ffe","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":44},"updated":"2020-12-15 12:52:40.000000000","message":"I\u0027m afraid the shown example is a bit misleading and seems to imply any requirement about naming. Also, IIUC the usage of cinder_volume_type is still valid even if there is only a single cinder backend.\n\nHow about the following description ?\n The volume type to be used to create image volumes in cinder.","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e9106da137611de114b9cc44fd3cc64b3f0338b2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#   (Optional) The apropriate volume type as per backend name to configure multiple"},{"line_number":66,"context_line":"#   cinder stores. Example: \u0027glance-cinder1\u0027"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*cinder_os_region_name*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"aa850769_57898624","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":44},"in_reply_to":"9ca52b13_cd099d4d","updated":"2020-12-17 10:26:30.000000000","message":"Ack","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"034d9250a9d0505c610dfc3771d00d6ee744d4be","unresolved":true,"context_lines":[{"line_number":62,"context_line":"#   Defaults to $::os_service_default."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*cinder_volume_type*]"},{"line_number":65,"context_line":"#   (Optional) The apropriate volume type as per backend name to configure multiple"},{"line_number":66,"context_line":"#   cinder stores. Example: \u0027glance-cinder1\u0027"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*cinder_os_region_name*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9ca52b13_cd099d4d","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":44},"in_reply_to":"eb31b59a_81e48ffe","updated":"2020-12-15 21:51:33.000000000","message":"+1 on that suggestion!","commit_id":"272bc857547a901228a378a5861cd009493c836c"}],"releasenotes/notes/add_cinder_volume_type_for_multiple_cinder_stores-c19b0bb1c753715b.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bf5fe08ad9014221f07ca8ffc24549845e7f4d38","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027cinder_volume_type\u0027 configuration parameter which will"},{"line_number":5,"context_line":"    be used to configure multiple cinder stores as per configured"},{"line_number":6,"context_line":"    volume types."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4cdcb974_2f3178bf","line":4,"updated":"2020-12-10 19:50:19.000000000","message":"I find this a little confusing. How about something like this:\n\nAdd \u0027cinder_volume_type\u0027 configuration parameter to allow cinder stores to specify a volume type for each cinder store.","commit_id":"96508a3ddb65ba4c0e139db25bed0daf2099c26d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c448bfceea6b4603cb91a068d6577bfc1c6f0cb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027cinder_volume_type\u0027 configuration parameter which will"},{"line_number":5,"context_line":"    be used to configure multiple cinder stores as per configured"},{"line_number":6,"context_line":"    volume types."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2fbad3a3_eb91b3f5","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":17},"updated":"2020-12-15 12:52:40.000000000","message":"I agree with Alan about his comment about this. It might be true that the cinder_volume_type parameter was introduced to support multiple cinder stores, but I think the parameter is still valid in a deployment with a single cinder store. So I prefer the description proposed by him.","commit_id":"272bc857547a901228a378a5861cd009493c836c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e9106da137611de114b9cc44fd3cc64b3f0338b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027cinder_volume_type\u0027 configuration parameter which will"},{"line_number":5,"context_line":"    be used to configure multiple cinder stores as per configured"},{"line_number":6,"context_line":"    volume types."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"872fd439_4e315e43","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":17},"in_reply_to":"2fbad3a3_eb91b3f5","updated":"2020-12-17 10:26:30.000000000","message":"Ack","commit_id":"272bc857547a901228a378a5861cd009493c836c"}]}