)]}'
{"manifests/healthcheck.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d6cec0eda20a717b1c48a76a55b63da96cdd1b5b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Define: glance::healthcheck"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configure oslo_middleware options in healthcheck section"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"43300a22_b390fbf1","line":1,"updated":"2021-04-20 15:55:15.000000000","message":"Class (not Define)","commit_id":"097250bb859f38a1c0e5ce65c5131225b1ca62c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"839a4304cd1a9546d221612f4935f683697b6d00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Define: glance::healthcheck"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configure oslo_middleware options in healthcheck section"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2b7d6607_1252cc68","line":1,"in_reply_to":"43300a22_b390fbf1","updated":"2021-04-20 16:07:26.000000000","message":"Good catch. I noticed that I made the same mistake in other modules so will submit a follow up to fix it...","commit_id":"097250bb859f38a1c0e5ce65c5131225b1ca62c9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"69de8e7598ad321b9d61f03d4febbb407729f871","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  include glance::deps"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  oslo::healthcheck { \u0027glance_api_config\u0027:"},{"line_number":36,"context_line":"    detailed              \u003d\u003e $detailed,"},{"line_number":37,"context_line":"    backends              \u003d\u003e $backends,"},{"line_number":38,"context_line":"    disable_by_file_path  \u003d\u003e $disable_by_file_path,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"92f15aa6_b116d136","line":35,"updated":"2021-04-20 16:29:05.000000000","message":"I notice the resource name mentions glance_api, which triggered a follow-up question. This patch adds glance::healthcheck, but I don\u0027t see the rest of the puppet-glance code referencing it. Is the expectation that a higher layer orchestration tool will determine whether to include this class, or would it be appropriate for glance::api to automatically include it?","commit_id":"dd731f5d600ac15c1e74068cb267e5421ddd53c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2468392462b09e4acfb78b4c10b709038ecf7f62","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  include glance::deps"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  oslo::healthcheck { \u0027glance_api_config\u0027:"},{"line_number":36,"context_line":"    detailed              \u003d\u003e $detailed,"},{"line_number":37,"context_line":"    backends              \u003d\u003e $backends,"},{"line_number":38,"context_line":"    disable_by_file_path  \u003d\u003e $disable_by_file_path,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8c7511af_e5acd34c","line":35,"in_reply_to":"40edb886_ea6880c5","updated":"2021-04-20 16:46:59.000000000","message":"\u003e For example if we add \"include glance::api\" then\n\nSorry I meant\n\nFor example if we add \"include glance::healthcheck\" in glance::api then ...","commit_id":"dd731f5d600ac15c1e74068cb267e5421ddd53c5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b0aa312bba413fdc7cb6628e361f69d94717d4e2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  include glance::deps"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  oslo::healthcheck { \u0027glance_api_config\u0027:"},{"line_number":36,"context_line":"    detailed              \u003d\u003e $detailed,"},{"line_number":37,"context_line":"    backends              \u003d\u003e $backends,"},{"line_number":38,"context_line":"    disable_by_file_path  \u003d\u003e $disable_by_file_path,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f798238d_b3b94466","line":35,"in_reply_to":"8c7511af_e5acd34c","updated":"2021-04-20 16:57:32.000000000","message":"OK, that makes sense. Thanks for the explanation!","commit_id":"dd731f5d600ac15c1e74068cb267e5421ddd53c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb88d20b845c0d096c422a169fba929fce34f0b8","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  include glance::deps"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  oslo::healthcheck { \u0027glance_api_config\u0027:"},{"line_number":36,"context_line":"    detailed              \u003d\u003e $detailed,"},{"line_number":37,"context_line":"    backends              \u003d\u003e $backends,"},{"line_number":38,"context_line":"    disable_by_file_path  \u003d\u003e $disable_by_file_path,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"40edb886_ea6880c5","line":35,"in_reply_to":"92f15aa6_b116d136","updated":"2021-04-20 16:45:22.000000000","message":"Some of the existing implementations don\u0027t follow this unfortunately, but generally speaking we should avoid automatic inclusion.\n\nAdding include works well in the deployment which uses hieradata to define all parameters but doesn\u0027t work in the deployment which uses the explicit parameter values in class definition.\nFor example if we add \"include glance::api\" then the following example doesn\u0027t work because of resource re-declaration, and we are forced to put glance::healthcheck first.\n\n```\nclass { \u0027glance::api\u0027:\n  ...\n}\n\nclass { \u0027glance::healthcheck\u0027:\n  detailed \u003d\u003e false\n}\n```\n\nSo to avoid such enforced ordering we should avoid including classes in this later and leave that composition to upper later like puppet-tripleo or own manifests to define whole resources.","commit_id":"dd731f5d600ac15c1e74068cb267e5421ddd53c5"}],"releasenotes/notes/healthcheck-902378a7b8bf405f.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d6cec0eda20a717b1c48a76a55b63da96cdd1b5b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - | "},{"line_number":4,"context_line":"    The new ``glance::healthcheck`` class has been added. This class manages"},{"line_number":5,"context_line":"    parameters of healthcheck middlware in oslo.middleware."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be3af163_177cf42c","line":3,"updated":"2021-04-20 15:55:15.000000000","message":"nit: trailing space","commit_id":"097250bb859f38a1c0e5ce65c5131225b1ca62c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"839a4304cd1a9546d221612f4935f683697b6d00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - | "},{"line_number":4,"context_line":"    The new ``glance::healthcheck`` class has been added. This class manages"},{"line_number":5,"context_line":"    parameters of healthcheck middlware in oslo.middleware."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c33de93b_09e92e02","line":3,"in_reply_to":"be3af163_177cf42c","updated":"2021-04-20 16:07:26.000000000","message":"Done","commit_id":"097250bb859f38a1c0e5ce65c5131225b1ca62c9"}]}