)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"28383747417a9ebfa6335cc72b8dae86ccc1ba6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3ba3eebd_ce17dec2","updated":"2021-11-23 17:12:27.000000000","message":"\u003e Patch Set 9:\n\u003e \n\u003e IIRC there\u0027s a reason it\u0027s not under wsgi, has that been addressed?\n\nAs far as I understand, the main problem with running glance-api under wsgi was handling of async tasks[1], but that was already resolved.\n\n[1] https://bugs.launchpad.net/glance/+bug/1888713","commit_id":"235f37cb44b0caf09c84df04dbcb88d6816f2c55"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"77512e0590aa9dd33de75b51e0293a48e62d36fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f782d951_90797871","updated":"2021-11-23 17:19:30.000000000","message":"Putting WIP until I test this in integration jobs.","commit_id":"8a94e844faa660a238e51840c7b1a9f379d54565"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a9fd584c4a0f16bee338fe0aebf14ef5afd9bede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"052e3d12_049d7191","updated":"2021-11-24 15:10:53.000000000","message":"recheck","commit_id":"4c983a456604e51b50214b756671e59de4368840"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"614391aa3b1eed6e5772b21e5a6985ca192b823f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"626417f3_9ebbf296","updated":"2022-06-24 10:36:49.000000000","message":"Tested by https://review.opendev.org/c/openstack/puppet-openstack-integration/+/847516","commit_id":"d84e0ad255a4d01cfda23653c4dd4a65e3f323b9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8bf774857fb21cd381ef906f52ccd89f901187ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"0d319325_43207395","updated":"2022-07-14 15:41:52.000000000","message":"I hear from glance developers that glance doesn\u0027t always work well under httpd+mod_wsgi. I don\u0027t know the details, and it\u0027s possible the issues are related to large production deployments (i.e. httpd+mod_wsgi might be OK, but only in some environments).\n\nI just want to raise this point before this patch might merge.","commit_id":"d158fb67216d14f1d21c21900d63fd90cbcae26f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"724016068d990126699c7d59b765833e18c990de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f75ca61b_c0cf0b38","in_reply_to":"0618ff71_35b079ad","updated":"2022-07-14 16:06:04.000000000","message":"Downstream use of TripleO (RHOSP) is specifically the context in which I was told by a glance core that it\u0027s a \"bad idea.\"\n\nI\u0027m trying to get the glance people to comment here, but I\u0027m sort of caught in the middle.","commit_id":"d158fb67216d14f1d21c21900d63fd90cbcae26f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"586847a955b6ce213347b3a69fec121d4a830ef7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"0618ff71_35b079ad","in_reply_to":"0d319325_43207395","updated":"2022-07-14 16:00:45.000000000","message":"As far as I\u0027m aware of, there was an issue with async tasks in the past but that has been fixed by https://bugs.launchpad.net/glance/+bug/1888713 . Currently glance runs under uwsgi in devstack by default and it has been tested for some extent. So providing the option to use wsgi is now useful, I believe.\n\nWe might still need to continue discussion before we switch the default set up in our testing, but I personally hope we can pursue this as it helps us to deploy all services consistently. Also, as you know, this would help us implement TLS support easier in TripleO, with getting rid of tls-proxy we are forced to use now.","commit_id":"d158fb67216d14f1d21c21900d63fd90cbcae26f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c2985eb32c9bf31b248cd9da26e97e81280a6cc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"597cf5e1_640fdc89","in_reply_to":"158547b1_6badf6b6","updated":"2022-07-14 20:23:12.000000000","message":"I\u0027m OK knowing the original deployment model is retained as the default, and adding support for httpd+mod_wsgi is an option for deployments that wish to opt into it.","commit_id":"d158fb67216d14f1d21c21900d63fd90cbcae26f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"013b073a76eae72a60462c0f26ec473eb366434b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"158547b1_6badf6b6","in_reply_to":"991c200e_caddeee7","updated":"2022-07-14 18:01:53.000000000","message":"I don\u0027t really intend to make this switch in either TripleO or RHOSP atm without consulting the respective teams but just trying to implement the initial capability here so that we can use this in the future.\n\nAs long as I tested this in puppet ci it has been working and I\u0027d think this is quite reasonable to add this capability and start testing this (would be better to limit this to specific jobs atm ?) in puppet CI considering the benefits we are expecting for this.\n\nWe can discuss futher especially when we think of implementing this in TripleO but at this moment this change does not affect usage of TripleO so I don\u0027t see any blocker for it, unless Glance team is planning to abandon support for wsgi mechanism which is not true AFAIK.","commit_id":"d158fb67216d14f1d21c21900d63fd90cbcae26f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"c1a401c541f5806497f7a4bb3e76190e8c656842","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"991c200e_caddeee7","in_reply_to":"f75ca61b_c0cf0b38","updated":"2022-07-14 17:48:49.000000000","message":"I don\u0027t have time nor energy to get into the details now. I can get back to the conversation some point in August when I\u0027m back from PTO. If your aim is to make this default in the downstream product, I\u0027d advice to discuss it with the service team first, spoiler alert I don\u0027t see us supporting this for OSP.\n\nWhile the bug you mentioned was the last hard cap why you couldn\u0027t deploy g-api on mod_wsgi it by no means was not the only reason why you shouldn\u0027t.","commit_id":"d158fb67216d14f1d21c21900d63fd90cbcae26f"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"57bd5a74e67516dec478f8b3ae3304e1e5db2660","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"d58096bf_ab14a630","updated":"2022-07-15 18:49:57.000000000","message":"I agree that we can still implement this logic in Puppet OpenStack to keep consistency it\u0027s up to deployments (or deployment tools) to make a decision on how to run it, this should cause us any more churn that we already have on all other modules.\n\nI\u0027ll leave it open for somebody else to +w","commit_id":"53eefc2d951a16577c1385a452b9f3ad989d69c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"afb25500e946331e3b8ca7388f292221c2d2b21c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"34bc2a01_4e239b21","updated":"2022-07-25 16:43:39.000000000","message":"recheck\n\nthe failure in sc05 test looks intermittent .","commit_id":"53eefc2d951a16577c1385a452b9f3ad989d69c5"}],"manifests/wsgi.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c2985eb32c9bf31b248cd9da26e97e81280a6cc0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"881c5beb_7e01088e","updated":"2022-07-14 20:23:12.000000000","message":"Do you want to add a copyright header? I see one in the new manifests/wsgi/apache.pp file.","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"089e4542327a7158a4d7ac4faee063994c00a77a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"902d73ba_df2f0ab6","in_reply_to":"6770150a_fd858831","updated":"2022-07-15 13:05:11.000000000","message":"Ack","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfe15349e7d3c10602eafcbbb068c126786a8f03","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6770150a_fd858831","in_reply_to":"881c5beb_7e01088e","updated":"2022-07-15 01:50:41.000000000","message":"I kept the licence header in apache.pp to make it consistent with cinder::wsgi::apache. I don\u0027t have strong opinion but I tend to avoid putting the license headers now as we don\u0027t do it usually and the top-level file should be enough as far as I know.","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c2985eb32c9bf31b248cd9da26e97e81280a6cc0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: glance::wsgi"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Setup and configure Key Manager options"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"048b7099_ac57c28f","line":3,"updated":"2022-07-14 20:23:12.000000000","message":"This doesn\u0027t look right.","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfe15349e7d3c10602eafcbbb068c126786a8f03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: glance::wsgi"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Setup and configure Key Manager options"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"7647e6e8_d474d9fc","line":3,"in_reply_to":"048b7099_ac57c28f","updated":"2022-07-15 01:50:41.000000000","message":"Done","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c2985eb32c9bf31b248cd9da26e97e81280a6cc0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"# \u003d\u003d Parameters"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#   [*servername*]"},{"line_number":21,"context_line":"#     The servername for the virtualhost."},{"line_number":22,"context_line":"#     Optional. Defaults to $::fqdn"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"#   [*port*]"},{"line_number":25,"context_line":"#     The port."}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3c54ebcd_3389dec3","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":35},"updated":"2022-07-14 20:23:12.000000000","message":"I don\u0027t have a strong view on this, but I note there a two styles used for describing the parameters in this file. The alternative for this one would be:\n\n#     (optional) The servername for the virtualhost.\n#     Defaults to $::fqdn\n\nI see a roughly a 50/50 mix of both styles.","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfe15349e7d3c10602eafcbbb068c126786a8f03","unresolved":true,"context_lines":[{"line_number":18,"context_line":"# \u003d\u003d Parameters"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#   [*servername*]"},{"line_number":21,"context_line":"#     The servername for the virtualhost."},{"line_number":22,"context_line":"#     Optional. Defaults to $::fqdn"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"#   [*port*]"},{"line_number":25,"context_line":"#     The port."}],"source_content_type":"text/x-puppet","patch_set":20,"id":"529f432e_27eb4d46","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":35},"in_reply_to":"3c54ebcd_3389dec3","updated":"2022-07-15 01:50:41.000000000","message":"This is being imported from puppet-cinder. Atm I prefer keeping this to make implementation consistent among modules.\n\nI\u0027ve been willing to fix this and attempted to fix this a few times but I eventually gave up that not to make git blame dirty...","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"089e4542327a7158a4d7ac4faee063994c00a77a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# \u003d\u003d Parameters"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"#   [*servername*]"},{"line_number":21,"context_line":"#     The servername for the virtualhost."},{"line_number":22,"context_line":"#     Optional. Defaults to $::fqdn"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"#   [*port*]"},{"line_number":25,"context_line":"#     The port."}],"source_content_type":"text/x-puppet","patch_set":20,"id":"aeafe8e2_8ed10ee6","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":35},"in_reply_to":"529f432e_27eb4d46","updated":"2022-07-15 13:05:11.000000000","message":"I\u0027m fine either way.","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c2985eb32c9bf31b248cd9da26e97e81280a6cc0","unresolved":true,"context_lines":[{"line_number":183,"context_line":"    wsgi_daemon_process         \u003d\u003e \u0027glance-api\u0027,"},{"line_number":184,"context_line":"    wsgi_process_display_name   \u003d\u003e $wsgi_process_display_name,"},{"line_number":185,"context_line":"    wsgi_process_group          \u003d\u003e \u0027glance-api\u0027,"},{"line_number":186,"context_line":"    wsgi_script_dir             \u003d\u003e $::glance::params::glance_wsgi_script_path,"},{"line_number":187,"context_line":"    wsgi_script_file            \u003d\u003e \u0027glance-api\u0027,"},{"line_number":188,"context_line":"    wsgi_script_source          \u003d\u003e $::glance::params::glance_wsgi_script_source,"},{"line_number":189,"context_line":"    custom_wsgi_process_options \u003d\u003e $custom_wsgi_process_options,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"66016fdb_4537fc10","line":186,"range":{"start_line":186,"start_character":54,"end_line":186,"end_character":77},"updated":"2022-07-14 20:23:12.000000000","message":"Just curious why you chose a \"_path\" suffix for the parameter when the module you pass it to uses \"_dir\"","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cfe15349e7d3c10602eafcbbb068c126786a8f03","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    wsgi_daemon_process         \u003d\u003e \u0027glance-api\u0027,"},{"line_number":184,"context_line":"    wsgi_process_display_name   \u003d\u003e $wsgi_process_display_name,"},{"line_number":185,"context_line":"    wsgi_process_group          \u003d\u003e \u0027glance-api\u0027,"},{"line_number":186,"context_line":"    wsgi_script_dir             \u003d\u003e $::glance::params::glance_wsgi_script_path,"},{"line_number":187,"context_line":"    wsgi_script_file            \u003d\u003e \u0027glance-api\u0027,"},{"line_number":188,"context_line":"    wsgi_script_source          \u003d\u003e $::glance::params::glance_wsgi_script_source,"},{"line_number":189,"context_line":"    custom_wsgi_process_options \u003d\u003e $custom_wsgi_process_options,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"58c6a270_64c043ee","line":186,"range":{"start_line":186,"start_character":54,"end_line":186,"end_character":77},"in_reply_to":"66016fdb_4537fc10","updated":"2022-07-15 01:50:41.000000000","message":"This follows the implementation in the other modules like puppet-cinder. I\u0027m also curious about this but we better keep the consistency among modules.","commit_id":"403c8a87f72c5f3c950597e2eb784b77c6301e9e"}]}