)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a6aeafbba2db816e02d7c7ebf24af281e6297020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"515ef202_3c957ae8","updated":"2021-12-25 19:15:46.000000000","message":"Code looks great, but I have comments about the release note (which has typos).","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ecf1ffbd4f5915dde4f6e4c1d18dc9830df2341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9a930fe8_2db4bcb4","updated":"2021-12-26 23:31:32.000000000","message":"Thank you, Alan, for your good feedback. I\u0027ve updated the release note and fixed some typos you addresses.\n\nAlso, I modified the implementation to make some parameters mandatory, following the old implementation, to have more strict validation about the required parameters.","commit_id":"d83b33353e60a9fa2488b4647944ddd2b7dad0c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a60ecd8d66d8eba035e567c40b0c9b6944989e83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d9155116_9d97d4bc","updated":"2021-12-27 05:15:25.000000000","message":"recheck","commit_id":"40315729bc455bfb3dee4abde09e0d8556d96984"}],"manifests/backend/multistore/s3.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ecf1ffbd4f5915dde4f6e4c1d18dc9830df2341","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*s3_store_host*]"},{"line_number":23,"context_line":"#   (optional) The host where the S3 server is listening."},{"line_number":24,"context_line":"#   Defaults to $::os_service_default."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*s3_store_access_key*]"},{"line_number":27,"context_line":"#   (optional) The S3 query token access key."},{"line_number":28,"context_line":"#   Defaults to $::os_service_default."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*s3_store_secret_key*]"},{"line_number":31,"context_line":"#   (optional) The S3 query token secret key."},{"line_number":32,"context_line":"#   Defaults to $::os_service_default."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*s3_store_bucket*]"},{"line_number":35,"context_line":"#   (optional) The S3 bucket to be used to store the Glance data."},{"line_number":36,"context_line":"#   Defaults to $::os_service_default."},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"# [*s3_store_create_bucket_on_put*]"},{"line_number":39,"context_line":"#   (optional) Determine whether S3 should create a new bucket."},{"line_number":40,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"a22f393f_091a6c68","line":37,"range":{"start_line":22,"start_character":0,"end_line":37,"end_character":1},"updated":"2021-12-26 23:31:32.000000000","message":"I\u0027ve made these parameters required, following the old implementation.","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"}],"releasenotes/notes/restore-s3-support-82e63d83b1184cdf.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a6aeafbba2db816e02d7c7ebf24af281e6297020","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for S3 backent has been re-inroduced, because s3 backend support"},{"line_number":5,"context_line":"    was restored in glance_store."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"791ebfc2_c9444e4a","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":26},"updated":"2021-12-25 19:15:46.000000000","message":"typo: backend","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a6aeafbba2db816e02d7c7ebf24af281e6297020","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for S3 backent has been re-inroduced, because s3 backend support"},{"line_number":5,"context_line":"    was restored in glance_store."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"25abd11a_98a7b74c","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":48},"updated":"2021-12-25 19:15:46.000000000","message":"typo: reintroduced (no hyphen, missing \u0027t\u0027)","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ecf1ffbd4f5915dde4f6e4c1d18dc9830df2341","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for S3 backent has been re-inroduced, because s3 backend support"},{"line_number":5,"context_line":"    was restored in glance_store."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"49f99ec2_4fb4b649","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":48},"in_reply_to":"25abd11a_98a7b74c","updated":"2021-12-26 23:31:32.000000000","message":"Done","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ecf1ffbd4f5915dde4f6e4c1d18dc9830df2341","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for S3 backent has been re-inroduced, because s3 backend support"},{"line_number":5,"context_line":"    was restored in glance_store."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"81bb7d53_e40e9faa","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":26},"in_reply_to":"791ebfc2_c9444e4a","updated":"2021-12-26 23:31:32.000000000","message":"Done","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a6aeafbba2db816e02d7c7ebf24af281e6297020","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The ``glance::backend::s3`` class has been removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"167506a8_801e8962","line":9,"updated":"2021-12-25 19:15:46.000000000","message":"This is accurate, but may be confusing because another section of the release notes states the s3 backend is being reintroduced. I think the message we want to convey is the deprecated non-multistore class (which didn\u0027t actually do anything) is removed, and support for the s3 backend is provided by a new multistore defined resource.","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ecf1ffbd4f5915dde4f6e4c1d18dc9830df2341","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The ``glance::backend::s3`` class has been removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4a796832_4d33497e","line":9,"in_reply_to":"167506a8_801e8962","updated":"2021-12-26 23:31:32.000000000","message":"That concern is reasonable. I\u0027ve updated this note to explain usage of the new resource type.","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c53aa8b19cf256e13b958e50e27b2d68f09bc6c8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for S3 backend has been reinroduced, because s3 backend support"},{"line_number":5,"context_line":"    was restored in glance_store."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"edfa5968_7a0a72a9","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":47},"updated":"2021-12-27 01:15:19.000000000","message":"forgot the \u0027t\u0027 again :-/ \n\n\"reintroduced\"","commit_id":"d83b33353e60a9fa2488b4647944ddd2b7dad0c6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5604e5501851e2ebbd0ea2ed04932e0500fae10e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for S3 backend has been reinroduced, because s3 backend support"},{"line_number":5,"context_line":"    was restored in glance_store."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b32de7e8_d8144df5","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":47},"in_reply_to":"edfa5968_7a0a72a9","updated":"2021-12-27 02:53:14.000000000","message":":facepalm:","commit_id":"d83b33353e60a9fa2488b4647944ddd2b7dad0c6"}],"spec/defines/glance_backend_multistore_s3_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a6aeafbba2db816e02d7c7ebf24af281e6297020","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"cf8c283c_d85f1c3e","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2021-12-25 19:15:46.000000000","message":"nit: 2021","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ecf1ffbd4f5915dde4f6e4c1d18dc9830df2341","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"12ade9d9_fa9b85ba","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"cf8c283c_d85f1c3e","updated":"2021-12-26 23:31:32.000000000","message":"Done","commit_id":"ea2f4a2821fcf18652984047662f0b59195cd9ce"}]}