)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"93da28730d7229ef8f309df36fc15bf5f152c8f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5310db81_81d446a2","updated":"2022-06-21 23:02:03.000000000","message":"recheck","commit_id":"d82df7aeddac0bdaaa2e687e5950ad9ccfa98001"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c2dab6dcc9deae72247c450b56352c2020c9e223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4a925c8_80e162b0","updated":"2022-06-22 02:53:38.000000000","message":"recheck","commit_id":"d82df7aeddac0bdaaa2e687e5950ad9ccfa98001"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e871982d32a14f074f6bacf9f327d123d6651121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bef18d0a_1c75b074","updated":"2022-06-22 08:14:21.000000000","message":"recheck","commit_id":"d82df7aeddac0bdaaa2e687e5950ad9ccfa98001"}],"manifests/backend/reserved/staging.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1c2bf3fdfa6d83fe2847c255db27f7a02750f385","unresolved":true,"context_lines":[{"line_number":36,"context_line":"#   Defaults to $::os_service_default"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class glance::backend::reserved::staging("},{"line_number":39,"context_line":"  $filesystem_store_datadir     \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $filesystem_store_file_perm   \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $filesystem_store_chunk_size  \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $filesystem_thin_provisioning \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a009b98_96861a89","line":39,"range":{"start_line":39,"start_character":34,"end_line":39,"end_character":55},"updated":"2022-06-21 17:04:48.000000000","message":"I\u0027m reading the glance release note [1], and from what I can tell the two reserved filesystem stores (tasks and staging) may need to use different data dirs. If that\u0027s the case then should we require users of this puppet class to explicitly configure these parameters (this one, plus the \u0027tasks\u0027 one)? If we allow $::os_service_default then that might inadvertently lead to users deploying these reserved stores with the same data dir, which [1] seems to indicate should not be done.\n\n[1] https://opendev.org/openstack/glance/src/branch/master/releasenotes/notes/rethinking-filesystem-access-120bc46064b3d40a.yaml#L55","commit_id":"d82df7aeddac0bdaaa2e687e5950ad9ccfa98001"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63f6d2b2903baa8b4824d0853e716fccf980af9b","unresolved":true,"context_lines":[{"line_number":36,"context_line":"#   Defaults to $::os_service_default"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class glance::backend::reserved::staging("},{"line_number":39,"context_line":"  $filesystem_store_datadir     \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $filesystem_store_file_perm   \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $filesystem_store_chunk_size  \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $filesystem_thin_provisioning \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"97cabd74_58754bad","line":39,"range":{"start_line":39,"start_character":34,"end_line":39,"end_character":55},"in_reply_to":"3a009b98_96861a89","updated":"2022-06-21 17:20:26.000000000","message":"The default value of filesystem_store_datadir is overridden when registering these reserved store and different default values are used \u0027by default\u0027, so we can use $::os_service_default here.\n\nhttps://opendev.org/openstack/glance_store/src/branch/master/glance_store/multi_backend.py#L133-L135","commit_id":"d82df7aeddac0bdaaa2e687e5950ad9ccfa98001"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"31432770e4b3361116587cd8c4fcddce58bfb9d4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   Defaults to $::os_service_default"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class glance::backend::reserved::staging("},{"line_number":39,"context_line":"  $filesystem_store_datadir     \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $filesystem_store_file_perm   \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $filesystem_store_chunk_size  \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $filesystem_thin_provisioning \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"815bc584_3b8fea68","line":39,"range":{"start_line":39,"start_character":34,"end_line":39,"end_character":55},"in_reply_to":"97cabd74_58754bad","updated":"2022-06-21 17:44:51.000000000","message":"You\u0027re correct, thanks for linking to the relevant code!","commit_id":"d82df7aeddac0bdaaa2e687e5950ad9ccfa98001"}]}