)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"234140e2af40d5b0d5122a637443a078579d5bf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3d399150_1b85e9fb","updated":"2022-06-21 02:52:02.000000000","message":"recheck","commit_id":"7e6392e1d04cb97d8a3507cef4b69926594c0528"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"21a79f6812d512782d3ab3dd19820a861a3cd892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4cb0f0a9_91937248","updated":"2022-06-21 18:25:53.000000000","message":"Maybe I missed something, but it looks like old parameters were swapped for new ones, but without backward compatibility to help the user during upgrades.","commit_id":"653f52d187b2e06c273bd349abc6ea82e788a6a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08f4cf73d74ea8c02dd5c2d27db7a6a82e9f4ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8d34ab77_26d5f744","in_reply_to":"4cb0f0a9_91937248","updated":"2022-06-22 05:11:55.000000000","message":"I could not find the good way to keep the parameters working regardless of the order to include classes, but I came up with a better solution so updated the patch.\nI hope this addresses your concerns well.\n\nThe filesystem_store_* parameters in glance_store section are used only when multi store is disabled (IIUC) so I believe we should deprecate these parameters, but that can be done in master only, as a separate work.","commit_id":"653f52d187b2e06c273bd349abc6ea82e788a6a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"398e60ccf463bfe7db31c8c3bccc41a29a355729","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4bcf519c_b31a11a2","updated":"2022-06-22 08:13:46.000000000","message":"recheck","commit_id":"0495848983374b52ac2fa394e0ceb416cf2fac36"}],"manifests/api.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"21a79f6812d512782d3ab3dd19820a861a3cd892","unresolved":true,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"  [\u0027filesystem_store_metadata_file\u0027, \u0027filesystem_store_file_perm\u0027].each |String $fs_opt| {"},{"line_number":389,"context_line":"    if getvar($fs_opt) !\u003d undef {"},{"line_number":390,"context_line":"      warning(\"The ${fs_opt} parameter has been deprecated and has no effect.\")"},{"line_number":391,"context_line":"    }"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"868558d1_a14f3f69","line":390,"updated":"2022-06-21 18:25:53.000000000","message":"Can we assume users know they need to use the new glance::backend::file parameters? I\u0027m thinking of the upgrade situation.","commit_id":"653f52d187b2e06c273bd349abc6ea82e788a6a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08f4cf73d74ea8c02dd5c2d27db7a6a82e9f4ebf","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"  [\u0027filesystem_store_metadata_file\u0027, \u0027filesystem_store_file_perm\u0027].each |String $fs_opt| {"},{"line_number":389,"context_line":"    if getvar($fs_opt) !\u003d undef {"},{"line_number":390,"context_line":"      warning(\"The ${fs_opt} parameter has been deprecated and has no effect.\")"},{"line_number":391,"context_line":"    }"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"03faeaff_4ff17b08","line":390,"in_reply_to":"868558d1_a14f3f69","updated":"2022-06-22 05:11:55.000000000","message":"I updated the patch and now the parameter is NOT deprecated by this change.","commit_id":"653f52d187b2e06c273bd349abc6ea82e788a6a0"}],"releasenotes/notes/bug-1979232-0201e0cdb00fccb9.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"21a79f6812d512782d3ab3dd19820a861a3cd892","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following parameters of the ``glance::api`` class have been deprecated"},{"line_number":5,"context_line":"    and have no effect now. Use the same parameters of"},{"line_number":6,"context_line":"    the ``glance::backend::file`` class instead."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"234257a8_7856829a","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":78},"updated":"2022-06-21 18:25:53.000000000","message":"I don\u0027t see code that handles the deprecated parameters on upgrades (no \"pick\").","commit_id":"653f52d187b2e06c273bd349abc6ea82e788a6a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08f4cf73d74ea8c02dd5c2d27db7a6a82e9f4ebf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following parameters of the ``glance::api`` class have been deprecated"},{"line_number":5,"context_line":"    and have no effect now. Use the same parameters of"},{"line_number":6,"context_line":"    the ``glance::backend::file`` class instead."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"70e4555d_2323db30","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":78},"in_reply_to":"234257a8_7856829a","updated":"2022-06-22 05:11:55.000000000","message":"It was intentional because pick requires us to enforce order of class inclusions. (glance::api should be included before glance::backend::file, which would break existing manifests like the one we have in p-o-i)","commit_id":"653f52d187b2e06c273bd349abc6ea82e788a6a0"}]}