)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d25a14f8cb928474a24c15b0f2d640f2c5cca91a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fba71e94_2317ada7","updated":"2022-06-22 14:09:28.000000000","message":"I\u0027m curious about the deprecation plan. I realize these two parameters never should have been part of this class, and instead should have been glance::backend::file parameters. \n\nIf we\u0027re trying to deprecate them in glance::api then should they be added to glance::backend::file? \n\nOr are we looking ahead to the day when all of the legacy (non-multistore) backend classes are deprecated?\n\nAnd though the git subjects make it seem like this and [1] are separate topics, I\u0027d be in favor of combining them in a single patch.\n","commit_id":"d192a7654ab66554ff4964a3fe217a7b00b4c219"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7b75f7b642920dcc1d8206aa6d5c1f4136d6e5c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"33d4fe10_608d0295","updated":"2022-06-22 08:13:52.000000000","message":"recheck","commit_id":"d192a7654ab66554ff4964a3fe217a7b00b4c219"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5c467f671c05fc3229ea1a54b916c070006f6df6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2741ae28_903e1d8e","in_reply_to":"031d00d7_a0d75ccf","updated":"2022-06-22 15:53:13.000000000","message":"Thanks, this makes sense. And I didn\u0027t notice the other patch (which fixes the duplicate resource error) also needs to be fixed in yoga.","commit_id":"d192a7654ab66554ff4964a3fe217a7b00b4c219"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"665f2d3824f99b15e2e5220a2ed3724b64b24a99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"031d00d7_a0d75ccf","in_reply_to":"fba71e94_2317ada7","updated":"2022-06-22 15:25:37.000000000","message":"My current plan is to remove these parameters when we remove deprecated support for legacy store as these parameters are unused when multistore backends are used.\n\nThese parameters in glance::api look strange but these might be needed to customize behavior of internal stores like svaging store even if different backends are used.\n\nI\u0027ve made this deprecation separate so that we can backport the parent fix to yoga without parameter deprecation.","commit_id":"d192a7654ab66554ff4964a3fe217a7b00b4c219"}],"manifests/api.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d25a14f8cb928474a24c15b0f2d640f2c5cca91a","unresolved":true,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"  [\u0027filesystem_store_metadata_file\u0027, \u0027filesystem_store_file_perm\u0027].each |String $fs_opt| {"},{"line_number":389,"context_line":"    if getvar($fs_opt) !\u003d undef {"},{"line_number":390,"context_line":"      warning(\"The ${fs_opt} parameter has been deprecated and has no effect.\")"},{"line_number":391,"context_line":"    }"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2b467f03_8e3a5e89","line":390,"range":{"start_line":390,"start_character":59,"end_line":390,"end_character":76},"updated":"2022-06-22 14:09:28.000000000","message":"This is not true, if defined then they will have an effect.","commit_id":"d192a7654ab66554ff4964a3fe217a7b00b4c219"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"665f2d3824f99b15e2e5220a2ed3724b64b24a99","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"  [\u0027filesystem_store_metadata_file\u0027, \u0027filesystem_store_file_perm\u0027].each |String $fs_opt| {"},{"line_number":389,"context_line":"    if getvar($fs_opt) !\u003d undef {"},{"line_number":390,"context_line":"      warning(\"The ${fs_opt} parameter has been deprecated and has no effect.\")"},{"line_number":391,"context_line":"    }"},{"line_number":392,"context_line":"  }"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fcf9e383_45b0eab4","line":390,"range":{"start_line":390,"start_character":59,"end_line":390,"end_character":76},"in_reply_to":"2b467f03_8e3a5e89","updated":"2022-06-22 15:25:37.000000000","message":"Done","commit_id":"d192a7654ab66554ff4964a3fe217a7b00b4c219"}]}