)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7eac4e5aa7291283a91360eced1c45e250c62895","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ctkajinam@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-02 12:11:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure the oslo.coordination lock_path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A recent change in os-brick [1], which used by cinder backends,"},{"line_number":10,"context_line":"requires external file locks. This patch adds support for configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a0e9b24c_ba98b761","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2022-07-02 03:14:08.000000000","message":"I\u0027m fine with implementing this in puppet-glance, but I still think we should consider adding the distribution default[1] so that we don\u0027t cause direct breakage by this fix backported.\n\n[1] https://review.rdoproject.org/r/c/openstack/glance-distgit/+/43834","commit_id":"e1e712f235038cd7a357a496212b23c9c5e8d80d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b7c9d892fa3a247212f5811be2d66fa09601aa8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ctkajinam@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-02 12:11:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure the oslo.coordination lock_path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A recent change in os-brick [1], which used by cinder backends,"},{"line_number":10,"context_line":"requires external file locks. This patch adds support for configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6f1f7d93_772490a8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"in_reply_to":"0b6d9c3b_1fd0f756","updated":"2022-07-02 09:15:25.000000000","message":"I intended to say that we should feedback this default to mechanisms used in each distros to cover any use cases without puppet. However your point is valid and I agree it\u0027s better to document that.","commit_id":"e1e712f235038cd7a357a496212b23c9c5e8d80d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2d841b20220d0709306721a41cd41f5ce63ba9fb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ctkajinam@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-02 12:11:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure the oslo.coordination lock_path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A recent change in os-brick [1], which used by cinder backends,"},{"line_number":10,"context_line":"requires external file locks. This patch adds support for configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0b6d9c3b_1fd0f756","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"in_reply_to":"a0e9b24c_ba98b761","updated":"2022-07-02 04:32:21.000000000","message":"I agree there is a concern about upgrades when a distribution has used its own distro conf file to assign their own default value. I will address this by adding something to the release notes.","commit_id":"e1e712f235038cd7a357a496212b23c9c5e8d80d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7eac4e5aa7291283a91360eced1c45e250c62895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0d52c15f_4b5b6422","updated":"2022-07-02 03:14:08.000000000","message":"Updated the patch by my side to address a few minor comments in unit tests. The other parts looks good to me.","commit_id":"e1e712f235038cd7a357a496212b23c9c5e8d80d"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"36f5310039cea8d380c094a9c0c13c1ab0d1beb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0efea5c3_c0c6d447","updated":"2022-07-04 09:13:38.000000000","message":"LGTM","commit_id":"6f61ecd9c5b030817d0255fd8fd485722f9556f4"}],"spec/classes/glance_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf9f9f9baec91cab917b308a5674299faed2a464","unresolved":true,"context_lines":[{"line_number":268,"context_line":"      end"},{"line_number":269,"context_line":"    end"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    describe \u0027setting oslo concurrency lock_path\u0027 do"},{"line_number":272,"context_line":"      let :params do"},{"line_number":273,"context_line":"        default_params.merge({:lock_path \u003d\u003e \u0027/glance/lock/path\u0027 })"},{"line_number":274,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7b7262e0_203fd136","line":271,"range":{"start_line":271,"start_character":14,"end_line":271,"end_character":21},"updated":"2022-07-02 03:11:24.000000000","message":"would be useful to test the default value as well.","commit_id":"d3d85d4d25b6ff11ecdbefafa628f803e8fc4540"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7eac4e5aa7291283a91360eced1c45e250c62895","unresolved":false,"context_lines":[{"line_number":268,"context_line":"      end"},{"line_number":269,"context_line":"    end"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    describe \u0027setting oslo concurrency lock_path\u0027 do"},{"line_number":272,"context_line":"      let :params do"},{"line_number":273,"context_line":"        default_params.merge({:lock_path \u003d\u003e \u0027/glance/lock/path\u0027 })"},{"line_number":274,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"f6bae214_4528fc4c","line":271,"range":{"start_line":271,"start_character":14,"end_line":271,"end_character":21},"in_reply_to":"7b7262e0_203fd136","updated":"2022-07-02 03:14:08.000000000","message":"Done","commit_id":"d3d85d4d25b6ff11ecdbefafa628f803e8fc4540"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf9f9f9baec91cab917b308a5674299faed2a464","unresolved":true,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    describe \u0027setting oslo concurrency lock_path\u0027 do"},{"line_number":272,"context_line":"      let :params do"},{"line_number":273,"context_line":"        default_params.merge({:lock_path \u003d\u003e \u0027/glance/lock/path\u0027 })"},{"line_number":274,"context_line":"      end"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"      it { is_expected.to contain_oslo__concurrency(\u0027glance_api_config\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":2,"id":"a253fefd_abbfb28f","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":22},"updated":"2022-07-02 03:11:24.000000000","message":"this is not specific to this test case but IMO this does not look quite correct and we don\u0027t really need to \u0027set the default values\u0027 here. I\u0027ll fix the other test cases in a follow up.","commit_id":"d3d85d4d25b6ff11ecdbefafa628f803e8fc4540"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7eac4e5aa7291283a91360eced1c45e250c62895","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    describe \u0027setting oslo concurrency lock_path\u0027 do"},{"line_number":272,"context_line":"      let :params do"},{"line_number":273,"context_line":"        default_params.merge({:lock_path \u003d\u003e \u0027/glance/lock/path\u0027 })"},{"line_number":274,"context_line":"      end"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"      it { is_expected.to contain_oslo__concurrency(\u0027glance_api_config\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":2,"id":"53331ca0_a2526eb0","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":22},"in_reply_to":"a253fefd_abbfb28f","updated":"2022-07-02 03:14:08.000000000","message":"Done","commit_id":"d3d85d4d25b6ff11ecdbefafa628f803e8fc4540"}]}