)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d83cc9b47b6ce4c1c1199ae898c0764352482656","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance::api: Test actual default values"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"... instead of setting the default values hard-coded in the spec file."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cfc4a17e0e42d1929098673b654d72b11a8e86b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f173be76_5b9fef1b","line":9,"updated":"2022-07-02 05:09:19.000000000","message":"I\u0027m not sure I follow. From what I can see, some of the old rspec code would do things like this:\n\n      let :params do\n        default_params.merge({:some_param \u003d\u003e \u0027some_value\u0027 })\n      end\n      \nWhich would result in a large set of params, based largely only the default_params values but with one param\u0027s value being overridden. Then the rspec code would test for the override.\n\nThe new code would look like this:\n\n      let :params do\n        {:some_param \u003d\u003e \u0027some_value\u0027 }\n      end\n\nResulting in a small set of params that still override the same set of default values.\n\nCertainly the new code looks cleaner, but I guess I don\u0027t see where the old code wasn\u0027t testing default values.","commit_id":"c485242e7a28a8066b9cae30013e1a9158d6dd03"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d4d205bb61eb0f43dee695e66988d0cdbcd806c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance::api: Test actual default values"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"... instead of setting the default values hard-coded in the spec file."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7cfc4a17e0e42d1929098673b654d72b11a8e86b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fe598b6e_edf73378","line":9,"in_reply_to":"f173be76_5b9fef1b","updated":"2022-07-02 09:08:17.000000000","message":"I think I didn\u0027t explain it well. How is the updated version of the commit message ?\n\nMy point is that setting some parameters by the actual parameters is quite redundant and we can just let the class to use its own default. Unless we have any specific reason to do so, I prefer setting less parameters to makes sure none of the other parameters are affecting what is being tested.","commit_id":"c485242e7a28a8066b9cae30013e1a9158d6dd03"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"262b4fd92e6c306be3de8688c5b5240f857a5289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5b536747_90f14384","updated":"2022-07-02 21:04:08.000000000","message":"Ah, good! The updated commit message perfectly matches what I originally saw in the code, but wasn\u0027t sure it matched what I read in the original commit message.\n","commit_id":"1bd9dfddcbdb1431858be8770348572674938cff"}],"spec/classes/glance_api_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d83cc9b47b6ce4c1c1199ae898c0764352482656","unresolved":true,"context_lines":[{"line_number":337,"context_line":"    end"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    describe \u0027with enabled_backends and stores by default\u0027 do"},{"line_number":340,"context_line":"      let :params do"},{"line_number":341,"context_line":"        {}"},{"line_number":342,"context_line":"      end"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"      it { is_expected.to_not contain_glance_api_config(\u0027DEFAULT/enabled_backends\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":345,"context_line":"      it { is_expected.to_not contain_glance_api_config(\u0027glance_store/stores\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"b8cf364c_6f9b2c50","line":342,"range":{"start_line":340,"start_character":0,"end_line":342,"end_character":9},"updated":"2022-07-02 05:09:19.000000000","message":"I think these can then be eliminated.","commit_id":"c485242e7a28a8066b9cae30013e1a9158d6dd03"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d4d205bb61eb0f43dee695e66988d0cdbcd806c","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    end"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    describe \u0027with enabled_backends and stores by default\u0027 do"},{"line_number":340,"context_line":"      let :params do"},{"line_number":341,"context_line":"        {}"},{"line_number":342,"context_line":"      end"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"      it { is_expected.to_not contain_glance_api_config(\u0027DEFAULT/enabled_backends\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":345,"context_line":"      it { is_expected.to_not contain_glance_api_config(\u0027glance_store/stores\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3dc03a73_deee7ba8","line":342,"range":{"start_line":340,"start_character":0,"end_line":342,"end_character":9},"in_reply_to":"b8cf364c_6f9b2c50","updated":"2022-07-02 09:08:17.000000000","message":"Done","commit_id":"c485242e7a28a8066b9cae30013e1a9158d6dd03"}]}