)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a344a59abca2d5554425538e05d1f6e315ea17ef","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new option for api: public_endpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running glance-api behind a proxy or load balancer that hides glance"},{"line_number":10,"context_line":"behind an extended base URL, it is necessary to provide information about"},{"line_number":11,"context_line":"the base URL to glance-api to ensure that clients know where to pass"},{"line_number":12,"context_line":"subsequent requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bebee01c2580f0500a069f5ab57ac2a8c329389"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff7e74d_7ff65418","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":20},"updated":"2022-08-23 05:54:06.000000000","message":"Please wrap each line at 72 chars.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\nSubsequent lines should be wrapped at 72 characters.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":23866,"name":"Trygve Vea","email":"trygve.vea@gmail.com","username":"trygve.vea"},"change_message_id":"3f64f4fea0c0372e23da55a93e17341de37fa6d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new option for api: public_endpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running glance-api behind a proxy or load balancer that hides glance"},{"line_number":10,"context_line":"behind an extended base URL, it is necessary to provide information about"},{"line_number":11,"context_line":"the base URL to glance-api to ensure that clients know where to pass"},{"line_number":12,"context_line":"subsequent requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bebee01c2580f0500a069f5ab57ac2a8c329389"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"020ab9f9_6075c98a","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":20},"in_reply_to":"5ff7e74d_7ff65418","updated":"2022-08-23 09:21:06.000000000","message":"Ack","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a344a59abca2d5554425538e05d1f6e315ea17ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb26d019_a39d2ea6","updated":"2022-08-23 05:54:06.000000000","message":"I agree we need unit tests and a release note. Also, please find my comments inline.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"125dd5dff7d3f6c5e7622d568a706a06c1e5f27c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55120082_a391a61f","updated":"2022-08-23 05:58:45.000000000","message":"Just a side note.\n\nI\u0027m ok with implementing this option as the parameter is supported by Glance, but usually as long as your loadbalancer adds the proper request headers(such as X-Forwarded-For) and you enable the [oslo_middleware] enable_proxy_headers_parsing option, you don\u0027t need to give the public_endpoint option, and the actual endpoint host is automatically detected.\n\nThis setting works better especially in case you have multiple endpoints (admin, public, internal) listening at different IPs/Hosts.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"95423b11cff4b5e2639ab1ae26fa16ace7c219f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38cf522e_f9244829","updated":"2022-08-22 17:53:17.000000000","message":"Please add unit test coverage and a release note.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":23866,"name":"Trygve Vea","email":"trygve.vea@gmail.com","username":"trygve.vea"},"change_message_id":"3f64f4fea0c0372e23da55a93e17341de37fa6d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66b12e5e_907abf64","updated":"2022-08-23 09:21:06.000000000","message":"Thank you for your reviews.\n\nI believe I have addressed the points you\u0027ve made.  Ready for new review now! 👍","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":23866,"name":"Trygve Vea","email":"trygve.vea@gmail.com","username":"trygve.vea"},"change_message_id":"3f64f4fea0c0372e23da55a93e17341de37fa6d2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4d462cd_1b019175","in_reply_to":"55120082_a391a61f","updated":"2022-08-23 09:21:06.000000000","message":"It detects the host just fine, but it\u0027s necessary when the base URL isn\u0027t /.\n\nExample: The advertised public endpoint is https://cloud.acme.org/api/image\n\ncurl https://cloud.acme.org/api/image returns URLs that is unaware of /api/image being the base URL, (https://cloud.acme.org/v2).  Setting the option will make it behave correctly (https://cloud.acme.org/api/image/v2)\n\nSo this is necessary if you want everything to reside under a single domain for public facing traffic.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbf3911d8dbc034795bd58e76058c300d8993e22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2caa6eff_bdc6751a","in_reply_to":"b4d462cd_1b019175","updated":"2022-08-23 14:56:38.000000000","message":"Ah, ok. That makes sense, though we might want to consider a good way to automate detection somehow.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":23866,"name":"Trygve Vea","email":"trygve.vea@gmail.com","username":"trygve.vea"},"change_message_id":"3f64f4fea0c0372e23da55a93e17341de37fa6d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"131d21dd_cd9b994b","in_reply_to":"fb26d019_a39d2ea6","updated":"2022-08-23 09:21:06.000000000","message":"Ack","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":23866,"name":"Trygve Vea","email":"trygve.vea@gmail.com","username":"trygve.vea"},"change_message_id":"dbf457c613c5fc04cccda1bde56ffee741706533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f51fee0_726e9c01","updated":"2022-08-23 12:21:53.000000000","message":"Recheck","commit_id":"9bc327f5af75ee4640fc9a5d77964fe4065fd1dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbf3911d8dbc034795bd58e76058c300d8993e22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"daa311d3_1d99a180","updated":"2022-08-23 14:56:38.000000000","message":"Thanks for updating the patch. Change almost looks good to me now, except for the two suggestions mainly about documentations.","commit_id":"9bc327f5af75ee4640fc9a5d77964fe4065fd1dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b5d78ad572a3109a1d1d8ce530e9b2d99471c3f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f8b5c123_63b0dc2e","updated":"2022-08-29 14:02:38.000000000","message":"Just fixed a missing space in parameter description. Will vote +A once we hear back from CI.","commit_id":"709b83b390a747beb55b08c6cf3477a5ca231264"},{"author":{"_account_id":23866,"name":"Trygve Vea","email":"trygve.vea@gmail.com","username":"trygve.vea"},"change_message_id":"c277445d15af8f2cccc0ce7ae653d18873904993","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3bcb8521_33e91470","updated":"2022-09-02 09:30:34.000000000","message":"recheck","commit_id":"709b83b390a747beb55b08c6cf3477a5ca231264"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92e17dce096880244d36b0449486c99d1d156ece","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2051a52b_93a04169","updated":"2022-09-05 15:57:41.000000000","message":"recheck\n\nthe issue with ovn-metadata-agent was fixed.","commit_id":"709b83b390a747beb55b08c6cf3477a5ca231264"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a6983bdfbb31386dae0665eb2e929201d3dd5eca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36e5bec3_0998afa2","updated":"2022-08-30 09:32:31.000000000","message":"recheck Segmentation fault","commit_id":"709b83b390a747beb55b08c6cf3477a5ca231264"}],"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a344a59abca2d5554425538e05d1f6e315ea17ef","unresolved":true,"context_lines":[{"line_number":226,"context_line":"#   Defaults to: $::glance::params::lock_path"},{"line_number":227,"context_line":"#"},{"line_number":228,"context_line":"# [*public_endpoint*]"},{"line_number":229,"context_line":"#   (optional) Change the endpoint to represent the proxy URL if the API service is"},{"line_number":230,"context_line":"#   running behind a proxy."},{"line_number":231,"context_line":"#   Default: $::os_service_default."},{"line_number":232,"context_line":"#"},{"line_number":233,"context_line":"# DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"60bfc023_9e361609","line":230,"range":{"start_line":229,"start_character":15,"end_line":230,"end_character":27},"updated":"2022-08-23 05:54:06.000000000","message":"IMO we should explain the meaning of this parameter rather than how this should be used.\n\nPublic url endpoint to use for Glance versions response.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92e17dce096880244d36b0449486c99d1d156ece","unresolved":false,"context_lines":[{"line_number":226,"context_line":"#   Defaults to: $::glance::params::lock_path"},{"line_number":227,"context_line":"#"},{"line_number":228,"context_line":"# [*public_endpoint*]"},{"line_number":229,"context_line":"#   (optional) Change the endpoint to represent the proxy URL if the API service is"},{"line_number":230,"context_line":"#   running behind a proxy."},{"line_number":231,"context_line":"#   Default: $::os_service_default."},{"line_number":232,"context_line":"#"},{"line_number":233,"context_line":"# DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"122a343a_db7926ea","line":230,"range":{"start_line":229,"start_character":15,"end_line":230,"end_character":27},"in_reply_to":"5e3efb32_ef3e4b89","updated":"2022-09-05 15:57:41.000000000","message":"Done","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbf3911d8dbc034795bd58e76058c300d8993e22","unresolved":true,"context_lines":[{"line_number":226,"context_line":"#   Defaults to: $::glance::params::lock_path"},{"line_number":227,"context_line":"#"},{"line_number":228,"context_line":"# [*public_endpoint*]"},{"line_number":229,"context_line":"#   (optional) Change the endpoint to represent the proxy URL if the API service is"},{"line_number":230,"context_line":"#   running behind a proxy."},{"line_number":231,"context_line":"#   Default: $::os_service_default."},{"line_number":232,"context_line":"#"},{"line_number":233,"context_line":"# DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9ac52c74_e34edbe8","line":230,"range":{"start_line":229,"start_character":15,"end_line":230,"end_character":27},"in_reply_to":"60bfc023_9e361609","updated":"2022-08-23 14:56:38.000000000","message":"Can we add the above sentence ?","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ac9e70f403b562252d55de4acccc072a1153d40","unresolved":true,"context_lines":[{"line_number":226,"context_line":"#   Defaults to: $::glance::params::lock_path"},{"line_number":227,"context_line":"#"},{"line_number":228,"context_line":"# [*public_endpoint*]"},{"line_number":229,"context_line":"#   (optional) Change the endpoint to represent the proxy URL if the API service is"},{"line_number":230,"context_line":"#   running behind a proxy."},{"line_number":231,"context_line":"#   Default: $::os_service_default."},{"line_number":232,"context_line":"#"},{"line_number":233,"context_line":"# DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5e3efb32_ef3e4b89","line":230,"range":{"start_line":229,"start_character":15,"end_line":230,"end_character":27},"in_reply_to":"9ac52c74_e34edbe8","updated":"2022-08-23 14:58:39.000000000","message":"To make my previous comment clear...\n\nPlease add \"Public url endpoint to use for Glance versions response.\" before \"Change the endpoint ...\" . The current description does not explain what \"the endpoint\" means. We better use the original description in Glance to help users understand how the parameter is used.","commit_id":"8261fdc32fab672b5ec5948fb0364e9088008183"}],"releasenotes/notes/new_option_public_endpoint-26ba31afc09cabf0.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbf3911d8dbc034795bd58e76058c300d8993e22","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``glance::api`` class accepts a new parameter ``public_endpoint``."},{"line_number":5,"context_line":"    This is useful if you have a proxy or load balancer that rewrites the"},{"line_number":6,"context_line":"    base URL of the image API.  If the image API is advertised as"},{"line_number":7,"context_line":"    ``https://cloud.acme.org/api/image`` in Keystone, you will need to set"},{"line_number":8,"context_line":"    this option to the full value of the endpoint to have glance API"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f8415e99_b7a885c3","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":19},"updated":"2022-08-23 14:56:38.000000000","message":"I\u0027d add \"for example\" or \"especially\" here, to make it clear there might be other use cases which would require this option.","commit_id":"9bc327f5af75ee4640fc9a5d77964fe4065fd1dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92e17dce096880244d36b0449486c99d1d156ece","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``glance::api`` class accepts a new parameter ``public_endpoint``."},{"line_number":5,"context_line":"    This is useful if you have a proxy or load balancer that rewrites the"},{"line_number":6,"context_line":"    base URL of the image API.  If the image API is advertised as"},{"line_number":7,"context_line":"    ``https://cloud.acme.org/api/image`` in Keystone, you will need to set"},{"line_number":8,"context_line":"    this option to the full value of the endpoint to have glance API"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fac0813c_0da8a1f6","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":19},"in_reply_to":"f8415e99_b7a885c3","updated":"2022-09-05 15:57:41.000000000","message":"Done","commit_id":"9bc327f5af75ee4640fc9a5d77964fe4065fd1dd"}]}