)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bf1ff22a436b24e666997737b9ec6c35b354b161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16634c82_2424f040","updated":"2023-09-11 18:13:09.000000000","message":"Let\u0027s see if the option will no longer be deprecated.\n\nhttps://review.opendev.org/c/openstack/glance_store/+/894514","commit_id":"953bd7154409ec3361fc14696f14962d98461a12"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"732e828a7ffabf92d1f58ead9f591769027b1cf8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2216a066_360c0940","in_reply_to":"16634c82_2424f040","updated":"2023-09-12 01:45:20.000000000","message":"Yes. I\u0027ve added WIP so that we won\u0027t merge this until we see some conclusions in that patch.\n\nI\u0027ll remove this from the patch chain so that we can merge the weight parameter first.","commit_id":"953bd7154409ec3361fc14696f14962d98461a12"}],"manifests/backend/rbd.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"97c1e77832d88cac330ad060b3e8517e97ca9185","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    rbd_store_pool        \u003d\u003e $rbd_store_pool,"},{"line_number":67,"context_line":"    rbd_store_chunk_size  \u003d\u003e $rbd_store_chunk_size,"},{"line_number":68,"context_line":"    rbd_thin_provisioning \u003d\u003e $rbd_thin_provisioning,"},{"line_number":69,"context_line":"    rados_connect_timeout \u003d\u003e $rados_connect_timeout,"},{"line_number":70,"context_line":"    manage_packages       \u003d\u003e $manage_packages,"},{"line_number":71,"context_line":"    package_ensure        \u003d\u003e $package_ensure,"},{"line_number":72,"context_line":"    store_description     \u003d\u003e undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"88ea991f_e9907c2a","line":69,"updated":"2023-09-08 13:54:30.000000000","message":"Is there a reason why you aren\u0027t using pick() the way you handle the option in the legacy (non-multistore) code?\n\nBTW, I left a note on the glance-store review [1] that suggests they might reconsider deprecating the option.\n\n[1] https://review.opendev.org/c/openstack/glance_store/+/852044/comments/8dd87c06_be3cfa39","commit_id":"953bd7154409ec3361fc14696f14962d98461a12"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3edaedf853ec94ea42cc6d1584fd8f06475b8529","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    rbd_store_pool        \u003d\u003e $rbd_store_pool,"},{"line_number":67,"context_line":"    rbd_store_chunk_size  \u003d\u003e $rbd_store_chunk_size,"},{"line_number":68,"context_line":"    rbd_thin_provisioning \u003d\u003e $rbd_thin_provisioning,"},{"line_number":69,"context_line":"    rados_connect_timeout \u003d\u003e $rados_connect_timeout,"},{"line_number":70,"context_line":"    manage_packages       \u003d\u003e $manage_packages,"},{"line_number":71,"context_line":"    package_ensure        \u003d\u003e $package_ensure,"},{"line_number":72,"context_line":"    store_description     \u003d\u003e undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7c60bd5d_5ccf626d","line":69,"in_reply_to":"88ea991f_e9907c2a","updated":"2023-09-08 14:05:48.000000000","message":"If we add pick here and replace undef by $::os_service_default, then we always get deprecation warning from glance::backend::multistore::rbd.\nI skipped adding pick and warning log to avoid redundant warning logs generated from two layers (glance::backend::rbd and glance::backend::multistore::rbd).\n\nAnd thanks for that note in glance-store ! That makes clear sense to me. If they agree to implement that mechanism now then I\u0027m ok to hold this or if we can merge this and then revert it later if needed.","commit_id":"953bd7154409ec3361fc14696f14962d98461a12"}]}