)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e2f1cc5a3ec4e22d552656554406505dabcdb0bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"36251846_fa9df935","updated":"2023-09-08 13:30:37.000000000","message":"This patch made me pause, and wonder if another approach would be better. It\u0027s rather large, and is in the middle of a chain of patches. I wondered if it would be better to relocate it at the end of the chain, so that smaller patches that are easier to review could get in ahead of this one.\n\nI also wondered if there was a way to avoid nearly duplicating the glance-api.conf and glance-cache.conf settings. Perhaps glance-cache.conf could be generated from the glance-api.conf values? I don\u0027t know of the cache prefetcher would be bothered if it encountered settings in glance-cache.conf that it doesn\u0027t recognize (for example, the store_description that appears in glance-api.conf).\n\nIn the end, I managed to make my way through all of the changes, and they lgtm. I\u0027ll vote +2 and let others decide if my comments warrant further consideration.","commit_id":"10d7bbdeef69651d9f1f1d5b164b51ef84b0cd56"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"82718d93cbbe8d7efce3656c21a2748a994de4d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e21a6fad_54419a11","in_reply_to":"36251846_fa9df935","updated":"2023-09-08 13:43:36.000000000","message":"I can probably refactor this using create_resources or even adding a feature to glance_api_conf to replicate the option to cache.conf as well, but I decided the \"bare\" approach because\n - Someone might want to backport this\n - The logic may be much cleaned up when we remove legacy store support\n \nI\u0027ll take another look probably after Bobcat release to find out a good way to refactor the existing logic.","commit_id":"10d7bbdeef69651d9f1f1d5b164b51ef84b0cd56"}]}