)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1d4f43de9873d5421c1ab36cae4e5b59ff08f0b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"019f2652_49bdf3f8","updated":"2024-01-09 03:04:02.000000000","message":"recheck https://review.opendev.org/c/openstack/puppet-nova/+/905000 was merged","commit_id":"d1401c48adaf649ed62fde203e1988931a43d37f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fea1b72c2c432960f32260f1ab4c8a104ad874ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"97a39bcd_2fcb92fa","updated":"2024-01-04 01:47:01.000000000","message":"recheck timed out","commit_id":"d1401c48adaf649ed62fde203e1988931a43d37f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6eaca695f009b9431653281b176bb781c8f9ec9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6ba2075d_bc809e2e","updated":"2024-01-06 15:56:21.000000000","message":"recheck timeout","commit_id":"d1401c48adaf649ed62fde203e1988931a43d37f"}],"lib/puppet/type/glance_property_protections_config.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1f80923bdede06c91e10e9b02bb478e8c1c7b4cc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from glance-property-protections.conf\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":21,"id":"7a92d5dd_41016a7f","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":78},"updated":"2024-01-02 16:23:20.000000000","message":"Should this match the value in init_setting.rb? That\u0027s \"property-protections.conf\" without the \"glance-\" prefix.","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"24a3e9da3b42cbc001589fde67793f5bae095c0b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from glance-property-protections.conf\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":21,"id":"821170db_21da4408","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":78},"in_reply_to":"7a92d5dd_41016a7f","updated":"2024-01-03 02:06:01.000000000","message":"Yes. I removed the prefix later but didn\u0027t update this. Fixed in the latest version.","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"}],"manifests/property_protection.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1f80923bdede06c91e10e9b02bb478e8c1c7b4cc","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  case $property_protection_rule_format {"},{"line_number":34,"context_line":"    \u0027roles\u0027, \u0027policy\u0027: {"},{"line_number":35,"context_line":"      glance_api_config {"},{"line_number":36,"context_line":"        \u0027DEFAULT/property_protection_file\u0027:        value \u003d\u003e \u0027/etc/glance/property-protections.conf\u0027;"},{"line_number":37,"context_line":"        \u0027DEFAULT/property_protection_rule_format\u0027: value \u003d\u003e $property_protection_rule_format;"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"56add786_0235134e","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":20},"updated":"2024-01-02 16:23:20.000000000","message":"-1: Per [1] this should be \"policies\"\n\n[1] https://docs.openstack.org/glance/latest/admin/property-protections.html","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"24a3e9da3b42cbc001589fde67793f5bae095c0b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  case $property_protection_rule_format {"},{"line_number":34,"context_line":"    \u0027roles\u0027, \u0027policy\u0027: {"},{"line_number":35,"context_line":"      glance_api_config {"},{"line_number":36,"context_line":"        \u0027DEFAULT/property_protection_file\u0027:        value \u003d\u003e \u0027/etc/glance/property-protections.conf\u0027;"},{"line_number":37,"context_line":"        \u0027DEFAULT/property_protection_rule_format\u0027: value \u003d\u003e $property_protection_rule_format;"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"df8eb679_405d227c","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":20},"in_reply_to":"56add786_0235134e","updated":"2024-01-03 02:06:01.000000000","message":"Yes. Thanks for catching this. I\u0027ve added the additional unit test case to validate policies format.","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1f80923bdede06c91e10e9b02bb478e8c1c7b4cc","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      File[\u0027/etc/glance/property-protections.conf\u0027] -\u003e Glance_property_protections_config\u003c||\u003e"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"    default: {"},{"line_number":66,"context_line":"      glance_api_config {"},{"line_number":67,"context_line":"        \u0027DEFAULT/property_protection_file\u0027:        value \u003d\u003e $facts[\u0027os_service_default\u0027];"},{"line_number":68,"context_line":"        \u0027DEFAULT/property_protection_rule_format\u0027: value \u003d\u003e $facts[\u0027os_service_default\u0027];"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"b7b91407_97591366","line":65,"updated":"2024-01-02 16:23:20.000000000","message":"Do you need to remove any existing property-protections.conf file when the rule format is undef?","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"24a3e9da3b42cbc001589fde67793f5bae095c0b","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      File[\u0027/etc/glance/property-protections.conf\u0027] -\u003e Glance_property_protections_config\u003c||\u003e"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"    default: {"},{"line_number":66,"context_line":"      glance_api_config {"},{"line_number":67,"context_line":"        \u0027DEFAULT/property_protection_file\u0027:        value \u003d\u003e $facts[\u0027os_service_default\u0027];"},{"line_number":68,"context_line":"        \u0027DEFAULT/property_protection_rule_format\u0027: value \u003d\u003e $facts[\u0027os_service_default\u0027];"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"f722f90c_7dc63dd4","line":65,"in_reply_to":"b7b91407_97591366","updated":"2024-01-03 02:06:01.000000000","message":"I didn\u0027t add the purge logic in case the file may be installed by the glance package in the future, but that is not likely happen very soon so removing the file explicitly would be a better option. I\u0027ve added the resource to remove the file.","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"}],"releasenotes/notes/property-protections-3db869c274eb175f.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1f80923bdede06c91e10e9b02bb478e8c1c7b4cc","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``glance::property_protections`` class has been added. This class"},{"line_number":5,"context_line":"    allows confuguration of the image property protections feature."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"d197d7e6_b4a18624","line":5,"range":{"start_line":5,"start_character":11,"end_line":5,"end_character":24},"updated":"2024-01-02 16:23:20.000000000","message":"typo (\"configuration\"): typically a nit, but not in a release note.","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"24a3e9da3b42cbc001589fde67793f5bae095c0b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``glance::property_protections`` class has been added. This class"},{"line_number":5,"context_line":"    allows confuguration of the image property protections feature."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1d0ed5e3_092c94ff","line":5,"range":{"start_line":5,"start_character":11,"end_line":5,"end_character":24},"in_reply_to":"d197d7e6_b4a18624","updated":"2024-01-03 02:06:01.000000000","message":"Done","commit_id":"d9181b15aadae39b619523dbb5285a9bf7ec6f9a"}]}