)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"051e05f66049abf1a55fde980b21bbccd836bdeb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Peter Zhurba \u003cpzhurba@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-15 16:58:54 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move glare puppet support into separate module (params and db parts)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I085f08a4ca2a9e13e3b0bc75f383bb1f9e8f393a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_474180a8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":68},"updated":"2016-09-16 10:11:50.000000000","message":"this is not valid commit message in terms of current puppet module","commit_id":"499ce936b9e34ca9ddff8694df270f917c7492b4"}],"manifests/db/sync.pp":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"c124ce02368bfc3f06b3d380e1e39f289fb58e2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   Defaults to undef"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"include ::glare::params"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"class glare::db::sync("},{"line_number":15,"context_line":"  $extra_params  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_b7af1393","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2016-09-15 10:27:38.000000000","message":"should be inside class definition","commit_id":"9920ec05156c7fb0cd13be89ad2957cbf77f6a93"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"6601eddfd70c9c7be0d8e017cf4693225ee8088a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*command*]"},{"line_number":12,"context_line":"#    (Optional) command line of db manager"},{"line_number":13,"context_line":"#    Default  to \u0027/usr/bin/glare-db-manage upgrade\u0027,"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_658d067b","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":12},"updated":"2016-09-20 09:32:57.000000000","message":"Defaults to","commit_id":"fc489d9bfc6491652e03e52b9bb303d7f93d6192"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"6601eddfd70c9c7be0d8e017cf4693225ee8088a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    (Optional) command line of db manager"},{"line_number":13,"context_line":"#    Default  to \u0027/usr/bin/glare-db-manage upgrade\u0027,"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class glare::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d \u0027--config-file /etc/glare.conf\u0027,"},{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage upgrade\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_85813250","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":0},"updated":"2016-09-20 09:32:57.000000000","message":"please remove 15,16 empty lines","commit_id":"fc489d9bfc6491652e03e52b9bb303d7f93d6192"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8edd3e191df03aa39317649b761e67b05b5afe3d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage\u0027,"},{"line_number":20,"context_line":") {"},{"line_number":21,"context_line":"  exec { \u0027glare-db-sync\u0027:"},{"line_number":22,"context_line":"    command     \u003d\u003e \"${command} ${extra_params} upgrade\","},{"line_number":23,"context_line":"    user        \u003d\u003e \u0027glare\u0027,"},{"line_number":24,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":25,"context_line":"    subscribe   \u003d\u003e [Package[\u0027glare\u0027], Glare_config[\u0027database/connection\u0027]],"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_9ed24733","line":22,"updated":"2016-09-20 16:34:30.000000000","message":"Let\u0027s leave the path in and the command here. I don\u0027t think those truely need to be configurable.  If someone really has to change out the full path then they can use Exec\u003c| title \u003d\u003d \u0027glare-db-sync\u0027 |\u003e for the override.","commit_id":"4bf62da21dc04220a4669a6b66153725cc93b6a9"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"f3fc1cbde93f2de54437966799deab04a83f4dc0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage\u0027,"},{"line_number":20,"context_line":") {"},{"line_number":21,"context_line":"  exec { \u0027glare-db-sync\u0027:"},{"line_number":22,"context_line":"    command     \u003d\u003e \"${command} ${extra_params} upgrade\","},{"line_number":23,"context_line":"    user        \u003d\u003e \u0027glare\u0027,"},{"line_number":24,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":25,"context_line":"    subscribe   \u003d\u003e [Package[\u0027glare\u0027], Glare_config[\u0027database/connection\u0027]],"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_b96d369b","line":22,"in_reply_to":"7a8ec9b2_9ed24733","updated":"2016-09-21 10:05:24.000000000","message":"I really need it. \nIs it good practice use overriding parameters","commit_id":"4bf62da21dc04220a4669a6b66153725cc93b6a9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2189aa01bd8d80cbc55aeae68f1c9ac5507fbcef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# [*command*]"},{"line_number":12,"context_line":"#    (Optional) command line of db manager"},{"line_number":13,"context_line":"#    Default  to \u0027/usr/bin/glare-db-manage upgrade\u0027,"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class glare::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d \u0027--config-file /etc/glare/glare.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_3c1e58bb","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":0},"updated":"2016-09-21 15:50:50.000000000","message":"empty lines","commit_id":"0cae66f947b159324dd2573e008fe874719ad116"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5ec28d0f7b29518eba853e217067a12c1754fc76","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class glare::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d \u0027--config-file /etc/glare/glare.conf\u0027,"},{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage\u0027,"},{"line_number":20,"context_line":") {"},{"line_number":21,"context_line":"  exec { \u0027glare-db-sync\u0027:"},{"line_number":22,"context_line":"    command     \u003d\u003e \"${command} ${extra_params} upgrade\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_7fc0dd50","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":46},"updated":"2016-09-21 13:53:49.000000000","message":"why do you really need to be able to override this?  The module should handle the default cases and if you specifically need to override it for something that isn\u0027t a normal package path that should be handled in your composition layer.","commit_id":"0cae66f947b159324dd2573e008fe874719ad116"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2189aa01bd8d80cbc55aeae68f1c9ac5507fbcef","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class glare::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d \u0027--config-file /etc/glare/glare.conf\u0027,"},{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage\u0027,"},{"line_number":20,"context_line":") {"},{"line_number":21,"context_line":"  exec { \u0027glare-db-sync\u0027:"},{"line_number":22,"context_line":"    command     \u003d\u003e \"${command} ${extra_params} upgrade\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_3c4c98c7","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":46},"in_reply_to":"7a8ec9b2_0615c93e","updated":"2016-09-21 15:50:50.000000000","message":"i\u0027d like to use path here","commit_id":"0cae66f947b159324dd2573e008fe874719ad116"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"d72028d1580de62e1bb538bc1e5491b300178be8","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class glare::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d \u0027--config-file /etc/glare/glare.conf\u0027,"},{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage\u0027,"},{"line_number":20,"context_line":") {"},{"line_number":21,"context_line":"  exec { \u0027glare-db-sync\u0027:"},{"line_number":22,"context_line":"    command     \u003d\u003e \"${command} ${extra_params} upgrade\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_c3091386","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":46},"in_reply_to":"7a8ec9b2_7fc0dd50","updated":"2016-09-21 15:15:02.000000000","message":"As I can see, command has changed at least once. \nAlso as I saw RedHat and Ubuntu are using /bin and /user/bin for the same binaries. \n\nHonestly I need this part for using pip backend for package. It seems this part not will be merged. But  we may still using this part.  Any way your propose is allow to do it. If you insist please set  -1 I will change  this part back.","commit_id":"0cae66f947b159324dd2573e008fe874719ad116"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b8bb895e18ea37278375f6c486b8eedf8ffbbf6c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class glare::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d \u0027--config-file /etc/glare/glare.conf\u0027,"},{"line_number":19,"context_line":"  $command       \u003d \u0027/usr/bin/glare-db-manage\u0027,"},{"line_number":20,"context_line":") {"},{"line_number":21,"context_line":"  exec { \u0027glare-db-sync\u0027:"},{"line_number":22,"context_line":"    command     \u003d\u003e \"${command} ${extra_params} upgrade\","}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8ec9b2_0615c93e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":46},"in_reply_to":"7a8ec9b2_c3091386","updated":"2016-09-21 15:19:04.000000000","message":"the /bin and /usr/bin can be addressed by fixing the path to be [\u0027/bin\u0027,\u0027/usr/bin\u0027].  Just wondering what the exact reason was. I\u0027m not completely against it as we seem to be pretty inconsistent on these classes anyway since just about every project is doing it in a different fashion","commit_id":"0cae66f947b159324dd2573e008fe874719ad116"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b951cae49120e18fe2d956104a0ce7030be81ab9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   to the glare-db-manage command."},{"line_number":9,"context_line":"#   Defaults to \u0027--config-file /etc/glare.conf\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*command*]"},{"line_number":12,"context_line":"#    (Optional) command line of db manager"},{"line_number":13,"context_line":"#    Default  to \u0027/usr/bin/glare-db-manage upgrade\u0027,"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"class glare::db::sync("},{"line_number":16,"context_line":"  $extra_params  \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a8bc5a2_d2fdad3b","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":52},"updated":"2016-09-23 09:03:31.000000000","message":"not needed","commit_id":"e4063d6f0b1cbd1a4ea40ffc1cd7bc5bec2fba57"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"37457ee8c6a6b7b3cf68bf7580ead5d1594632b4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   to the glare-db-manage command."},{"line_number":9,"context_line":"#   Defaults to \u0027--config-file /etc/glare.conf\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"class glare::db::sync("},{"line_number":13,"context_line":"  $extra_params  \u003d \u0027\u0027,"},{"line_number":14,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5a8bc5a2_58112503","line":11,"updated":"2016-09-27 10:32:47.000000000","message":"nit: empty line","commit_id":"54d8acc9dc5cb14f18a595e4a2201add97826691"}],"manifests/params.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"842d09564c9df835efe451ee0322b36b1da5a9a5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class glare::params {"},{"line_number":4,"context_line":"  include ::openstacklib::defaults"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  $glare_service_name \u003d \u0027glare-api\u0027"},{"line_number":7,"context_line":"  $config_dir         \u003d \u0027/etc/glare\u0027"},{"line_number":8,"context_line":"  $log_dir            \u003d \u0027/var/log/glare\u0027"},{"line_number":9,"context_line":"  $work_dir           \u003d \u0027/var/lib/glare\u0027"},{"line_number":10,"context_line":"  $srv_bin            \u003d \u0027/usr/local/bin/glare-api\u0027"},{"line_number":11,"context_line":"  $user               \u003d \u0027glare\u0027"},{"line_number":12,"context_line":"  $group              \u003d \u0027glare\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  case $::osfamily {"},{"line_number":15,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a8ec9b2_d7781fc7","line":12,"range":{"start_line":6,"start_character":0,"end_line":12,"end_character":31},"updated":"2016-09-15 10:34:03.000000000","message":"please copy all params from puppet-glance module, which are related to glare.\n\nparameters, that are can be configured should be placed into classes.","commit_id":"9920ec05156c7fb0cd13be89ad2957cbf77f6a93"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"443773695ecc02c9f174e5a674e75612ba32cbbb","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  case $::osfamily {"},{"line_number":7,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":8,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":9,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":10,"context_line":"      $svc_type              \u003d \u0027systemd\u0027"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_a22424af","line":9,"range":{"start_line":8,"start_character":5,"end_line":9,"end_character":42},"updated":"2016-09-15 13:32:57.000000000","message":"according to https://github.com/openstack/puppet-glance/blob/master/manifests/params.pp this is not the name of the package, did you double check with RDO?","commit_id":"1245ee37d8f4e62d4f867ddd6361f31cf71eb5ae"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"051e05f66049abf1a55fde980b21bbccd836bdeb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    }"},{"line_number":24,"context_line":"  } # Case $::osfamily"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_e7e36cd7","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":0},"updated":"2016-09-16 10:11:50.000000000","message":"empty lines","commit_id":"499ce936b9e34ca9ddff8694df270f917c7492b4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fb50a4fca63550cfc68f233d22dad4b46b3dc88c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u0027Debian\u0027: {"},{"line_number":13,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":14,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":15,"context_line":"      if (versioncmp($::operatingsystemrelease, \u002715\u0027) \u003c 0) {"},{"line_number":16,"context_line":"        $svc_type \u003d \u0027upstart\u0027"},{"line_number":17,"context_line":"        } else {"},{"line_number":18,"context_line":"        $svc_type \u003d \u0027systemd\u0027"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"    default: {"},{"line_number":22,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_5f028f3f","line":19,"range":{"start_line":15,"start_character":0,"end_line":19,"end_character":7},"updated":"2016-09-20 12:21:13.000000000","message":"why do we need that? Provider can automatically detect init unit.","commit_id":"57bb5e1ecd98195749aaef858b46c34f8c1b19a5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ee0bab825adf6a1aaaf07186f90a3ed959902706","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u0027Debian\u0027: {"},{"line_number":13,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":14,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":15,"context_line":"      if (versioncmp($::operatingsystemrelease, \u002715\u0027) \u003c 0) {"},{"line_number":16,"context_line":"        $svc_type \u003d \u0027upstart\u0027"},{"line_number":17,"context_line":"        } else {"},{"line_number":18,"context_line":"        $svc_type \u003d \u0027systemd\u0027"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"    default: {"},{"line_number":22,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_53e0c3fa","line":19,"range":{"start_line":15,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"7a8ec9b2_00c7bf12","updated":"2016-09-20 13:42:17.000000000","message":"you mean install package by pip?\n\"pip install glare\" or something?\n\nThe package should the provide by the OS to be installed\nusing yum or apt-get","commit_id":"57bb5e1ecd98195749aaef858b46c34f8c1b19a5"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"b75b606e496f7caa14bd7c39ca3a35eb2ced0ae4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u0027Debian\u0027: {"},{"line_number":13,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":14,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":15,"context_line":"      if (versioncmp($::operatingsystemrelease, \u002715\u0027) \u003c 0) {"},{"line_number":16,"context_line":"        $svc_type \u003d \u0027upstart\u0027"},{"line_number":17,"context_line":"        } else {"},{"line_number":18,"context_line":"        $svc_type \u003d \u0027systemd\u0027"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"    default: {"},{"line_number":22,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8ec9b2_00c7bf12","line":19,"range":{"start_line":15,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"7a8ec9b2_5f028f3f","updated":"2016-09-20 13:35:03.000000000","message":"I\u0027m going also using pip as a package provider. \nIt does not know anting about service handling","commit_id":"57bb5e1ecd98195749aaef858b46c34f8c1b19a5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8edd3e191df03aa39317649b761e67b05b5afe3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u0027Debian\u0027: {"},{"line_number":13,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":14,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":15,"context_line":"      if (versioncmp($::operatingsystemrelease, \u002715\u0027) \u003c 0) {"},{"line_number":16,"context_line":"        $svc_type \u003d \u0027upstart\u0027"},{"line_number":17,"context_line":"        } else {"},{"line_number":18,"context_line":"        $svc_type \u003d \u0027systemd\u0027"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"    default: {"},{"line_number":22,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_3ec9337a","line":19,"range":{"start_line":15,"start_character":0,"end_line":19,"end_character":7},"updated":"2016-09-20 16:34:30.000000000","message":"is this used by anything? Also i think we name svc_type as service_provider for most other modules where we do something like this","commit_id":"4bf62da21dc04220a4669a6b66153725cc93b6a9"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"f3fc1cbde93f2de54437966799deab04a83f4dc0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u0027Debian\u0027: {"},{"line_number":13,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":14,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":15,"context_line":"      if (versioncmp($::operatingsystemrelease, \u002715\u0027) \u003c 0) {"},{"line_number":16,"context_line":"        $svc_type \u003d \u0027upstart\u0027"},{"line_number":17,"context_line":"        } else {"},{"line_number":18,"context_line":"        $svc_type \u003d \u0027systemd\u0027"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"    }"},{"line_number":21,"context_line":"    default: {"},{"line_number":22,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7a8ec9b2_192c6a49","line":19,"range":{"start_line":15,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"7a8ec9b2_3ec9337a","updated":"2016-09-21 10:05:24.000000000","message":"Done","commit_id":"4bf62da21dc04220a4669a6b66153725cc93b6a9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b951cae49120e18fe2d956104a0ce7030be81ab9","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  case $::osfamily {"},{"line_number":7,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":8,"context_line":"      $glare_package_name    \u003d \u0027openstack-glare\u0027"},{"line_number":9,"context_line":"      $glare_service_name    \u003d \u0027openstack-glare-api\u0027"},{"line_number":10,"context_line":"      $svc_type              \u003d \u0027systemd\u0027"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    \u0027Debian\u0027: {"},{"line_number":13,"context_line":"      $glare_package_name    \u003d \u0027glare\u0027"},{"line_number":14,"context_line":"      $glare_service_name    \u003d \u0027glare-api\u0027"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    default: {"},{"line_number":17,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a8bc5a2_12bd5568","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":42},"updated":"2016-09-23 09:03:31.000000000","message":"out of scope for current patch and commit message","commit_id":"e4063d6f0b1cbd1a4ea40ffc1cd7bc5bec2fba57"}]}
