)]}'
{"lib/puppet/provider/glare_paste_ini/ini_setting.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  :ini_setting,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ini_setting)"},{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/glare/glare-paste.ini\u0027"},{"line_number":8,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"5a8bc5a2_3857f9ca","line":5,"updated":"2016-09-27 10:32:16.000000000","message":"tests for provider?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":17730,"name":"Maciej Relewicz","email":"mrelewicz@mirantis.com","username":"mrelewicz"},"change_message_id":"bec58c6e2f0f51d55b1704fcb812c806137070b1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  :ini_setting,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ini_setting)"},{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/glare/glare-paste.ini\u0027"},{"line_number":8,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"5a8bc5a2_8638a7d4","line":5,"in_reply_to":"5a8bc5a2_3857f9ca","updated":"2016-09-27 12:25:47.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"}],"lib/puppet/type/glare_paste_ini.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:glare_paste_ini) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from glare_paste.ini\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"5a8bc5a2_585a05f3","line":4,"updated":"2016-09-27 10:32:16.000000000","message":"tests for type?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":17730,"name":"Maciej Relewicz","email":"mrelewicz@mirantis.com","username":"mrelewicz"},"change_message_id":"bec58c6e2f0f51d55b1704fcb812c806137070b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:glare_paste_ini) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from glare_paste.ini\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"5a8bc5a2_e64fab68","line":4,"in_reply_to":"5a8bc5a2_585a05f3","updated":"2016-09-27 12:25:47.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5858adb5f1b36281d40e3acf6c627cbdcc7a7ad4","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class glare ("},{"line_number":97,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":98,"context_line":"  $package_name              \u003d undef,"},{"line_number":99,"context_line":"  $bind_host                 \u003d \u00270.0.0.0\u0027,"},{"line_number":100,"context_line":"  $bind_port                 \u003d \u00279494\u0027,"},{"line_number":101,"context_line":"  $backlog                   \u003d \u00274096\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_4266f251","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":37},"updated":"2016-09-21 11:10:55.000000000","message":"?","commit_id":"f133568e579abc0600937a815ce331e833df4b4a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5858adb5f1b36281d40e3acf6c627cbdcc7a7ad4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  include ::glare::db"},{"line_number":120,"context_line":"  include ::glare::logging"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  if (! defined (Package[\u0027glare\u0027])) {"},{"line_number":123,"context_line":"     package { \u0027glare\u0027:"},{"line_number":124,"context_line":"      name      \u003d\u003e \"$::glare::params::glare_package_name\","},{"line_number":125,"context_line":"      ensure    \u003d\u003e \"$package_ensure\","},{"line_number":126,"context_line":"     }"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Glare_config {"},{"line_number":130,"context_line":"    require     \u003d\u003e Package[\u0027glare\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_42bc32bb","line":127,"range":{"start_line":122,"start_character":0,"end_line":127,"end_character":3},"updated":"2016-09-21 11:10:55.000000000","message":"you can use ensure_packages function","commit_id":"f133568e579abc0600937a815ce331e833df4b4a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5858adb5f1b36281d40e3acf6c627cbdcc7a7ad4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"     }"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Glare_config {"},{"line_number":130,"context_line":"    require     \u003d\u003e Package[\u0027glare\u0027],"},{"line_number":131,"context_line":"    before      \u003d\u003e Service[\u0027glare\u0027],"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  glare_config {"},{"line_number":135,"context_line":"    \u0027DEFAULT/bind_host\u0027:           value \u003d\u003e $bind_host;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_c2cf6254","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":3},"updated":"2016-09-21 11:10:55.000000000","message":"no need that here, you can add autorequire in provider.\n\ntake a look on glance examples","commit_id":"f133568e579abc0600937a815ce331e833df4b4a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5858adb5f1b36281d40e3acf6c627cbdcc7a7ad4","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  glare_config {"},{"line_number":135,"context_line":"    \u0027DEFAULT/bind_host\u0027:           value \u003d\u003e $bind_host;"},{"line_number":136,"context_line":"    \u0027DEFAULT/bind_port\u0027:           value \u003d\u003e $bind_port;"},{"line_number":137,"context_line":"    \u0027DEFAULT/backlog\u0027:             value \u003d\u003e $backlog;"},{"line_number":138,"context_line":"    \u0027DEFAULT/workers\u0027:             value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_e21d3ebf","line":135,"updated":"2016-09-21 11:10:55.000000000","message":"alignment","commit_id":"f133568e579abc0600937a815ce331e833df4b4a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5858adb5f1b36281d40e3acf6c627cbdcc7a7ad4","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  glare_config {"},{"line_number":142,"context_line":"    \u0027glance_store/os_region_name\u0027: value  \u003d\u003e $os_region_name;"},{"line_number":143,"context_line":"    \u0027glance_store/stores\u0027: value          \u003d\u003e $stores;"},{"line_number":144,"context_line":"    \u0027glance_store/default_store\u0027: value   \u003d\u003e $default_store;"},{"line_number":145,"context_line":"    \u0027glance_store/filesystem_store_datadir\u0027: value   \u003d\u003e $filesystem_store_datadir;"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_021b0acb","line":143,"updated":"2016-09-21 11:10:55.000000000","message":"same","commit_id":"f133568e579abc0600937a815ce331e833df4b4a"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2dfa16b3d4340edf73af16a29d47656a0cf41748","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  $bind_host                 \u003d \u00270.0.0.0\u0027,"},{"line_number":114,"context_line":"  $bind_port                 \u003d \u00279494\u0027,"},{"line_number":115,"context_line":"  $backlog                   \u003d \u00274096\u0027,"},{"line_number":116,"context_line":"  $workers                   \u003d $::processorcount,"},{"line_number":117,"context_line":"  $auth_strategy             \u003d undef,"},{"line_number":118,"context_line":"  $pipeline                  \u003d undef,"},{"line_number":119,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a8bc5a2_9a8e85ce","line":116,"updated":"2016-09-26 11:52:23.000000000","message":"i think we should use this fact https://review.openstack.org/#/c/375146/3/lib/facter/os_workers.rb here, because it was decided that usage of processorcount leads to excessive resource usage","commit_id":"154dc2d3e387192e2b9647b0e5403bf1bc78082e"},{"author":{"_account_id":17730,"name":"Maciej Relewicz","email":"mrelewicz@mirantis.com","username":"mrelewicz"},"change_message_id":"adf5779668b1bf4a781fd6b77ba2cb69685c4250","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  $bind_host                 \u003d \u00270.0.0.0\u0027,"},{"line_number":114,"context_line":"  $bind_port                 \u003d \u00279494\u0027,"},{"line_number":115,"context_line":"  $backlog                   \u003d \u00274096\u0027,"},{"line_number":116,"context_line":"  $workers                   \u003d $::processorcount,"},{"line_number":117,"context_line":"  $auth_strategy             \u003d undef,"},{"line_number":118,"context_line":"  $pipeline                  \u003d undef,"},{"line_number":119,"context_line":"  $manage_service            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a8bc5a2_0bdb0550","line":116,"in_reply_to":"5a8bc5a2_9a8e85ce","updated":"2016-09-26 12:38:01.000000000","message":"Done","commit_id":"154dc2d3e387192e2b9647b0e5403bf1bc78082e"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"68ab73cae9a222d615bcc3cdef177b9f9bcac400","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#   (optional) Number of Glare worker processes to start"},{"line_number":25,"context_line":"#   Default: $::processorcount"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*auth_strategy*]"},{"line_number":28,"context_line":"#   (optional) Type is authorization being used."}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5a8bc5a2_ff4d84c4","line":25,"updated":"2016-09-27 07:32:07.000000000","message":"and update also please this default","commit_id":"1cedcc62811f3dacac51c57b8585d22710974bc4"},{"author":{"_account_id":17730,"name":"Maciej Relewicz","email":"mrelewicz@mirantis.com","username":"mrelewicz"},"change_message_id":"ef23991681110e9adc1dfe742bd5a7c33e7278f6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#   (optional) Number of Glare worker processes to start"},{"line_number":25,"context_line":"#   Default: $::processorcount"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*auth_strategy*]"},{"line_number":28,"context_line":"#   (optional) Type is authorization being used."}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5a8bc5a2_019acf6d","line":25,"in_reply_to":"5a8bc5a2_ff4d84c4","updated":"2016-09-27 09:09:03.000000000","message":"Done","commit_id":"1cedcc62811f3dacac51c57b8585d22710974bc4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $bind_port                 \u003d \u00279494\u0027,"},{"line_number":115,"context_line":"  $backlog                   \u003d \u00274096\u0027,"},{"line_number":116,"context_line":"  $workers                   \u003d $::os_workers,"},{"line_number":117,"context_line":"  $auth_strategy             \u003d undef,"},{"line_number":118,"context_line":"  $pipeline                  \u003d undef,"},{"line_number":119,"context_line":"  $manage_service            \u003d true,"},{"line_number":120,"context_line":"  $enabled                   \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_5d14b74b","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":37},"updated":"2016-09-27 10:32:16.000000000","message":"by default i believe it\u0027s keystone","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $bind_port                 \u003d \u00279494\u0027,"},{"line_number":115,"context_line":"  $backlog                   \u003d \u00274096\u0027,"},{"line_number":116,"context_line":"  $workers                   \u003d $::os_workers,"},{"line_number":117,"context_line":"  $auth_strategy             \u003d undef,"},{"line_number":118,"context_line":"  $pipeline                  \u003d undef,"},{"line_number":119,"context_line":"  $manage_service            \u003d true,"},{"line_number":120,"context_line":"  $enabled                   \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_2b84fc08","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":37},"in_reply_to":"5a8bc5a2_5d14b74b","updated":"2016-09-27 12:46:59.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  $backlog                   \u003d \u00274096\u0027,"},{"line_number":116,"context_line":"  $workers                   \u003d $::os_workers,"},{"line_number":117,"context_line":"  $auth_strategy             \u003d undef,"},{"line_number":118,"context_line":"  $pipeline                  \u003d undef,"},{"line_number":119,"context_line":"  $manage_service            \u003d true,"},{"line_number":120,"context_line":"  $enabled                   \u003d true,"},{"line_number":121,"context_line":"  $cert_file                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_d817f542","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":37},"updated":"2016-09-27 10:32:16.000000000","message":"same","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  $backlog                   \u003d \u00274096\u0027,"},{"line_number":116,"context_line":"  $workers                   \u003d $::os_workers,"},{"line_number":117,"context_line":"  $auth_strategy             \u003d undef,"},{"line_number":118,"context_line":"  $pipeline                  \u003d undef,"},{"line_number":119,"context_line":"  $manage_service            \u003d true,"},{"line_number":120,"context_line":"  $enabled                   \u003d true,"},{"line_number":121,"context_line":"  $cert_file                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_4b7f8814","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":37},"in_reply_to":"5a8bc5a2_d817f542","updated":"2016-09-27 12:46:59.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  $cert_file                 \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $key_file                  \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $ca_file                   \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_d8e1b52b","line":124,"updated":"2016-09-27 10:32:16.000000000","message":"i think it\u0027s default from glare","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  $cert_file                 \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $key_file                  \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $ca_file                   \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_061e576f","line":124,"in_reply_to":"5a8bc5a2_d8e1b52b","updated":"2016-09-27 12:46:59.000000000","message":"according this http://paste.ubuntu.com/23216335/\nyes they are.\nDo you mean we should omit default parameters?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  $key_file                  \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $ca_file                   \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_38f29906","line":125,"updated":"2016-09-27 10:32:16.000000000","message":"is it default store in glare at all?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  $key_file                  \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $ca_file                   \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_a64da3c5","line":125,"in_reply_to":"5a8bc5a2_38f29906","updated":"2016-09-27 12:46:59.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  $ca_file                   \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_f8d2f15a","line":126,"updated":"2016-09-27 10:32:16.000000000","message":"same","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"},{"line_number":130,"context_line":"  $app_catalog_mode          \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_9849ed33","line":127,"range":{"start_line":127,"start_character":2,"end_line":127,"end_character":37},"updated":"2016-09-27 10:32:16.000000000","message":"os_service_default?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  $stores                    \u003d \u0027file,http\u0027,"},{"line_number":125,"context_line":"  $default_store             \u003d \u0027file\u0027,"},{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"},{"line_number":130,"context_line":"  $app_catalog_mode          \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_660f1b37","line":127,"range":{"start_line":127,"start_character":2,"end_line":127,"end_character":37},"in_reply_to":"5a8bc5a2_9849ed33","updated":"2016-09-27 12:46:59.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"},{"line_number":130,"context_line":"  $app_catalog_mode          \u003d false,"},{"line_number":131,"context_line":"  $app_memcached_server      \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":132,"context_line":"  $app_cookie_name           \u003d \u0027s.aoo\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_b854e9c9","line":129,"range":{"start_line":129,"start_character":2,"end_line":129,"end_character":37},"updated":"2016-09-27 10:32:16.000000000","message":"same?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  $filesystem_store_datadir  \u003d \u0027/var/lib/glare/images\u0027,"},{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"},{"line_number":130,"context_line":"  $app_catalog_mode          \u003d false,"},{"line_number":131,"context_line":"  $app_memcached_server      \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":132,"context_line":"  $app_cookie_name           \u003d \u0027s.aoo\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_860a6724","line":129,"range":{"start_line":129,"start_character":2,"end_line":129,"end_character":37},"in_reply_to":"5a8bc5a2_b854e9c9","updated":"2016-09-27 12:46:59.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"},{"line_number":130,"context_line":"  $app_catalog_mode          \u003d false,"},{"line_number":131,"context_line":"  $app_memcached_server      \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":132,"context_line":"  $app_cookie_name           \u003d \u0027s.aoo\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  include ::glare::params"},{"line_number":135,"context_line":"  include ::glare::db"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_784ee13b","line":132,"range":{"start_line":130,"start_character":0,"end_line":132,"end_character":39},"updated":"2016-09-27 10:32:16.000000000","message":"are those parameters are present in glare?","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  $multi_store               \u003d false,"},{"line_number":128,"context_line":"  $os_region_name            \u003d \u0027RegionOne\u0027,"},{"line_number":129,"context_line":"  $allow_anonymous_access    \u003d false,"},{"line_number":130,"context_line":"  $app_catalog_mode          \u003d false,"},{"line_number":131,"context_line":"  $app_memcached_server      \u003d \u0027127.0.0.1:11211\u0027,"},{"line_number":132,"context_line":"  $app_cookie_name           \u003d \u0027s.aoo\u0027,"},{"line_number":133,"context_line":") {"},{"line_number":134,"context_line":"  include ::glare::params"},{"line_number":135,"context_line":"  include ::glare::db"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_58e925b6","line":132,"range":{"start_line":130,"start_character":0,"end_line":132,"end_character":39},"in_reply_to":"5a8bc5a2_784ee13b","updated":"2016-09-27 12:46:59.000000000","message":"This is parameters which we are adding when we are use midleware for app catalog. they are absent in default paste.ini","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c92f072b4bca00d1b15459d2fb2938f47b71a23","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  })"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  glare_config {"},{"line_number":144,"context_line":"    \u0027DEFAULT/bind_host\u0027               : value \u003d\u003e $bind_host;"},{"line_number":145,"context_line":"    \u0027DEFAULT/bind_port\u0027               : value \u003d\u003e $bind_port;"},{"line_number":146,"context_line":"    \u0027DEFAULT/backlog\u0027                 : value \u003d\u003e $backlog;"},{"line_number":147,"context_line":"    \u0027DEFAULT/workers\u0027                 : value \u003d\u003e $workers;"},{"line_number":148,"context_line":"  }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  glare_config {"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_1d506f31","line":147,"range":{"start_line":144,"start_character":28,"end_line":147,"end_character":36},"updated":"2016-09-27 10:32:16.000000000","message":"alignment","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":14316,"name":"Peter Zhurba","email":"peter.zhurba@gmail.com","username":"pzhurba"},"change_message_id":"a070ebed89f1e5224e866a8d5dc582e52fd3abbd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  })"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  glare_config {"},{"line_number":144,"context_line":"    \u0027DEFAULT/bind_host\u0027               : value \u003d\u003e $bind_host;"},{"line_number":145,"context_line":"    \u0027DEFAULT/bind_port\u0027               : value \u003d\u003e $bind_port;"},{"line_number":146,"context_line":"    \u0027DEFAULT/backlog\u0027                 : value \u003d\u003e $backlog;"},{"line_number":147,"context_line":"    \u0027DEFAULT/workers\u0027                 : value \u003d\u003e $workers;"},{"line_number":148,"context_line":"  }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  glare_config {"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5a8bc5a2_6116254d","line":147,"range":{"start_line":144,"start_character":28,"end_line":147,"end_character":36},"in_reply_to":"5a8bc5a2_1d506f31","updated":"2016-09-27 12:46:59.000000000","message":"Done","commit_id":"a4da6f2b8d252558d55d34b69ff27bc3f7dc30f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7652058fe589f691a4685eaca15eea5634a23882","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        value  \u003d\u003e $pipeline,"},{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"    if $pipeline \u003d\u003d \u0027session\u0027 {"},{"line_number":158,"context_line":"      glare_paste_ini { \u0027pipeline:glare-api-session/pipeline\u0027:"},{"line_number":159,"context_line":"        value  \u003d\u003e \u0027cors faultwrapper healthcheck versionnegotiation context glarev1api\u0027"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":"    if $app_catalog_mode {"},{"line_number":163,"context_line":"      glare_paste_ini {"},{"line_number":164,"context_line":"        \u0027filter:session/paste.filter_factory\u0027:"},{"line_number":165,"context_line":"          value \u003d\u003e \u0027openstack_app_catalog.middlewares:SessionMiddleware.factory\u0027;"},{"line_number":166,"context_line":"        \u0027filter:session/memcached_server\u0027:"},{"line_number":167,"context_line":"          value \u003d\u003e $app_memcached_server;"},{"line_number":168,"context_line":"        \u0027filter:session/session_cookie_name\u0027:"},{"line_number":169,"context_line":"          value \u003d\u003e $app_cookie_name;"},{"line_number":170,"context_line":"      }"},{"line_number":171,"context_line":"      glare_config {"},{"line_number":172,"context_line":"        \u0027DEFAULT/allow_anonymous_access\u0027  : value \u003d\u003e $allow_anonymous_access;"},{"line_number":173,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"5a8bc5a2_4a1ca677","line":170,"range":{"start_line":158,"start_character":0,"end_line":170,"end_character":7},"updated":"2016-09-28 11:04:55.000000000","message":"i can\u0027t find such sections in glare paste. Can you point me on those parameters?","commit_id":"121119cbf556cb27ba31b373cf1727d4a79d5a24"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4dd477c8212bc798cbaa82a47b94ed311528b606","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#   value)"},{"line_number":91,"context_line":"#   Defaults to false"},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class glare ("},{"line_number":95,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":96,"context_line":"  $bind_host                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"3a98d1f4_7ea670c2","line":93,"updated":"2016-09-29 11:26:17.000000000","message":"empty line","commit_id":"cbf45028bdae295679c916ea018eb46b23f308eb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4dd477c8212bc798cbaa82a47b94ed311528b606","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \u0027glance_store/stores\u0027                  : value   \u003d\u003e $stores;"},{"line_number":133,"context_line":"    \u0027glance_store/default_store\u0027           : value   \u003d\u003e $default_store;"},{"line_number":134,"context_line":"    \u0027glance_store/filesystem_store_datadir\u0027: value   \u003d\u003e $filesystem_store_datadir;"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  if $pipeline !\u003d \u0027\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"3a98d1f4_de7ce422","line":135,"updated":"2016-09-29 11:26:17.000000000","message":"empty line","commit_id":"cbf45028bdae295679c916ea018eb46b23f308eb"}],"spec/acceptance/glare_config_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4dd477c8212bc798cbaa82a47b94ed311528b606","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027basic glare config resource\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":28,"id":"3a98d1f4_deca244f","line":3,"updated":"2016-09-29 11:26:17.000000000","message":"can you also please add main acceptance test with running glare service? Is it possible on current stage?","commit_id":"cbf45028bdae295679c916ea018eb46b23f308eb"},{"author":{"_account_id":17730,"name":"Maciej Relewicz","email":"mrelewicz@mirantis.com","username":"mrelewicz"},"change_message_id":"5fd10060ce3f2382bfc0f1437e59d4d364ed51a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027basic glare config resource\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":28,"id":"3a98d1f4_faec492b","line":3,"in_reply_to":"3a98d1f4_deca244f","updated":"2016-09-29 12:16:16.000000000","message":"I will be added in patch https://review.openstack.org/#/c/373805/ when we will have deb glare package available. Test will install, configure glare and check whether service responds on configured port.","commit_id":"cbf45028bdae295679c916ea018eb46b23f308eb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"cc25c09d7e1fee15780de5019b1140515ff1a421","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027basic glare config resource\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":28,"id":"3a98d1f4_63f97480","line":3,"in_reply_to":"3a98d1f4_faec492b","updated":"2016-09-29 13:05:48.000000000","message":"Ack","commit_id":"cbf45028bdae295679c916ea018eb46b23f308eb"}]}