)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d3af6ba3ecac78d3f245765f14eb26273727c63f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change switches the gnocchi module to use the os_service_default"},{"line_number":10,"context_line":"fact for configuration options that default to \u0027\u003cSERVICE DEFAULT\u003e\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-bug: #1515273"},{"line_number":13,"context_line":"Change-Id: I88f51a7025905b381c117675afc30a9ec1756c5b"},{"line_number":14,"context_line":"Signed-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a8ffd7b_51a3d04f","line":12,"updated":"2015-12-01 00:52:15.000000000","message":"if this patches is related to this bug why db.pp it\u0027s not here?","commit_id":"95a55a3ef05f597529bd2fd4fa70cd83db563b49"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"cfff02528b38862d01c90cb8b7d7a00594d168ff","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $debug                              \u003d undef,"},{"line_number":54,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":55,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":56,"context_line":"  $log_dir                            \u003d \u0027/var/log/gnocchi\u0027,"},{"line_number":57,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":58,"context_line":"  $database_connection                \u003d undef,"},{"line_number":59,"context_line":") inherits gnocchi::params {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_e919a623","line":56,"updated":"2015-12-01 10:57:27.000000000","message":"should be undef","commit_id":"95a55a3ef05f597529bd2fd4fa70cd83db563b49"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5567363c40b79e22bb045b9bdd5d45daa194f406","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $debug                              \u003d undef,"},{"line_number":54,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":55,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":56,"context_line":"  $log_dir                            \u003d \u0027/var/log/gnocchi\u0027,"},{"line_number":57,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":58,"context_line":"  $database_connection                \u003d undef,"},{"line_number":59,"context_line":") inherits gnocchi::params {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_dada5e17","line":56,"in_reply_to":"9a8ffd7b_e919a623","updated":"2015-12-01 11:45:06.000000000","message":"+1","commit_id":"95a55a3ef05f597529bd2fd4fa70cd83db563b49"}],"manifests/logging.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ce55b865c2d452c1345f458eb0fa8fb13081c1c8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#    (optional) hash of logger (keys) and level (values) pairs."},{"line_number":62,"context_line":"#    Defaults to $::os_service_default"},{"line_number":63,"context_line":"#    example:"},{"line_number":64,"context_line":"#      { \u0027amqp\u0027 \u003d\u003e \u0027warn\u0027, \u0027amqplib\u0027 \u003d\u003e \u0027warn\u0027, \u0027boto\u0027 \u003d\u003e \u0027warn\u0027,"},{"line_number":65,"context_line":"#        \u0027qpid\u0027 \u003d\u003e \u0027warn\u0027, \u0027sqlalchemy\u0027 \u003d\u003e \u0027warn\u0027, \u0027suds\u0027 \u003d\u003e \u0027info\u0027,"},{"line_number":66,"context_line":"#        \u0027iso8601\u0027 \u003d\u003e \u0027warn\u0027,"},{"line_number":67,"context_line":"#        \u0027requests.packages.urllib3.connectionpool\u0027 \u003d\u003e \u0027warn\u0027 }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_edc6b248","line":64,"updated":"2015-11-30 20:13:50.000000000","message":"why do you convert WARN to warn?","commit_id":"95a55a3ef05f597529bd2fd4fa70cd83db563b49"}],"spec/classes/gnocchi_api_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":125,"context_line":"    let :facts do"},{"line_number":126,"context_line":"      @default_facts.merge!({"},{"line_number":127,"context_line":"        :osfamily               \u003d\u003e \u0027Debian\u0027,"},{"line_number":128,"context_line":"        :operatingsystem        \u003d\u003e \u0027Debian\u0027,"},{"line_number":129,"context_line":"        :operatingsystemrelease \u003d\u003e \u00278.0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_b3f3060a","line":126,"updated":"2015-10-29 13:55:56.000000000","message":"This shouldn\u0027t be a .merge!(), should just be merge().","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"be0e8e92d50d4c244a94199037719d7b7995693a","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":125,"context_line":"    let :facts do"},{"line_number":126,"context_line":"      @default_facts.merge!({"},{"line_number":127,"context_line":"        :osfamily               \u003d\u003e \u0027Debian\u0027,"},{"line_number":128,"context_line":"        :operatingsystem        \u003d\u003e \u0027Debian\u0027,"},{"line_number":129,"context_line":"        :operatingsystemrelease \u003d\u003e \u00278.0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_966ef894","line":126,"in_reply_to":"1a26ad4f_162ae87e","updated":"2015-10-29 14:22:37.000000000","message":"So no one caught my usage which was incorrect. merge!(...) will update the @default_facts variable with the merged hash. This would be problematic if we reuse the same @default_facts elsewhere with in the same test.  By correctly using .merge(...), we are setting :facts to the merged result without touching @default_facts. \n\nCurrently we don\u0027t reuse @default_facts so we don\u0027t run into the problem, however if we ever refactor it such that @default_facts is not recreated for each run or reuse it we would run into issues.  It would be best not to propagate the misuse of .merge! which is why I made a -1. I\u0027ll submit a patch to fix it in cinder.","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"cd7ef37cf5ef2c7657d080080d2a11dbe2d4c5ec","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":125,"context_line":"    let :facts do"},{"line_number":126,"context_line":"      @default_facts.merge!({"},{"line_number":127,"context_line":"        :osfamily               \u003d\u003e \u0027Debian\u0027,"},{"line_number":128,"context_line":"        :operatingsystem        \u003d\u003e \u0027Debian\u0027,"},{"line_number":129,"context_line":"        :operatingsystemrelease \u003d\u003e \u00278.0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_76555c4e","line":126,"in_reply_to":"1a26ad4f_966ef894","updated":"2015-10-29 14:33:05.000000000","message":"Thanks for explanation. Btw, fix for cinder: https://review.openstack.org/#/c/240247/","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c21c3f85f96015b9d5930659e21862c6532184e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":125,"context_line":"    let :facts do"},{"line_number":126,"context_line":"      @default_facts.merge!({"},{"line_number":127,"context_line":"        :osfamily               \u003d\u003e \u0027Debian\u0027,"},{"line_number":128,"context_line":"        :operatingsystem        \u003d\u003e \u0027Debian\u0027,"},{"line_number":129,"context_line":"        :operatingsystemrelease \u003d\u003e \u00278.0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_162ae87e","line":126,"in_reply_to":"1a26ad4f_b3f3060a","updated":"2015-10-29 14:12:41.000000000","message":"Alex,\n\nCan you explain why? Here is your commit: https://github.com/openstack/puppet-cinder/commit/667e6c0850672dbbf99381eb92468f95e5591913 and you used merge!().","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":145,"context_line":"    let :facts do"},{"line_number":146,"context_line":"      @default_facts.merge!({"},{"line_number":147,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":148,"context_line":"        :operatingsystem        \u003d\u003e \u0027RedHat\u0027,"},{"line_number":149,"context_line":"        :operatingsystemrelease \u003d\u003e \u00277.1\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_73dece6e","line":146,"updated":"2015-10-29 13:55:56.000000000","message":"Same here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  describe \u0027with custom auth_uri\u0027 do"},{"line_number":165,"context_line":"    let :facts do"},{"line_number":166,"context_line":"      @default_facts.merge!({ :osfamily \u003d\u003e \u0027redhat\u0027 })"},{"line_number":167,"context_line":"    end"},{"line_number":168,"context_line":"    before do"},{"line_number":169,"context_line":"      params.merge!({"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_33bff6fc","line":166,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"  describe \"with custom keystone identity_uri\" do"},{"line_number":179,"context_line":"    let :facts do"},{"line_number":180,"context_line":"      @default_facts.merge!({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":181,"context_line":"    end"},{"line_number":182,"context_line":"    before do"},{"line_number":183,"context_line":"      params.merge!({"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_53bab20b","line":180,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"  describe \"with custom keystone identity_uri and auth_uri\" do"},{"line_number":193,"context_line":"    let :facts do"},{"line_number":194,"context_line":"      @default_facts.merge!({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":195,"context_line":"    end"},{"line_number":196,"context_line":"    before do"},{"line_number":197,"context_line":"      params.merge!({"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_f3373eae","line":194,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a96de8af985a16afce24afc7a9419a2f488ae1a3","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  describe \u0027with custom auth_uri\u0027 do"},{"line_number":168,"context_line":"    let :facts do"},{"line_number":169,"context_line":"      @default_facts.merge({ :osfamily \u003d\u003e \u0027redhat\u0027 })"},{"line_number":170,"context_line":"    end"},{"line_number":171,"context_line":"    before do"},{"line_number":172,"context_line":"      params.merge!({"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7a740942_69d71eee","line":169,"updated":"2015-12-09 14:46:27.000000000","message":"Did you mean to switch case here?  This should probably be RedHat","commit_id":"2c6ddc3814314f4bd81f04ea3c1307ddcb9187c5"}],"spec/classes/gnocchi_init_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":23,"context_line":"    let :facts do"},{"line_number":24,"context_line":"      @default_facts.merge!({"},{"line_number":25,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":26,"context_line":"        :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":27,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_d344821c","line":24,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":38,"context_line":"    let :facts do"},{"line_number":39,"context_line":"      @default_facts.merge!({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":40,"context_line":"    end"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    let :platform_params do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_9347ea1c","line":39,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"}],"spec/classes/gnocchi_logging_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":128,"context_line":"    let :facts do"},{"line_number":129,"context_line":"      @default_facts.merge!({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":130,"context_line":"    end"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    it_configures \u0027gnocchi-logging\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_f35e5ee8","line":129,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99adb6284dbb18b1c8da6e2f97180c1b46725b3e","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":136,"context_line":"    let :facts do"},{"line_number":137,"context_line":"      @default_facts.merge!({ :osfamily \u003d\u003e \u0027RedHat\u0027 })"},{"line_number":138,"context_line":"    end"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    it_configures \u0027gnocchi-logging\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a26ad4f_d35b22f5","line":137,"updated":"2015-10-29 13:55:56.000000000","message":"and here","commit_id":"e5145a43f8031b30a789a6431a81ab98ab671837"}]}
