)]}'
{"manifests/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb41a27eace5a11f0489a2d8f677ded191f9bd53","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"      $sqlite_package_name        \u003d \u0027python-pysqlite2\u0027"},{"line_number":21,"context_line":"      $influxdb_package_name      \u003d \u0027python-influxdb\u0027"},{"line_number":22,"context_line":"      $common_package_name        \u003d \u0027gnocchi-common\u0027"},{"line_number":23,"context_line":"      $api_package_name           \u003d \u0027gnocchi-api\u0027"},{"line_number":24,"context_line":"      $api_service_name           \u003d \u0027gnocchi-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_b831790d","line":21,"updated":"2015-12-02 00:09:04.000000000","message":"This is an external resource, I\u0027m not sure puppet-gnocchi should manage it. Instead, it should be up to the composition layer.","commit_id":"52aecf1ea3fd5eb130aa9ad615baee392d2b48bd"}],"manifests/storage/influxdb.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb41a27eace5a11f0489a2d8f677ded191f9bd53","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $influxdb_block_until_data_ingested \u003d \u0027false\u0027,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $::gnocchi::params::influxdb_package_name {"},{"line_number":58,"context_line":"    package { \u0027gnocchi-influxdb-package\u0027:"},{"line_number":59,"context_line":"      ensure \u003d\u003e \u0027present\u0027,"},{"line_number":60,"context_line":"      name   \u003d\u003e $::gnocchi::params::influxdb_package_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_cc1da267","line":57,"updated":"2015-12-02 00:09:04.000000000","message":"I don\u0027t think we should manage it. If someone already manage the package in the catalog, the Puppet run would fail for duplicate resource. I suggest we don\u0027t manage it or use ensure_resource for that so we allow multiple resource declarations.","commit_id":"52aecf1ea3fd5eb130aa9ad615baee392d2b48bd"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"f56fe7c883b5e153fa8bd8208ed565475f7ffd76","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*influxdb_database*]"},{"line_number":33,"context_line":"#   (optional) influxdb database name"},{"line_number":34,"context_line":"#   Defaults to \u0027mydb\u0027"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*influxdb_username*]"},{"line_number":37,"context_line":"#   (optional) influxdb username"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_16dc11e3","line":34,"updated":"2015-12-02 04:01:27.000000000","message":"Should default to gnocchi","commit_id":"ca5e35246c971ae7a3fea53ad5fbdb30647852a1"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"f56fe7c883b5e153fa8bd8208ed565475f7ffd76","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class gnocchi::storage::influxdb("},{"line_number":49,"context_line":"  $influxdb_host     \u003d \u0027localhost\u0027,"},{"line_number":50,"context_line":"  $influxdb_port     \u003d 8086,"},{"line_number":51,"context_line":"  $influxdb_database \u003d \u0027mydb\u0027,"},{"line_number":52,"context_line":"  $influxdb_username \u003d \u0027root\u0027,"},{"line_number":53,"context_line":"  $influxdb_password \u003d undef,"},{"line_number":54,"context_line":"  $influxdb_block_until_data_ingested \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_56d139cc","line":51,"updated":"2015-12-02 04:01:27.000000000","message":"Should default to \u0027gnocchi\u0027","commit_id":"ca5e35246c971ae7a3fea53ad5fbdb30647852a1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"34e6eab31d0c4dfc9a110910a9c28fc2b0197316","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $influxdb_port     \u003d 8086,"},{"line_number":51,"context_line":"  $influxdb_database \u003d \u0027gnocchi\u0027,"},{"line_number":52,"context_line":"  $influxdb_username \u003d \u0027root\u0027,"},{"line_number":53,"context_line":"  $influxdb_password \u003d undef,"},{"line_number":54,"context_line":"  $influxdb_block_until_data_ingested \u003d false,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_040b43d7","line":53,"updated":"2015-12-02 21:55:39.000000000","message":"I would make this parameter required to avoid mistakes when using this class. I\u0027m not sure you can deploy the driver without a password anyway.","commit_id":"3c159ee8b9b38c1070371602b63c13eeb40e095e"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"7726936d81ede65ea7216dca113afa3a4522d2c2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $influxdb_port     \u003d 8086,"},{"line_number":51,"context_line":"  $influxdb_database \u003d \u0027gnocchi\u0027,"},{"line_number":52,"context_line":"  $influxdb_username \u003d \u0027root\u0027,"},{"line_number":53,"context_line":"  $influxdb_password \u003d undef,"},{"line_number":54,"context_line":"  $influxdb_block_until_data_ingested \u003d false,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_a46917fa","line":53,"in_reply_to":"9a8ffd7b_040b43d7","updated":"2015-12-02 22:05:23.000000000","message":"That\u0027s not correct, you don\u0027t need to set a password. We are using this patch like this and works fine.","commit_id":"3c159ee8b9b38c1070371602b63c13eeb40e095e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"34e6eab31d0c4dfc9a110910a9c28fc2b0197316","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  $influxdb_database \u003d \u0027gnocchi\u0027,"},{"line_number":52,"context_line":"  $influxdb_username \u003d \u0027root\u0027,"},{"line_number":53,"context_line":"  $influxdb_password \u003d undef,"},{"line_number":54,"context_line":"  $influxdb_block_until_data_ingested \u003d false,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  gnocchi_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_a40b57d4","line":54,"updated":"2015-12-02 21:55:39.000000000","message":"please align \u0027\u003d\u0027","commit_id":"3c159ee8b9b38c1070371602b63c13eeb40e095e"}],"spec/classes/gnocchi_storage_influxdb_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"34e6eab31d0c4dfc9a110910a9c28fc2b0197316","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        is_expected.to contain_gnocchi_config(\u0027storage/influxdb_database\u0027).with_value(\u0027gnocchi\u0027)"},{"line_number":20,"context_line":"        is_expected.to contain_gnocchi_config(\u0027storage/influxdb_username\u0027).with_value(\u0027root\u0027)"},{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":"    end"},{"line_number":23,"context_line":"  end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  context \u0027on Debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_c410db02","line":22,"updated":"2015-12-02 21:55:39.000000000","message":"it would be great to have a context that override the defaults values.","commit_id":"3c159ee8b9b38c1070371602b63c13eeb40e095e"}]}