)]}'
{"manifests/db.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2074f9c5c7f7780f5665fbb9cc6d7bcd3667c269","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"#  [*sync_db*]"},{"line_number":16,"context_line":"#    enable dbsync."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"class gnocchi::db ("},{"line_number":19,"context_line":"  $database_connection \u003d \u0027sqlite:////var/lib/gnocchi/gnocchi.sqlite\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba0121b8_8accfe35","line":16,"updated":"2016-04-01 18:28:44.000000000","message":"Defaults to true.","commit_id":"04f41730518ae5dbf97bc4614af30ed4c307326f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bf0b91e816b76a90d22cfa5ee54142a4d520c47e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"#  [*sync_db*]"},{"line_number":16,"context_line":"#    enable dbsync."},{"line_number":17,"context_line":"#    Defaults to true"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class gnocchi::db ("}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba0121b8_b802f970","line":16,"updated":"2016-04-01 18:43:02.000000000","message":"(optional)","commit_id":"0ec78c9a2566ed4a43eee3ac2fb624203d5b0b63"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f2c85d8b6524ea2a4b15bf0b9ab8295d9c1c31b7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class gnocchi::db ("},{"line_number":20,"context_line":"  $database_connection \u003d \u0027sqlite:////var/lib/gnocchi/gnocchi.sqlite\u0027,"},{"line_number":21,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":22,"context_line":"  $sync_db             \u003d false,"},{"line_number":23,"context_line":") inherits gnocchi::params {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_058967c9","line":22,"updated":"2016-04-06 15:35:07.000000000","message":"So in other modules this is added to the init or service classes (like api). Should we follow the same pattern here and leave this out of the db class?  As a side note this class seems to be out of sync with the other modules as far as missing the $database_* settings as well.","commit_id":"e83fca00a1ca0961e30e5dc1099b8d1b6b8d50f9"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"8fc9f50ed076cbf443f0c948704e9146605d5c74","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class gnocchi::db ("},{"line_number":20,"context_line":"  $database_connection \u003d \u0027sqlite:////var/lib/gnocchi/gnocchi.sqlite\u0027,"},{"line_number":21,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":22,"context_line":"  $sync_db             \u003d false,"},{"line_number":23,"context_line":") inherits gnocchi::params {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_8c1e326e","line":22,"in_reply_to":"9a061dce_058967c9","updated":"2016-04-06 20:30:50.000000000","message":"I dont think we have a standard. If you look at other modeules such as ceilometer for example, its done in db class. I think it should be fine here. As for the missing settings thats not related tot his change, we can look into that as a separate patch.","commit_id":"e83fca00a1ca0961e30e5dc1099b8d1b6b8d50f9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a1cd1a730d3c42e82cd333cc5e4e04531d8f2cbe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class gnocchi::db ("},{"line_number":20,"context_line":"  $database_connection \u003d \u0027sqlite:////var/lib/gnocchi/gnocchi.sqlite\u0027,"},{"line_number":21,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":22,"context_line":"  $sync_db             \u003d false,"},{"line_number":23,"context_line":") inherits gnocchi::params {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_0fafb42a","line":22,"in_reply_to":"9a061dce_8c1e326e","updated":"2016-04-06 20:51:20.000000000","message":"You\u0027re right that we don\u0027t have an explicit one but just about every other module that exposes this type of flag also includes this parameter in the class that setups the service. be it the init or api or engine or server classes.  The one ones that only do it in the db class are ceilometer.  Heat which has it in the db class also has it exposed in the init as well and designate also has another sync exposes via powerdns.  Is there a technological reason to not do it elsewhere? Given that we have so many modules it seems the defacto pattern is to do it in the main init class or with the api endpoint.\n\n\nOnly db:\n\n ceilometer\n designate (but also has another sync)\n\nWith the api endpoint or in the main class:\n\n  cinder\n  glance\n  ironic\n  keystone\n  murano\n  neutron\n  nova\n  sahara\n\n\nAnd yes I would be ok with waiting on the other parameters for a different review, just mentioning it as I was looking into the db classes elsewhere.  My primary concern is adding this to the db class rather than elsewhere. Since it\u0027s disabled by default I don\u0027t necessarily agree with it here.","commit_id":"e83fca00a1ca0961e30e5dc1099b8d1b6b8d50f9"}],"releasenotes/notes/add-sync_db-to-gnocchi-db-class-d3fed198a27b15e0.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fad14536c0eb4feb85b93fd3f9e88d96c27cfc39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"    - Add a sync_db option to ::gnocchi::db class. This makes it easier"},{"line_number":4,"context_line":"      to control the db sync from t-h-t"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a061dce_45f649d8","line":4,"updated":"2016-04-04 12:41:04.000000000","message":"please do not mention TripleO in Puppet OpenStack release notes.\nAlso please specify that we add a boolean, False by default for backward compatibility that whether or not run this db_sync for us.","commit_id":"e7e444c9122b2e5bf2b39d9dc4dc204bc98b6f10"}]}